Root cause (owner repro, verified in a real browser 2026-09-06): the five navbar views (Chat, RAG, Sources, Tuning, History) were separate HTML documents, so a navbar click was a REAL cross-document navigation — the chat page unloaded, the in-flight SSE fetch was aborted, and the phase-48 teardown (app/api/chat.py `finally`, "chat: turn cancelled") stopped the model. Observed: send question -> click RAG mid-stream -> click Chat -> the answer never finished: no `query_log` row, and on return a dangling question with no brain record (the pre-token pagehide partial persist skips because `acc` is empty). Phase-48 LOCKED-DECISION REFINEMENT (owner-confirmed 2026-09-06, flagged per AGENTS.md rule 3, not silently deviated): "real navigation cancels the fetch" now means LEAVING THE APP — tab close, external/other-document navigation, the Stop button. In-app navbar switches are client-side view switches and no longer cancel. Fix — Option A (SPA shell), chosen over B (Service Worker owns the stream) and C (server-side turn registry + resume): - frontend/index.html is the shell: ONE `<main id="main">` holds the five `<section class="view">` blocks; hidden views carry BOTH `hidden` and `inert` (WCAG — no focus/keyboard traversal). The shared header, the single `doc-modal-*` skeleton, and the `#app-version` footer each exist exactly once; the per-view copies from the four folded pages are dropped. - New frontend/assets/router.js (vanilla module — no framework, no bundler, No-CDN rule intact): lazy-imports a view module on FIRST show only (mount-once, hide-forever — the chat view's in-flight SSE reader persists across switches; that persistence IS the fix); intercepts same-shell navbar links with preventDefault + history.pushState (never a document load); handles popstate; single writer of `.nav-link` active state (is-active + aria-current), document.title, and the per-view meta description (values carried over from the old pages' heads, brand-resolved at write time). - Each folded page's JS becomes `export async function mount(root)` — root-scoped queries; `initSharedHeader()` dropped (the header boots once in the shell via the chat module; the admin flag comes from the same cached `fetchIsAdmin()` promise — zero extra requests). - app/main.py: a small list-driven route factory serves the shell for /tuning.html, /sources.html, /git-sources.html, /history.html — registered AFTER the API routers and BEFORE the static catch-all (routes-first). The phase-33 caching middleware applies no-cache + `?v=` rewriting unchanged; app/core/caching.py needed NO change (the view paths did not change — pinned by the integration tests). - The four old view .html files are DELETED (one source of truth); deep links to the old URLs keep working (the router picks the view from the pathname); `/?chat=<id>` is unaffected; the Containerfile bundles router.js (inlining the lazy view modules) and drops the folded page files. - app/schemas.py: HistoryTurn.text cap 4000 -> 32000 — the shell keeps long saved answers in the chat, and the old cap (stricter than the 24_000-char total history budget) 422-rejected any second turn in such a chat (found by the phase-42 E2E suite on the shell). Boundaries: login.html, shared.html, doc-edit.html, document.html REMAIN separate documents (flow pages, not navbar tabs); a mid-stream navigation to doc-edit/document.html still cancels per phase 48 (follow-up candidate, out of scope). The SSE API is unchanged. Real departures still cancel the turn — phase 48 intact (pinned by tests/e2e/test_stop_generation.py, unchanged, and by the new suite's real-departure control). Tests: - Phase-20 suite REWRITTEN to the new semantics (tests/e2e/test_sources_midstream_bug.py): a navbar switch no longer cancels — the stream survives the switch and the FULL answer settles; the pagehide partial persist REMAINS for real departures (the partial's exact shape — first streamed chunk prefix, no done metadata — is still pinned there). - NEW story suite tests/e2e/test_nav_switch_keeps_stream.py (mock LLM): the owner repro (send -> RAG mid-stream -> Chat: window sentinel survives = same document, FULL answer, exactly one brain turn in bor.chat.v1, exactly one settled query_log row, auto-saved row matches) + the same mid-stream switch against the other three views + the real-departure-still-cancels control + the no-switch baseline. - tests/unit/test_frontend_router.py: source-level pins of the router invariants (click interceptor targets ONLY same-shell view paths, pushState-only switches, mount-once guard, hidden+inert pair, single-writer active state/title); shell-route integration tests (each folded path serves the shell with no-cache + `?v=` body; a non-view path still 404s); the file-reading unit pins re-pointed at the shell (the four view files are gone — the shell is the source of truth). Verification (this commit): full suite green — 1565 unit+integration tests, app/ coverage 99% (>90% floor); ruff + pyright clean; the phase's E2E suites green in isolation (house protocol, AGENTS.md rule 9). Owner repro verified in a real browser against the real LLM (dev server :8010, headful Chromium): "tell me about everquest" -> RAG mid-stream -> Chat — the answer completed with one brain bubble and no error banner, `query_log` gained exactly one settled row (deflected=True: the dev KB holds no EverQuest docs — the settle, not the topic, is the proof), zero "chat: turn cancelled" lines for that turn; the control (real navigation to /shared.html mid-stream) still cancelled (no settled row, the cancel line logged, the partial persisted on return). Screenshots: .agents/screenshots/76_manual_*. Phase 76 (76_spa_nav_shell) complete — moved to .agents/phases/complete/.
120 lines
5.0 KiB
Python
120 lines
5.0 KiB
Python
"""Phase 61 E2E (Playwright): the retired homelab-era copy is gone — the
|
|
visitor SEES the locked neutral copy on the shared default server.
|
|
|
|
Story: n/a (TODO-derived — TODO.md L4 "Clean up the UI, there's text
|
|
that references old features…"). Run in isolation (DB must be up:
|
|
``podman compose up -d db``):
|
|
|
|
uv run pytest tests/e2e/test_stale_ui_copy.py -v --no-cov
|
|
|
|
The shared conftest server boots with the default env — and the code
|
|
defaults are exactly this phase's locked copy (A1/A2; the conftest
|
|
forces ``BOR_SUGGESTIONS`` from the ``Settings`` field so an operator's
|
|
local ``.env`` cannot leak corpus-specific chips). Every assertion is a
|
|
settled-state check: static HTML + one ``GET /api/suggestions`` fetch;
|
|
Playwright's ``expect`` retries ride out the chip rendering.
|
|
|
|
Test → lock mapping (Playwright Mapping Rule):
|
|
1. ``test_chat_page_placeholder_meta_footer_are_the_locked_copy``
|
|
2. ``test_chat_page_shows_no_homelab_or_deployment_text``
|
|
3. ``test_chat_page_suggestion_chips_are_the_locked_list``
|
|
4. ``test_sources_page_sub_describes_the_current_source_model``
|
|
5. ``test_git_sources_example_url_is_neutral``
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from playwright.sync_api import Page, expect
|
|
|
|
# The locked replacement copy (owner-locked A1 / A2 / A3 — same literals
|
|
# as tests/unit/test_stale_ui_copy.py; the unit pins guard the files,
|
|
# this suite guards what the visitor actually sees).
|
|
META = "Ask anything about your indexed documents — every answer cites the exact doc."
|
|
PLACEHOLDER = "Ask me anything…"
|
|
FOOTER = "Powered by self-hosted models"
|
|
GIT_EXAMPLE = "https://github.com/you/your-repo.git"
|
|
|
|
CHIPS = [
|
|
"What documents are in the knowledge base?",
|
|
"Which source does each answer come from?",
|
|
"How do I add a new source?",
|
|
"Summarize the most recent document.",
|
|
]
|
|
|
|
|
|
def test_chat_page_placeholder_meta_footer_are_the_locked_copy(
|
|
page: Page, app_url: str, db_ready: None
|
|
) -> None:
|
|
"""The composer placeholder, the <meta description> content and the
|
|
footer span all read the locked (A1) copy — read from the DOM a
|
|
visitor gets."""
|
|
page.goto(f"{app_url}/")
|
|
expect(page.locator("#message-input")).to_have_attribute(
|
|
"placeholder", PLACEHOLDER
|
|
)
|
|
meta = page.eval_on_selector('meta[name="description"]', "el => el.content")
|
|
assert meta == META, "the rendered meta description must be the locked copy"
|
|
expect(page.locator(".footer-text").first).to_have_text(FOOTER)
|
|
|
|
|
|
def test_chat_page_shows_no_homelab_or_deployment_text(
|
|
page: Page, app_url: str, db_ready: None
|
|
) -> None:
|
|
"""The entire rendered chat page (nav, empty state, composer, footer)
|
|
shows no homelab-era text — the empty-state sub AND the four
|
|
rendered suggestion chips are covered by this body scan (case-
|
|
insensitive; a fresh page context has no saved chats, so the empty
|
|
state is what renders)."""
|
|
page.goto(f"{app_url}/")
|
|
expect(page.locator("#suggestions .suggestion-chip")).to_have_count(len(CHIPS))
|
|
body = page.evaluate("() => document.body.innerText.toLowerCase()")
|
|
assert "homelab" not in body, f"homelab-era text rendered on the chat page: {body!r}"
|
|
assert "deployment" not in body, (
|
|
f"homelab-era text rendered on the chat page: {body!r}"
|
|
)
|
|
|
|
|
|
def test_chat_page_suggestion_chips_are_the_locked_list(
|
|
page: Page, app_url: str, db_ready: None
|
|
) -> None:
|
|
"""The four rendered empty-state chips (from ``GET
|
|
/api/suggestions``, the code default) are the locked (A2) list, in
|
|
order."""
|
|
page.goto(f"{app_url}/")
|
|
chips = page.locator("#suggestions .suggestion-chip")
|
|
expect(chips).to_have_count(len(CHIPS))
|
|
for i, chip in enumerate(CHIPS):
|
|
expect(chips.nth(i)).to_have_text(chip)
|
|
|
|
|
|
def test_sources_page_sub_describes_the_current_source_model(
|
|
page: Page, app_url: str, db_ready: None
|
|
) -> None:
|
|
"""The KB page-sub (the string the TODO cited by name) no longer
|
|
names ~/Homelab or ~/Deployments and describes the current source
|
|
model. The page is anonymously viewable — the catalog gate hides
|
|
the table, not the page-head."""
|
|
page.goto(f"{app_url}/sources.html")
|
|
# Phase 76 (task 02): the shell carries the hidden tuning view's
|
|
# .page-sub earlier in the DOM — scope to the RAG view.
|
|
sub = page.locator("#view-rag .page-sub")
|
|
expect(sub).to_be_visible()
|
|
text = sub.inner_text().lower()
|
|
assert "homelab" not in text, f"retired copy in the page-sub: {text!r}"
|
|
assert "deployments" not in text, f"retired copy in the page-sub: {text!r}"
|
|
assert "configured sources" in text, (
|
|
f"the page-sub must name the current source model: {text!r}"
|
|
)
|
|
|
|
|
|
def test_git_sources_example_url_is_neutral(
|
|
page: Page, app_url: str, db_ready: None
|
|
) -> None:
|
|
"""The repo-URL form example (A3) is the neutral your-repo.git —
|
|
read from the DOM; the element exists even while
|
|
``#git-sources-content`` is hidden for an anonymous visitor (no
|
|
sign-in needed)."""
|
|
page.goto(f"{app_url}/git-sources.html")
|
|
expect(page.locator("#git-source-url")).to_have_attribute(
|
|
"placeholder", GIT_EXAMPLE
|
|
)
|