ducoterra
a19d78d284
**Phase 122 (image documents) — final verification pass: all green. No code changes were needed; defects found: none.**
**Verified (implementation already complete in working tree, reviewed end-to-end):**
- Toggle (`BOR_IMAGES`/`BOR_IMAGE_EXTENSIONS`/`BOR_IMAGE_DIR`, off by default) + `GET /api/config` `images` flag
- Ingest: bytes digest, `image_dir` persistent copy, `content = summary = vision description` (chat-model call; only text embedded), fail-soft skip + `images_failed` counter
- Serve/display: `/api/documents/{id}/image` route (404 matrix), viewer `<img>` + description, Sources 48px lazy thumbnails, chat inline source figure (alt = summary), agent `read` marker
- Prune guard: images-off syncs never prune `is_image` docs
**Test / lint / coverage (exact commands & outcomes):**
- `uv run pytest` → exit 0 (green; note: pytest 9.1.1 `-q` omits the final count line in output — exit code authoritative)
- `uv run pytest --cov=app --cov-report=term-missing` → **2715 passed, exit 0, TOTAL 99%** (>90% gate)
- `uv run ruff check . && uv run pyright` → "All checks passed!" / "0 errors, 0 warnings, 0 informations"
- `uv run pytest tests/e2e/test_image_documents.py -v --no-cov` → **4 passed, exit 0** (isolation)
**Completion criteria:** (1) images=true → described/embedded/displayed docs: ✅ (E2E + integration) · (2) images=false byte-identical + image docs survive sync: ✅ (E2E negative app + unit/integration) · (3) viewer + chat rendering with alt text; failed description skips + logs, sync completes: ✅ · (4) test/lint/coverage gates: ✅ · (5) commit + phase move: deferred to harness per this pass's rules (working tree left uncommitted).
**Notable deviation (pre-existing, documented in code):** image route uses `require_user` (phase-79 posture, same gate as the document content endpoint) rather than the phase text's "public" parenthetical — matches the endpoint it mirrors.
**Next pending phase:** `123_chat_image_questions`.
61 lines
2.7 KiB
Python
61 lines
2.7 KiB
Python
"""Public app metadata (display name + version) for the frontend brand
|
|
layer, the phase-59 docs-push flag (the "Save as doc" gating), the
|
|
phase-122 image flag (UI affordance gating), and the phase-62 UI
|
|
customization strings (composer placeholder, footer line).
|
|
|
|
Phase 91 (task 01): the three UI strings are now the EFFECTIVE values —
|
|
the ``ui_settings`` row (admin Theme tab) over the env values (B1: DB
|
|
wins when set, env is the fallback), resolved by the SAME
|
|
:func:`app.core.theming.effective_settings` resolver the
|
|
``/api/ui-settings`` API uses, so the brand layer and the tab can never
|
|
disagree. The route opens a short-lived session (the sync-endpoint
|
|
house pattern — the route is sync, matching the middleware world).
|
|
|
|
Phase 91 (task 03): the retired CSS-file theming's ``theme`` key is
|
|
deleted with the mechanism — the five keys below are the entire
|
|
contract (the colors never rode this endpoint; the server injects
|
|
them pre-paint, :mod:`app.core.theming`).
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from fastapi import APIRouter, Depends
|
|
|
|
from app.config import Settings, get_settings
|
|
from app.core import theming
|
|
from app.db import SessionLocal
|
|
|
|
router = APIRouter(tags=["config"])
|
|
|
|
|
|
@router.get("/config")
|
|
def app_config(settings: Settings = Depends(get_settings)) -> dict[str, str | bool]: # noqa: B008
|
|
"""Public app metadata for the frontend brand layer (phase 39) +
|
|
the phase-59 ``docs_repo_configured`` flag + the phase-122
|
|
``images`` flag + the phase-62 UI customization keys
|
|
(``input_placeholder``, ``footer_text``) — all display strings,
|
|
the SAME boot fetch (no new network surface) and the same public
|
|
posture as ``app_name`` (no secrets). Phase 91:
|
|
``app_name`` / ``input_placeholder`` / ``footer_text`` are the
|
|
EFFECTIVE values (the admin Theme tab's ``ui_settings`` row over
|
|
the env values — DB-over-env, B1); the frontend brand layer treats
|
|
an empty string as "keep the template default" (the unset =>
|
|
byte-identical contract). Phase 91 (task 03): the retired
|
|
CSS-file theming's ``theme`` key is gone. Phase 122 (task 01):
|
|
``images`` mirrors ``settings.images`` (the ``BOR_IMAGES`` master
|
|
switch) — consumed by the chat composer (phase 123) to show/hide
|
|
the image-attach control, optionally by the Sources page (an
|
|
"images off" hint). The six keys are the entire response."""
|
|
db = SessionLocal()
|
|
try:
|
|
effective = theming.effective_settings(db, settings)
|
|
finally:
|
|
db.close()
|
|
return {
|
|
"app_name": effective["app_name"],
|
|
"version": settings.app_version,
|
|
"docs_repo_configured": settings.docs_configured,
|
|
"images": settings.images,
|
|
"input_placeholder": effective["input_placeholder"],
|
|
"footer_text": effective["footer_text"],
|
|
}
|