147 lines
5.8 KiB
Python
147 lines
5.8 KiB
Python
"""Integration: migration 0004 (document summaries) schema contract.
|
|
|
|
Drives the **real Alembic engine** against the live dev database
|
|
(``podman compose up -d db``), mirroring the style of
|
|
``test_migration_0002.py`` (information_schema assertions on the state the
|
|
migration must leave). The tests target revision ``0004`` explicitly so
|
|
later migrations (0005, …) cannot break them:
|
|
|
|
* upgrade 0003 → 0004 → ``documents.summary`` (TEXT, nullable) and
|
|
``chunks.is_summary`` (BOOLEAN NOT NULL, default false) both exist, and a
|
|
chunk inserted without the column gets ``is_summary = false`` (pre-0004
|
|
insert paths stay valid);
|
|
* downgrade to 0003 → both columns are gone;
|
|
* upgrade 0003 → 0004 again → both are back (round-trip).
|
|
|
|
The ``alembic`` fixture guarantees the DB ends at head even if a test
|
|
fails or the process is interrupted.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from collections.abc import Iterator
|
|
from typing import Any
|
|
|
|
import pytest
|
|
from alembic.config import Config
|
|
from sqlalchemy import text
|
|
from sqlalchemy.orm import Session
|
|
|
|
from alembic import command
|
|
from app.db import db_available
|
|
|
|
|
|
@pytest.fixture()
|
|
def alembic(db: Session) -> Iterator[Config]:
|
|
"""Real Alembic config bound to the dev DB (URL from app settings).
|
|
|
|
Starts at head (repairs an interrupted earlier run); teardown upgrades
|
|
to head no matter what happened, so the dev DB is never left below
|
|
head.
|
|
"""
|
|
if not db_available():
|
|
pytest.skip("Postgres not reachable — run `podman compose up -d db` first")
|
|
cfg = Config() # no alembic.ini file — env.py gets the URL from app config
|
|
cfg.set_main_option("script_location", "alembic")
|
|
command.upgrade(cfg, "head")
|
|
try:
|
|
yield cfg
|
|
finally:
|
|
command.upgrade(cfg, "head")
|
|
|
|
|
|
def _column(db: Session, table: str, column: str) -> tuple[Any, ...] | None:
|
|
"""(data_type, is_nullable, column_default) for one column, or None."""
|
|
row = db.execute(
|
|
text(
|
|
"SELECT data_type, is_nullable, column_default"
|
|
" FROM information_schema.columns"
|
|
" WHERE table_name = :t AND column_name = :c"
|
|
),
|
|
{"t": table, "c": column},
|
|
).fetchone()
|
|
return tuple(row) if row is not None else None
|
|
|
|
|
|
def _version(db: Session) -> str | None:
|
|
return db.execute(text("SELECT version_num FROM alembic_version")).scalar()
|
|
|
|
|
|
def test_upgrade_to_0004_adds_summary_columns(db: Session, alembic: Config) -> None:
|
|
"""Upgrade 0003 → 0004: both columns exist with the locked types/defaults."""
|
|
command.downgrade(alembic, "0003") # start from the pre-0004 state
|
|
assert _version(db) == "0003"
|
|
|
|
command.upgrade(alembic, "0004")
|
|
assert _version(db) == "0004", "alembic_version must be at 0004"
|
|
|
|
summary = _column(db, "documents", "summary")
|
|
assert summary is not None, "documents.summary is missing"
|
|
assert summary[0] == "text", "documents.summary must be TEXT"
|
|
assert summary[1] == "YES", "documents.summary must be NULLABLE"
|
|
|
|
is_summary = _column(db, "chunks", "is_summary")
|
|
assert is_summary is not None, "chunks.is_summary is missing"
|
|
assert is_summary[0] == "boolean", "chunks.is_summary must be BOOLEAN"
|
|
assert is_summary[1] == "NO", "chunks.is_summary must be NOT NULL"
|
|
assert is_summary[2] is not None and "false" in is_summary[2], (
|
|
"chunks.is_summary must have server default false"
|
|
)
|
|
|
|
|
|
def test_is_summary_defaults_false_for_new_chunks(db: Session, alembic: Config) -> None:
|
|
"""The default keeps old rows/insert paths valid: a chunk inserted
|
|
without the column (the pre-0004 insert shape) lands as ``false``."""
|
|
command.upgrade(alembic, "head")
|
|
doc_id = db.execute(text("SELECT gen_random_uuid()")).scalar()
|
|
try:
|
|
db.execute(
|
|
text(
|
|
"INSERT INTO documents (id, source, path, full_path, title, content,"
|
|
" content_hash, indexed_at) VALUES"
|
|
" (:id, 'mig_test', 't.md', '/t.md', 'T', 'content here',"
|
|
" repeat('0', 64), now())"
|
|
),
|
|
{"id": doc_id},
|
|
)
|
|
db.execute(
|
|
text(
|
|
"INSERT INTO chunks (id, document_id, position, content)"
|
|
" VALUES (gen_random_uuid(), :id, 0, 'content here')"
|
|
),
|
|
{"id": doc_id},
|
|
)
|
|
db.commit()
|
|
flag = db.execute(
|
|
text("SELECT is_summary FROM chunks WHERE document_id = :id"), {"id": doc_id}
|
|
).scalar()
|
|
assert flag is False, "chunks.is_summary must default to false"
|
|
finally:
|
|
db.execute(text("DELETE FROM chunks WHERE document_id = :id"), {"id": doc_id})
|
|
db.execute(text("DELETE FROM documents WHERE id = :id"), {"id": doc_id})
|
|
db.commit()
|
|
|
|
|
|
def test_downgrade_to_0003_removes_columns(db: Session, alembic: Config) -> None:
|
|
"""Downgrade to 0003: both columns are dropped (A13 — reversible)."""
|
|
command.downgrade(alembic, "0003")
|
|
assert _version(db) == "0003"
|
|
|
|
assert _column(db, "documents", "summary") is None, "documents.summary must be dropped"
|
|
assert _column(db, "chunks", "is_summary") is None, "chunks.is_summary must be dropped"
|
|
|
|
|
|
def test_upgrade_round_trip_restores_columns(db: Session, alembic: Config) -> None:
|
|
"""Downgrade to 0003, then upgrade 0003 → 0004: both columns are back."""
|
|
command.downgrade(alembic, "0003")
|
|
command.upgrade(alembic, "0004")
|
|
assert _version(db) == "0004", "round-trip upgrade must land at 0004"
|
|
|
|
summary = _column(db, "documents", "summary")
|
|
assert summary is not None and summary[1] == "YES", "documents.summary must be back"
|
|
|
|
is_summary = _column(db, "chunks", "is_summary")
|
|
assert is_summary is not None and is_summary[1] == "NO", "chunks.is_summary must be back"
|
|
assert is_summary[2] is not None and "false" in is_summary[2], (
|
|
"chunks.is_summary must keep its server default false after the round-trip"
|
|
)
|