Single consolidated commit for four completed, validated phases (77, 78, 79, 80). The pipeline run left all work uncommitted because the harness commits only with PHASE_COMMIT=1 while child executors are forbidden from committing; the phases themselves all passed validation and moved to .agents/phases/complete/. Phase 77 — navbar view refresh - router.js dispatches bor:view-refresh on re-show / active re-click / popstate (gated on wasMounted; first show and boot exempt) - History / RAG / Sources / Tuning re-fetch on refresh (admin branch); Chat deliberately excluded (stream survival) - History "Refresh" button (admin-only, in-flight disable + status line) - New story suite tests/e2e/test_navbar_refresh.py (7 tests) Phase 78 — static background - Removed the animated glow layers; static 44px grid over the flat --bg canvas; default and reduced-motion renders byte-identical - Updated background/theme E2E suites; removed bg-glow test pins Phase 79 — API tokens - api_tokens model + migration 0012; hash-only token service - Admin tokens API + Tokens admin view; POST /api/token-auth; live-revoking require_user on chat / suggestions / document content - Frontend token gate with localStorage cache; anonymous E2E suites migrated to token login - New story suite tests/e2e/test_api_tokens.py (9 tests) Phase 80 — history suggestion chips - last_questions() endpoint with SEED fallback; startNewChat() refetch - Seed-semantics docs (config.py, .env.example, README) - Integration state matrix + E2E suite rewritten to the 4 chip states Also included: phase-76 report artifacts and the repo restore-test-db skill (previously untracked), scripts/* ruff fixes from phase 77. Final gate state (phase 80 final pass, covers everything above): - uv run pytest --cov=app → 1637 passed, 0 failed, app/ coverage 99% - uv run ruff check . && uv run pyright → clean, 0 errors - Per-phase story E2E suites green in isolation
185 lines
7.1 KiB
Python
185 lines
7.1 KiB
Python
"""Phase 03 E2E (Playwright): the happy-path RAG chat turn.
|
|
|
|
Story: ``.agents/user_stories/chat-rag-answer.md``
|
|
Run in isolation (DB must be up: ``podman compose up -d db``):
|
|
|
|
uv run pytest tests/e2e/test_chat_rag.py -v --no-cov
|
|
|
|
Seeding reuses the real importer against ``tests/fixtures/docs/`` with the
|
|
deterministic mock embeddings (same pattern as the phase 02 story suite);
|
|
the mock LLM answers on-topic questions by quoting the question and the
|
|
document context, so the UI assertions are fully deterministic.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import json
|
|
from pathlib import Path
|
|
from threading import Thread
|
|
from typing import Any
|
|
|
|
import httpx
|
|
from playwright.sync_api import Page, expect
|
|
from sqlalchemy import select, text
|
|
|
|
from app.config import Settings
|
|
from app.db import SessionLocal
|
|
from app.models import QueryLog
|
|
from app.rag.importer import ImportSummary, import_sources
|
|
from app.rag.llm import LLMClient
|
|
from e2e.auth_helpers import ADMIN_PASSWORD, login
|
|
|
|
REPO = Path(__file__).resolve().parents[2]
|
|
FIXTURES = REPO / "tests" / "fixtures" / "docs"
|
|
QUESTION = "How is my Kubernetes cluster set up?"
|
|
MOCK_ANSWER_MARKER = "Deterministic mock answer for E2E"
|
|
|
|
|
|
async def _import_fixtures(mock_port: int) -> ImportSummary:
|
|
kwargs: dict[str, Any] = {"_env_file": None, "llm_base_url": f"http://127.0.0.1:{mock_port}/v1"}
|
|
settings = Settings(**kwargs) # pyright: ignore[reportCallIssue]
|
|
return await import_sources([FIXTURES], LLMClient(settings))
|
|
|
|
|
|
def _run_in_thread(coro: Any) -> Any:
|
|
"""Run a coroutine on a worker thread.
|
|
|
|
Playwright's sync API keeps an asyncio loop running on the test thread,
|
|
so ``asyncio.run`` cannot be called directly from a test body.
|
|
"""
|
|
box: dict[str, Any] = {}
|
|
|
|
def runner() -> None:
|
|
try:
|
|
box["value"] = asyncio.run(coro)
|
|
except BaseException as e: # noqa: BLE001 — re-raised on the test thread
|
|
box["error"] = e
|
|
|
|
t = Thread(target=runner)
|
|
t.start()
|
|
t.join()
|
|
if "error" in box:
|
|
raise box["error"]
|
|
return box["value"]
|
|
|
|
|
|
def _reset_db(mock_port: int, seed: bool) -> ImportSummary | None:
|
|
"""Truncate the KB (and query log), then optionally re-import fixtures."""
|
|
with SessionLocal() as db:
|
|
db.execute(text("TRUNCATE chunks, documents, query_log"))
|
|
db.commit()
|
|
if not seed:
|
|
return None
|
|
return _run_in_thread(_import_fixtures(mock_port))
|
|
|
|
|
|
def test_on_topic_question_streams_grounded_answer(
|
|
page: Page, app_url: str, mock_llm: int, db_ready: None
|
|
) -> None:
|
|
summary = _reset_db(mock_llm, seed=True)
|
|
assert summary is not None and summary.added == 13 # A9 formats (phase 47 added quadlet+j2)
|
|
page.set_default_timeout(30_000)
|
|
login(page, app_url, next="/")
|
|
|
|
# Healthy KB: the offline banner must stay hidden.
|
|
expect(page.locator("#kb-banner")).to_be_hidden()
|
|
|
|
page.fill("#message-input", QUESTION)
|
|
page.click("#send-btn")
|
|
|
|
# User bubble (right, brand) shows the question.
|
|
expect(page.locator(".msg.user .bubble")).to_contain_text(QUESTION)
|
|
|
|
# Brain bubble streams in: the mock quotes the question and ends with a
|
|
# deterministic marker — waiting on the marker proves content arrived.
|
|
bubble = page.locator(".msg.brain .bubble")
|
|
bubble.first.wait_for(state="visible", timeout=30_000)
|
|
expect(bubble.first).to_contain_text(QUESTION, timeout=30_000)
|
|
expect(bubble.first).to_contain_text(MOCK_ANSWER_MARKER, timeout=30_000)
|
|
|
|
# Grounded: a kubernetes.md source chip renders under the bubble
|
|
# (top-N docs can add more chips; the question's doc must be among them).
|
|
# Phase 26: the chip opens the document in the SAME-PAGE modal — no new
|
|
# tab; the encoded href stays as the no-JS / context-menu escape hatch
|
|
# (phase 13's back=/ lets the viewer's back button return to chat).
|
|
chip = page.locator(".msg.brain .source-chip", has_text="kubernetes.md")
|
|
expect(chip).to_have_count(1)
|
|
expect(chip.first).to_contain_text("kubernetes.md")
|
|
expect(chip.first).to_have_attribute(
|
|
"href", "/document.html?source=docs&path=homelab%2Fkubernetes.md&back=%2F"
|
|
)
|
|
expect(chip.first).not_to_have_attribute("target") # phase 26: modal, not a new tab
|
|
|
|
# Button recovers: enabled + "Send" (never stale).
|
|
expect(page.locator("#send-btn")).to_be_enabled()
|
|
expect(page.locator("#send-label")).to_have_text("Send")
|
|
|
|
|
|
def test_chat_logs_query(page: Page, app_url: str, mock_llm: int, db_ready: None) -> None:
|
|
_reset_db(mock_llm, seed=True)
|
|
page.set_default_timeout(30_000)
|
|
login(page, app_url, next="/")
|
|
page.fill("#message-input", QUESTION)
|
|
page.click("#send-btn")
|
|
expect(
|
|
page.locator(".msg.brain .source-chip", has_text="kubernetes.md")
|
|
).to_have_count(1, timeout=30_000)
|
|
|
|
# App still healthy after the turn.
|
|
r = httpx.get(f"{app_url}/api/health", timeout=5)
|
|
assert r.status_code == 200
|
|
body = r.json()
|
|
assert body["status"] == "ok" and body["db"] == "up"
|
|
|
|
# Durable record: exactly one query_log row for the turn.
|
|
with SessionLocal() as db:
|
|
rows = db.scalars(select(QueryLog)).all()
|
|
assert len(rows) == 1
|
|
row = rows[0]
|
|
assert row.question == QUESTION
|
|
assert row.deflected is False
|
|
assert row.top_score > 0.0
|
|
assert row.chunk_hits >= 1
|
|
assert "docs/homelab/kubernetes.md" in row.sources
|
|
assert row.latency_ms >= 0
|
|
|
|
|
|
def test_sse_stream_shape(app_url: str, mock_llm: int, db_ready: None) -> None:
|
|
"""Raw transport contract (PLAN §4): delta events, then one done."""
|
|
_reset_db(mock_llm, seed=True)
|
|
|
|
# Phase 79: POST /api/chat is require_user-gated — the httpx client
|
|
# signs in as the admin first (the form login's API side: 204 + the
|
|
# signed session cookie in the jar).
|
|
client = httpx.Client(timeout=60.0)
|
|
r = client.post(f"{app_url}/api/login", json={"password": ADMIN_PASSWORD})
|
|
assert r.status_code == 204
|
|
|
|
frames: list[dict[str, Any]] = []
|
|
with client.stream(
|
|
"POST", f"{app_url}/api/chat", json={"message": QUESTION}, timeout=60.0
|
|
) as r:
|
|
assert r.status_code == 200
|
|
assert r.headers["content-type"].startswith("text/event-stream")
|
|
buf = ""
|
|
for part in r.iter_text():
|
|
buf += part
|
|
while "\n\n" in buf:
|
|
frame, buf = buf.split("\n\n", 1)
|
|
if frame.strip().startswith("data:"):
|
|
frames.append(json.loads(frame.strip().removeprefix("data:").strip()))
|
|
assert buf.strip() == "" # stream ends cleanly on a frame boundary
|
|
|
|
deltas = [f for f in frames if f.get("type") == "delta"]
|
|
assert len(deltas) >= 2, "answer must arrive as multiple deltas (streamed)"
|
|
assert all(d.get("text") for d in deltas)
|
|
assert "".join(d["text"] for d in deltas) # non-empty answer
|
|
|
|
done = [f for f in frames if f.get("type") == "done"]
|
|
assert len(done) == 1
|
|
assert frames[-1]["type"] == "done" # done is the final event
|
|
assert done[0]["deflected"] is False
|
|
assert done[0]["suggestions"] == []
|
|
assert done[0]["sources"], "done must carry the cited sources"
|
|
assert any(s["path"] == "homelab/kubernetes.md" for s in done[0]["sources"])
|