ducoterra
baefcde668
Fixed: index.html meta description, empty-state sub and composer placeholder (A1); app/config.py default suggestion chips → the four neutral A2 defaults (BOR_SUGGESTIONS override unchanged); sources.html KB page-sub → the current source model (git repos + local dirs + uploaded archives, Sync pulls/imports); git-sources.html example URL → your-repo.git (A3); all 9 footers → neutral default in span.footer-text (the phase-62 hook); E2E/unit conftests force the code defaults so a local .env cannot leak corpus copy into tests; new unit text pins + dedicated E2E suite. Task 02 verification read-through — no change needed: - sources.html sync result/error copy (matches the real sync behavior) - tuning.html page-sub (accurate as written) - history.html page-sub (accurate as written) - doc-edit.html page-sub (accurate as written) - git-sources.html page-sub (accurate as written) - #sources-gate anonymous copy (accurate as written)
598 lines
26 KiB
Python
598 lines
26 KiB
Python
"""Unit: the admin "Sync sources" button contract (phase 32, task 02).
|
|
|
|
The browser behavior is E2E-covered (tests/e2e/test_sync_button.py,
|
|
task 03); here we pin the source-level wiring — the anonymous-safe
|
|
ship-hidden button markup, the Sources-page admin reveal on the SAME
|
|
cached whoami (no extra fetch), the sync state machine that now lives
|
|
in sources.js (owner rework 2026-08-28: the button is Sources-page
|
|
only, so the page owns the machine it drives — 2 s poll, 202 start
|
|
/ 409 adoption / 403 hide, terminal labels, the "bor:sync-status"
|
|
event with the status object as detail, the single-poll-loop guard, no
|
|
client-side hard timeout), the page's #sync-result line +
|
|
#sync-error-banner, the lazily created error modal (phase 41), and the
|
|
§7.4 never-stale CSS (spin + reduced-motion opt-out,
|
|
disabled state, 44px floor, contrast pair) — so a silent regression is
|
|
caught without a browser.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
from pathlib import Path
|
|
|
|
FRONTEND = Path(__file__).resolve().parents[2] / "frontend"
|
|
ASSETS = FRONTEND / "assets"
|
|
|
|
HEADER_JS = ASSETS / "header.js"
|
|
SOURCES_JS = ASSETS / "sources.js"
|
|
STYLES_CSS = ASSETS / "styles.css"
|
|
SOURCES_HTML = FRONTEND / "sources.html"
|
|
|
|
|
|
def _text(path: Path) -> str:
|
|
assert path.is_file(), f"missing frontend file: {path}"
|
|
return path.read_text(encoding="utf-8")
|
|
|
|
|
|
def _body(js: str, fn_name: str) -> str:
|
|
"""The source of the first top-level `function <fn_name>` in js."""
|
|
fn = js.find(f"function {fn_name}")
|
|
assert fn != -1, f"{fn_name} must be defined"
|
|
return js[fn : js.find("\n}", fn)]
|
|
|
|
|
|
# ---------- sources.html: anonymous-safe ship-hidden markup ----------
|
|
|
|
|
|
def test_sync_button_ships_hidden_and_labeled() -> None:
|
|
"""#sync-btn SHIPS with the hidden attribute (anonymous-safe —
|
|
sources.js reveals it for the admin at page boot), is a real
|
|
<button type="button">, and carries aria-label="Sync sources" so
|
|
the accessible name stays stable across the label states."""
|
|
tag = re.search(r"<button[^>]*id=\"sync-btn\"[^>]*>", _text(SOURCES_HTML))
|
|
assert tag, "sources.html must carry the #sync-btn button"
|
|
attrs = tag.group(0)
|
|
assert 'class="sync-btn"' in attrs
|
|
assert 'type="button"' in attrs
|
|
assert re.search(r"\bhidden\b", attrs), "#sync-btn must ship hidden"
|
|
assert 'aria-label="Sync sources"' in attrs
|
|
|
|
|
|
def test_sync_button_has_icon_and_label_span() -> None:
|
|
"""The button body is a refresh-cycle svg (aria-hidden — decorative,
|
|
the spin is the visible running state) + the .sync-label span with
|
|
the idle text, so the label can be swapped by sources.js."""
|
|
text = _text(SOURCES_HTML)
|
|
btn = text[text.find('id="sync-btn"') : text.find("</button>", text.find('id="sync-btn"'))]
|
|
assert re.search(r'<svg[^>]*class="sync-icon"[^>]*aria-hidden="true"', btn)
|
|
# class for the module query + id for the E2E label assertions
|
|
label = re.search(
|
|
r'<span\b[^>]*id="sync-label"[^>]*>\s*Sync sources\s*</span>', btn
|
|
)
|
|
assert label, "the #sync-label span carrying the idle text is missing"
|
|
assert 'class="sync-label"' in label.group(0)
|
|
|
|
|
|
def test_sync_result_is_the_aria_live_announcer() -> None:
|
|
"""#sync-result sits right after the button and is a polite live
|
|
region (role="status" + aria-live="polite") — the last-result /
|
|
counts announcement for screen readers."""
|
|
text = _text(SOURCES_HTML)
|
|
tag = re.search(r'<span[^>]*id="sync-result"[^>]*>', text)
|
|
assert tag, "sources.html must carry the #sync-result announcer"
|
|
attrs = tag.group(0)
|
|
assert 'role="status"' in attrs
|
|
assert 'aria-live="polite"' in attrs
|
|
assert text.find('id="sync-result"') > text.find("</button>", text.find('id="sync-btn"'))
|
|
|
|
|
|
def test_sync_error_banner_is_a_hidden_alert() -> None:
|
|
"""The failure banner uses the chat error-banner markup style
|
|
(kb-banner + is-error) and role="alert", shipping hidden —
|
|
sources.js un-hides it with the error text on a failed run."""
|
|
text = _text(SOURCES_HTML)
|
|
tag = re.search(r'<div[^>]*id="sync-error-banner"[^>]*>', text)
|
|
assert tag, "sources.html must carry the #sync-error-banner"
|
|
attrs = tag.group(0)
|
|
assert "kb-banner" in attrs and "is-error" in attrs
|
|
assert 'role="alert"' in attrs
|
|
assert re.search(r"\bhidden\b", attrs)
|
|
assert 'id="sync-error-text"' in text
|
|
# The banner lives in the page content, not the 64px header bar.
|
|
assert text.find('id="sync-error-banner"') > text.find('<main id="main"')
|
|
|
|
|
|
def test_page_sub_copy_mentions_the_button() -> None:
|
|
"""The page-sub copy names the button as the one-click way to pull
|
|
the latest and re-import (the import CLI docs live elsewhere).
|
|
Phase 61: the copy describes the current source model (git repos +
|
|
local directories + uploaded archives), not the old ~/Homelab +
|
|
~/Deployments clone."""
|
|
sub = re.search(r'<p class="page-sub">(.*?)</p>', _text(SOURCES_HTML), re.DOTALL)
|
|
assert sub, "sources.html must keep the .page-sub copy"
|
|
copy = re.sub(r"\s+", " ", sub.group(1)) # the markup wraps lines
|
|
assert "Press <strong>Sync sources</strong>" in copy
|
|
assert "pull the latest and re-import" in copy
|
|
assert "git repositories," in copy
|
|
assert "local directories, and uploaded archives" in copy
|
|
|
|
|
|
def test_sources_page_stays_cdn_free() -> None:
|
|
"""No-CDN rule (PLAN §7.3, A11): the new button markup adds no
|
|
external references — same-origin assets only (the integration
|
|
test_index_html_served_locally re-checks this on the served page)."""
|
|
text = _text(SOURCES_HTML)
|
|
assert 'src="https://' not in text
|
|
assert 'href="https://' not in text
|
|
|
|
|
|
# ---------- sources.js: the admin reveal (page boot) ----------
|
|
|
|
|
|
def test_sources_js_reveals_sync_btn_on_the_admin_branch() -> None:
|
|
"""The page boot reveals #sync-btn for the admin on the SAME cached
|
|
whoami initSharedHeader() used (no extra fetch — header.js keeps
|
|
the single /api/whoami call site); anonymous users never leave the
|
|
ship-hidden default."""
|
|
js = _text(SOURCES_JS)
|
|
boot = js[js.rfind("(async () => {"):]
|
|
assert "const admin = await initSharedHeader()" in boot
|
|
assert "syncBtn.hidden = !admin" in boot, "#sync-btn must join the admin reveal"
|
|
# The reveal must not introduce a second whoami call site.
|
|
header = _text(HEADER_JS)
|
|
assert header.count('fetch("/api/whoami")') == 1
|
|
assert 'fetch("/api/whoami")' not in js
|
|
|
|
|
|
# ---------- sources.js: the sync state machine (moved here from
|
|
# ---------- header.js in the owner rework 2026-08-28) ----------
|
|
|
|
|
|
def test_sources_js_owns_the_sync_button_elements() -> None:
|
|
"""The button refs are module-level and null-safe: #sync-btn, the
|
|
.sync-label inside the button, the .sync-icon inside the button — a
|
|
page without the markup is a complete no-op."""
|
|
js = _text(SOURCES_JS)
|
|
assert 'querySelector("#sync-btn")' in js
|
|
assert 'syncBtn.querySelector(".sync-label")' in js
|
|
assert 'syncBtn.querySelector(".sync-icon")' in js
|
|
|
|
|
|
def test_sources_js_calls_the_sync_api() -> None:
|
|
"""The click posts to POST /api/sync and the poll loop GETs
|
|
/api/sync/status — both through the same-origin API (A10)."""
|
|
js = _text(SOURCES_JS)
|
|
assert 'fetch("/api/sync", { method: "POST" })' in js
|
|
assert 'fetch("/api/sync/status")' in js
|
|
|
|
|
|
def test_sources_js_polls_every_2000ms() -> None:
|
|
"""The feedback loop is a 2000 ms poll of the status endpoint,
|
|
re-scheduled one tick at a time (setTimeout, not setInterval — an
|
|
in-flight fetch can never overlap the next tick)."""
|
|
js = _text(SOURCES_JS)
|
|
assert "SYNC_POLL_MS = 2000" in js
|
|
assert "setTimeout(tick, SYNC_POLL_MS)" in js
|
|
assert "setInterval" not in js
|
|
|
|
|
|
def test_sources_js_adopts_409_and_starts_on_202() -> None:
|
|
"""202 (started) and 409 (a run started elsewhere — e.g. a second
|
|
tab) both enter the running state and start polling: the UI never
|
|
starts a second run, it adopts the in-flight one."""
|
|
js = _text(SOURCES_JS)
|
|
assert "r.status === 202 || r.status === 409" in js
|
|
idx = js.find("r.status === 202 || r.status === 409")
|
|
branch = js[idx : idx + 400]
|
|
assert "enterSyncRunningState()" in branch
|
|
assert "startSyncPolling()" in branch
|
|
|
|
|
|
def test_sources_js_hides_the_button_on_403() -> None:
|
|
"""A 403 anywhere (POST, the status poll, the load re-attach) is
|
|
treated as not-admin: the button hides — defense in depth behind
|
|
the whoami reveal (the primary gate)."""
|
|
js = _text(SOURCES_JS)
|
|
assert len(re.findall(r"r\.status === 403", js)) >= 3, (
|
|
"POST, the status poll, and the load re-attach must all handle 403"
|
|
)
|
|
assert js.count("syncBtn.hidden = true") >= 3, (
|
|
"every 403 branch must hide the button"
|
|
)
|
|
|
|
|
|
def test_sources_js_running_state_is_never_stale() -> None:
|
|
"""Entering the running state disables the button, sets aria-busy,
|
|
spins the icon, and swaps the label to 'Syncing…' (the §7.4
|
|
feedback while the poll waits) — and a fresh run starts clean: the
|
|
previous failure's title / aria-label / .is-error come off NOW,
|
|
not when the run settles."""
|
|
js = _text(SOURCES_JS)
|
|
body = _body(js, "enterSyncRunningState")
|
|
assert "syncBtn.disabled = true" in body
|
|
assert 'syncBtn.setAttribute("aria-busy", "true")' in body
|
|
assert 'syncBtn.removeAttribute("title")' in body
|
|
assert 'syncBtn.setAttribute("aria-label", "Sync sources")' in body
|
|
assert "syncBtn.classList.remove(\"is-error\")" in body
|
|
assert "syncIcon.classList.add(\"is-spinning\")" in body
|
|
assert '"Syncing…"' in body
|
|
|
|
|
|
def test_sources_js_terminal_states() -> None:
|
|
"""Terminal rendering: success → enabled + 'Synced HH:MM' (local
|
|
time of finished_at); failed → enabled + retry-ready 'Sync sources'
|
|
label + the sanitized error in the button's title + aria-label +
|
|
the .is-error class. The counts formatting (fmtSyncResult) lives
|
|
here ('added' always announced, zero terms omitted — a no-op
|
|
re-sync reads '0 added · 1 unchanged')."""
|
|
js = _text(SOURCES_JS)
|
|
|
|
success = _body(js, "applySyncSuccess")
|
|
assert '"Synced"' in success and "fmtSyncTime(status.finished_at)" in success
|
|
|
|
failure = _body(js, "applySyncFailure")
|
|
assert 'settleSyncButton("Sync sources")' in failure # retry-ready
|
|
assert "syncBtn.title = error" in failure
|
|
assert 'syncBtn.setAttribute("aria-label", error)' in failure
|
|
assert "syncBtn.classList.add(\"is-error\")" in failure
|
|
assert "sanitizeSyncError(status.error)" in failure
|
|
|
|
result = _body(js, "fmtSyncResult")
|
|
assert "added" in result and "unchanged" in result
|
|
assert " · " in result
|
|
assert "> 0" in result, "zero terms must be omitted"
|
|
|
|
time = _body(js, "fmtSyncTime")
|
|
assert "getHours()" in time and "getMinutes()" in time, "local HH:MM of finished_at"
|
|
|
|
|
|
def test_sources_js_failed_error_is_sanitized() -> None:
|
|
"""The button's title/aria-label error is sanitized for the
|
|
attributes: the server already masks credentials (sync.py
|
|
_sanitize_error); the page collapses whitespace to a single line
|
|
and caps the length, and a missing error still names a failure."""
|
|
js = _text(SOURCES_JS)
|
|
body = _body(js, "sanitizeSyncError")
|
|
assert "replace(/\\s+/g, \" \")" in body, "single line for the attributes"
|
|
assert "200" in body, "long errors (chatty git stderr) are capped"
|
|
assert '"The sync failed."' in body
|
|
|
|
|
|
def test_sources_js_settles_the_button_on_terminal() -> None:
|
|
"""settleSyncButton re-enables the control, drops aria-busy, the
|
|
title, and the failed affordances, and un-spins the icon — the
|
|
button can never sit disabled after a run reaches a terminal state
|
|
(failed included: retry-ready)."""
|
|
js = _text(SOURCES_JS)
|
|
body = _body(js, "settleSyncButton")
|
|
assert "syncBtn.disabled = false" in body
|
|
assert 'syncBtn.removeAttribute("aria-busy")' in body
|
|
assert 'syncBtn.removeAttribute("title")' in body
|
|
assert 'syncBtn.setAttribute("aria-label", "Sync sources")' in body
|
|
assert "syncIcon.classList.remove(\"is-spinning\")" in body
|
|
|
|
|
|
def test_sources_js_never_starts_a_second_poll_loop() -> None:
|
|
"""startSyncPolling is guarded by the module-level timer: a 409
|
|
adoption, a reload re-attach, or a stray call can never run two
|
|
poll loops at once (phase completion criterion)."""
|
|
js = _text(SOURCES_JS)
|
|
fn = js.find("function startSyncPolling")
|
|
head = js[fn : js.find("const tick", fn)]
|
|
assert re.search(r"if\s*\(\s*syncPollTimer\s*!==\s*null\s*\)\s*return", head), (
|
|
"the single-loop guard must be the first statement"
|
|
)
|
|
assert "clearTimeout(syncPollTimer)" in _body(js, "stopSyncPolling")
|
|
|
|
|
|
def test_sources_js_has_no_client_side_hard_timeout() -> None:
|
|
"""Phase locked decision: a sync can legitimately run for minutes
|
|
(and outlive the page), so there is NO client-side hard timeout —
|
|
the 2 s poll is the feedback loop and the server state is
|
|
authoritative (the 120 s LLM-turn guard must not leak into the
|
|
sync path)."""
|
|
js = _text(SOURCES_JS)
|
|
assert "TURN_TIMEOUT" not in js
|
|
sync_start = js.find("Sync sources button (Sources page only)")
|
|
assert sync_start != -1, "the sync section marker comment"
|
|
assert "120" not in js[sync_start:]
|
|
|
|
|
|
def test_sources_js_reattaches_on_load_admin_only() -> None:
|
|
"""initSyncButton (run at page boot, after the click binding)
|
|
awaits the SAME cached whoami — ADMIN ONLY (non-admins never poll,
|
|
the status endpoint is admin-only): a running run re-enters the
|
|
running state (reload mid-sync), a terminal run renders its last
|
|
result, idle settles retry-ready; the click binding wires
|
|
startSync to the button."""
|
|
js = _text(SOURCES_JS)
|
|
fn = js.find("function initSyncButton")
|
|
assert fn != -1
|
|
body = js[fn : js.find("\n}\n", fn)]
|
|
assert "await fetchIsAdmin()" in body, "admin-only boot (no extra fetch)"
|
|
assert 'fetch("/api/sync/status")' in body
|
|
assert 'status.state === "running"' in body
|
|
assert 'status.state === "success"' in body
|
|
assert 'status.state === "failed"' in body
|
|
assert (
|
|
'syncBtn.addEventListener("click", startSync);\n initSyncButton();'
|
|
in js
|
|
), "the click binding and the boot re-attach ship together, guarded on syncBtn"
|
|
|
|
|
|
def test_sources_js_emits_bor_sync_status_on_state_changes() -> None:
|
|
"""Every state change dispatches window 'bor:sync-status' with the
|
|
status object as detail — the channel other page scripts (or
|
|
future ones) can subscribe to. The click path emits the synthetic
|
|
running frame IMMEDIATELY (no 2 s poll lag)."""
|
|
js = _text(SOURCES_JS)
|
|
assert (
|
|
'window.dispatchEvent(new CustomEvent("bor:sync-status", { detail: status }))'
|
|
in js
|
|
)
|
|
for fn in ("applySyncSuccess", "applySyncFailure", "applySyncIdle"):
|
|
assert "emitSyncStatus" in _body(js, fn), f"{fn} must emit its frame"
|
|
# the running frame: synthetic on click, the real object on boot
|
|
assert 'emitSyncStatus({ state: "running" })' in js
|
|
assert "emitSyncStatus(status)" in _body(js, "initSyncButton")
|
|
|
|
|
|
# ---------- sources.js: the sync failure modal (phase 41, TODO.md L4) ----------
|
|
|
|
|
|
def test_sources_js_owns_a_lazily_created_sync_modal() -> None:
|
|
"""The modal is page-owned and created lazily ONCE (module-level
|
|
`let syncModal = null`): a .sync-modal-backdrop holding a
|
|
.sync-modal panel with role="alertdialog" + aria-modal +
|
|
labelled/described ids + the close button, appended to
|
|
document.body — no page-markup changes needed (the section marker
|
|
records that the former header.js modal was recreated here)."""
|
|
js = _text(SOURCES_JS)
|
|
assert "let syncModal = null" in js, "module-level once-only modal ref"
|
|
assert 'role="alertdialog"' in js
|
|
assert 'aria-modal="true"' in js
|
|
assert 'aria-labelledby="sync-modal-title"' in js
|
|
assert 'aria-describedby="sync-modal-error"' in js
|
|
assert "sync failure modal" in js, "the modal section marker"
|
|
create = _body(js, "createSyncModal")
|
|
assert "sync-modal-backdrop" in create
|
|
assert 'document.body.appendChild(backdrop)' in create
|
|
assert "return backdrop" in create, "the module ref must hold the created element"
|
|
assert "Sync failed" in create, "the dialog title"
|
|
assert 'class="sync-modal-close"' in create
|
|
assert 'aria-label="Close error dialog"' in create
|
|
|
|
|
|
def test_sync_modal_error_is_rendered_via_text_content() -> None:
|
|
"""The error text is ALWAYS set via textContent (XSS-safe — no
|
|
innerHTML with user data in the open path), and it is set BEFORE
|
|
the already-open check, so a second failure while open updates the
|
|
text IN PLACE (no stacking, no focus jump)."""
|
|
js = _text(SOURCES_JS)
|
|
body = _body(js, "showSyncModal")
|
|
assert 'querySelector("#sync-modal-error").textContent' in body
|
|
assert "innerHTML" not in body, "the open path never touches innerHTML"
|
|
text = body.find("textContent")
|
|
open_check = body.find('contains("is-open")')
|
|
assert text != -1 and open_check != -1 and text < open_check, (
|
|
"the in-place update happens while the modal is already open"
|
|
)
|
|
|
|
|
|
def test_sync_modal_focus_goes_in_and_out_to_sync_btn() -> None:
|
|
"""On open: document.activeElement is remembered and focus moves
|
|
to the close button — with a fallback to #sync-btn when the active
|
|
element is <body> (the run's disabled button dropped focus there;
|
|
the close must still land on the control that started the run);
|
|
on close: focus returns to the remembered element (guarded by
|
|
document.contains — a detached target is a no-op)."""
|
|
js = _text(SOURCES_JS)
|
|
open_body = _body(js, "showSyncModal")
|
|
assert "const active = document.activeElement" in open_body
|
|
assert "active !== document.body" in open_body, (
|
|
"the disabled-button window leaves focus on <body> — the fallback"
|
|
)
|
|
assert "? active : syncBtn" in open_body, ("the fallback remembers #sync-btn")
|
|
assert 'querySelector(".sync-modal-close").focus()' in open_body
|
|
close_body = _body(js, "closeSyncModal")
|
|
assert "document.contains(target)" in close_body
|
|
assert "target.focus()" in close_body
|
|
assert 'contains("is-open")' in close_body, "closing a closed modal is a no-op"
|
|
|
|
|
|
def test_sync_modal_closes_via_button_esc_and_backdrop() -> None:
|
|
"""All three dismissal paths call the SAME close function: the
|
|
close button, Esc (ONE document keydown binding, acting only while
|
|
the modal is open), and a click on the backdrop element itself —
|
|
the event.target check keeps clicks bubbling from the panel from
|
|
closing it."""
|
|
js = _text(SOURCES_JS)
|
|
create = _body(js, "createSyncModal")
|
|
assert 'addEventListener("click", closeSyncModal)' in create
|
|
assert 'e.key === "Escape"' in create
|
|
assert 'addEventListener("keydown"' in create
|
|
assert 'backdrop.classList.contains("is-open")' in create
|
|
assert "e.target === backdrop" in create
|
|
|
|
|
|
def test_sources_js_apply_sync_failure_opens_the_modal_after_the_event() -> None:
|
|
"""applySyncFailure opens the modal with the SANITIZED error, and
|
|
the call comes AFTER the existing button title/aria/.is-error
|
|
lines + emitSyncStatus (the bor:sync-status event — those lines
|
|
stay byte-identical; the modal is additive)."""
|
|
js = _text(SOURCES_JS)
|
|
body = _body(js, "applySyncFailure")
|
|
call = body.find("showSyncModal(")
|
|
emit = body.find("emitSyncStatus(status)")
|
|
assert call != -1, "the modal must open from the failure path"
|
|
assert emit != -1 and call > emit, "the event still emits first (byte-identical)"
|
|
assert "showSyncModal(error)" in body, "the sanitized error goes to the modal"
|
|
# The pre-existing affordances stay (the Sources banner contract).
|
|
assert "syncBtn.title = error" in body
|
|
assert 'syncBtn.setAttribute("aria-label", error)' in body
|
|
assert 'syncBtn.classList.add("is-error")' in body
|
|
assert "emitSyncStatus(status)" in body
|
|
|
|
|
|
# ---------- sources.js: the page-specific result line + banner ----------
|
|
|
|
|
|
def test_sources_js_renders_result_line_and_banner_directly() -> None:
|
|
"""sources.js owns the page-specific rendering on the Sources page:
|
|
#sync-result (aria-live) + #sync-error-banner (role=alert), driven
|
|
directly by the state appliers: success → the counts (fmtSyncResult)
|
|
+ a live catalog refresh; failed → the banner with the sanitized
|
|
error; every state change still emits 'bor:sync-status' (the status
|
|
object as detail) for other subscribers."""
|
|
js = _text(SOURCES_JS)
|
|
success = _body(js, "applySyncSuccess")
|
|
assert "syncResult.textContent = fmtSyncResult(status.detail)" in success, (
|
|
"the counts live in status.detail — a bare status renders all zeros"
|
|
)
|
|
assert "loadDocs()" in success, "the catalog re-fetches live on a successful sync"
|
|
failure = _body(js, "applySyncFailure")
|
|
assert "showSyncError(error)" in failure
|
|
assert "emitSyncStatus" in _body(js, "applySyncIdle")
|
|
assert (
|
|
'window.dispatchEvent(new CustomEvent("bor:sync-status", { detail: status }))'
|
|
in _body(js, "emitSyncStatus")
|
|
)
|
|
|
|
|
|
def test_header_js_no_longer_owns_the_sync_machine() -> None:
|
|
"""The state machine is GONE from header.js (sources.js owns it —
|
|
the button is Sources-page only, so the page drives it): no button
|
|
refs, no POST, no status poll, no button-state helpers, no modal.
|
|
sources.js keeps every one of them."""
|
|
header = _text(HEADER_JS)
|
|
for gone in (
|
|
"SYNC_POLL_MS",
|
|
"syncPollTimer",
|
|
"startSyncPolling",
|
|
"stopSyncPolling",
|
|
"enterSyncRunningState",
|
|
"settleSyncButton",
|
|
"applySyncSuccess",
|
|
"applySyncFailure",
|
|
"applySyncIdle",
|
|
"initSyncButton",
|
|
"syncModal",
|
|
"syncBtn",
|
|
'fetch("/api/sync", { method: "POST" })',
|
|
'fetch("/api/sync/status")',
|
|
'querySelector("#sync-btn")',
|
|
):
|
|
assert gone not in header, f"{gone!r} must be gone from header.js (sources.js owns it)"
|
|
js = _text(SOURCES_JS)
|
|
for kept in (
|
|
"SYNC_POLL_MS = 2000",
|
|
"syncPollTimer",
|
|
"startSyncPolling",
|
|
"enterSyncRunningState",
|
|
"initSyncButton",
|
|
'fetch("/api/sync", { method: "POST" })',
|
|
'fetch("/api/sync/status")',
|
|
'querySelector("#sync-btn")',
|
|
):
|
|
assert kept in js, f"{kept!r} must be in sources.js (the owner)"
|
|
|
|
|
|
# ---------- styles.css: the §7.4 states ----------
|
|
|
|
|
|
def test_sync_button_css_ghost_pill_and_disabled_state() -> None:
|
|
""".sync-btn is a pill in the shared button family (contrast pair
|
|
ink-soft on surface ≥ 4.5:1), with a ≥44px touch floor and a
|
|
:disabled state (never stale — the busy look is visible)."""
|
|
css = _text(STYLES_CSS)
|
|
block = re.search(r"\.sync-btn\s*\{([^}]*)\}", css)
|
|
assert block, "styles.css must define .sync-btn"
|
|
body = block.group(1)
|
|
assert "min-height: 44px" in body
|
|
assert "color: var(--ink-soft)" in body
|
|
assert "border-radius: 999px" in body
|
|
disabled = re.search(r"\.sync-btn:disabled\s*\{([^}]*)\}", css)
|
|
assert disabled, ".sync-btn:disabled must be styled"
|
|
assert "cursor: wait" in disabled.group(1)
|
|
|
|
|
|
def test_sync_icon_spins_and_respects_reduced_motion() -> None:
|
|
"""The running state spins the refresh icon on the shared spin
|
|
keyframes (1s linear infinite), and prefers-reduced-motion stills
|
|
it — the existing opt-out pattern."""
|
|
css = _text(STYLES_CSS)
|
|
spin = re.search(r"\.sync-btn \.sync-icon\.is-spinning\s*\{([^}]*)\}", css)
|
|
assert spin, "the .is-spinning state must be styled"
|
|
assert "animation: spin 1s linear infinite" in spin.group(1)
|
|
spinner = r"\.sync-btn \.sync-icon\.is-spinning\s*\{([^}]*)\}"
|
|
reduced = re.search(r"@media \(prefers-reduced-motion: reduce\)\s*\{\s*" + spinner, css)
|
|
assert reduced, "the spin must opt out under prefers-reduced-motion"
|
|
assert "animation: none" in reduced.group(1)
|
|
assert "@keyframes spin" in css, "the spin keyframes are shared (pre-existing)"
|
|
|
|
|
|
def test_sync_result_is_styled() -> None:
|
|
"""#sync-result (the aria-live last-result line) is styled in the
|
|
theme tokens — soft ink, small mono, no wrap in the header bar."""
|
|
css = _text(STYLES_CSS)
|
|
block = re.search(r"\.sync-result\s*\{([^}]*)\}", css)
|
|
assert block, "styles.css must define .sync-result"
|
|
assert "var(--ink-soft)" in block.group(1)
|
|
|
|
|
|
# ---------- styles.css: the sync failure modal (phase 41, TODO.md L4) ----------
|
|
|
|
|
|
def test_sync_modal_css_error_palette_and_stacking() -> None:
|
|
""".sync-modal-backdrop: fixed, full-viewport, rgba dim, z-index
|
|
above the sticky header; .sync-modal: the centered ≈28rem panel on
|
|
the phase-08 error palette (panel on --err-bg, 1px --err-line
|
|
border, --err-ink error text, --ink title — all computed ≥4.5:1);
|
|
open/close via .is-open (visibility/opacity)."""
|
|
css = _text(STYLES_CSS)
|
|
backdrop = re.search(r"\.sync-modal-backdrop\s*\{([^}]*)\}", css)
|
|
assert backdrop, "styles.css must define .sync-modal-backdrop"
|
|
b = backdrop.group(1)
|
|
assert "position: fixed" in b
|
|
assert "inset: 0" in b
|
|
assert "z-index: 1000" in b, "above the sticky header (20) + skip-link (100)"
|
|
assert "rgba(" in b, "the dim over the page"
|
|
open_state = re.search(r"\.sync-modal-backdrop\.is-open\s*\{([^}]*)\}", css)
|
|
assert open_state, ".is-open must be the open state"
|
|
assert "visibility: visible" in open_state.group(1)
|
|
assert "opacity: 1" in open_state.group(1)
|
|
panel = re.search(r"\.sync-modal\s*\{([^}]*)\}", css)
|
|
assert panel, "styles.css must define .sync-modal"
|
|
p = panel.group(1)
|
|
assert "max-width: 28rem" in p
|
|
assert "var(--err-bg)" in p
|
|
assert "var(--err-line)" in p
|
|
title = re.search(r"#sync-modal-title\s*\{([^}]*)\}", css)
|
|
assert title, "the modal title must be styled"
|
|
assert "var(--ink)" in title.group(1)
|
|
error = re.search(r"#sync-modal-error\s*\{([^}]*)\}", css)
|
|
assert error, "the modal error line must be styled"
|
|
assert "var(--err-ink)" in error.group(1)
|
|
|
|
|
|
def test_sync_modal_close_button_touch_floor() -> None:
|
|
"""The close button keeps the 44px touch floor at every width (the
|
|
global 3px :focus-visible outline applies — no per-button
|
|
override)."""
|
|
css = _text(STYLES_CSS)
|
|
block = re.search(r"\.sync-modal-close\s*\{([^}]*)\}", css)
|
|
assert block, "styles.css must define .sync-modal-close"
|
|
assert "min-width: 44px" in block.group(1)
|
|
assert "min-height: 44px" in block.group(1)
|
|
|
|
|
|
def test_sync_modal_respects_reduced_motion() -> None:
|
|
"""The open/close fade is stilled under prefers-reduced-motion —
|
|
the phase-25 / doc-modal opt-out pattern."""
|
|
css = _text(STYLES_CSS)
|
|
reduced = re.search(
|
|
r"@media \(prefers-reduced-motion: reduce\)\s*\{\s*\.sync-modal-backdrop\s*\{([^}]*)\}",
|
|
css,
|
|
)
|
|
assert reduced, "the backdrop fade must opt out under prefers-reduced-motion"
|
|
assert "transition: none" in reduced.group(1)
|