ducoterra
a19d78d284
**Phase 122 (image documents) — final verification pass: all green. No code changes were needed; defects found: none.**
**Verified (implementation already complete in working tree, reviewed end-to-end):**
- Toggle (`BOR_IMAGES`/`BOR_IMAGE_EXTENSIONS`/`BOR_IMAGE_DIR`, off by default) + `GET /api/config` `images` flag
- Ingest: bytes digest, `image_dir` persistent copy, `content = summary = vision description` (chat-model call; only text embedded), fail-soft skip + `images_failed` counter
- Serve/display: `/api/documents/{id}/image` route (404 matrix), viewer `<img>` + description, Sources 48px lazy thumbnails, chat inline source figure (alt = summary), agent `read` marker
- Prune guard: images-off syncs never prune `is_image` docs
**Test / lint / coverage (exact commands & outcomes):**
- `uv run pytest` → exit 0 (green; note: pytest 9.1.1 `-q` omits the final count line in output — exit code authoritative)
- `uv run pytest --cov=app --cov-report=term-missing` → **2715 passed, exit 0, TOTAL 99%** (>90% gate)
- `uv run ruff check . && uv run pyright` → "All checks passed!" / "0 errors, 0 warnings, 0 informations"
- `uv run pytest tests/e2e/test_image_documents.py -v --no-cov` → **4 passed, exit 0** (isolation)
**Completion criteria:** (1) images=true → described/embedded/displayed docs: ✅ (E2E + integration) · (2) images=false byte-identical + image docs survive sync: ✅ (E2E negative app + unit/integration) · (3) viewer + chat rendering with alt text; failed description skips + logs, sync completes: ✅ · (4) test/lint/coverage gates: ✅ · (5) commit + phase move: deferred to harness per this pass's rules (working tree left uncommitted).
**Notable deviation (pre-existing, documented in code):** image route uses `require_user` (phase-79 posture, same gate as the document content endpoint) rather than the phase text's "public" parenthetical — matches the endpoint it mirrors.
**Next pending phase:** `123_chat_image_questions`.
54 lines
2.2 KiB
Python
54 lines
2.2 KiB
Python
"""Shared test fakes (no network, deterministic)."""
|
|
from __future__ import annotations
|
|
|
|
from typing import Any
|
|
|
|
from app.config import Settings
|
|
from app.rag.llm import LLMError
|
|
|
|
|
|
class FakeEmbedder:
|
|
"""Duck-typed stand-in for :class:`app.rag.llm.LLMClient` (see the
|
|
``Embedder`` protocol in :mod:`app.rag.importer`).
|
|
|
|
Returns deterministic vectors of *dim* dimensions; records every call
|
|
so tests can assert batching behaviour. ``chat`` is the deterministic
|
|
``lite``-model stand-in (phase 30): it returns
|
|
``"Summary of <first token of the user content>"`` and raises
|
|
:class:`LLMError` when the content contains the sentinel word
|
|
``SUMMARY-BLOWUP`` (drives the importer's fail-soft summary path).
|
|
``content`` may be a string or a phase-122 multimodal part list
|
|
(``dict[str, Any]`` messages, the ``LLMClient.chat`` shape) — the
|
|
text-summary body above is string-only; a subclass handling the
|
|
multimodal image description (task 03's vision mock) overrides
|
|
``chat``.
|
|
"""
|
|
|
|
def __init__(self, dim: int = 768) -> None:
|
|
self.dim = dim
|
|
self.settings = Settings(_env_file=None) # pyright: ignore[reportCallIssue]
|
|
self.embed_batches = 0
|
|
self.calls: list[list[str]] = []
|
|
self.chat_calls: list[list[dict[str, str]]] = []
|
|
|
|
async def embed(self, texts: list[str]) -> list[list[float]]:
|
|
self.calls.append(list(texts))
|
|
self.embed_batches += 1
|
|
return [[0.01 * (i % 97) for i in range(self.dim)] for _ in texts]
|
|
|
|
async def embed_one(self, text: str) -> list[float]:
|
|
"""The retrieval/probe convenience path — delegates to :meth:`embed`
|
|
(satisfies the phase-41 pre-sync model probe)."""
|
|
(vec,) = await self.embed([text])
|
|
return vec
|
|
|
|
async def chat(
|
|
self, messages: list[dict[str, Any]], model: str | None = None
|
|
) -> str:
|
|
self.chat_calls.append(list(messages))
|
|
user = next((m["content"] for m in messages if m.get("role") == "user"), "")
|
|
if "SUMMARY-BLOWUP" in user:
|
|
raise LLMError("simulated lite-model failure (SUMMARY-BLOWUP sentinel)")
|
|
first = user.split()
|
|
return "Summary of " + (first[0] if first else "<empty>")
|