Files

T

ducoterra 895f309f8e phase: 22_disks_hide_unconfigured

All green. Final report:

**Verified (phase 22 final pass — both task files already in `complete/`)**
- `api._disk_visible` (`is not False`) is the single gate, applied to the assembled host list in `/api/disks/snapshot` **and** `/api/summary`'s disks block before the fleet sum and the rows; `sources/disks.py`, `page-disks.js`, `poller.py`, `store.py` and `alerts.py` are byte-unchanged (`git diff --stat`: only `api.py`, `test_api.py`, docs).
- Re-ran the live browser pass `data/logs/22-task02-disks-live.cjs` against the running dev server: **34/34 PASS** — no gateway card/why-line, `2/2 hosts answering`, fleet header reads the API's `2 of 2` / `17-17-0-1`, deskwork `nvme0n1` OK 47 °C/19 202 h/11 %, driveripper 16 live cards + `13 uncorrectable` chip, both aria-labelled plots, `/` still 3 fleet rows. Screenshots + `22-task02-api.json` refreshed.
- `./scripts/dev-server.sh status`: all **nine sources `ok`**, `disks:gateway` included; live `/api/events?source=disks` still carries gateway transitions (10 of 45), proving the README/AGENTS claim the gate hides a row and not the job's history.

**Completion criteria**
- `false` host absent from both endpoints, `None` + `unreachable` stub present, fleet ≡ row count: **PASS** (6 pins in `tests/test_api.py`, incl. the single-hidden-host = 200-with-empty-list leg).
- Live `/disks` = deskwork + driveripper, header 2 hosts, cards unchanged, screenshot in `data/logs/`: **PASS** (re-run above).
- `uv run pytest` → **1477 passed, 15 skipped**; `--cov --cov-fail-under=94` → **98.94 %** (`api.py` 100 %); `ruff check src tests agent` → all passed; `pyright` → 0 errors; `bash .agents/validate.sh` → **EXIT 0**. `uv run pytest -m live --live` → **11 passed**.
- No behaviour change in completed work: **PASS** (unchanged files above; live numbers match the pre-phase fleet record).

**Docs** — README: `/disks` page-table row + the agent SMART paragraph now distinguish "cannot read drives" (dimmed cards kept) from "no smartctl" (host absent from the page/API lists). AGENTS.md: hermetic tally 1471→**1477**, and the `collectors.py`/`api.py` passages now note the `false` arm never reaches the `/disks` why-line while an overview alert from a hidden host's `disks` job still names it. Everything else (routes vs served table, env table vs `config.py`, commands, scripts/fixtures/tests references, masthead/POLL_MS/threshold/retention claims) **verified consistent**.

**Deviations** — `NOTES.md` left empty by the task runs (both notes are tracked: mTLS → phase 24 `todo/`, the admin-links bug → fixed in phase 20 task 04); `/disks`' `#hosts-empty` copy left as pinned markup (it already names smartmontools + the disk group, so an all-hidden fleet is still told the fix); validate's advisory `fastapi 0.153.0 → 0.156.4` untouched (no dependency changed this phase). No live fleet writes of any kind.

**Next pending phase:** `23_llm_rate_responsiveness`.

2026-10-21 03:27:08 -04:00

2.7 KiB

Raw Blame History

Task 02 — Live verification: gateway gone, the rest intact

Phase: 22_disks_hide_unconfigured · Source: TODO.md:13 — "VMs that don't have smartctl enabled disks should not show up. Gateway shouldn't even be a host on the disks page." Story: n/a

Objective

The gate is proven on the live fleet, read-only: the dev server (invariant 10: ./scripts/dev-server.sh restart, sign in with testpass) answers /api/health with all nine sources ok, the /disks page shows deskwork and driveripper only, and every number that used to render still renders. No fleet change is made — this task dials the fleet and screenshots it.

Work

./scripts/dev-server.sh restart — the dev server up on http://127.0.0.1:8090; ./scripts/dev-server.sh status — the nine-source table: host:driveripper, host:deskwork, host:gateway, disks:driveripper, disks:deskwork, disks:gateway, nut, llm:gufo, llm:vllm all ok (gateway's agent still answers — the job is ok; only the page hides it, which is the point: the disks:gateway health record must not be touched by the API filter, and status is the proof).
Signed-in GET /api/disks/snapshot: no gateway entry, deskwork and driveripper present with their smartctl_available: true payloads; GET /api/summary: the disks block's hosts_total is 2, the per-host rows are the two, and the system block still lists all three hosts (the filter is /disks-scoped only — a system host list that lost gateway would be the over-reach the pin must catch).
Browser on /disks (invariant 10): the fleet header reads the two-host sum; gateway has no card and no why-line; deskwork's nvme0n1 and driveripper's 16 drives render exactly as before the phase (the live SMART numbers from the fleet record); a screenshot in data/logs/.
The None-arm check: no live host is currently None (all three agents post-date the SMART pass), so the None arm is proven by the task-01 pins only — state that in the notes rather than fabricating a live case.

Testing & Quality

Coverage: n/a (verification task; the gate's coverage is task 01's)
The read-only rule: no POST to the fleet, no upsd command, no unit change — a live test that writes is not a test (AGENTS.md testing policy)

Completion Criteria

./scripts/dev-server.sh status — nine sources ok, including disks:gateway (the job is healthy; only the page hides it)
/api/disks/snapshot has no gateway entry; /api/summary's system block still lists gateway (screenshot or transcript in data/logs/)
the /disks page shows the two live hosts with their pre-phase numbers (screenshot in data/logs/)
the full suite + bash .agents/validate.sh green

2.7 KiB Raw Blame History