Files

T

ducoterra ad993c7b03 phase: 01_severity_language

**Gate defect found & fixed (the "does not lint" bug).** `.agents/validate.sh` — the phase gate — ran `python3 -m pytest` on `/usr/bin/python3` + `~/.local` site-packages (not the uv venv), ran `ruff check .` *only if* a ruff happened to be on PATH, and **never ran pyright or the coverage floor**. Rewrote it to the project's real gate: cd to repo root → `uv run pytest --cov --cov-fail-under=94` → `uv run ruff check src tests agent` → `uv run pyright` → `node --check web/static/*.js` → hygiene gates; a missing toolchain now fails loudly. Provoked it to confirm it bites (floor + a seeded F401 both fail).

**Verification (all green)**
- `bash .agents/validate.sh` → **exit 0**: 356 passed, 6 skipped · coverage **94.75%** (floor 94) · ruff `All checks passed!` · pyright `0 errors` · node syntax clean
- `uv run pytest --cov` → `severity.py` **100%**; `uv run pytest -m live --live` → **6 passed**; `uv pip list --outdated` → empty
- Criteria: `classify('cpu.usage_pct',…)` → `fail`/`ok`/`None` ✓ · `/api/ups/snapshot` carries `severity` beside `charge_pct`/`load_pct`/`battery_runtime` (apc now live-`warn` at 498 s — threshold working) ✓ · no `.sev-*`/synonym vocabulary (only a comment saying so) ✓ · pytest/coverage/lint ✓ · dev server restarted, `/api/health` ok 6/6 sources, all pages+assets 200 ✓
- Chromium against live fleet: `severityFrom` cell→`fail`, bare→`warn`, null→`''`, unrated→`''`; `hero` fail → `rgb(207,34,46)`, null → `n/a` with **no** verdict class, warn+bar 42%; all four pages render unchanged → `data/logs/phase01-final-{index,system,llm,ups}.png`

**Docs (full review, incl. pre-existing drift).** README: `/ups` row claimed "upsd on 3493" (fleet is 3051, stated elsewhere in the same file); config table omitted `DASH_HOST/PORT`, llm/ups `*_INTERVAL_SECONDS`, `*_TIMEOUT_SECONDS`, `GUFO/VLLM_API_KEY`, `POLL_MS_*`, `DEBUGPY` (+ dedup); severity bullet omitted `disks`/`gpus[]`/rated LLM cells and the ratio rescale; agent section listed only `/snapshot` though `/info`+`/health` exist. AGENTS.md: same 3493 claim; `install-agent.sh --token-file` (its flags are `--bind/--port/--token/--rotate-token/--status/--uninstall` — it hands *the agent* `--token-file`); gap 3 "Two commits" (now 6, still no `origin`); gap 1 given the sudoers install command + verified live gating reason; coverage line now 80% repo floor vs 94% gate floor; cyberpower `identity.model: GX1500U` vs `ups.description` quirk. `.env.dev.example`: `DEV_FORWARDS` remote port 3493→3051 and engine URLs that pointed at `127.0.0.1` with nothing forwarding them.

**Deviations.** No `ruff format` (30 files would reformat; the project gate is `ruff check` + pyright — reformatting completed phases is out of scope). **No live-infra changes**: enabling the battery-test buttons needs `deploy/nut-sudoers` installed on driveripper + a nut-server restart and a scoped `[dashboards]` `instcmds` user — prod write with a documented shutdown risk (AGENTS gap 1), so repo-side only. 36 pre-existing `ResourceWarning: unclosed database` from test fixtures are noise, not failures; left rather than churn ~15 fixtures. `severity.attach()` is unit-tested but has no production call site until phases 02–05.

**Next pending phase:** `02_overview_fleet_and_alerts` (`01_alerts_builder.md`).

2026-10-16 22:22:26 -04:00

2.6 KiB

Raw Permalink Blame History

Phase 01 — Severity language

Source: TODO.md L5, L7 — "proper green (good), yellow (warn), red (danger) color coding" / "charge, load, and runtime left to be big, obvious, and color coded" Story: n/a Context: .agents/PLAN.md → Architectural Anchors (severity computed in Python, JS renders classes), src/dashboards/sources/host.py, src/dashboards/sources/nut.py, src/dashboards/api.py, src/dashboards/web/static/dash.css, src/dashboards/web/static/app.js

Objective

Introduce one place that decides whether a number is fine, worrying, or bad, and put that verdict on the values the API already returns. Phases 02–05 all want the same colour language; doing it here means they render a class instead of each inventing its own thresholds.

Deliverable: severity next to the value in the payloads the pages colour, and CSS/JS helpers that make a "hero number" one call.

Dependencies

— (none)

Tasks

01_severity_module.md — src/dashboards/severity.py: the threshold table and the classifier, unit-tested.
02_severity_in_payloads.md — attach severity to host and UPS values and to the /api/summary rows; API tests.
03_hero_number_style.md — a .hero big-number style on the existing .ok/.warn/.fail colours, plus Dash.hero() and Dash.severityFrom(payload) so pages read the verdict instead of passing thresholds.

Testing & Quality

Unit: every threshold boundary (below warn, exactly at warn, between, exactly at danger, above), None input, and the "unknown is not ok" rule — a value the upstream does not publish must get severity: null, never a green pass.
API: /api/system/snapshot, /api/ups/snapshot, /api/summary carry severity where the spec says, and no existing field changes name or meaning (additive-only anchor).
Coverage: >90% on new/modified code.
Live: uv run pytest -m live --live must stay at 6 passed.

Completion Criteria

uv run python -c "from dashboards import severity; print(severity.classify('cpu.usage_pct', 95))" → fail; 60 → ok; None → None
curl -s localhost:8090/api/ups/snapshot | python3 -m json.tool shows severity beside charge_pct, load_pct, battery_runtime
no new colour vocabulary: classes stay .ok / .warn / .fail as in dash.css
uv run pytest green; coverage ≥94% overall, >90% on severity.py
uv run ruff check src tests agent && uv run pyright clean
Existing pages render unchanged (severity is additive; nothing consumes it yet) — one screenshot in data/logs/
no behavior change in completed phases

2.6 KiB Raw Permalink Blame History Unescape Escape