Everything is verified green. Final report: ## Phase 140 final verification pass — report - Verified all 4 tasks already complete (code in working tree, task files in `complete/`): `pictorial_pages` gate + 2 settings (`BOR_PDF_PICTORIAL`, `BOR_PDF_PICTORIAL_MIN_CHARS` + validator), `PICTORIAL_PAGE_MODE`/`describe_pdf_page` seam + `render_pdf_pages` page selector + mock branch, `_pictorial_pdf_pass` in `_index_pdf_file` with log-only counters, dedicated E2E. No code changes needed. - Test results (exact commands): - `uv run pytest --cov=app --cov-report=term-missing` → **3320 passed, 11 skipped, 0 failed; TOTAL 99%** (>90% gate) - `uv run pytest tests/e2e/test_pictorial_pdf.py -v --no-cov` → **3 passed in isolation** (Playwright, mock-only) - Pre-existing suites unedited: `test_pdf_support.py` 6 passed; `test_garbage_pdf.py` 2 passed + 1 skipped (owner fixture); `test_pdf_image_context.py` 4 passed - `uv run ruff check .` → All checks passed; `uv run pyright` → 0 errors - Completion criteria: 1. IKEA tar import repro — pinned by 2 integration tests; **skipped loudly here** (`test_sources/ikea_instructions.tar` absent on this machine — verified repo-wide; same house convention as completed phase-133 HNB tests; runs real on the owner's machine). Equivalent logic fully covered by unit pins on synthetic IKEA-class (vector-drawn, zero-raster) PDFs. 2. Chat grounded on described page — **green** (E2E test b: phrase-only-in-illustration question, PDF in `done.sources`, answer echoes the block) 3. Clean-text no-op (zero vision calls) + garbage precedence pin — **green** (`test_zero_candidates_is_a_noop` unit; `test_garbage_pdf_with_pictorial_on_takes_the_fallback_not_the_pass` integration, verified alone) 4. `BOR_PDF_PICTORIAL=0` byte-identical — **green** (unit pin on synthetic PDF; IKEA variant runs on owner's machine) 5. Full gate + E2E isolation + pre-existing suites — **green** (above) 6. ruff + pyright — **clean** 7. Commit/phase-move — delegated to harness per run rules (left in working tree: 16 modified + 8 new files, uncommitted) - Deviations: none beyond the expected owner-fixture skips (11, all pre-existing fixture-missing skips, including 2 IKEA). - Next pending phase: **none** — `todo/` holds only 140; 139 is already complete.
200 lines
8.2 KiB
Python
200 lines
8.2 KiB
Python
"""Playwright E2E fixtures (shared by every story's test file).
|
||
|
||
Each user story in ``.agents/user_stories/`` gets its own isolated E2E test
|
||
file; this conftest provides the shared environment:
|
||
|
||
* ``mock_llm`` — deterministic OpenAI-compatible server (see mock_llm.py).
|
||
Set ``E2E_REAL_LLM=1`` to point at the real aipi endpoint
|
||
instead (requires an imported knowledge base).
|
||
* ``app_server`` — the real FastAPI app under test (uvicorn subprocess).
|
||
* ``browser``/``page`` — headless Chromium pointed at the app.
|
||
|
||
Prerequisite for story tests that touch the database:
|
||
podman compose up -d db
|
||
"""
|
||
from __future__ import annotations
|
||
|
||
import json
|
||
import os
|
||
import subprocess
|
||
import sys
|
||
import time
|
||
from collections.abc import Iterator
|
||
from pathlib import Path
|
||
|
||
import httpx
|
||
import pytest
|
||
from playwright.sync_api import Browser, Page, sync_playwright
|
||
|
||
from app.config import Settings as _Settings
|
||
|
||
REPO = Path(__file__).resolve().parents[2]
|
||
APP_PORT = int(os.environ.get("E2E_APP_PORT", "8123"))
|
||
MOCK_PORT = int(os.environ.get("E2E_MOCK_PORT", "8901"))
|
||
APP_URL = f"http://127.0.0.1:{APP_PORT}"
|
||
USE_REAL_LLM = os.environ.get("E2E_REAL_LLM") == "1"
|
||
|
||
# Phase 16: the app under test boots with single-admin auth configured
|
||
# (fail-loud otherwise). Known E2E values — the shared form-login helper
|
||
# (tests/e2e/auth_helpers.py) uses ADMIN_PASSWORD; the secret is fixed so
|
||
# session cookies stay valid across a session-scoped app restart.
|
||
ADMIN_PASSWORD = "e2e-admin-password"
|
||
SESSION_SECRET = "e2e-session-secret-0123456789abcdef0123456789abcdef"
|
||
|
||
# Phase 140 (task 03): the pictorial-PDF kill switch is pinned OFF for
|
||
# every E2E app. The code default is ON (LOCKED A3), and the pre-phase-
|
||
# 140 story suites pin the PRE-phase content shape byte-exactly (their
|
||
# synthetic PDFs carry sparse pages — under the 100-char bar — so a
|
||
# default-ON app would append ``[Page N illustration: …]`` blocks and
|
||
# move those pins). The line rides into every app's env through the
|
||
# house ``env = dict(os.environ)`` pattern; the phase-140 story suite
|
||
# (tests/e2e/test_pictorial_pdf.py) opts in explicitly
|
||
# (``env["BOR_PDF_PICTORIAL"] = "1"`` in its module app).
|
||
os.environ["BOR_PDF_PICTORIAL"] = "0"
|
||
|
||
|
||
def _wait_http(url: str, timeout: float = 40.0) -> None:
|
||
deadline = time.monotonic() + timeout
|
||
last_err = "unknown"
|
||
while time.monotonic() < deadline:
|
||
try:
|
||
httpx.get(url, timeout=2.0)
|
||
return
|
||
except Exception as e: # noqa: BLE001 — retry until deadline
|
||
last_err = str(e)
|
||
time.sleep(0.5)
|
||
raise RuntimeError(f"server at {url} did not come up: {last_err}")
|
||
|
||
|
||
@pytest.fixture(scope="session")
|
||
def mock_llm() -> Iterator[int]:
|
||
"""Deterministic OpenAI-compatible LLM (chat + embeddings)."""
|
||
if USE_REAL_LLM:
|
||
yield 0
|
||
return
|
||
env = dict(os.environ)
|
||
env.pop("DEBUGPY", None)
|
||
proc = subprocess.Popen(
|
||
[sys.executable, "-m", "uvicorn", "tests.e2e.mock_llm:app",
|
||
"--host", "127.0.0.1", "--port", str(MOCK_PORT), "--log-level", "warning"],
|
||
cwd=REPO,
|
||
env=env,
|
||
)
|
||
try:
|
||
_wait_http(f"http://127.0.0.1:{MOCK_PORT}/v1/models")
|
||
yield MOCK_PORT
|
||
finally:
|
||
proc.terminate()
|
||
try:
|
||
proc.wait(timeout=10)
|
||
except subprocess.TimeoutExpired:
|
||
proc.kill()
|
||
|
||
|
||
@pytest.fixture(scope="session")
|
||
def app_server(mock_llm: int) -> Iterator[str]:
|
||
"""The real app under test."""
|
||
env = dict(os.environ)
|
||
env.pop("DEBUGPY", None)
|
||
env["BOR_ENVIRONMENT"] = "e2e"
|
||
env["BOR_STATIC_DIR"] = str(REPO / "frontend")
|
||
env["BOR_LLM_BASE_URL"] = (
|
||
"https://aipi.reeseapps.com/v1"
|
||
if USE_REAL_LLM
|
||
else f"http://127.0.0.1:{mock_llm}/v1"
|
||
)
|
||
# The E2E mock's token-overlap embeddings have their own score
|
||
# distribution (phase 09) — the app under test gets the mock-calibrated
|
||
# threshold so every story suite keeps its deterministic gate behavior.
|
||
# The production default stays 0.62 (re-tuned against the real
|
||
# `embed` model's 0.41–0.84 cosine range, PLAN A8).
|
||
env["BOR_RELEVANCE_THRESHOLD"] = "0.30"
|
||
# Phase 112 (defect fix): the code-default lexical_support_floor (0.35)
|
||
# violates the startup validator against the mock-calibrated threshold
|
||
# (0.30) and the app under test refused to boot — pin the
|
||
# mock-calibrated value (tests/conftest.py pattern). It also pins the
|
||
# gate quadrant end-to-end: "Who composed Rhapsody in Blue?" (top
|
||
# ~0.124 with FTS hits) deflects while the corroborated-lexical
|
||
# kafkabridge question (top ~0.239) grounds.
|
||
env["BOR_LEXICAL_SUPPORT_FLOOR"] = "0.15"
|
||
# Phase 113: the source usefulness bar (citation slot), mock-calibrated
|
||
# (half the threshold, like the lexical floor): a doc earns a citation
|
||
# chip only when its best-chunk cosine clears it (e.g. the kafkabridge
|
||
# doc at ~0.20 clears; the rhapsody weak hits at ~0.12 or below do not
|
||
# and demote to the related tier). The production default stays 0.35
|
||
# (app/config.py, LOCKED A2).
|
||
env["BOR_SOURCE_USEFULNESS_FLOOR"] = "0.15"
|
||
# Phase 67 (LLM retry): the e2e pins the retry MECHANISM with instant
|
||
# waits (BOR_LLM_RETRY_DELAY=0 — the 5 s default is unit-pinned via
|
||
# tests/unit/test_config.py). BOR_LLM_RETRIES is forced to the code
|
||
# default (derived from the class field, never drifts from
|
||
# app/config.py) so the exhaustion test relies on the REAL budget and
|
||
# an operator's local (gitignored) .env cannot leak a different one
|
||
# into the app under test (the phase-61 leak-guard pattern).
|
||
env["BOR_LLM_RETRY_DELAY"] = "0"
|
||
env["BOR_LLM_RETRIES"] = str(_Settings.model_fields["llm_retries"].default)
|
||
env.setdefault("BOR_DATABASE_URL", "postgresql+psycopg://reese:reese@localhost:5432/brain_of_reese")
|
||
# Phase 16: admin auth must be set or create_app() refuses to boot.
|
||
env["BOR_ADMIN_PASSWORD"] = ADMIN_PASSWORD
|
||
env["BOR_SESSION_SECRET"] = SESSION_SECRET
|
||
# Phase 61 (defect fix): force the code DEFAULTS so an operator's local
|
||
# (gitignored) ``.env`` — loaded by pydantic-settings from ``cwd=REPO``
|
||
# — cannot leak corpus-specific chips / a docs repo into the app under
|
||
# test: process env ranks above the ``.env`` file. The suggestions
|
||
# default is derived from the class field (never drifts from
|
||
# ``app/config.py``); docs-push stays inert (empty repo).
|
||
env["BOR_DOCS_REPO"] = ""
|
||
env["BOR_SUGGESTIONS"] = json.dumps(
|
||
_Settings.model_fields["suggestions"].default
|
||
)
|
||
# Phase 62: the same leak class for the new UI customization
|
||
# settings — an operator's local (gitignored) ``.env`` may
|
||
# legitimately carry ``BOR_INPUT_PLACEHOLDER`` /
|
||
# ``BOR_FOOTER_TEXT``, and the byte-identical default contract
|
||
# must see the code defaults (derived from the class fields, never
|
||
# drifts from ``app/config.py``). (Phase 91, task 03: the retired
|
||
# CSS-file theme env var no longer exists — nothing to pin.)
|
||
env["BOR_INPUT_PLACEHOLDER"] = _Settings.model_fields["input_placeholder"].default
|
||
env["BOR_FOOTER_TEXT"] = _Settings.model_fields["footer_text"].default
|
||
proc = subprocess.Popen(
|
||
[sys.executable, "-m", "uvicorn", "app.main:app",
|
||
"--host", "127.0.0.1", "--port", str(APP_PORT), "--log-level", "warning"],
|
||
cwd=REPO,
|
||
env=env,
|
||
)
|
||
try:
|
||
_wait_http(f"{APP_URL}/api/health")
|
||
yield APP_URL
|
||
finally:
|
||
proc.terminate()
|
||
try:
|
||
proc.wait(timeout=10)
|
||
except subprocess.TimeoutExpired:
|
||
proc.kill()
|
||
|
||
|
||
@pytest.fixture(scope="session")
|
||
def app_url(app_server: str) -> str:
|
||
return app_server
|
||
|
||
|
||
@pytest.fixture()
|
||
def db_ready(app_url: str) -> None:
|
||
"""Skip a test with clear instructions when Postgres is not running."""
|
||
body = httpx.get(f"{app_url}/api/health", timeout=5).json()
|
||
if body["db"] != "up":
|
||
pytest.skip("Postgres not reachable — run `podman compose up -d db` first")
|
||
|
||
|
||
@pytest.fixture(scope="session")
|
||
def browser() -> Iterator[Browser]:
|
||
with sync_playwright() as p:
|
||
yield p.chromium.launch(headless=True)
|
||
|
||
|
||
@pytest.fixture()
|
||
def page(browser: Browser) -> Iterator[Page]:
|
||
pg = browser.new_page(viewport={"width": 1280, "height": 800})
|
||
yield pg
|
||
pg.close()
|