ducoterra b233c8d714 phase: 148_pdf_pages_in_sources ...

**Phase 148 — final verification pass: complete, 100% green.**

- **Verified (tasks 01–04 already implemented):** page render/persist at index (`_persist_page_copies`, fail-soft, stale-replace, qualifier-loss, prune hook via `_delete_page_copies`); public `GET /api/documents/{id}/pages/{n}` (uuid4-credential, 404-all-non-servable, `image/png` + cache header); `DocContent.page_urls` additive-omitted; shared `renderDocument` strip (lazy imgs, "Page N" captions, text + Summary suppressed, onerror note, createElement-only); migration 0026; `pdf_page_dir` setting; `.env.example` entry
- **Completion criteria:** (1) pictorial + fallback classes get `p{N}.png` + `page_count`, text-heavy gets neither — pinned, pass; (2) unchanged re-sync renders zero (fast path) — pass; (3) changed re-index replaces copies, qualifier-loss/prune delete — pass; (4) route 404 matrix + payload key absent-never-null — pass; (5) modal AND /document.html strip with suppression, text-heavy byte-identical — E2E pass; (6) see below; (7) no completed-phase drift — full suite green
- **Tests:** `uv run pytest --cov=app --cov-report=term-missing` → **3461 passed, 0 failed**, `app/` coverage **99%** (>90%); `uv run pytest tests/e2e/test_pdf_pages_in_sources.py -v --no-cov` → **4 passed** in isolation; `uv run ruff check .` clean; `uv run pyright` → 0 errors, 0 warnings
- **Documentation:** README had **1 pre-existing inconsistency** — the Production Deployment section's standalone `podman run` example (and compose note) omitted the **required** `BOR_ADMIN_PASSWORD`/`BOR_SESSION_SECRET` (the fail-loud boot gate the README's own Admin section documents — the container would refuse to start); fixed with the two `-e` flags + a note for the compose path. All else verified consistent: 70/70 `.env.example` vars documented, all defaults match `config.py`, pages table matches routes, Containerfile/esbuild/uid-10001/healthcheck/entrypoint claims accurate, QA commands match pytest config. **AGENTS.md: verified consistent — no changes needed**
- **Notable:** repo uses `Containerfile` (Podman) — README's `podman build` example is valid as-is; no live infrastructure touched
- **Next pending phase:** `149_sync_progress_box`

2026-10-01 16:58:01 -04:00

..

conftest.py

phase: 106_document_dates

2026-09-13 19:28:05 -04:00

test_agent_tools_dates.py

phase: 110_fix_sse_db_pool_exhaustion

2026-09-14 15:55:13 -04:00

test_agent_tools.py

phase: 131_read_line_ranges

2026-09-28 11:49:55 -04:00

test_api.py

phase: 122_image_documents

2026-09-25 01:54:23 -04:00

test_auth_api.py

phase: 122_image_documents

2026-09-25 01:54:23 -04:00

test_caching_revalidation.py

phase: 91_admin_theme_tab

2026-09-09 17:22:24 -04:00

test_chat_api.py

phase: 129_sync_chunk_progress

2026-09-28 03:38:14 -04:00

test_chat_concurrency.py

phase: 110_fix_sse_db_pool_exhaustion

2026-09-14 15:55:13 -04:00

test_chat_db_sessions.py

phase: 110_fix_sse_db_pool_exhaustion

2026-09-14 15:55:13 -04:00

test_chats_api.py

phase: 146_search_tool_scope

2026-10-01 12:48:04 -04:00

test_containerfile_assets.py

fix(chat): keep in-flight answers alive across in-app view switches

2026-09-06 06:31:31 -04:00

test_doc_drafts_api.py

phase: 115_doc_draft_discard

2026-09-15 05:35:05 -04:00

test_docs_api_dates.py

phase: 106_document_dates

2026-09-13 19:28:05 -04:00

test_docs_api.py

phase: 148_pdf_pages_in_sources

2026-10-01 16:58:01 -04:00

test_document_content.py

phase: 145_git_source_links

2026-10-01 11:13:43 -04:00

test_git_file_dates.py

phase: 107_git_full_history_dates

2026-09-13 23:21:39 -04:00

test_git_sources_api.py

phase: 135_git_source_branch

2026-09-28 21:15:03 -04:00

test_git_sources_upload.py

phase: 90_upload_no_scan

2026-09-09 14:08:18 -04:00

test_import_docs_git.py

phase: 136_force_push_reset

2026-09-28 22:38:54 -04:00

test_import_docs_overview.py

phase: 142_kb_overview_freshness

2026-10-01 04:25:03 -04:00

test_import_extensionless.py

phase: 118_summary_seed_context

2026-09-16 06:57:49 -04:00

test_import_extensions_env.py

phase: 118_summary_seed_context

2026-09-16 06:57:49 -04:00

test_import_quadlet_jinja.py

feat(import): index quadlet unit files and jinja templates (A9 revision)

2026-08-28 07:02:24 -04:00

test_importer_dates.py

phase: 106_document_dates

2026-09-13 19:28:05 -04:00

test_importer_e2e.py

phase: 118_summary_seed_context

2026-09-16 06:57:49 -04:00

test_importer_ignore.py

phase: 118_summary_seed_context

2026-09-16 06:57:49 -04:00

test_importer_include_hidden.py

phase: 118_summary_seed_context

2026-09-16 06:57:49 -04:00

test_importer.py

phase: 147_sync_changed_only

2026-10-01 14:23:33 -04:00

test_kb_overview_api.py

phase: 119_name_signal_read_chips

2026-09-16 15:50:48 -04:00

test_migration_0002.py

feat(rag): hybrid FTS+vector retrieval and multi-format ingestion — name-your-tool questions find the right document

2026-08-22 01:27:02 -04:00

test_migration_0004.py

feat(rag): lite-generated KB overview in the system prompt — stored single row, regenerated on import, <knowledge_base> section in HIGH+LOW prompts

2026-08-25 20:22:51 -04:00

test_migration_0005.py

feat(sources): admin page to add and remove git sources (TODO.md L4)

2026-08-26 18:42:28 -04:00

test_migration_0006.py

feat(sources): admin page to add and remove git sources (TODO.md L4)

2026-08-26 18:42:28 -04:00

test_migration_0007.py

feat(admin): local directory sources — kind/path on git_sources, combined sync + import, page form + badges

2026-08-27 01:04:16 -04:00

test_migration_0008.py

feat(chat): save and view chat history — admin-only saved_chats, History page, open-a-chat return

2026-08-29 21:22:25 -04:00

test_migration_0009.py

feat(chat): share a chat by link — anonymous read-only /shared/<token> page, share/unshare

2026-08-30 01:34:44 -04:00

test_migration_0010.py

feat(chat): invalidate saved chats on sources sync — versioned stamps, stale marker, Regenerate against the new index

2026-08-30 23:39:15 -04:00

test_migration_0011.py

feat(docs): save chat answers as docs — edit screen, commit + push to the .env docs branch

2026-09-01 03:52:03 -04:00

test_migration_0012.py

feat: phases 77–80 — navbar view refresh, static background, API tokens, history suggestion chips

2026-09-07 12:39:01 -04:00

test_migration_0014.py

phase: 91_admin_theme_tab

2026-09-09 17:22:24 -04:00

test_migration_0016.py

phase: 93_theme_semantic_completion

2026-09-10 16:43:08 -04:00

test_migration_0017.py

phase: 94_ls_tree_drilldown

2026-09-11 00:59:35 -04:00

test_migration_0018.py

phase: 97_kb_tree_catalog

2026-09-11 22:48:02 -04:00

test_migration_0019.py

phase: 105_hidden_folders_toggle

2026-09-12 21:26:30 -04:00

test_migration_0020.py

phase: 106_document_dates

2026-09-13 19:28:05 -04:00

test_migration_0021.py

phase: 121_git_source_tokens

2026-09-24 20:51:39 -04:00

test_migration_0022.py

phase: 122_image_documents

2026-09-25 01:54:23 -04:00

test_migration_0023.py

phase: 135_git_source_branch

2026-09-28 21:15:03 -04:00

test_migration_0024.py

phase: 135_git_source_branch

2026-09-28 21:15:03 -04:00

test_migration_0025.py

phase: 147_sync_changed_only

2026-10-01 14:23:33 -04:00

test_migration_0026.py

phase: 148_pdf_pages_in_sources

2026-10-01 16:58:01 -04:00

test_name_hit_lexical.py

phase: 119_name_signal_read_chips

2026-09-16 15:50:48 -04:00

test_pdf_hnb_guide_regression.py

phase: 140_pictorial_pdf_pages

2026-09-30 19:16:35 -04:00

test_read_line_ranges_handbook.py

phase: 141_read_range_dedupe_fix

2026-10-01 01:27:46 -04:00

test_read_range_dedupe_two_ranges.py

phase: 141_read_range_dedupe_fix

2026-10-01 01:27:46 -04:00

test_recency_boost.py

phase: 119_name_signal_read_chips

2026-09-16 15:50:48 -04:00

test_security_headers.py

phase: 123_chat_image_questions

2026-09-25 05:19:18 -04:00

test_source_removal_api.py

feat(sources): removing a source deletes its files and index entries behind a confirmation modal

2026-09-02 15:55:33 -04:00

test_steering_api.py

feat(import): index quadlet unit files and jinja templates (A9 revision)

2026-08-28 07:02:24 -04:00

test_suggestions_api.py

phase: 103_suggestions_session_openers

2026-09-12 16:37:50 -04:00

test_sync_api.py

phase: 135_git_source_branch

2026-09-28 21:15:03 -04:00

test_sync_folder_summaries.py

phase: 118_summary_seed_context

2026-09-16 06:57:49 -04:00

test_tokens_api.py

phase: 101_tokens_page_overhaul

2026-09-12 15:16:02 -04:00

test_ui_settings_api.py

phase: 122_image_documents

2026-09-25 01:54:23 -04:00