ducoterra
4971e2859d
Remove the blanket .agent/ gitignore so the phase roadmap, user stories, reports, and PLAN.md are versioned with the code. Only runtime artifacts (.agent/phase-sessions/, .agent/pipeline.log) remain ignored. Update AGENTS.md git protocol rule to match.
1.8 KiB
1.8 KiB
Phase 13 complete — committed as 2485b50, tree clean.
Implemented
- Chat source chips carry
&back=%2F:documentUrl(source, path, back = "/")infrontend/assets/app.js(percent-encoded). - Viewer (
frontend/assets/document.js): back target resolved from thebackparam — honored only for same-origin relative URLs (starts with/, not//);https://,//,javascript:etc. fall back to/sources.html. Label set to Chat / Sources / Back. Dropped thehistory.lengthheuristic entirely — withhrefset, the anchor's default click IS the deterministic navigation; statichref="/sources.html"no-JS fallback untouched. - Sources links unchanged (no
backparam → default/sources.html). - New E2E
tests/e2e/test_document_back_navigation.py(3 tests per story mapping, incl. malicious-param rejection); updated stale contract pins: phase-10 E2E chip href, phase-03test_chat_rag.pyhref, and phase-10 unit pins intests/unit/test_document_viewer.py(re-pinned to the new builder/resolution contract, plus a node behavioral check forbackencoding).
Verification (all green)
uv run pytest tests/e2e/test_document_back_navigation.py -v --no-cov→ 3 passeduv run pytest tests/e2e/test_document_viewer.py -v --no-cov→ 5 passeduv run pytest --cov=app --cov-report=term→ 203 passed,app/coverage 99% (>90%)uv run ruff check .→ clean;uv run pyright→ 0 errors- Full E2E regression sweep (
uv run pytest tests/e2e --no-cov) → 51 passed
Decisions: removed the click listener rather than forcing location.assign (cleaner, same determinism); a pyright complaint in the new E2E was fixed by using the phase-10 named dialog-handler pattern.
Next pending phase: .agent/phases/todo/14_chat_persistence.md