ducoterra 5e87622b30 phase: 137_pdf_image_context ...

All verification complete — everything is 100% green. Final report:

**Phase 137 final verification pass — all tasks already complete, all criteria verified**

- **Full suite:** `uv run pytest --cov=app --cov-report=term-missing` → 3272 passed, exit 0; `app/` coverage **99%** (>90% ✓)
- **Phase E2E in isolation:** `uv run pytest tests/e2e/test_pdf_image_context.py -v --no-cov` → **4 passed** (forward context, display line, standalone parity, both-blocks markdown case)
- **Pre-existing suites in isolation:** `test_pdf_support.py` + `test_image_anchor_context.py` + `test_image_documents.py` → **14 passed**; ripple-edited `test_garbage_pdf.py` → **3 passed**
- **Lint/types:** `uv run ruff check .` → all passed; `uv run pyright` → 0 errors

**Completion criteria:** (1) forward-path context in vision msg + stored `image_context`/summary — ✓ (unit builder/seam + integration fake-LLM + E2E); (2) both blocks document-first + standalone describe byte-identical — ✓ (combiner + standalone pins); (3) backfill with context + zero-vision idempotent re-sync + parent-gone origin-only — ✓ (6 integration tests); (4) suggestion block leads with `From <source>/<pdf> (page N)` — ✓ (renderer units + E2E); (5) all gates green — ✓ above; (6) no behavior change in phases 122/125/126 + sync `detail` shape untouched — ✓ (verified in code: new counter is log-only); (7) ruff+pyright — ✓; (8) commit — left to the harness per pipeline rules (working tree untouched by me).

**Documentation:** README.md audited in full — the new phase-137 bullet verified against code (6 000-char cap, log-only `image_context_backfilled=N`, `<document>`-body locator placement), all env tables/defaults cross-checked vs `app/config.py` and `.env.example` — consistent, no changes needed. AGENTS.md: every rule/command verified — consistent, no changes needed.

**Notable deviations (pre-existing, documented in task-05 report, forced by design):** `test_pdf_support.py`/`test_garbage_pdf.py` got minimal ripple edits (the "UNEDITED" pin was unsatisfiable once describe calls carry context by design); the unit `test_image_anchor_context.py` CONTEXT_PREFIX pin generalized per ASSUMPTION A5; one extra mock line (`_seed_context_line` accepts `From …`).

**Next pending phase:** none — `todo/` holds only this phase.

2026-09-29 02:14:46 -04:00

..

conftest.py

phase: 106_document_dates

2026-09-13 19:28:05 -04:00

test_agent_tools_dates.py

phase: 110_fix_sse_db_pool_exhaustion

2026-09-14 15:55:13 -04:00

test_agent_tools.py

phase: 131_read_line_ranges

2026-09-28 11:49:55 -04:00

test_api.py

phase: 122_image_documents

2026-09-25 01:54:23 -04:00

test_auth_api.py

phase: 122_image_documents

2026-09-25 01:54:23 -04:00

test_caching_revalidation.py

phase: 91_admin_theme_tab

2026-09-09 17:22:24 -04:00

test_chat_api.py

phase: 129_sync_chunk_progress

2026-09-28 03:38:14 -04:00

test_chat_concurrency.py

phase: 110_fix_sse_db_pool_exhaustion

2026-09-14 15:55:13 -04:00

test_chat_db_sessions.py

phase: 110_fix_sse_db_pool_exhaustion

2026-09-14 15:55:13 -04:00

test_chats_api.py

phase: 124_image_chips_and_answers

2026-09-26 17:06:09 -04:00

test_containerfile_assets.py

fix(chat): keep in-flight answers alive across in-app view switches

2026-09-06 06:31:31 -04:00

test_doc_drafts_api.py

phase: 115_doc_draft_discard

2026-09-15 05:35:05 -04:00

test_docs_api_dates.py

phase: 106_document_dates

2026-09-13 19:28:05 -04:00

test_docs_api.py

phase: 125_image_anchor_context

2026-09-27 05:53:12 -04:00

test_document_content.py

phase: 122_image_documents

2026-09-25 01:54:23 -04:00

test_git_file_dates.py

phase: 107_git_full_history_dates

2026-09-13 23:21:39 -04:00

test_git_sources_api.py

phase: 135_git_source_branch

2026-09-28 21:15:03 -04:00

test_git_sources_upload.py

phase: 90_upload_no_scan

2026-09-09 14:08:18 -04:00

test_import_docs_git.py

phase: 136_force_push_reset

2026-09-28 22:38:54 -04:00

test_import_docs_overview.py

phase: 118_summary_seed_context

2026-09-16 06:57:49 -04:00

test_import_extensionless.py

phase: 118_summary_seed_context

2026-09-16 06:57:49 -04:00

test_import_extensions_env.py

phase: 118_summary_seed_context

2026-09-16 06:57:49 -04:00

test_import_quadlet_jinja.py

feat(import): index quadlet unit files and jinja templates (A9 revision)

2026-08-28 07:02:24 -04:00

test_importer_dates.py

phase: 106_document_dates

2026-09-13 19:28:05 -04:00

test_importer_e2e.py

phase: 118_summary_seed_context

2026-09-16 06:57:49 -04:00

test_importer_ignore.py

phase: 118_summary_seed_context

2026-09-16 06:57:49 -04:00

test_importer_include_hidden.py

phase: 118_summary_seed_context

2026-09-16 06:57:49 -04:00

test_importer.py

phase: 137_pdf_image_context

2026-09-29 02:14:46 -04:00

test_kb_overview_api.py

phase: 119_name_signal_read_chips

2026-09-16 15:50:48 -04:00

test_migration_0002.py

feat(rag): hybrid FTS+vector retrieval and multi-format ingestion — name-your-tool questions find the right document

2026-08-22 01:27:02 -04:00

test_migration_0004.py

feat(rag): lite-generated KB overview in the system prompt — stored single row, regenerated on import, <knowledge_base> section in HIGH+LOW prompts

2026-08-25 20:22:51 -04:00

test_migration_0005.py

feat(sources): admin page to add and remove git sources (TODO.md L4)

2026-08-26 18:42:28 -04:00

test_migration_0006.py

feat(sources): admin page to add and remove git sources (TODO.md L4)

2026-08-26 18:42:28 -04:00

test_migration_0007.py

feat(admin): local directory sources — kind/path on git_sources, combined sync + import, page form + badges

2026-08-27 01:04:16 -04:00

test_migration_0008.py

feat(chat): save and view chat history — admin-only saved_chats, History page, open-a-chat return

2026-08-29 21:22:25 -04:00

test_migration_0009.py

feat(chat): share a chat by link — anonymous read-only /shared/<token> page, share/unshare

2026-08-30 01:34:44 -04:00

test_migration_0010.py

feat(chat): invalidate saved chats on sources sync — versioned stamps, stale marker, Regenerate against the new index

2026-08-30 23:39:15 -04:00

test_migration_0011.py

feat(docs): save chat answers as docs — edit screen, commit + push to the .env docs branch

2026-09-01 03:52:03 -04:00

test_migration_0012.py

feat: phases 77–80 — navbar view refresh, static background, API tokens, history suggestion chips

2026-09-07 12:39:01 -04:00

test_migration_0014.py

phase: 91_admin_theme_tab

2026-09-09 17:22:24 -04:00

test_migration_0016.py

phase: 93_theme_semantic_completion

2026-09-10 16:43:08 -04:00

test_migration_0017.py

phase: 94_ls_tree_drilldown

2026-09-11 00:59:35 -04:00

test_migration_0018.py

phase: 97_kb_tree_catalog

2026-09-11 22:48:02 -04:00

test_migration_0019.py

phase: 105_hidden_folders_toggle

2026-09-12 21:26:30 -04:00

test_migration_0020.py

phase: 106_document_dates

2026-09-13 19:28:05 -04:00

test_migration_0021.py

phase: 121_git_source_tokens

2026-09-24 20:51:39 -04:00

test_migration_0022.py

phase: 122_image_documents

2026-09-25 01:54:23 -04:00

test_migration_0023.py

phase: 135_git_source_branch

2026-09-28 21:15:03 -04:00

test_migration_0024.py

phase: 135_git_source_branch

2026-09-28 21:15:03 -04:00

test_name_hit_lexical.py

phase: 119_name_signal_read_chips

2026-09-16 15:50:48 -04:00

test_pdf_hnb_guide_regression.py

phase: 137_pdf_image_context

2026-09-29 02:14:46 -04:00

test_read_line_ranges_handbook.py

phase: 131_read_line_ranges

2026-09-28 11:49:55 -04:00

test_recency_boost.py

phase: 119_name_signal_read_chips

2026-09-16 15:50:48 -04:00

test_security_headers.py

phase: 123_chat_image_questions

2026-09-25 05:19:18 -04:00

test_source_removal_api.py

feat(sources): removing a source deletes its files and index entries behind a confirmation modal

2026-09-02 15:55:33 -04:00

test_steering_api.py

feat(import): index quadlet unit files and jinja templates (A9 revision)

2026-08-28 07:02:24 -04:00

test_suggestions_api.py

phase: 103_suggestions_session_openers

2026-09-12 16:37:50 -04:00

test_sync_api.py

phase: 135_git_source_branch

2026-09-28 21:15:03 -04:00

test_sync_folder_summaries.py

phase: 118_summary_seed_context

2026-09-16 06:57:49 -04:00

test_tokens_api.py

phase: 101_tokens_page_overhaul

2026-09-12 15:16:02 -04:00

test_ui_settings_api.py

phase: 122_image_documents

2026-09-25 01:54:23 -04:00