Files
brain-of-reese/tests/e2e/test_stale_ui_copy.py
T
ducoterra 7fce6572d0
Build and Push Containers / build-and-push-app (push) Successful in 1m45s
Build and Push Containers / build-and-push-db (push) Successful in 13s
feat: phases 77–80 — navbar view refresh, static background, API tokens, history suggestion chips
Single consolidated commit for four completed, validated phases (77, 78,
79, 80). The pipeline run left all work uncommitted because the harness
commits only with PHASE_COMMIT=1 while child executors are forbidden from
committing; the phases themselves all passed validation and moved to
.agents/phases/complete/.

Phase 77 — navbar view refresh
- router.js dispatches bor:view-refresh on re-show / active re-click /
  popstate (gated on wasMounted; first show and boot exempt)
- History / RAG / Sources / Tuning re-fetch on refresh (admin branch);
  Chat deliberately excluded (stream survival)
- History "Refresh" button (admin-only, in-flight disable + status line)
- New story suite tests/e2e/test_navbar_refresh.py (7 tests)

Phase 78 — static background
- Removed the animated glow layers; static 44px grid over the flat --bg
  canvas; default and reduced-motion renders byte-identical
- Updated background/theme E2E suites; removed bg-glow test pins

Phase 79 — API tokens
- api_tokens model + migration 0012; hash-only token service
- Admin tokens API + Tokens admin view; POST /api/token-auth;
  live-revoking require_user on chat / suggestions / document content
- Frontend token gate with localStorage cache; anonymous E2E suites
  migrated to token login
- New story suite tests/e2e/test_api_tokens.py (9 tests)

Phase 80 — history suggestion chips
- last_questions() endpoint with SEED fallback; startNewChat() refetch
- Seed-semantics docs (config.py, .env.example, README)
- Integration state matrix + E2E suite rewritten to the 4 chip states

Also included: phase-76 report artifacts and the repo restore-test-db
skill (previously untracked), scripts/* ruff fixes from phase 77.

Final gate state (phase 80 final pass, covers everything above):
- uv run pytest --cov=app → 1637 passed, 0 failed, app/ coverage 99%
- uv run ruff check . && uv run pyright → clean, 0 errors
- Per-phase story E2E suites green in isolation
2026-09-07 12:39:01 -04:00

122 lines
5.1 KiB
Python

"""Phase 61 E2E (Playwright): the retired homelab-era copy is gone — the
visitor SEES the locked neutral copy on the shared default server.
Story: n/a (TODO-derived — TODO.md L4 "Clean up the UI, there's text
that references old features…"). Run in isolation (DB must be up:
``podman compose up -d db``):
uv run pytest tests/e2e/test_stale_ui_copy.py -v --no-cov
The shared conftest server boots with the default env — and the code
defaults are exactly this phase's locked copy (A1/A2; the conftest
forces ``BOR_SUGGESTIONS`` from the ``Settings`` field so an operator's
local ``.env`` cannot leak corpus-specific chips). Every assertion is a
settled-state check: static HTML + one ``GET /api/suggestions`` fetch;
Playwright's ``expect`` retries ride out the chip rendering.
Test → lock mapping (Playwright Mapping Rule):
1. ``test_chat_page_placeholder_meta_footer_are_the_locked_copy``
2. ``test_chat_page_shows_no_homelab_or_deployment_text``
3. ``test_chat_page_suggestion_chips_are_the_locked_list``
4. ``test_sources_page_sub_describes_the_current_source_model``
5. ``test_git_sources_example_url_is_neutral``
"""
from __future__ import annotations
from playwright.sync_api import Page, expect
from e2e.auth_helpers import login
# The locked replacement copy (owner-locked A1 / A2 / A3 — same literals
# as tests/unit/test_stale_ui_copy.py; the unit pins guard the files,
# this suite guards what the visitor actually sees).
META = "Ask anything about your indexed documents — every answer cites the exact doc."
PLACEHOLDER = "Ask me anything…"
FOOTER = "Powered by self-hosted models"
GIT_EXAMPLE = "https://github.com/you/your-repo.git"
CHIPS = [
"What documents are in the knowledge base?",
"Which source does each answer come from?",
"How do I add a new source?",
"Summarize the most recent document.",
]
def test_chat_page_placeholder_meta_footer_are_the_locked_copy(
page: Page, app_url: str, db_ready: None
) -> None:
"""The composer placeholder, the <meta description> content and the
footer span all read the locked (A1) copy — read from the DOM a
visitor gets."""
page.goto(f"{app_url}/")
expect(page.locator("#message-input")).to_have_attribute(
"placeholder", PLACEHOLDER
)
meta = page.eval_on_selector('meta[name="description"]', "el => el.content")
assert meta == META, "the rendered meta description must be the locked copy"
expect(page.locator(".footer-text").first).to_have_text(FOOTER)
def test_chat_page_shows_no_homelab_or_deployment_text(
page: Page, app_url: str, db_ready: None
) -> None:
"""The entire rendered chat page (nav, empty state, composer, footer)
shows no homelab-era text — the empty-state sub AND the four
rendered suggestion chips are covered by this body scan (case-
insensitive; a fresh page context has no saved chats, so the empty
state is what renders)."""
login(page, app_url, next="/")
expect(page.locator("#suggestions .suggestion-chip")).to_have_count(len(CHIPS))
body = page.evaluate("() => document.body.innerText.toLowerCase()")
assert "homelab" not in body, f"homelab-era text rendered on the chat page: {body!r}"
assert "deployment" not in body, (
f"homelab-era text rendered on the chat page: {body!r}"
)
def test_chat_page_suggestion_chips_are_the_locked_list(
page: Page, app_url: str, db_ready: None
) -> None:
"""The four rendered empty-state chips (from ``GET
/api/suggestions``, the code default) are the locked (A2) list, in
order."""
login(page, app_url, next="/")
chips = page.locator("#suggestions .suggestion-chip")
expect(chips).to_have_count(len(CHIPS))
for i, chip in enumerate(CHIPS):
expect(chips.nth(i)).to_have_text(chip)
def test_sources_page_sub_describes_the_current_source_model(
page: Page, app_url: str, db_ready: None
) -> None:
"""The KB page-sub (the string the TODO cited by name) no longer
names ~/Homelab or ~/Deployments and describes the current source
model. The page is anonymously viewable — the catalog gate hides
the table, not the page-head."""
page.goto(f"{app_url}/sources.html")
# Phase 76 (task 02): the shell carries the hidden tuning view's
# .page-sub earlier in the DOM — scope to the RAG view.
sub = page.locator("#view-rag .page-sub")
expect(sub).to_be_visible()
text = sub.inner_text().lower()
assert "homelab" not in text, f"retired copy in the page-sub: {text!r}"
assert "deployments" not in text, f"retired copy in the page-sub: {text!r}"
assert "configured sources" in text, (
f"the page-sub must name the current source model: {text!r}"
)
def test_git_sources_example_url_is_neutral(
page: Page, app_url: str, db_ready: None
) -> None:
"""The repo-URL form example (A3) is the neutral your-repo.git —
read from the DOM; the element exists even while
``#git-sources-content`` is hidden for an anonymous visitor (no
sign-in needed)."""
page.goto(f"{app_url}/git-sources.html")
expect(page.locator("#git-source-url")).to_have_attribute(
"placeholder", GIT_EXAMPLE
)