Root cause (owner repro, verified in a real browser 2026-09-06): the five navbar views (Chat, RAG, Sources, Tuning, History) were separate HTML documents, so a navbar click was a REAL cross-document navigation — the chat page unloaded, the in-flight SSE fetch was aborted, and the phase-48 teardown (app/api/chat.py `finally`, "chat: turn cancelled") stopped the model. Observed: send question -> click RAG mid-stream -> click Chat -> the answer never finished: no `query_log` row, and on return a dangling question with no brain record (the pre-token pagehide partial persist skips because `acc` is empty). Phase-48 LOCKED-DECISION REFINEMENT (owner-confirmed 2026-09-06, flagged per AGENTS.md rule 3, not silently deviated): "real navigation cancels the fetch" now means LEAVING THE APP — tab close, external/other-document navigation, the Stop button. In-app navbar switches are client-side view switches and no longer cancel. Fix — Option A (SPA shell), chosen over B (Service Worker owns the stream) and C (server-side turn registry + resume): - frontend/index.html is the shell: ONE `<main id="main">` holds the five `<section class="view">` blocks; hidden views carry BOTH `hidden` and `inert` (WCAG — no focus/keyboard traversal). The shared header, the single `doc-modal-*` skeleton, and the `#app-version` footer each exist exactly once; the per-view copies from the four folded pages are dropped. - New frontend/assets/router.js (vanilla module — no framework, no bundler, No-CDN rule intact): lazy-imports a view module on FIRST show only (mount-once, hide-forever — the chat view's in-flight SSE reader persists across switches; that persistence IS the fix); intercepts same-shell navbar links with preventDefault + history.pushState (never a document load); handles popstate; single writer of `.nav-link` active state (is-active + aria-current), document.title, and the per-view meta description (values carried over from the old pages' heads, brand-resolved at write time). - Each folded page's JS becomes `export async function mount(root)` — root-scoped queries; `initSharedHeader()` dropped (the header boots once in the shell via the chat module; the admin flag comes from the same cached `fetchIsAdmin()` promise — zero extra requests). - app/main.py: a small list-driven route factory serves the shell for /tuning.html, /sources.html, /git-sources.html, /history.html — registered AFTER the API routers and BEFORE the static catch-all (routes-first). The phase-33 caching middleware applies no-cache + `?v=` rewriting unchanged; app/core/caching.py needed NO change (the view paths did not change — pinned by the integration tests). - The four old view .html files are DELETED (one source of truth); deep links to the old URLs keep working (the router picks the view from the pathname); `/?chat=<id>` is unaffected; the Containerfile bundles router.js (inlining the lazy view modules) and drops the folded page files. - app/schemas.py: HistoryTurn.text cap 4000 -> 32000 — the shell keeps long saved answers in the chat, and the old cap (stricter than the 24_000-char total history budget) 422-rejected any second turn in such a chat (found by the phase-42 E2E suite on the shell). Boundaries: login.html, shared.html, doc-edit.html, document.html REMAIN separate documents (flow pages, not navbar tabs); a mid-stream navigation to doc-edit/document.html still cancels per phase 48 (follow-up candidate, out of scope). The SSE API is unchanged. Real departures still cancel the turn — phase 48 intact (pinned by tests/e2e/test_stop_generation.py, unchanged, and by the new suite's real-departure control). Tests: - Phase-20 suite REWRITTEN to the new semantics (tests/e2e/test_sources_midstream_bug.py): a navbar switch no longer cancels — the stream survives the switch and the FULL answer settles; the pagehide partial persist REMAINS for real departures (the partial's exact shape — first streamed chunk prefix, no done metadata — is still pinned there). - NEW story suite tests/e2e/test_nav_switch_keeps_stream.py (mock LLM): the owner repro (send -> RAG mid-stream -> Chat: window sentinel survives = same document, FULL answer, exactly one brain turn in bor.chat.v1, exactly one settled query_log row, auto-saved row matches) + the same mid-stream switch against the other three views + the real-departure-still-cancels control + the no-switch baseline. - tests/unit/test_frontend_router.py: source-level pins of the router invariants (click interceptor targets ONLY same-shell view paths, pushState-only switches, mount-once guard, hidden+inert pair, single-writer active state/title); shell-route integration tests (each folded path serves the shell with no-cache + `?v=` body; a non-view path still 404s); the file-reading unit pins re-pointed at the shell (the four view files are gone — the shell is the source of truth). Verification (this commit): full suite green — 1565 unit+integration tests, app/ coverage 99% (>90% floor); ruff + pyright clean; the phase's E2E suites green in isolation (house protocol, AGENTS.md rule 9). Owner repro verified in a real browser against the real LLM (dev server :8010, headful Chromium): "tell me about everquest" -> RAG mid-stream -> Chat — the answer completed with one brain bubble and no error banner, `query_log` gained exactly one settled row (deflected=True: the dev KB holds no EverQuest docs — the settle, not the topic, is the proof), zero "chat: turn cancelled" lines for that turn; the control (real navigation to /shared.html mid-stream) still cancelled (no settled row, the cancel line logged, the partial persisted on return). Screenshots: .agents/screenshots/76_manual_*. Phase 76 (76_spa_nav_shell) complete — moved to .agents/phases/complete/.
171 lines
6.6 KiB
Python
171 lines
6.6 KiB
Python
"""Phase 02 E2E (Playwright): the Sources page reflects the imported KB.
|
||
|
||
Story: ``.agents/user_stories/import-documents.md``
|
||
Run in isolation (DB must be up: ``podman compose up -d db``):
|
||
|
||
uv run pytest tests/e2e/test_import_documents.py -v --no-cov
|
||
|
||
Seeding runs the real import function in-process against
|
||
``tests/fixtures/docs/`` with the deterministic mock embeddings — it is a
|
||
fixture, not the subject of the tests.
|
||
|
||
Phase 16 adaptation: the Sources catalog is admin-only — every test
|
||
performs the real form login (``e2e.auth_helpers.login``) first.
|
||
"""
|
||
from __future__ import annotations
|
||
|
||
import asyncio
|
||
from pathlib import Path
|
||
from threading import Thread
|
||
from typing import Any
|
||
|
||
from playwright.sync_api import Browser, Page, expect
|
||
from sqlalchemy import text
|
||
|
||
from app.config import Settings
|
||
from app.db import SessionLocal
|
||
from app.rag.importer import ImportSummary, import_sources
|
||
from app.rag.llm import LLMClient
|
||
from e2e.auth_helpers import login
|
||
|
||
REPO = Path(__file__).resolve().parents[2]
|
||
FIXTURES = REPO / "tests" / "fixtures" / "docs"
|
||
|
||
EXPECTED_ROWS = (
|
||
"homelab/kubernetes.md",
|
||
"homelab/backups.md",
|
||
"deployments/new-service.md",
|
||
"homelab/container_gitlab/gitlab.md",
|
||
"homelab/container_gitlab/gitlab-compose.yaml",
|
||
"homelab/networking/static-dns.json",
|
||
"homelab/scripts/uptime_probe.py",
|
||
"homelab/ssh/ssh_aliases.txt",
|
||
"homelab/tables.md", # phase 44: the markdown-tables fixture
|
||
# phase 47 (A9 revised 2026-08-27): quadlet family + jinja fixtures
|
||
"homelab/quadlet/compose.container",
|
||
"homelab/quadlet/lan.network",
|
||
"homelab/quadlet/cache.volume",
|
||
"homelab/templates/deploy.j2",
|
||
)
|
||
|
||
|
||
async def _import_fixtures(mock_port: int) -> ImportSummary:
|
||
kwargs: dict[str, Any] = {"_env_file": None, "llm_base_url": f"http://127.0.0.1:{mock_port}/v1"}
|
||
settings = Settings(**kwargs) # pyright: ignore[reportCallIssue]
|
||
return await import_sources([FIXTURES], LLMClient(settings))
|
||
|
||
|
||
def _run_in_thread(coro: Any) -> Any:
|
||
"""Run a coroutine on a worker thread.
|
||
|
||
Playwright's sync API keeps an asyncio loop running on the test thread,
|
||
so ``asyncio.run`` cannot be called directly from a test body.
|
||
"""
|
||
box: dict[str, Any] = {}
|
||
|
||
def runner() -> None:
|
||
try:
|
||
box["value"] = asyncio.run(coro)
|
||
except BaseException as e: # noqa: BLE001 — re-raised on the test thread
|
||
box["error"] = e
|
||
|
||
t = Thread(target=runner)
|
||
t.start()
|
||
t.join()
|
||
if "error" in box:
|
||
raise box["error"]
|
||
return box["value"]
|
||
|
||
|
||
def _reset_db(mock_port: int, seed: bool) -> ImportSummary | None:
|
||
"""Truncate the KB (and query log), then optionally re-import fixtures."""
|
||
with SessionLocal() as db:
|
||
db.execute(text("TRUNCATE chunks, documents, query_log"))
|
||
db.commit()
|
||
if not seed:
|
||
return None
|
||
return _run_in_thread(_import_fixtures(mock_port))
|
||
|
||
|
||
def test_sources_page_lists_indexed_docs(
|
||
page: Page, app_url: str, mock_llm: int, db_ready: None
|
||
) -> None:
|
||
summary = _reset_db(mock_llm, seed=True)
|
||
# Thirteen A9-format files are imported (phase 44 added
|
||
# homelab/tables.md, phase 47 added the quadlet + j2 fixtures);
|
||
# .hidden/junk.md is out of scope (A9 revised — hidden path components
|
||
# are never walked).
|
||
assert summary is not None and summary.added == 13
|
||
assert summary.formats == {
|
||
"md": 5, "yaml": 1, "json": 1, "py": 1, "txt": 1,
|
||
"container": 1, "network": 1, "volume": 1, "j2": 1, # phase 47
|
||
}
|
||
|
||
login(page, app_url) # phase 16: the catalog is admin-only
|
||
expect(page.locator("#stat-docs")).to_have_text("13")
|
||
# Phase 30: non-markdown fixtures each gained one ``is_summary`` chunk,
|
||
# so the Sources total is content chunks + summary chunks.
|
||
expect(page.locator("#stat-chunks")).to_have_text(
|
||
str(summary.chunks + summary.summaries)
|
||
)
|
||
expect(page.locator("#stat-last")).not_to_have_text("–")
|
||
expect(page.locator("#sources-empty")).to_be_hidden()
|
||
|
||
for row_path in EXPECTED_ROWS:
|
||
expect(page.locator("#docs-tbody tr", has_text=row_path)).to_have_count(1)
|
||
# The hidden junk was never indexed (A9 scope).
|
||
expect(page.locator("#docs-tbody tr", has_text=".hidden")).to_have_count(0)
|
||
# The path column carries the full path for hover (ellipsis is visual only).
|
||
expect(page.locator("#docs-tbody tr", has_text="homelab/kubernetes.md")
|
||
.get_by_role("cell").nth(1)).to_have_attribute("title", "homelab/kubernetes.md")
|
||
|
||
|
||
def test_sources_table_layout(
|
||
page: Page, browser: Browser, app_url: str, mock_llm: int, db_ready: None
|
||
) -> None:
|
||
_reset_db(mock_llm, seed=True)
|
||
login(page, app_url) # phase 16: the catalog is admin-only
|
||
page.locator("#docs-tbody tr").first.wait_for(state="visible")
|
||
|
||
# Phase 76 (task 02): the shell carries BOTH views' .table-wrap —
|
||
# scope to the RAG view.
|
||
wrap = page.locator("#view-rag .table-wrap")
|
||
expect(wrap).to_be_visible()
|
||
expect(wrap).to_have_attribute("role", "region")
|
||
expect(wrap).to_have_attribute("tabindex", "0")
|
||
expect(page.locator("#docs-table caption")).to_have_count(1)
|
||
|
||
# Full-width table: the wrapper uses (well) ≥80% of the 72rem container.
|
||
wrap_box = wrap.bounding_box()
|
||
shell_box = page.locator(".sources-shell").bounding_box()
|
||
assert wrap_box is not None and shell_box is not None
|
||
assert wrap_box["width"] >= 0.80 * shell_box["width"]
|
||
|
||
# Mobile (375px): the table keeps its 640px min-width → the wrapper
|
||
# scrolls horizontally instead of squeezing into a hairline.
|
||
mobile = browser.new_page(viewport={"width": 375, "height": 812})
|
||
try:
|
||
login(mobile, app_url) # phase 16: the catalog is admin-only
|
||
mobile.locator("#docs-tbody tr").first.wait_for(state="visible")
|
||
scroll_width, client_width = mobile.evaluate(
|
||
"() => { const el = document.querySelector('#view-rag .table-wrap');"
|
||
" return [el.scrollWidth, el.clientWidth]; }"
|
||
)
|
||
assert scroll_width > client_width
|
||
finally:
|
||
mobile.close()
|
||
|
||
|
||
def test_empty_state_when_no_docs(page: Page, app_url: str, mock_llm: int, db_ready: None) -> None:
|
||
_reset_db(mock_llm, seed=False)
|
||
|
||
login(page, app_url) # phase 16: the (empty-state) catalog is admin-only
|
||
expect(page.locator("#sources-empty")).to_be_visible()
|
||
expect(page.locator("#sources-empty")).to_contain_text("Nothing indexed yet")
|
||
expect(page.locator("#sources-empty code")).to_have_text(
|
||
"uv run python -m scripts.import_docs"
|
||
)
|
||
expect(page.locator("#view-rag .table-wrap")).to_be_hidden()
|
||
expect(page.locator("#stat-docs")).to_have_text("0")
|
||
expect(page.locator("#stat-chunks")).to_have_text("0")
|