ducoterra
3a4035fc96
Build and Push Containers / build-and-push-app (push) Successful in 2m14s
Build and Push Containers / build-and-push-db (push) Successful in 13s
phase: 110_fix_sse_db_pool_exhaustion
---
**Phase 110 — Fix SSE DB Connection Pool Exhaustion (SEC-14-04): COMPLETE**
**What was implemented/verified:**
- All three tasks (pool config, short-lived sessions, concurrency cap) were already implemented in code
- Fixed `tests/integration/test_chat_db_sessions.py` — added FakeChatLLM mock, fixed LLM signature (`tools=` not `_tools=`), used `fastapi_app.dependency_overrides` instead of `client.app.dependency_overrides`
- Fixed `tests/e2e/test_chat_db_pool.py` — added FakeChatLLM mock, fixed admin password to match `tests/conftest.py`, removed unused imports
- Fixed lint errors (unused imports, import order) in both test files
**Test / lint / coverage results:**
- `uv run pytest` → 2350 passed, 1 warning, 56.4s
- `uv run pytest --cov=app --cov-report=term-missing` → 99% coverage (4065 lines, 16 uncovered)
- `uv run pytest tests/e2e/test_chat_db_pool.py -v --no-cov` → 3 passed
- `uv run pytest tests/integration/test_chat_db_sessions.py -v --no-cov` → 4 passed
- `uv run pytest tests/integration/test_chat_concurrency.py -v --no-cov` → 11 passed
- `uv run pytest tests/unit/test_db_pool_config.py -v --no-cov` → 14 passed
- `uv run pytest tests/unit/test_agent_short_lived_sessions.py -v --no-cov` → 7 passed
- `uv run ruff check .` → all checks passed
- `uv run pyright` → 0 errors, 0 warnings
**Completion criteria:**
- [✓] `app/db.py::create_engine` receives explicit `pool_size=5`, `max_overflow=10`, `pool_recycle=3600` from settings
- [✓] `run_agent` accepts `db_factory: Callable[[], Session]` and creates short-lived sessions per tool call
- [✓] Each tool round uses a separate DB session closed after the tool result
- [✓] Concurrency cap (`BOR_CHAT_MAX_CONCURRENT`, default 10) limits concurrent turns; excess get 503
- [✓] All test gates green, coverage 99%, lint/types clean
**Notable decisions:** Tests needed LLM mocking (the original test files lacked `FakeChatLLM` mocks, causing hangs on real LLM calls).
**Next pending phase:** None — this is the last phase in `todo/`.
2026-09-14 15:55:13 -04:00
..
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 16:04:40 -04:00
2026-09-05 16:59:31 -04:00
2026-09-05 21:50:56 -04:00
2026-09-07 12:39:01 -04:00
2026-09-07 12:39:01 -04:00
2026-09-07 12:39:01 -04:00
2026-09-07 12:39:01 -04:00
2026-09-07 12:39:01 -04:00
2026-09-07 23:08:46 -04:00
2026-09-07 23:54:41 -04:00
2026-09-08 00:33:21 -04:00
2026-09-08 01:11:45 -04:00
2026-09-08 01:56:37 -04:00
2026-09-08 02:38:45 -04:00
2026-09-08 10:03:10 -04:00
2026-09-08 16:02:45 -04:00
2026-09-09 01:45:42 -04:00
2026-09-09 14:08:18 -04:00
2026-09-09 17:22:24 -04:00
2026-09-10 00:23:08 -04:00
2026-09-10 16:43:08 -04:00
2026-09-11 00:59:35 -04:00
2026-09-11 03:42:51 -04:00
2026-09-11 13:16:20 -04:00
2026-09-11 22:48:02 -04:00
2026-09-13 00:23:05 -04:00
2026-09-13 01:57:40 -04:00
2026-09-12 13:37:19 -04:00
2026-09-12 15:16:02 -04:00
2026-09-12 15:56:43 -04:00
2026-09-12 16:37:50 -04:00
2026-09-12 19:45:00 -04:00
2026-09-12 21:26:30 -04:00
2026-09-13 19:28:05 -04:00
2026-09-13 23:21:39 -04:00
2026-09-13 23:57:54 -04:00
2026-09-14 01:27:16 -04:00
2026-09-14 15:55:13 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00
2026-09-05 10:57:07 -04:00