558 lines
25 KiB
Python
558 lines
25 KiB
Python
"""Unit: the shared header module contract (phase 19).
|
|
|
|
The browser behavior is E2E-covered (tests/e2e/test_shared_header.py);
|
|
here we pin the source-level wiring — the header.js exports, the cached
|
|
whoami promise, the per-page HTML ids (anonymous-safe hidden-by-default
|
|
controls), the sign-out binding move out of app.js, the SINGLE
|
|
module-owned New chat binding (phase 34 task 02) + the sign-in
|
|
?next= rewrite, and the viewer-bar CSS — so a silent regression is
|
|
catched without a browser.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
from pathlib import Path
|
|
|
|
FRONTEND = Path(__file__).resolve().parents[2] / "frontend"
|
|
ASSETS = FRONTEND / "assets"
|
|
|
|
HEADER_JS = ASSETS / "header.js"
|
|
APP_JS = ASSETS / "app.js"
|
|
SOURCES_JS = ASSETS / "sources.js"
|
|
DOCUMENT_JS = ASSETS / "document.js"
|
|
LOGIN_JS = ASSETS / "login.js"
|
|
TUNING_JS = ASSETS / "tuning.js"
|
|
STYLES_CSS = ASSETS / "styles.css"
|
|
|
|
INDEX_HTML = FRONTEND / "index.html"
|
|
SOURCES_HTML = FRONTEND / "sources.html"
|
|
DOCUMENT_HTML = FRONTEND / "document.html"
|
|
LOGIN_HTML = FRONTEND / "login.html"
|
|
TUNING_HTML = FRONTEND / "tuning.html"
|
|
|
|
|
|
def _text(path: Path) -> str:
|
|
assert path.is_file(), f"missing frontend file: {path}"
|
|
return path.read_text(encoding="utf-8")
|
|
|
|
|
|
def _script_srcs(path: Path) -> list[str]:
|
|
return re.findall(r'<script[^>]*src="([^"]+)"', _text(path))
|
|
|
|
|
|
# ---------- header.js: the module itself ----------
|
|
|
|
|
|
def test_header_module_exports_the_three_functions() -> None:
|
|
"""header.js must export the three functions every page script
|
|
imports (fetchIsAdmin / initSharedHeader / clearChatStorage)."""
|
|
js = _text(HEADER_JS)
|
|
assert "export function fetchIsAdmin" in js
|
|
assert "export async function initSharedHeader" in js
|
|
assert "export function clearChatStorage" in js
|
|
|
|
|
|
def test_whoami_fetch_is_cached_in_a_module_level_promise() -> None:
|
|
"""The whoami fetch is cached in the module-level `adminPromise`
|
|
marker — first call stores the promise, later calls return it, so a
|
|
page makes exactly ONE /api/whoami request per load no matter how
|
|
many consumers await it. Anonymous-safe: a failure resolves to
|
|
false."""
|
|
js = _text(HEADER_JS)
|
|
assert re.search(r"let\s+adminPromise\s*=\s*null", js), (
|
|
"module-level adminPromise marker missing"
|
|
)
|
|
assert 'fetch("/api/whoami")' in js
|
|
assert "if (!adminPromise)" in js, "fetchIsAdmin must reuse the stored promise"
|
|
assert "return adminPromise" in js
|
|
assert ".catch(() => false)" in js, "network failure must resolve to anonymous"
|
|
|
|
|
|
def test_init_shared_header_toggles_only_elements_that_exist() -> None:
|
|
"""initSharedHeader awaits the cached whoami, toggles ONLY the
|
|
controls present on the page (querySelector, null-safe), and returns
|
|
the admin flag for reuse."""
|
|
js = _text(HEADER_JS)
|
|
fn = js.find("function initSharedHeader")
|
|
assert fn != -1
|
|
body = js[fn : js.find("\n}", fn)]
|
|
assert "await fetchIsAdmin()" in body
|
|
for selector in ("#sign-in-link", "#sign-out-btn", "#nav-sources", "#nav-tuning"):
|
|
assert f'querySelector("{selector}")' in body
|
|
assert "return admin" in body, "callers may reuse the flag"
|
|
|
|
|
|
def test_clear_chat_storage_removes_the_phase14_key_silently() -> None:
|
|
"""clearChatStorage removes the SAME phase-14 key as app.js, inside
|
|
a try/catch (private mode / storage errors are swallowed — the
|
|
navigation still happens)."""
|
|
js = _text(HEADER_JS)
|
|
fn = js.find("function clearChatStorage")
|
|
assert fn != -1
|
|
body = js[fn : js.find("\n}", fn)]
|
|
assert 'localStorage.removeItem("bor.chat.v1")' in body
|
|
assert "try" in body and "catch" in body
|
|
|
|
|
|
def test_sign_out_binding_lives_in_the_shared_module() -> None:
|
|
"""The #sign-out-btn click binding (disable → POST /api/logout →
|
|
reload) is owned by header.js at module import — exactly one
|
|
implementation for every page that loads it."""
|
|
js = _text(HEADER_JS)
|
|
assert "querySelector(\"#sign-out-btn\")" in js
|
|
assert "signOutBtn.addEventListener" in js
|
|
assert "signOutBtn.disabled = true" in js
|
|
assert 'fetch("/api/logout", { method: "POST" })' in js
|
|
assert "location.reload()" in js
|
|
|
|
|
|
# ---------- HTML wiring: one shared bar on every page ----------
|
|
|
|
|
|
def test_nav_sources_ships_hidden_on_every_nav_page() -> None:
|
|
"""Phase 19 UX revision (owner permission 2026-08-23), completed on
|
|
all five pages by phase 34 task 03 (owner confirmation 2026-08-26):
|
|
the Sources nav link is hidden for anonymous — so it SHIPS with the
|
|
hidden attribute (anonymous-safe default) on every page (they all
|
|
carry the nav now, viewer included)."""
|
|
for html in (INDEX_HTML, SOURCES_HTML, DOCUMENT_HTML, LOGIN_HTML, TUNING_HTML):
|
|
text = _text(html)
|
|
assert re.search(r'id="nav-sources"[^>]*\bhidden\b', text), (
|
|
f"{html.name}: #nav-sources must ship hidden"
|
|
)
|
|
|
|
|
|
def test_all_five_pages_share_the_header_control_order() -> None:
|
|
"""Phase 34 task 03 (owner confirmation 2026-08-26): every page
|
|
ships the IDENTICAL header control inventory in the IDENTICAL
|
|
order — brand, nav [Chat, Sources, Tuning], #sync-btn, #new-chat-btn,
|
|
Sign in, Sign out (the #steering-toggle was removed from the navbar
|
|
at owner request, 2026-08-28) — inside the shared
|
|
.header-inner row (the document viewer's row 1). Only the
|
|
current-page is-active nav marker and the static ?next= fallback
|
|
may differ per page (task 05's story E2E pins the rendered
|
|
result)."""
|
|
markers = (
|
|
'class="brand"',
|
|
'<nav class="app-nav"',
|
|
'href="/"',
|
|
'id="nav-sources"',
|
|
'id="nav-tuning"',
|
|
'id="sync-btn"',
|
|
'id="new-chat-btn"',
|
|
'id="sign-in-link"',
|
|
'id="sign-out-btn"',
|
|
)
|
|
for html in (INDEX_HTML, SOURCES_HTML, DOCUMENT_HTML, TUNING_HTML, LOGIN_HTML):
|
|
text = _text(html)
|
|
start = text.find('<div class="container header-inner">')
|
|
assert start != -1, f"{html.name}: missing the shared .header-inner row"
|
|
region = text[start : text.find("</header>", start)]
|
|
missing = [m for m in markers if m not in region]
|
|
assert not missing, f"{html.name}: header controls missing {missing}"
|
|
for m in markers:
|
|
assert region.count(m) == 1, f"{html.name}: {m} must appear exactly once"
|
|
# Same order on every page: each control follows the previous one.
|
|
pos = -1
|
|
for m in markers:
|
|
idx = region.find(m, pos + 1)
|
|
assert idx > pos, f"{html.name}: {m} out of order in the shared bar"
|
|
pos = idx
|
|
|
|
|
|
def test_all_five_pages_carry_the_steering_panel() -> None:
|
|
"""Phase 34 task 03: the #steering-panel section (+ the
|
|
#steering-announcer live region) ships on every page — after
|
|
#kb-banner in the chat shell, first child of <main> on the other
|
|
four pages — ship hidden, driven by assets/header.js."""
|
|
for html in (INDEX_HTML, SOURCES_HTML, DOCUMENT_HTML, TUNING_HTML, LOGIN_HTML):
|
|
text = _text(html)
|
|
tag = re.search(r'<section[^>]*id="steering-panel"[^>]*>', text)
|
|
assert tag, f"{html.name}: missing the #steering-panel section"
|
|
assert re.search(r'\bhidden\b', tag.group(0)), "the panel ships hidden"
|
|
assert 'id="steering-list"' in text
|
|
assert 'id="steering-empty"' in text
|
|
assert re.search(r'<p[^>]*id="steering-announcer"[^>]*role="status"[^>]*>', text), (
|
|
f"{html.name}: missing the #steering-announcer live region"
|
|
)
|
|
# The announcer follows the panel (the copied index.html block).
|
|
assert text.find('id="steering-panel"') < text.find('id="steering-announcer"')
|
|
|
|
|
|
def test_nav_tuning_ships_hidden_on_the_tuning_page() -> None:
|
|
"""Phase 27: the Global Tuning page reuses the shared header — the
|
|
"Tuning" nav link is admin-only, so it SHIPS hidden (revealed by
|
|
initSharedHeader once whoami says admin), is the page's active link
|
|
(is-active + aria-current), and the page loads markdown.js (classic)
|
|
+ the tuning.js module with NO direct header.js <script> tag
|
|
(single-evaluation design)."""
|
|
text = _text(TUNING_HTML)
|
|
tag = re.search(r'<a[^>]*id="nav-tuning"[^>]*>', text)
|
|
assert tag, "tuning.html must carry the #nav-tuning nav link"
|
|
assert 'class="nav-link is-active"' in tag.group(0), "the Tuning link is the active one"
|
|
assert 'aria-current="page"' in tag.group(0)
|
|
assert "hidden" in tag.group(0), "#nav-tuning must ship hidden (admin-only)"
|
|
srcs = _script_srcs(TUNING_HTML)
|
|
assert [s for s in srcs if "header.js" in s] == [], "no direct header.js <script> tag"
|
|
assert [s for s in srcs if "markdown.js" in s]
|
|
assert [s for s in srcs if "tuning.js" in s]
|
|
|
|
|
|
def test_viewer_carries_the_standard_nav() -> None:
|
|
"""Phase 34 task 03 (owner confirmation 2026-08-26): the document
|
|
viewer carries the SAME standard bar as every other page — row 1 is
|
|
the shared .header-inner block, so the nav (Chat + the admin-only
|
|
#nav-sources / #nav-tuning links, ship hidden) is there too. No nav
|
|
link is "current" on the viewer: a document is a detail view
|
|
reachable from chat or Sources, and the phase-13 back link (row 2)
|
|
carries the return affordance. The phase-19 single-row bar
|
|
(.doc-header-actions) is superseded by the two-row layout —
|
|
.doc-titlebar keeps #doc-back / #doc-title / #doc-meta, so
|
|
document.js needs no render change."""
|
|
text = _text(DOCUMENT_HTML)
|
|
chat = re.search(r'<a[^>]*href="/"[^>]*>Chat</a>', text)
|
|
assert chat, "the viewer bar carries the standard nav"
|
|
assert "is-active" not in chat.group(0), "no nav link is current on the viewer"
|
|
for link in ("nav-sources", "nav-tuning"):
|
|
tag = re.search(rf'<a[^>]*id="{link}"[^>]*>', text)
|
|
assert tag, f"the viewer bar must carry #{link}"
|
|
assert "hidden" in tag.group(0), f"#{link} must ship hidden (admin-only)"
|
|
assert "is-active" not in tag.group(0)
|
|
# Row 1 is the standard bar inside the two-row viewer header.
|
|
assert re.search(r'<header[^>]*class="doc-header"', text), "the header keeps .doc-header"
|
|
assert 'class="app-header"' in text, "row 1 reuses the .app-header bar"
|
|
assert 'doc-header-inner' not in text, "the old single-row wrapper is gone"
|
|
assert 'doc-header-actions' not in text, "the old actions wrapper is gone"
|
|
# Row 2: the .doc-titlebar keeps the back link + title + meta.
|
|
assert 'class="doc-titlebar"' in text, "row 2 must be the .doc-titlebar"
|
|
assert 'id="doc-back"' in text
|
|
assert 'id="doc-title"' in text
|
|
assert 'id="doc-meta"' in text
|
|
back = re.search(r'<a[^>]*id="doc-back"[^>]*href="/sources.html"', text)
|
|
assert back, "the back link keeps its /sources.html no-JS fallback"
|
|
|
|
|
|
def test_sources_and_viewer_carry_the_shared_controls() -> None:
|
|
"""Sources AND the document viewer gain the New Chat button + the
|
|
Sign in / Sign out pair (both starting hidden — initSharedHeader
|
|
reveals exactly one after whoami), and their page scripts load
|
|
header.js (phase 23: via the page script's relative import, not a
|
|
direct script tag)."""
|
|
for html in (SOURCES_HTML, DOCUMENT_HTML):
|
|
text = _text(html)
|
|
assert 'id="new-chat-btn"' in text
|
|
assert re.search(r'id="sign-in-link"[^>]*\bhidden\b', text)
|
|
assert re.search(r'id="sign-out-btn"[^>]*\bhidden\b', text)
|
|
for js_file in (SOURCES_JS, DOCUMENT_JS):
|
|
assert 'from "./header.js"' in _text(js_file), (
|
|
f"{js_file.name}: page script must load the shared header module"
|
|
)
|
|
# Each page's Sign in link returns to ITS OWN page after login.
|
|
assert 'href="/login.html?next=/sources.html"' in _text(SOURCES_HTML)
|
|
assert 'href="/login.html?next=/document.html"' in _text(DOCUMENT_HTML)
|
|
|
|
|
|
def test_header_module_loads_before_the_page_script() -> None:
|
|
"""Phase 23 (owner-confirmed single-evaluation design): NO page loads
|
|
header.js with a direct <script> tag anymore. Each page script
|
|
imports it relatively (`from "./header.js"`) — a hoisted import that
|
|
the browser evaluates BEFORE the page script body runs, and that the
|
|
image bundler inlines into the page bundle. The sign-out binding and
|
|
the whoami cache therefore exist when the page script boots, and
|
|
header.js can never be evaluated twice on a page (a tag + import pair
|
|
would double-bind the sign-out listener)."""
|
|
cases = [
|
|
(INDEX_HTML, "app.js"),
|
|
(SOURCES_HTML, "sources.js"),
|
|
(DOCUMENT_HTML, "document.js"),
|
|
(LOGIN_HTML, "login.js"),
|
|
]
|
|
for html, page_script in cases:
|
|
srcs = _script_srcs(html)
|
|
assert [s for s in srcs if "header.js" in s] == [], (
|
|
f"{html.name}: no direct header.js <script> tag (single-evaluation design)"
|
|
)
|
|
assert [s for s in srcs if page_script in s], (
|
|
f"{html.name}: must load {page_script}"
|
|
)
|
|
js = _text(ASSETS / page_script)
|
|
assert 'from "./header.js"' in js, (
|
|
f"{page_script}: must import the shared header module relatively"
|
|
)
|
|
assert 'from "/assets/header.js"' not in js, (
|
|
f"{page_script}: absolute header import would break the esbuild bundle"
|
|
)
|
|
|
|
|
|
def test_login_page_carries_the_full_header() -> None:
|
|
"""Phase 34 task 03 (owner confirmation 2026-08-26): the noted
|
|
boundary is reversed by owner decision — the login page finally
|
|
carries the FULL shared header: the nav gains the #nav-tuning link
|
|
(same ship-hidden markup as the other pages), plus the admin-only
|
|
Sync button, New chat, and the Sign in / Sign out pair (ship hidden
|
|
— initSharedHeader reveals exactly one after whoami; the static
|
|
?next= fallback is the login page itself). The Tuning toggle is NOT
|
|
among them — removed from the navbar at owner request (2026-08-28).
|
|
No nav link is "current" on the auth page."""
|
|
text = _text(LOGIN_HTML)
|
|
for marker in (
|
|
'id="nav-sources"',
|
|
'id="nav-tuning"',
|
|
'id="sync-btn"',
|
|
'id="new-chat-btn"',
|
|
'id="sign-in-link"',
|
|
'id="sign-out-btn"',
|
|
):
|
|
assert marker in text, f"login.html must carry {marker} (phase 34 full header)"
|
|
assert 'href="/login.html?next=/login.html"' in text, (
|
|
"the login page's Sign in returns to the login page (no-JS fallback)"
|
|
)
|
|
for tag in re.findall(r'<a[^>]*class="nav-link[^"]*"[^>]*>', text):
|
|
assert "is-active" not in tag, "no nav link is current on the login page"
|
|
|
|
|
|
# ---------- page-script adaptations ----------
|
|
|
|
|
|
def test_app_js_delegates_the_shared_controls_to_header_module() -> None:
|
|
"""app.js imports the shared module, runs initSharedHeader() at boot
|
|
(BEFORE the phase-14 restore), takes its isAdmin from the cached
|
|
fetchIsAdmin(), and owns NO whoami fetch and NO sign-out binding
|
|
anymore (both moved to header.js). Phase 23: the import is relative
|
|
(`./header.js`) so esbuild can bundle it into the image."""
|
|
js = _text(APP_JS)
|
|
assert 'from "./header.js"' in js
|
|
assert "fetchIsAdmin" in js and "initSharedHeader" in js
|
|
assert "signOutBtn.addEventListener" not in js, (
|
|
"the sign-out binding moved to header.js"
|
|
)
|
|
assert 'fetch("/api/whoami")' not in js, (
|
|
"app.js must not fetch whoami itself — header.js caches it (one request/page)"
|
|
)
|
|
assert "loadAuthState" not in js, "loadAuthState was deleted in phase 19"
|
|
assert "function applyAuthState" in js, "chat-page tuning gate stays"
|
|
assert "isAdmin = await fetchIsAdmin();" in js
|
|
init_idx = js.find("await initSharedHeader();")
|
|
restore_idx = js.find("restoreConversation();")
|
|
assert -1 < init_idx < restore_idx, (
|
|
"header init must run before the phase-14 restore"
|
|
)
|
|
|
|
|
|
def test_login_js_uses_the_shared_fetch_is_admin() -> None:
|
|
"""login.js switches its whoami check to the shared cached promise
|
|
(one request per page) and calls initSharedHeader for the Sources
|
|
link; its already-admin → redirect behavior is unchanged. Phase 23:
|
|
the import is relative (`./header.js`)."""
|
|
js = _text(LOGIN_JS)
|
|
assert 'from "./header.js"' in js
|
|
assert "fetchIsAdmin" in js
|
|
assert "fetchIsAdmin()" in js
|
|
assert "initSharedHeader()" in js
|
|
assert 'fetch("/api/whoami")' not in js
|
|
assert "window.location.replace(safeNext())" in js
|
|
|
|
|
|
def test_new_chat_binding_is_single_and_module_owned() -> None:
|
|
"""Phase 34 task 02: header.js owns the SINGLE #new-chat-btn binding
|
|
(module import, like the sign-out binding): on the chat page
|
|
(#messages exists) it dispatches window "bor:new-chat" — app.js acts
|
|
through its own in-flight-turn guard + list reset; on every other
|
|
page it means "go to the chat, fresh" (clearChatStorage + navigate
|
|
to "/"). NO page script binds #new-chat-btn anymore, and each page
|
|
still runs initSharedHeader() on the shared cached whoami. Phase 23:
|
|
the import is relative (`./header.js`)."""
|
|
js = _text(HEADER_JS)
|
|
assert 'querySelector("#new-chat-btn")' in js
|
|
assert "newChatBtn.addEventListener" in js
|
|
assert 'querySelector("#messages")' in js, "the chat-page branch key"
|
|
assert 'new CustomEvent("bor:new-chat")' in js
|
|
assert "clearChatStorage();" in js
|
|
assert 'window.location.href = "/"' in js
|
|
for js_file in (SOURCES_JS, DOCUMENT_JS, TUNING_JS):
|
|
page_js = _text(js_file)
|
|
assert 'from "./header.js"' in page_js
|
|
assert "initSharedHeader()" in page_js
|
|
assert "new-chat-btn" not in page_js, (
|
|
f"{js_file.name}: no #new-chat-btn binding (the module owns it)"
|
|
)
|
|
assert 'fetch("/api/whoami")' not in page_js, (
|
|
f"{js_file.name}: whoami goes through the shared cached promise"
|
|
)
|
|
app_js = _text(APP_JS)
|
|
assert 'window.addEventListener("bor:new-chat", startNewChat)' in app_js
|
|
assert "newChatBtn.addEventListener" not in app_js, (
|
|
"app.js acts off the module's event, not its own binding"
|
|
)
|
|
|
|
|
|
def test_init_shared_header_rewrites_sign_in_next_to_current_page() -> None:
|
|
"""Phase 34 task 02: initSharedHeader points #sign-in-link at
|
|
/login.html?next=<current pathname> (default "/") — the admin lands
|
|
back on the page they signed in from. The page markup keeps its own
|
|
static ?next= as the no-JS fallback."""
|
|
js = _text(HEADER_JS)
|
|
fn = js.find("function initSharedHeader")
|
|
assert fn != -1
|
|
body = js[fn : js.find("\n}", fn)]
|
|
# raw pathname (always a query-safe "/…" string — never "//", and ?
|
|
# # / spaces stay percent-encoded inside it; login.js safeNext
|
|
# re-validates), same shape as the static markup fallbacks
|
|
assert '"/login.html?next=" + (window.location.pathname || "/")' in body
|
|
|
|
|
|
# ---------- phase 34 task 01: the steering controls move to the module ----------
|
|
# (task 02 — the sync machine + New chat + sign-in next — is pinned in
|
|
# test_sync_button.py / above)
|
|
|
|
|
|
def test_header_module_owns_the_steering_panel() -> None:
|
|
"""header.js owns the steering panel behavior (moved from app.js in
|
|
phase 34 task 01): the module-level null-safe element refs, the
|
|
newest-first textContent render (XSS contract), the labeled
|
|
per-note delete, and the announcer — and NO toggle wiring anymore
|
|
(the navbar #steering-toggle was removed at owner request,
|
|
2026-08-28; note management lives on /tuning.html)."""
|
|
js = _text(HEADER_JS)
|
|
for selector in (
|
|
"#steering-panel",
|
|
"#steering-list",
|
|
"#steering-empty",
|
|
"#steering-announcer",
|
|
):
|
|
assert f'querySelector("{selector}")' in js, f"missing {selector} ref"
|
|
assert "function renderSteeringPanel" in js
|
|
assert "text.className = \"steering-note-text\"" in js
|
|
assert "text.textContent = n.note" in js, (
|
|
"XSS contract: the note renders via textContent, never innerHTML"
|
|
)
|
|
assert 'del.setAttribute("aria-label", `Delete tuning note: ${n.note}`)' in js
|
|
assert "async function deleteSteeringNote" in js
|
|
assert 'fetch(`/api/steering/${encodeURIComponent(id)}`, { method: "DELETE" })' in js
|
|
assert "refreshSteering()" in js # the admin boot refresh + the form's save
|
|
assert "steeringToggle" not in js, "the navbar toggle is gone (2026-08-28)"
|
|
|
|
|
|
def test_header_module_exports_refresh_and_announce_steering() -> None:
|
|
"""refreshSteering() (fetch + render; non-2xx / unreachable API →
|
|
the empty list state) and announceSteering() (the polite live
|
|
region) are exported for the chat page's per-bubble Tune form.
|
|
"""
|
|
js = _text(HEADER_JS)
|
|
assert "export async function refreshSteering" in js
|
|
fn = js.find("function refreshSteering")
|
|
assert fn != -1
|
|
body = js[fn : js.find("\n}", fn)]
|
|
assert 'fetch("/api/steering")' in body
|
|
assert "renderSteeringPanel(notes)" in body
|
|
assert "export function announceSteering" in js
|
|
ann = js.find("function announceSteering")
|
|
assert ann != -1
|
|
ann_body = js[ann : js.find("\n}", ann)]
|
|
assert "steeringAnnouncer.textContent = message" in ann_body
|
|
|
|
|
|
def test_init_shared_header_gates_the_steering_surface() -> None:
|
|
"""Inside initSharedHeader: admin → the list refreshes (the panel
|
|
ships hidden and is only kept fresh; only when the page ships the
|
|
panel markup); anonymous → the panel is REMOVED from the DOM
|
|
(phase-16 'absent, not hidden') and /api/steering is never fetched.
|
|
The navbar toggle was removed at owner request (2026-08-28) — no
|
|
unhide / remove of a toggle may be left behind."""
|
|
js = _text(HEADER_JS)
|
|
fn = js.find("function initSharedHeader")
|
|
assert fn != -1
|
|
body = js[fn : js.find("\n}", fn)]
|
|
assert "if (steeringPanel) refreshSteering();" in body
|
|
assert "steeringToggle" not in body
|
|
assert "steeringPanel?.remove();" in body
|
|
|
|
|
|
def test_app_js_no_longer_owns_the_steering_panel() -> None:
|
|
"""app.js keeps only the chat-specific per-bubble Tune button +
|
|
inline form: the panel refs + logic are gone (header.js owns them
|
|
now), and the form's success path awaits the module's
|
|
refreshSteering() (announcing through the module's
|
|
announceSteering()). The form's POST /api/steering + error handling
|
|
stay in app.js, untouched."""
|
|
js = _text(APP_JS)
|
|
for gone in (
|
|
"steeringToggle",
|
|
"steeringCount",
|
|
"steeringPanel",
|
|
"steeringList",
|
|
"steeringEmpty",
|
|
"steeringAnnouncer",
|
|
"loadSteering",
|
|
"renderSteeringPanel",
|
|
"deleteSteeringNote",
|
|
"setSteeringPanel",
|
|
'querySelector("#steering-toggle")',
|
|
):
|
|
assert gone not in js, f"{gone!r} must be gone from app.js (header.js owns it)"
|
|
# the chat-specific part survives and is wired to the shared module
|
|
assert "function appendTuneButton" in js
|
|
assert "function openTuneForm" in js
|
|
assert "TUNE_ICON" in js
|
|
assert 'from "./header.js"' in js
|
|
assert "refreshSteering" in js and "announceSteering" in js
|
|
assert "await refreshSteering()" in js
|
|
assert 'fetch("/api/steering", {' in js # the form's POST still lives here
|
|
|
|
|
|
# ---------- viewer two-row-header CSS (phase 34 task 04) ----------
|
|
|
|
|
|
def test_viewer_two_row_header_css() -> None:
|
|
"""Phase 34 task 04: the viewer header is two rows — row 1 reuses
|
|
the .app-header / .header-inner rules verbatim (the pinned
|
|
--header-h height still applies to row 1), row 2 is the
|
|
.doc-titlebar: a quiet --line border-top separator, a flex
|
|
.container row, its own content-sized height. The old single-row
|
|
.doc-header-actions / .doc-header-inner rules are gone, .doc-header
|
|
no longer pins a fixed height, and .doc-title-block keeps
|
|
min-width: 0 so #doc-title / #doc-meta ellipsize in the row."""
|
|
css = _text(STYLES_CSS)
|
|
block = re.search(r"\.doc-titlebar\s*\{([^}]*)\}", css)
|
|
assert block, "styles.css must define .doc-titlebar"
|
|
body = block.group(1)
|
|
assert "border-top: 1px solid var(--line)" in body, (
|
|
"the titlebar separates from row 1 with the quiet hairline"
|
|
)
|
|
assert "height: var(--header-h)" not in body, (
|
|
"the titlebar row is content-sized (title line + meta line)"
|
|
)
|
|
assert re.search(r"\.doc-titlebar\s*\.container\s*\{[^}]*display:\s*flex", css), (
|
|
"the titlebar row must be a flex row (back link + title block)"
|
|
)
|
|
assert re.search(r"\.doc-header-actions\s*\{", css) is None, (
|
|
"the old single-row actions cluster rule is gone"
|
|
)
|
|
assert re.search(r"\.doc-header-inner\s*\{", css) is None, (
|
|
"the old single-row wrapper rule is gone"
|
|
)
|
|
header_block = re.search(r"\.doc-header\s*\{([^}]*)\}", css)
|
|
assert header_block, "styles.css must still style the .doc-header header element"
|
|
assert "height: var(--header-h)" not in header_block.group(1), (
|
|
"the two-row header is content-sized — row 1 keeps the pinned height"
|
|
)
|
|
assert re.search(r"\.doc-title-block\s*\{[^}]*min-width:\s*0", css), (
|
|
"the title block must keep clipping while the row stays tidy"
|
|
)
|
|
|
|
|
|
def test_failed_sync_button_carries_the_error_look() -> None:
|
|
"""Phase 34 task 04: the #sync-btn now lives on every page, and the
|
|
non-Sources pages have no error banner — the failed state must be
|
|
visible on the button itself. header.js adds .is-error (with the
|
|
sanitized error in title / aria-label); styles.css must render it
|
|
with the phase-08 error pair (--err-ink on --err-bg ≈9.1:1,
|
|
--err-line border — never the amber deflection accent)."""
|
|
css = _text(STYLES_CSS)
|
|
block = re.search(r"\.sync-btn\.is-error\s*\{([^}]*)\}", css)
|
|
assert block, "styles.css must define the failed .sync-btn look"
|
|
body = block.group(1)
|
|
assert "var(--err-bg)" in body
|
|
assert "var(--err-ink)" in body
|
|
assert "var(--accent-" not in body, "the amber deflection accent is never on errors"
|