fix(chat): keep in-flight answers alive across in-app view switches
Root cause (owner repro, verified in a real browser 2026-09-06): the five navbar views (Chat, RAG, Sources, Tuning, History) were separate HTML documents, so a navbar click was a REAL cross-document navigation — the chat page unloaded, the in-flight SSE fetch was aborted, and the phase-48 teardown (app/api/chat.py `finally`, "chat: turn cancelled") stopped the model. Observed: send question -> click RAG mid-stream -> click Chat -> the answer never finished: no `query_log` row, and on return a dangling question with no brain record (the pre-token pagehide partial persist skips because `acc` is empty). Phase-48 LOCKED-DECISION REFINEMENT (owner-confirmed 2026-09-06, flagged per AGENTS.md rule 3, not silently deviated): "real navigation cancels the fetch" now means LEAVING THE APP — tab close, external/other-document navigation, the Stop button. In-app navbar switches are client-side view switches and no longer cancel. Fix — Option A (SPA shell), chosen over B (Service Worker owns the stream) and C (server-side turn registry + resume): - frontend/index.html is the shell: ONE `<main id="main">` holds the five `<section class="view">` blocks; hidden views carry BOTH `hidden` and `inert` (WCAG — no focus/keyboard traversal). The shared header, the single `doc-modal-*` skeleton, and the `#app-version` footer each exist exactly once; the per-view copies from the four folded pages are dropped. - New frontend/assets/router.js (vanilla module — no framework, no bundler, No-CDN rule intact): lazy-imports a view module on FIRST show only (mount-once, hide-forever — the chat view's in-flight SSE reader persists across switches; that persistence IS the fix); intercepts same-shell navbar links with preventDefault + history.pushState (never a document load); handles popstate; single writer of `.nav-link` active state (is-active + aria-current), document.title, and the per-view meta description (values carried over from the old pages' heads, brand-resolved at write time). - Each folded page's JS becomes `export async function mount(root)` — root-scoped queries; `initSharedHeader()` dropped (the header boots once in the shell via the chat module; the admin flag comes from the same cached `fetchIsAdmin()` promise — zero extra requests). - app/main.py: a small list-driven route factory serves the shell for /tuning.html, /sources.html, /git-sources.html, /history.html — registered AFTER the API routers and BEFORE the static catch-all (routes-first). The phase-33 caching middleware applies no-cache + `?v=` rewriting unchanged; app/core/caching.py needed NO change (the view paths did not change — pinned by the integration tests). - The four old view .html files are DELETED (one source of truth); deep links to the old URLs keep working (the router picks the view from the pathname); `/?chat=<id>` is unaffected; the Containerfile bundles router.js (inlining the lazy view modules) and drops the folded page files. - app/schemas.py: HistoryTurn.text cap 4000 -> 32000 — the shell keeps long saved answers in the chat, and the old cap (stricter than the 24_000-char total history budget) 422-rejected any second turn in such a chat (found by the phase-42 E2E suite on the shell). Boundaries: login.html, shared.html, doc-edit.html, document.html REMAIN separate documents (flow pages, not navbar tabs); a mid-stream navigation to doc-edit/document.html still cancels per phase 48 (follow-up candidate, out of scope). The SSE API is unchanged. Real departures still cancel the turn — phase 48 intact (pinned by tests/e2e/test_stop_generation.py, unchanged, and by the new suite's real-departure control). Tests: - Phase-20 suite REWRITTEN to the new semantics (tests/e2e/test_sources_midstream_bug.py): a navbar switch no longer cancels — the stream survives the switch and the FULL answer settles; the pagehide partial persist REMAINS for real departures (the partial's exact shape — first streamed chunk prefix, no done metadata — is still pinned there). - NEW story suite tests/e2e/test_nav_switch_keeps_stream.py (mock LLM): the owner repro (send -> RAG mid-stream -> Chat: window sentinel survives = same document, FULL answer, exactly one brain turn in bor.chat.v1, exactly one settled query_log row, auto-saved row matches) + the same mid-stream switch against the other three views + the real-departure-still-cancels control + the no-switch baseline. - tests/unit/test_frontend_router.py: source-level pins of the router invariants (click interceptor targets ONLY same-shell view paths, pushState-only switches, mount-once guard, hidden+inert pair, single-writer active state/title); shell-route integration tests (each folded path serves the shell with no-cache + `?v=` body; a non-view path still 404s); the file-reading unit pins re-pointed at the shell (the four view files are gone — the shell is the source of truth). Verification (this commit): full suite green — 1565 unit+integration tests, app/ coverage 99% (>90% floor); ruff + pyright clean; the phase's E2E suites green in isolation (house protocol, AGENTS.md rule 9). Owner repro verified in a real browser against the real LLM (dev server :8010, headful Chromium): "tell me about everquest" -> RAG mid-stream -> Chat — the answer completed with one brain bubble and no error banner, `query_log` gained exactly one settled row (deflected=True: the dev KB holds no EverQuest docs — the settle, not the topic, is the proof), zero "chat: turn cancelled" lines for that turn; the control (real navigation to /shared.html mid-stream) still cancelled (no settled row, the cancel line logged, the partial persisted on return). Screenshots: .agents/screenshots/76_manual_*. Phase 76 (76_spa_nav_shell) complete — moved to .agents/phases/complete/.
This commit is contained in:
@@ -82,7 +82,20 @@
|
||||
</div>
|
||||
</header>
|
||||
|
||||
<!-- Phase 76 (task 01): the shell's single <main> holds the navbar
|
||||
views as <section class="view"> blocks — only the active one is
|
||||
shown (the others carry hidden + inert, so focus and keyboard
|
||||
traversal never enter them). A navbar click is a client-side
|
||||
view switch (assets/router.js — pushState + show/hide), never a
|
||||
document load; the in-flight chat stream in the hidden view
|
||||
keeps streaming through any switch. Each folded page's own
|
||||
<main class="app-main"> wrapper (identical on all five pages —
|
||||
the layout CSS is class-based) is dropped with the move, and
|
||||
the per-view copies of the header-owned steering panel are
|
||||
dropped too (this shell's ONE panel — the chat one, inside
|
||||
#view-chat — is the instance header.js drives). -->
|
||||
<main id="main" class="app-main" tabindex="-1">
|
||||
<section class="view" id="view-chat" aria-label="Chat" tabindex="-1">
|
||||
<div class="container chat-shell" data-state="empty">
|
||||
<div class="kb-banner" id="kb-banner" role="status" hidden>
|
||||
<svg aria-hidden="true" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M12 3.6 22.2 20.4H1.8Z"/><path d="M12 9.5v4.6"/><path d="M12 17.4h.01"/></svg>
|
||||
@@ -260,6 +273,467 @@
|
||||
</form>
|
||||
</div>
|
||||
</div>
|
||||
</section>
|
||||
|
||||
<!-- Phase 76 (task 01): the Global Tuning view — the content of
|
||||
frontend/tuning.html's <main> (wrapper dropped), folded into
|
||||
the shell. /tuning.html now serves THIS document (the shell
|
||||
route in app/main.py); the router shows this section for that
|
||||
pathname. Its own header / steering-panel copies lived in the
|
||||
old page's <header>/<main> and are dropped — the shell's
|
||||
single header + chat-view panel stand in for them. The
|
||||
hidden + inert pair is the WCAG contract: a hidden view must
|
||||
not receive focus or keyboard traversal (AGENTS.md rule 5).
|
||||
mounted lazily — assets/router.js imports tuning.js on first
|
||||
show only (mount-once, hide-forever). -->
|
||||
<section class="view" id="view-tuning" hidden inert aria-label="Global Tuning" tabindex="-1">
|
||||
<div class="container tuning-shell">
|
||||
<div class="page-head">
|
||||
<h1>Global Tuning</h1>
|
||||
<p class="page-sub">
|
||||
Every note below is read into the system prompt of
|
||||
<strong>every</strong> chat turn. Add, edit, or remove them here —
|
||||
no conversation required.
|
||||
</p>
|
||||
</div>
|
||||
|
||||
<!-- Phase 27: create a note without a chat. The label is
|
||||
visually-hidden (the heading + placeholder carry the visible
|
||||
context); the 1–2000-char contract mirrors the chat-page tune
|
||||
form — the server re-validates (422). -->
|
||||
<form id="tune-form">
|
||||
<label class="visually-hidden" for="tune-note">Add a global tuning note</label>
|
||||
<textarea
|
||||
id="tune-note"
|
||||
name="note"
|
||||
rows="3"
|
||||
maxlength="2000"
|
||||
placeholder="e.g. be more concise — or: assume I'm on NixOS"
|
||||
required
|
||||
></textarea>
|
||||
<button type="submit" id="tune-save">Add note</button>
|
||||
</form>
|
||||
|
||||
<!-- Live announcer for create / edit / delete — tuning.js (phase 27,
|
||||
task 03) owns the message text. -->
|
||||
<p class="visually-hidden" id="tune-announcer" role="status" aria-live="polite"></p>
|
||||
|
||||
<!-- Phase 27: the note list — the phase-15 steering panel's
|
||||
language, full column width. tuning.js fills it newest-first;
|
||||
each row is an <li class="tuning-note"> with a
|
||||
.tuning-note-text span + an Edit and a Delete button (styles:
|
||||
styles.css "Global tuning page"). The empty state toggles with
|
||||
the list. -->
|
||||
<section class="tuning-panel" aria-labelledby="tuning-panel-title">
|
||||
<h2 id="tuning-panel-title" class="tuning-panel-title">Tuning notes</h2>
|
||||
<ul id="tune-list" class="tuning-list" role="list"></ul>
|
||||
<p id="tune-empty">No tuning notes yet — add one above.</p>
|
||||
</section>
|
||||
</div>
|
||||
</section>
|
||||
<!-- Phase 76 (task 02): the RAG view (the Knowledge base catalog)
|
||||
— the content of frontend/sources.html's <main> (wrapper
|
||||
dropped), folded into the shell. /sources.html now serves THIS
|
||||
document (the shell route in app/main.py); the router shows
|
||||
this section for that pathname. The per-view copies of the
|
||||
header-owned steering panel + announcer are dropped (the
|
||||
shell's ONE panel — the chat one, inside #view-chat — is the
|
||||
instance header.js drives), and the old page's SECOND
|
||||
doc-modal-* skeleton copy is dropped too: the shell keeps
|
||||
EXACTLY ONE (the chat's, body level), which BOTH app.js (chat
|
||||
chips) and sources.js (RAG rows) open through
|
||||
openDocumentModal(...). The per-page footer does not move
|
||||
(body-level — the shell's single footer stands in). The
|
||||
hidden + inert pair is the WCAG contract: a hidden view must
|
||||
not receive focus or keyboard traversal (AGENTS.md rule 5).
|
||||
Mounted lazily — assets/router.js imports sources.js on first
|
||||
show only (mount-once, hide-forever). -->
|
||||
<section class="view" id="view-rag" hidden inert aria-label="RAG" tabindex="-1">
|
||||
<div class="container sources-shell">
|
||||
<div class="page-head">
|
||||
<div class="page-head-row">
|
||||
<h1>Knowledge base</h1>
|
||||
<button type="button" class="sync-btn" id="sync-btn" aria-label="Sync sources" hidden>
|
||||
<svg class="sync-icon" aria-hidden="true" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="1.7" stroke-linecap="round" stroke-linejoin="round"><path d="M21 12a9 9 0 1 1-9-9c2.52 0 4.93 1 6.74 2.74L21 8"/><path d="M21 3v5h-5"/></svg>
|
||||
<span class="sync-label" id="sync-label">Sync sources</span>
|
||||
</button>
|
||||
</div>
|
||||
<p class="page-sub">
|
||||
Every file indexed from your configured sources — git repositories,
|
||||
local directories, and uploaded archives. Press <strong>Sync sources</strong>
|
||||
to pull the latest and re-import.
|
||||
</p>
|
||||
</div>
|
||||
<!-- #sync-result is the aria-live announcer: the last sync
|
||||
result ("N added · …") when a sync settles, and — phase 64 —
|
||||
the LIVE file label while either job runs ("Syncing… <file>
|
||||
(n/m)" / "Importing <file> (n/m)"), UNTRUNCATED (the button's
|
||||
label span ellipsizes; screen readers hear the full
|
||||
source/relative path, which also rides the button title).
|
||||
After an upload settles it stays empty — the upload's counts
|
||||
live on the Sources page (A3). -->
|
||||
<span class="sync-result" id="sync-result" role="status" aria-live="polite"></span>
|
||||
<!-- Sync failure banner — role="alert" so a failed sync is announced. -->
|
||||
<div class="kb-banner is-error" id="sync-error-banner" role="alert" hidden>
|
||||
<svg aria-hidden="true" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><path d="M12 3.6 22.2 20.4H1.8Z"/><path d="M12 9.5v4.6"/><path d="M12 17.4h.01"/></svg>
|
||||
<span id="sync-error-text"></span>
|
||||
</div>
|
||||
|
||||
<!-- Phase 16: anonymous sign-in gate. The catalog is what the
|
||||
login locks — the document viewer itself stays public (soft
|
||||
rule), so the copy says what stays open. -->
|
||||
<section class="sources-gate" id="sources-gate" aria-labelledby="sources-gate-title" hidden>
|
||||
<div class="sources-gate-glyph" aria-hidden="true">
|
||||
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="1.6" stroke-linecap="round" stroke-linejoin="round"><rect x="4" y="10" width="16" height="10" rx="2"/><path d="M8 10V7a4 4 0 0 1 8 0v3"/><circle cx="12" cy="14.5" r="1.4" fill="currentColor" stroke="none"/><path d="M12 16v2"/></svg>
|
||||
</div>
|
||||
<h2 id="sources-gate-title">Sign in to view the full catalog</h2>
|
||||
<p class="sources-gate-sub">
|
||||
The complete list of indexed documents is admin-only. Chat — and
|
||||
any document an answer cites — stays open to everyone.
|
||||
</p>
|
||||
<a class="sources-gate-link" href="/login.html?next=/sources.html">Sign in</a>
|
||||
</section>
|
||||
|
||||
<div class="stat-cards" id="stat-cards">
|
||||
<div class="stat-card" role="group" aria-label="Document statistics">
|
||||
<span class="stat-value" id="stat-docs">–</span>
|
||||
<span class="stat-label">documents</span>
|
||||
</div>
|
||||
<div class="stat-card" role="group" aria-label="Chunk statistics">
|
||||
<span class="stat-value" id="stat-chunks">–</span>
|
||||
<span class="stat-label">chunks</span>
|
||||
</div>
|
||||
<div class="stat-card" role="group" aria-label="Last indexed">
|
||||
<span class="stat-value stat-value-sm" id="stat-last">–</span>
|
||||
<span class="stat-label">last indexed</span>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<div class="table-wrap" role="region" aria-label="Indexed documents" tabindex="0">
|
||||
<table class="docs-table" id="docs-table">
|
||||
<caption class="visually-hidden">Indexed markdown documents</caption>
|
||||
<thead>
|
||||
<tr>
|
||||
<th scope="col">Source</th>
|
||||
<th scope="col">Path</th>
|
||||
<th scope="col">Title</th>
|
||||
<th scope="col">Chunks</th>
|
||||
<th scope="col">Indexed</th>
|
||||
</tr>
|
||||
</thead>
|
||||
<tbody id="docs-tbody"></tbody>
|
||||
</table>
|
||||
</div>
|
||||
|
||||
<div class="empty-state" id="sources-empty" hidden>
|
||||
<div class="empty-state-glyph" aria-hidden="true">
|
||||
<svg viewBox="0 0 48 48" fill="none" stroke="currentColor" stroke-width="2.4" stroke-linecap="round" stroke-linejoin="round"><path d="M6 12a4 4 0 0 1 4-4h10l4 5h14a4 4 0 0 1 4 4v17a4 4 0 0 1-4 4H10a4 4 0 0 1-4-4Z"/><path d="M6 20h36"/><path d="M15 28h9M15 33h14"/></svg>
|
||||
</div>
|
||||
<h2 class="empty-state-title">Nothing indexed yet</h2>
|
||||
<p class="empty-state-sub">
|
||||
Run the import to pull in the markdown docs:
|
||||
<code>uv run python -m scripts.import_docs</code>
|
||||
</p>
|
||||
</div>
|
||||
</div>
|
||||
</section>
|
||||
|
||||
<!-- Phase 76 (task 02): the Sources view (the git-sources manager
|
||||
+ archive uploads) — the content of frontend/git-sources.html's
|
||||
<main> (wrapper dropped), folded into the shell.
|
||||
/git-sources.html now serves THIS document (the shell route
|
||||
in app/main.py); the router shows this section for that
|
||||
pathname. The per-view copies of the header-owned steering
|
||||
panel + announcer are dropped (same reasoning as the RAG
|
||||
view above), and the per-page footer does not move. The
|
||||
upload-progress state machine (phase 64/65) is mounted ONCE
|
||||
(mount-once, hide-forever) and keeps running across view
|
||||
switches in this one document: its poller is a self-chaining
|
||||
setTimeout started when an upload begins — never at boot — so
|
||||
progress continues while the user is on another view, and
|
||||
nothing refetches on re-show. The hidden + inert pair is the
|
||||
WCAG contract (AGENTS.md rule 5). Mounted lazily —
|
||||
assets/router.js imports git-sources.js on first show only. -->
|
||||
<section class="view" id="view-git-sources" hidden inert aria-label="Sources" tabindex="-1">
|
||||
<div class="container git-sources-shell">
|
||||
<!-- Phase 35: anonymous sign-in gate — the EXACT #sources-gate
|
||||
pattern (phase 16) and the same .sources-gate visual
|
||||
language: the page is the same shape as Sources. Visible
|
||||
for anonymous, hidden for the admin (git-sources.js). The
|
||||
catalog of git sources is what the login locks — chat stays
|
||||
open to everyone (the soft rule). -->
|
||||
<section class="sources-gate" id="git-sources-gate" aria-labelledby="git-sources-gate-title" hidden>
|
||||
<div class="sources-gate-glyph" aria-hidden="true">
|
||||
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="1.6" stroke-linecap="round" stroke-linejoin="round"><rect x="4" y="10" width="16" height="10" rx="2"/><path d="M8 10V7a4 4 0 0 1 8 0v3"/><circle cx="12" cy="14.5" r="1.4" fill="currentColor" stroke="none"/><path d="M12 16v2"/></svg>
|
||||
</div>
|
||||
<h2 id="git-sources-gate-title">Sign in to manage the git sources</h2>
|
||||
<p class="sources-gate-sub">
|
||||
The list of repositories cloned and indexed by the sync service
|
||||
clones and indexes is admin-only. Chat — and any document an
|
||||
answer cites — stays open to everyone.
|
||||
</p>
|
||||
<a class="sources-gate-link" href="/login.html?next=/git-sources.html">Sign in</a>
|
||||
</section>
|
||||
|
||||
<!-- Phase 35: the manager — SHIPS hidden (anonymous-safe; the
|
||||
gate is what anonymous visitors see). git-sources.js
|
||||
reveals it once the cached whoami says admin, then loads
|
||||
the list. Full-width table on the 72rem frame — the
|
||||
Sources-page pattern, no skinny single-column list. -->
|
||||
<div id="git-sources-content" hidden>
|
||||
<div class="page-head">
|
||||
<h1>Git sources</h1>
|
||||
<p class="page-sub">
|
||||
The git repositories and local directories the Sync button
|
||||
imports. Add or remove them here — no <code>.env</code>, no
|
||||
restart.
|
||||
</p>
|
||||
</div>
|
||||
|
||||
<!-- Load failure (role=alert) with a retry — a GET /api/git-sources
|
||||
non-2xx or network failure must never leave a stuck page.
|
||||
git-sources.js fills #git-sources-load-error-text. -->
|
||||
<div class="git-source-load-error" id="git-sources-load-error" role="alert" hidden>
|
||||
<span id="git-sources-load-error-text"></span>
|
||||
<button type="button" id="git-sources-retry">Try again</button>
|
||||
</div>
|
||||
|
||||
<!-- Env-fallback note (phase locked decision): while the
|
||||
git_sources table is EMPTY the list above comes from
|
||||
BOR_GIT_SOURCES in .env (from_env: true) — the note says
|
||||
so, and that adding or removing here switches management
|
||||
to the database. Hidden by default; git-sources.js shows
|
||||
it off the API's from_env flag. -->
|
||||
<p class="git-source-env-note" id="git-sources-env-note" role="note" hidden>
|
||||
These sources currently come from <code>BOR_GIT_SOURCES</code> in
|
||||
<code>.env</code> — adding or removing one here switches management
|
||||
to the database.
|
||||
</p>
|
||||
|
||||
<!-- Add form: visible label + mono URL input + brand button
|
||||
(dark ink on brand 5.2:1). §7.4 never-stale: the button
|
||||
disables + relabels "Adding…" while the POST is in flight
|
||||
and re-enables on success AND failure (the input is kept
|
||||
on failure, same as the tuning forms). -->
|
||||
<form id="git-source-form">
|
||||
<label for="git-source-url">Add a git source</label>
|
||||
<input
|
||||
id="git-source-url"
|
||||
name="url"
|
||||
type="text"
|
||||
maxlength="500"
|
||||
autocomplete="off"
|
||||
placeholder="https://github.com/you/your-repo.git"
|
||||
required
|
||||
>
|
||||
<button type="submit" id="git-source-add">Add source</button>
|
||||
<p class="git-source-error" id="git-source-error" role="alert" hidden></p>
|
||||
</form>
|
||||
|
||||
<!-- Phase 49 (owner permission 2026-08-28): the archive upload
|
||||
form replaces the phase-38 local-directory form — an
|
||||
uploaded .tar/.tar.gz/.tgz/.zip is unpacked under
|
||||
BOR_UPLOAD_DIR and scanned; the same filename replaces the
|
||||
source in place (no new folder, no duplicate row). The file
|
||||
control is labeled (visible <label for=…> — WCAG
|
||||
input-label rule); the button runs the §7.4 never-stale
|
||||
lifecycle ("Uploading…" while the POST is out). Phase 64
|
||||
(task 05) reworks the rest to the 202 contract (the
|
||||
phase-49 synchronous 200 paragraph is superseded): the 202
|
||||
arrives the moment the archive is safely on disk (A1) — a
|
||||
JS-created "Successfully uploaded — <file>" toast fires
|
||||
then (A2 — the phase-55 .toast node, no markup here; safe
|
||||
to navigate away) and the button settles into the live
|
||||
"Processing… <file> (n/m)" label (A4 — the full path rides
|
||||
the button title) driven by the 2 s poll of
|
||||
GET /api/git-sources/upload/status, until the success line
|
||||
(role=status) or the sanitized error banner (role=alert)
|
||||
lands; 409 re-attaches to the in-flight run — no error
|
||||
banner; the other non-2xx still show the server detail
|
||||
inline. -->
|
||||
<form id="archive-upload-form">
|
||||
<label for="archive-upload-file">Upload a source archive (.tar, .tar.gz, .tgz, .zip)</label>
|
||||
<input id="archive-upload-file" name="file" type="file"
|
||||
accept=".tar,.tar.gz,.tgz,.zip" required>
|
||||
<button type="submit" id="archive-upload-btn">Upload & scan</button>
|
||||
<p class="git-source-error" id="archive-upload-error" role="alert" hidden></p>
|
||||
<p class="git-source-result" id="archive-upload-result" role="status"
|
||||
aria-live="polite" hidden></p>
|
||||
</form>
|
||||
|
||||
<div class="table-wrap" id="git-sources-table-wrap" role="region" aria-label="Sources" tabindex="0">
|
||||
<table class="git-sources-table" id="git-sources-table">
|
||||
<caption class="visually-hidden">Sources the Sync button imports — git repositories it clones, local directories it walks, and uploaded archives (unpacked under the upload directory)</caption>
|
||||
<thead>
|
||||
<tr>
|
||||
<th scope="col">Source</th>
|
||||
<th scope="col">Added</th>
|
||||
<th scope="col">Actions</th>
|
||||
</tr>
|
||||
</thead>
|
||||
<tbody id="git-sources-tbody"></tbody>
|
||||
</table>
|
||||
</div>
|
||||
|
||||
<!-- Empty state — no stored rows AND no env fallback. With
|
||||
from_env, the env note above already explains where the
|
||||
active list comes from. -->
|
||||
<p class="git-sources-empty" id="git-sources-empty" hidden>No sources stored yet.</p>
|
||||
|
||||
<!-- Phase 69 (owner request 2026-09-02): removal is a TOTAL
|
||||
removal — the row, the source's indexed documents, and —
|
||||
for git clones and uploaded archives — the files on the
|
||||
server's disk, all immediately (the confirmation modal
|
||||
below spells it out; foreign local directories are never
|
||||
touched). Adding still does not clone — the Sync button
|
||||
mirrors the remaining sources (upstream file churn is
|
||||
pruned on that run); the phase-49 upload is the
|
||||
in-place exception (it unpacks and scans, and a
|
||||
same-name re-upload replaces the source in place). -->
|
||||
<p class="git-source-hint" id="git-sources-hint" role="note">
|
||||
Removing a source is a total removal, done immediately: its
|
||||
entry, its indexed documents, and — for git clones and
|
||||
uploaded archives — its files on the server's disk (the
|
||||
confirmation modal spells out exactly what will be deleted;
|
||||
files in your own local directories are never touched).
|
||||
Uploads unpack and scan immediately — re-uploading the same
|
||||
filename replaces that source in place (no new folder, no
|
||||
duplicate row). The Sync button still mirrors the remaining
|
||||
sources (files removed upstream are pruned on that run).
|
||||
</p>
|
||||
|
||||
<!-- Phase 69 (owner request 2026-09-02): the remove
|
||||
confirmation — a real in-app alertdialog (the native
|
||||
confirm() retired): a row's Remove button opens it
|
||||
(git-sources.js).
|
||||
It names the source (#remove-confirm-source — ALWAYS
|
||||
populated via textContent: URLs may embed user:pass@
|
||||
credentials, the phase-32 masking discipline) and states
|
||||
the full-removal policy. Focus lands on Cancel (the safe
|
||||
default for a destructive action); Escape, the Cancel
|
||||
button, and the dim backdrop all close as cancel (no
|
||||
request — focus returns to the row's Remove button); only
|
||||
"Remove source" sends the DELETE, in the §7.4 "Removing…"
|
||||
in-flight state. The .doc-modal overlay contract: a fixed
|
||||
full-viewport dim backdrop + a centered panel (no blur).
|
||||
Static markup so the E2E suite gets stable selectors (the
|
||||
#git-sources-hint / gate convention). -->
|
||||
<div class="remove-confirm" id="remove-confirm-dialog" role="alertdialog"
|
||||
aria-modal="true" aria-labelledby="remove-confirm-title"
|
||||
aria-describedby="remove-confirm-copy" hidden>
|
||||
<div class="remove-confirm-backdrop" aria-hidden="true"></div>
|
||||
<div class="remove-confirm-panel">
|
||||
<h2 class="remove-confirm-title" id="remove-confirm-title">Remove this source?</h2>
|
||||
<code class="remove-confirm-source" id="remove-confirm-source"></code>
|
||||
<p class="remove-confirm-copy" id="remove-confirm-copy">
|
||||
This permanently removes the source entry, all of its
|
||||
indexed documents from the knowledge base, and — for git
|
||||
clones and uploaded archives — the files on the server's
|
||||
disk. Files in your own local directories are never
|
||||
touched. This cannot be undone.
|
||||
</p>
|
||||
<p class="remove-confirm-error" id="remove-confirm-error" role="alert" hidden></p>
|
||||
<div class="remove-confirm-actions">
|
||||
<button type="button" class="remove-confirm-btn remove-confirm-cancel"
|
||||
id="remove-confirm-cancel">Cancel</button>
|
||||
<button type="button" class="remove-confirm-btn remove-confirm-remove"
|
||||
id="remove-confirm-remove">Remove source</button>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
<!-- Polite live region: the screen-reader confirmation for list
|
||||
loads, adds, and removals (git-sources.js owns the text). -->
|
||||
<p class="visually-hidden" id="git-sources-announcer" role="status" aria-live="polite"></p>
|
||||
</div>
|
||||
</section>
|
||||
|
||||
<!-- Phase 76 (task 03): the History view (saved chats) — the
|
||||
content of frontend/history.html's <main> (wrapper dropped),
|
||||
folded into the shell. /history.html now serves THIS document
|
||||
(the shell route in app/main.py); the router shows this
|
||||
section for that pathname. The per-view copies of the
|
||||
header-owned steering panel + announcer are dropped (the
|
||||
shell's ONE panel — the chat one, inside #view-chat — is the
|
||||
instance header.js drives), and the page's footer is dropped
|
||||
too (the history page's #app-version span would DUPLICATE the
|
||||
shell's single (chat) footer). The row actions stay REAL
|
||||
navigations: the Open link (?chat=<id>) and the copy-link
|
||||
field are plain anchor/document-load targets — opening a
|
||||
saved chat is a chat-view concern handled by app.js at boot
|
||||
via ?chat= (out of scope for the router). The hidden + inert
|
||||
pair is the WCAG contract: a hidden view must not receive
|
||||
focus or keyboard traversal (AGENTS.md rule 5). Mounted
|
||||
lazily — assets/router.js imports history.js on first show
|
||||
only (mount-once, hide-forever). -->
|
||||
<section class="view" id="view-history" hidden inert aria-label="History" tabindex="-1">
|
||||
<div class="container history-shell">
|
||||
<div class="page-head">
|
||||
<h1>Saved chats</h1>
|
||||
<p class="page-sub">
|
||||
Every conversation is saved automatically — newest activity first. Click a title to return to that chat.
|
||||
</p>
|
||||
</div>
|
||||
<!-- Phase 50 (owner permission 2026-08-29): anonymous sign-in
|
||||
gate — the EXACT #sources-gate pattern (phase 16) and the
|
||||
same .sources-gate visual language (phase 35, git-sources):
|
||||
the saved-chat list is what the login locks. Visible for
|
||||
anonymous, hidden for the admin (history.js) — and the
|
||||
view never fetches /api/chats for an anonymous visitor
|
||||
(the router 403s them; the story E2E pins the request
|
||||
log). -->
|
||||
<section class="sources-gate" id="history-gate" aria-labelledby="history-gate-title" hidden>
|
||||
<div class="sources-gate-glyph" aria-hidden="true">
|
||||
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="1.6" stroke-linecap="round" stroke-linejoin="round"><rect x="4" y="10" width="16" height="10" rx="2"/><path d="M8 10V7a4 4 0 0 1 8 0v3"/><circle cx="12" cy="14.5" r="1.4" fill="currentColor" stroke="none"/><path d="M12 16v2"/></svg>
|
||||
</div>
|
||||
<h2 id="history-gate-title">Sign in to view your saved chats</h2>
|
||||
<p class="sources-gate-sub">
|
||||
Saved conversations are admin-only. Chat — and any document an
|
||||
answer cites — stays open to everyone.
|
||||
</p>
|
||||
<a class="sources-gate-link" href="/login.html?next=/history.html">Sign in</a>
|
||||
</section>
|
||||
|
||||
<!-- Live-region feedback for row actions (the "never stale"
|
||||
contract): history.js sets textContent here — a delete's
|
||||
outcome, its error line, nothing else. -->
|
||||
<span class="history-status" id="history-status" role="status" aria-live="polite"></span>
|
||||
|
||||
<!-- Phase 50: the full-width table (AGENTS.md rule 5 — no skinny
|
||||
list): Title (the Open link → /?chat=<id>) | Messages |
|
||||
Updated | Stale (phase 53: the READ-ONLY staleness marker —
|
||||
the rose pill when the row predates the last KB-changing
|
||||
sync; the Regenerate action lives on the chat-page banner,
|
||||
task 05) | Share (phase 51: Create link / Copy / Unshare —
|
||||
the row's share_url comes from GET /api/chats itself, no
|
||||
second fetch) | Actions (Delete, inline two-step confirm).
|
||||
history.js fills #history-tbody; #history-empty-row ships
|
||||
hidden and is revealed by a 0-row fetch. The Actions column
|
||||
header is visually-hidden — the row buttons carry their own
|
||||
aria-labels. -->
|
||||
<div class="table-wrap history-table-wrap" id="history-table-wrap" role="region" aria-label="Saved chats" tabindex="0">
|
||||
<table class="history-table">
|
||||
<caption class="visually-hidden">Saved chats — click a title to return to that conversation</caption>
|
||||
<thead>
|
||||
<tr>
|
||||
<th scope="col">Title</th>
|
||||
<th scope="col">Messages</th>
|
||||
<th scope="col">Updated</th>
|
||||
<th scope="col">Stale</th>
|
||||
<th scope="col">Share</th>
|
||||
<th scope="col"><span class="visually-hidden">Actions</span></th>
|
||||
</tr>
|
||||
</thead>
|
||||
<tbody id="history-tbody">
|
||||
<tr class="history-empty-row" id="history-empty-row" hidden>
|
||||
<td colspan="6">No saved chats yet — start a conversation and it will be saved automatically.</td>
|
||||
</tr>
|
||||
</tbody>
|
||||
</table>
|
||||
</div>
|
||||
</div>
|
||||
</section>
|
||||
|
||||
</main>
|
||||
|
||||
<footer class="app-footer">
|
||||
@@ -279,6 +753,12 @@
|
||||
own `import "./header.js"` — a hoisted import that is evaluated
|
||||
before the page script body calls initSharedHeader() at boot. -->
|
||||
<script type="module" src="/assets/app.js"></script>
|
||||
<!-- Phase 76 (task 01): the shell router — AFTER app.js (boot order:
|
||||
brand.js classic → app.js module → router.js module). It reads
|
||||
location.pathname, shows the matching view, and lazy-imports the
|
||||
non-chat view modules on first show only (mount-once). The chat
|
||||
view needs no module import: app.js already ran at shell boot. -->
|
||||
<script type="module" src="/assets/router.js"></script>
|
||||
|
||||
<!-- Phase 26: the almost-fullscreen document modal. Source chips and
|
||||
Sources-table path links open documents here (same-page overlay,
|
||||
|
||||
Reference in New Issue
Block a user