phase: 84_docs_push_error_sanitization

Browse Source

**Phase 84 — final verification pass: all green, no defects found**

- Verified implementation: `app/core/errors.py` (verbatim lift of sync masker), `app/api/sync.py` alias import, docs-push 502 `detail=sanitize_error(str(exc))`, all five `llm.py` error sites sanitized; new/extended test pins in place
- Tests: `uv run pytest` → **1714 passed, 0 failed**; targeted pins (new unit ×2 + integration ×1, existing 502 pin) → 13 passed; sync/git-sources regression → 67 passed
- Coverage: `uv run pytest --cov=app --cov-report=term-missing` → **99%** (`app/core/errors.py` 100%, `app/rag/llm.py` 100%) — >90% met
- E2E isolation: `uv run pytest tests/e2e/test_smoke.py -v --no-cov` → **3 passed**
- Lint/types: `uv run ruff check .` → clean; `uv run pyright` → **0 errors**
- Criteria: 502 masks `*****@`/never token + row untouched ✅; LLM base-URL masked, credential-free strings byte-identical ✅; `_CREDS_RE` only in `app/core/errors.py` (working-tree grep) ✅; full gate green ✅; `git diff --stat` limited to the 4 app files + 2 modified test files + 3 phase task files (untracked: new module, new unit test, complete/ dir, reports, audit plan) ✅
- Commit/phase move left to the harness per instructions (task files already in `complete/`)
- No deviations; nothing to fix
- Next pending phase: **85_mobile_menu_gate_overlap**

...

This commit is contained in:

ducoterra

2026-09-08 01:11:45 -04:00

parent fa189dede7

commit f4150421bb

23 changed files with 732 additions and 29 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

.agents/phases/todo/84_docs_push_error_sanitization/00_phase.md → .agents/phases/complete/84_docs_push_error_sanitization/00_phase.md

.agents/phases/todo/84_docs_push_error_sanitization/01_shared_sanitizer.md → .agents/phases/complete/84_docs_push_error_sanitization/01_shared_sanitizer.md

.agents/phases/todo/84_docs_push_error_sanitization/02_apply_docs_push_and_llm.md → .agents/phases/complete/84_docs_push_error_sanitization/02_apply_docs_push_and_llm.md

.agents/phases/todo/84_docs_push_error_sanitization/03_verify_and_commit.md → .agents/phases/complete/84_docs_push_error_sanitization/03_verify_and_commit.md