Experimental/brain-of-reese
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(web): history tab copy — every chat saves automatically, there is no Save button
Build and Push Containers / build-and-push-app (push) Successful in 1m35s
Details
Build and Push Containers / build-and-push-db (push) Successful in 10s
Details

Browse Source 
meta description -> locked (A3) auto-save string (history.html L6).
page-sub -> locked (A3) string, the <strong>Save</strong> emphasis retired with the button (L106-109).
empty row -> locked (A3) string; colspan=6, hidden, and row id untouched (L163).
h1, the anonymous gate section, and history.js are byte-identical — state language verified accurate.
This commit is contained in:
ducoterra
2026-09-02 01:29:42 -04:00
parent 8a1f99cb38
commit f04ddbe1f8
16 changed files with 461 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.agent/reports/65_bottom_chat_actions/65_bottom_chat_actions__00_phase.a1.err
View File
.agent/reports/65_bottom_chat_actions/65_bottom_chat_actions__00_phase.a1.md
+11
View File
@@ -0,0 +1,11 @@
All verification is green. Final state check complete — no code changes were needed; this pass was pure verification.
**Phase 65 — final verification pass (all tasks 01–05 already complete in `complete/`; commit `8a1f99c` landed)**
- Verified implementation in code: `.chat-bottom` is the last child of `.chat-shell` wrapping `.chat-actions` (New chat → Share, ids/aria-labels intact) + `#composer`; `.chat-bottom` is `position: sticky; bottom: env(safe-area-inset-bottom, 0)` with no z-index (A1); `justify-content: flex-end` right-edge alignment (A2); ≤640px full-width vertical stack; `#composer` sticky declaration retained
- Dedicated suite: `uv run pytest tests/e2e/test_bottom_chat_actions.py -v --no-cov` → 4 passed (pin across sticky range, resting bottom, settled above footer, A2 + DOM order, mobile stack, 360px overflow, 44px targets, New chat/Share click-through)
- Regression E2E, each in isolation: pinned_composer 4 ✓, save_share_ux 5 ✓, chat_persistence 4 ✓, share_chat 4 ✓, chat_history 5 ✓, smoke 3 ✓
- Full gate: `.agent/validate.sh` exit 0 — `uv run pytest --cov=app` 1251 unit+integration tests passed, coverage TOTAL 99% (>90%); `uv run ruff check .` clean; `uv run pyright` 0 errors
- Criteria 1–7: all met (see above). Criterion 8: single `--no-gpg-sign` commit `8a1f99c` exists staging exactly `.agent/ frontend/ tests/` (no gpgsig; `commit.gpgsign=false`); the `00_phase.md` move to `complete/` is the harness pipeline step — left in `todo/` per instructions
**Deviations / notes:** No defects found, zero code edits. `.agent/PLAN.md` is absent from the repo (referenced by AGENTS.md; pre-existing — the phase overview/task files served as the binding spec). Worktree carries only uncommitted `.agent/` bookkeeping (task-05 file move + reports) managed by the harness. Next pending phase: `66_history_auto_save_copy`.
.agent/reports/65_bottom_chat_actions/65_bottom_chat_actions__00_phase.a1.validate
+72
View File
@@ -0,0 +1,72 @@
........................................................................ [ 5%]
........................................................................ [ 11%]
........................................................................ [ 17%]
........................................................................ [ 23%]
........................................................................ [ 28%]
........................................................................ [ 34%]
........................................................................ [ 40%]
........................................................................ [ 46%]
........................................................................ [ 51%]
........................................................................ [ 57%]
........................................................................ [ 63%]
........................................................................ [ 69%]
........................................................................ [ 74%]
........................................................................ [ 80%]
........................................................................ [ 86%]
........................................................................ [ 92%]
........................................................................ [ 97%]
........................... [100%]
=============================== warnings summary ===============================
.venv/lib/python3.13/site-packages/fastapi/testclient.py:1
/var/home/ducoterra/Projects/Personal/brain_of_reese/.venv/lib/python3.13/site-packages/fastapi/testclient.py:1: StarletteDeprecationWarning: Using `httpx` with `starlette.testclient` is deprecated; install `httpx2` instead.
from starlette.testclient import TestClient as TestClient # noqa
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================ tests coverage ================================
_______________ coverage: platform linux, python 3.13.13-final-0 _______________
Name Stmts Miss Cover
-----------------------------------------------
app/__init__.py 1 0 100%
app/api/__init__.py 0 0 100%
app/api/auth.py 22 0 100%
app/api/chat.py 131 0 100%
app/api/chats.py 110 0 100%
app/api/config.py 7 0 100%
app/api/doc_drafts.py 93 0 100%
app/api/docs.py 50 0 100%
app/api/git_sources.py 181 0 100%
app/api/health.py 10 0 100%
app/api/steering.py 42 0 100%
app/api/suggestions.py 8 0 100%
app/api/sync.py 101 0 100%
app/config.py 112 0 100%
app/core/__init__.py 0 0 100%
app/core/auth.py 20 0 100%
app/core/caching.py 108 0 100%
app/core/debugging.py 29 2 93%
app/core/docs_push.py 39 0 100%
app/core/logging.py 13 0 100%
app/db.py 21 0 100%
app/main.py 52 0 100%
app/models.py 86 0 100%
app/rag/__init__.py 0 0 100%
app/rag/agent.py 78 0 100%
app/rag/archive_upload.py 128 0 100%
app/rag/chunker.py 206 4 98%
app/rag/git_sources.py 14 0 100%
app/rag/importer.py 180 3 98%
app/rag/llm.py 189 0 100%
app/rag/overview.py 71 0 100%
app/rag/prompts.py 65 0 100%
app/rag/retriever.py 94 3 97%
app/rag/sources_meta.py 16 0 100%
app/rag/suggestions.py 27 0 100%
app/rag/summarizer.py 24 0 100%
app/schemas.py 201 0 100%
-----------------------------------------------
TOTAL 2529 12 99%
coverage gate: app/ 99% (>90%) OK
All checks passed!
0 errors, 0 warnings, 0 informations
validation OK
.agent/reports/65_bottom_chat_actions/65_bottom_chat_actions__05_regressions_and_commit.a1.md
+16
View File
@@ -0,0 +1,16 @@
Task 05 complete — all green.
**Report — Phase 65, Task 05 (regressions + commit)**
- Regression E2E matrix, each green in isolation (DB up, in task order):
- `uv run pytest tests/e2e/test_pinned_composer.py -v --no-cov` → 4 passed
- `uv run pytest tests/e2e/test_save_share_ux.py -v --no-cov` → 5 passed
- `uv run pytest tests/e2e/test_chat_persistence.py -v --no-cov` → 4 passed
- `uv run pytest tests/e2e/test_share_chat.py -v --no-cov` → 4 passed
- `uv run pytest tests/e2e/test_chat_history.py -v --no-cov` → 5 passed
- `uv run pytest tests/e2e/test_smoke.py -v --no-cov` → 3 passed
- Dedicated suite final run: `uv run pytest tests/e2e/test_bottom_chat_actions.py -v --no-cov` → 4 passed
- Full gate: `bash .agent/validate.sh` → exit 0 (unit+integration pass, app/ coverage **99%** >90%, `ruff check .` clean, `pyright` 0 errors)
- One atomic commit on `main`: `8a1f99c` `feat(web): move the chat action cluster to the pinned bottom and align the button sets` — `--no-gpg-sign`, staged exactly `.agent/ frontend/ tests/`, body has one line per task (01 move, 02 sticky `.chat-bottom` A1, 03 right-edge alignment A2, 04 dedicated suite, 05 regression outcome)
- No defects found in prior tasks' work — tasks 01–04 changes committed as-is; working tree clean
- Phase-dir move to `complete/` is the pipeline step (harness) per task rules — not done by me
- Next pending task: `.agent/phases/todo/66_history_auto_save_copy/01_history_page_copy.md`
.agent/reports/65_bottom_chat_actions/65_bottom_chat_actions__05_regressions_and_commit.a1.validate
+72
View File
@@ -0,0 +1,72 @@
........................................................................ [ 5%]
........................................................................ [ 11%]
........................................................................ [ 17%]
........................................................................ [ 23%]
........................................................................ [ 28%]
........................................................................ [ 34%]
........................................................................ [ 40%]
........................................................................ [ 46%]
........................................................................ [ 51%]
........................................................................ [ 57%]
........................................................................ [ 63%]
........................................................................ [ 69%]
........................................................................ [ 74%]
........................................................................ [ 80%]
........................................................................ [ 86%]
........................................................................ [ 92%]
........................................................................ [ 97%]
........................... [100%]
=============================== warnings summary ===============================
.venv/lib/python3.13/site-packages/fastapi/testclient.py:1
/var/home/ducoterra/Projects/Personal/brain_of_reese/.venv/lib/python3.13/site-packages/fastapi/testclient.py:1: StarletteDeprecationWarning: Using `httpx` with `starlette.testclient` is deprecated; install `httpx2` instead.
from starlette.testclient import TestClient as TestClient # noqa
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================ tests coverage ================================
_______________ coverage: platform linux, python 3.13.13-final-0 _______________
Name Stmts Miss Cover
-----------------------------------------------
app/__init__.py 1 0 100%
app/api/__init__.py 0 0 100%
app/api/auth.py 22 0 100%
app/api/chat.py 131 0 100%
app/api/chats.py 110 0 100%
app/api/config.py 7 0 100%
app/api/doc_drafts.py 93 0 100%
app/api/docs.py 50 0 100%
app/api/git_sources.py 181 0 100%
app/api/health.py 10 0 100%
app/api/steering.py 42 0 100%
app/api/suggestions.py 8 0 100%
app/api/sync.py 101 0 100%
app/config.py 112 0 100%
app/core/__init__.py 0 0 100%
app/core/auth.py 20 0 100%
app/core/caching.py 108 0 100%
app/core/debugging.py 29 2 93%
app/core/docs_push.py 39 0 100%
app/core/logging.py 13 0 100%
app/db.py 21 0 100%
app/main.py 52 0 100%
app/models.py 86 0 100%
app/rag/__init__.py 0 0 100%
app/rag/agent.py 78 0 100%
app/rag/archive_upload.py 128 0 100%
app/rag/chunker.py 206 4 98%
app/rag/git_sources.py 14 0 100%
app/rag/importer.py 180 3 98%
app/rag/llm.py 189 0 100%
app/rag/overview.py 71 0 100%
app/rag/prompts.py 65 0 100%
app/rag/retriever.py 94 3 97%
app/rag/sources_meta.py 16 0 100%
app/rag/suggestions.py 27 0 100%
app/rag/summarizer.py 24 0 100%
app/schemas.py 201 0 100%
-----------------------------------------------
TOTAL 2529 12 99%
coverage gate: app/ 99% (>90%) OK
All checks passed!
0 errors, 0 warnings, 0 informations
validation OK