phase: 150_drop_sync_result
**Phase 150 final verification pass — complete, 100% green.** All 6 task files were already in `complete/`, so this was verification + doc pass. - Verified: `#sync-progress` is the sole sync text surface + sole `aria-live` region (`role="status"`, polite, no `aria-hidden`); `span#sync-result` gone from HTML/JS/CSS/tests (incl. runtime-built `RETIRED_ID` absence pins in the unit suites); `setSyncProgress` single writer with text-driven visibility; running-only box write in `setSyncLabel`; all 9 settle/cancel sites routed; `requestCancel` pre-fetch clear is a NO-OP. - Tests: `uv run pytest` → **3463 passed**; `uv run pytest --cov=app` → **99% on app/** (>90%); `uv run ruff check .` + `uv run pyright` → clean (0 errors); `tests/e2e/test_sync_progress_box.py --no-cov` → **8 passed in isolation**; all 18 migrated sync/image-PDF E2E files green in isolation (77 tests). - Completion criteria: 1) grep clean ✅ 2) sole live region, attrs correct ✅ 3) in-flight/settle/cancel/idle box states proven by E2E + unit pins ✅ 4) icon-only running button + restore ✅ 5) full gates green ✅ 6) no completed-phase behavior change (18 family suites + full suite green) ✅ 7) commit — left to harness per pass instructions (working tree untouched, no `git add`/`commit`). - Documentation: README.md fixed 2 pre-existing inconsistencies (stale `~/Homelab`+`~/Deployments` source model in the intro — retired in phase 61 — now describes the git/local/archive Sources model; "Requires AIPI_KEY" in retrieval-quality now states `BOR_LLM_API_KEY` in `.env` or `$AIPI_KEY`, matching the scripts' real convention). Everything else (URL table, env defaults vs `app/config.py`, sync/phase-150 copy, prod claims) verified accurate. AGENTS.md: verified consistent — no changes needed. - Notable: no code changes were required — the phase implementation was correct as left; no live infrastructure touched. - Next pending phase: `151_pdf_image_extraction` in `.agents/phases/todo/`.
This commit is contained in:
@@ -513,8 +513,9 @@ def test_add_with_branch_syncs_that_branch(
|
||||
body = sync_and_wait(page, app_url)
|
||||
assert body["state"] == "success", body
|
||||
expect(page.locator("#sync-label")).to_have_text(SYNCED_LABEL, timeout=15_000)
|
||||
# Both branch docs are fresh after the per-test truncate.
|
||||
expect(page.locator("#sync-result")).to_have_text("2 added")
|
||||
# Both branch docs are fresh after the per-test truncate — the
|
||||
# counts line rides the box (phase 150).
|
||||
expect(page.locator("#sync-progress-text")).to_have_text("2 added")
|
||||
|
||||
# --- the branch's content is what got indexed ----------------------
|
||||
expect(catalog_has_doc(page, FIXTURE_NAME, "release-only.md")).to_have_count(1)
|
||||
@@ -537,8 +538,8 @@ def test_add_with_branch_syncs_that_branch(
|
||||
assert body["state"] == "success", body
|
||||
expect(page.locator("#sync-label")).to_have_text(SYNCED_LABEL, timeout=15_000)
|
||||
# Nothing re-embeds (sha256 delta) — the no-op run announces the
|
||||
# unchanged count (release's two files).
|
||||
expect(page.locator("#sync-result")).to_have_text("0 added · 2 unchanged")
|
||||
# unchanged count (release's two files) on the box (phase 150).
|
||||
expect(page.locator("#sync-progress-text")).to_have_text("0 added · 2 unchanged")
|
||||
# The branch's doc survived the prune re-import.
|
||||
expect(catalog_has_doc(page, FIXTURE_NAME, "release-only.md")).to_have_count(1)
|
||||
|
||||
@@ -574,7 +575,9 @@ def test_default_branch_source_unaffected(
|
||||
body = sync_and_wait(page, app_url)
|
||||
assert body["state"] == "success", body
|
||||
expect(page.locator("#sync-label")).to_have_text(SYNCED_LABEL, timeout=15_000)
|
||||
expect(page.locator("#sync-result")).to_have_text("2 added")
|
||||
# The default branch's two docs are fresh — the counts line rides
|
||||
# the box (phase 150).
|
||||
expect(page.locator("#sync-progress-text")).to_have_text("2 added")
|
||||
|
||||
# The default branch (main) is what landed — the pre-phase
|
||||
# byte-identical guarantee, observable through the UI…
|
||||
@@ -679,8 +682,9 @@ def test_row_editor_branch_change_fails_loud(
|
||||
assert body["state"] == "success", body
|
||||
expect(page.locator("#sync-label")).to_have_text(SYNCED_LABEL, timeout=15_000)
|
||||
# The KB is still empty (the failed sync aborted before the
|
||||
# import) — the restored branch's two docs are fresh additions.
|
||||
expect(page.locator("#sync-result")).to_have_text("2 added")
|
||||
# import) — the restored branch's two docs are fresh additions;
|
||||
# the counts line rides the box (phase 150).
|
||||
expect(page.locator("#sync-progress-text")).to_have_text("2 added")
|
||||
# And the branch's doc is what is indexed again.
|
||||
expect(catalog_has_doc(page, FIXTURE_NAME, "release-only.md")).to_have_count(1)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user