phase: 92_theme_save_and_coverage

**Phase 92 final verification pass — all green.** This pass re-verified the completed tasks (all 5 task files already in `complete/`) against every completion criterion; no defects found, nothing to fix. - Verified: 9th identity var `grid_line` end-to-end (migration `0015` at head, model/`theming.py`/schemas/API, 422 + built-in→NULL tests present); `styles.css` zero hardcoded literals outside `:root` + derived `--brand-*` vars; 9th picker in theme form; wordmark themed; `theme.js` save/reset/re-show/mount live-sync; dedicated E2E suite + phase-91 suite updated. - `uv run pytest --cov=app --cov-report=term-missing` → **1845 passed, exit 0, TOTAL 99%** (>90%) - `uv run ruff check .` → clean; `uv run pyright` → 0 errors, 0 warnings - `uv run pytest tests/e2e/test_theme_save_and_coverage.py -v --no-cov` → **3 passed** (save-live, reset-live, whole-site) - `uv run pytest tests/e2e/test_admin_theme_tab.py -v --no-cov` → **5 passed** - Criteria: (1) Save/Reset repaint open page, no nav, SPA-nav survives, pre-paint intact ✅; (2) both `rg` gates green (only `:root` + documented `#fff` Stop label; zero SVG hex attrs), grid/selection/hovers/wash/wordmark E2E-proven ✅; (3) no-op contract live-checked: row-less `/` = no tag + exact A1 CSP, grid-only row = 9-var tag in `COLOR_FIELDS` order + sha256 CSP, with-row ≡ row-less bytes ✅; (4) full suite/coverage/lint/both E2E ✅; (5) commit left to the harness per instructions. - Deviations (previously made, probe-verified, kept): live repaint uses CSSOM `<html>` overrides because Chromium blocks `<style>` textContent mutations under the locked sha256-only CSP (tag text still mirrors the next load; `<html>` style exact-saved after Save, empty after Reset); wordmark themed via 3 `.brand-mark` CSS rules instead of inline styles (task 03's inline attrs were CSP-blocked — fixed during task 04). - Next pending phase: none — `todo/` contains only `92_theme_save_and_coverage`.
2026-09-10 00:23:08 -04:00
parent d22d260b8b
commit df91c6316c
49 changed files with 2282 additions and 189 deletions
@@ -759,7 +759,7 @@ def test_history_refresh_button_css_reuses_the_new_chat_language() -> None:
    assert "color: var(--bg)" in body, "--bg text on --brand (5.2:1, AA)"
    assert "min-height: 44px" in body, "the comfortable touch target"
    assert "border-radius: 999px" in body and "border: 0" in body, "the pill"
-    assert ".history-refresh:hover { background: #f55a72; color: var(--bg); }" in css
+    assert ".history-refresh:hover { background: var(--brand-hover); color: var(--bg); }" in css
    assert ".history-refresh:disabled { opacity: 0.6; cursor: wait; }" in css, (
        "the in-flight disabled state is dimmed (the house language)"
    )
@@ -902,8 +902,8 @@ def test_theme_view_scaffold_in_the_shell() -> None:
    the ship-hidden #theme-content (the #git-sources-content pattern)
    holding the STATIC form skeleton: the page-head (h1 "Theme"), the
    #theme-form with the 3 labeled branding text inputs (maxlength=300
-    — the server re-validates) + the 8 labeled type=color palette inputs
-    (the 8 identity variables, in the theming.COLOR_FIELDS order), the
+    — the server re-validates) + the 9 labeled type=color palette inputs
+    (the 9 identity variables, in the theming.COLOR_FIELDS order), the
    #theme-save (primary) + #theme-reset (secondary) — BOTH type="button"
    (no real submit), and the three task-05 feedback lines: #theme-error
    (role=alert), #theme-result (role=status), #theme-contrast
@@ -941,7 +941,7 @@ def test_theme_view_scaffold_in_the_shell() -> None:
    )
    # The static form skeleton (the E2E-stable-selectors house
    # convention): the 3 labeled branding text inputs (maxlength=300)
-    # and the 8 labeled type=color palette inputs (the 8 identity
+    # and the 9 labeled type=color palette inputs (the 9 identity
    # variables — one per theming.COLOR_FIELDS field).
    assert re.search(r'<form[^>]*id="theme-form"[^>]*>', body), (
        "the #theme-form must be STATIC markup in the shell"
@@ -959,6 +959,7 @@ def test_theme_view_scaffold_in_the_shell() -> None:
        "theme-ink",
        "theme-ink-soft",
        "theme-line",
+        "theme-grid-line",
        "theme-brand",
        "theme-brand-soft",
        "theme-brand-ink",