phase: 92_theme_save_and_coverage

**Phase 92 final verification pass — all green.** This pass re-verified the completed tasks (all 5 task files already in `complete/`) against every completion criterion; no defects found, nothing to fix. - Verified: 9th identity var `grid_line` end-to-end (migration `0015` at head, model/`theming.py`/schemas/API, 422 + built-in→NULL tests present); `styles.css` zero hardcoded literals outside `:root` + derived `--brand-*` vars; 9th picker in theme form; wordmark themed; `theme.js` save/reset/re-show/mount live-sync; dedicated E2E suite + phase-91 suite updated. - `uv run pytest --cov=app --cov-report=term-missing` → **1845 passed, exit 0, TOTAL 99%** (>90%) - `uv run ruff check .` → clean; `uv run pyright` → 0 errors, 0 warnings - `uv run pytest tests/e2e/test_theme_save_and_coverage.py -v --no-cov` → **3 passed** (save-live, reset-live, whole-site) - `uv run pytest tests/e2e/test_admin_theme_tab.py -v --no-cov` → **5 passed** - Criteria: (1) Save/Reset repaint open page, no nav, SPA-nav survives, pre-paint intact ✅; (2) both `rg` gates green (only `:root` + documented `#fff` Stop label; zero SVG hex attrs), grid/selection/hovers/wash/wordmark E2E-proven ✅; (3) no-op contract live-checked: row-less `/` = no tag + exact A1 CSP, grid-only row = 9-var tag in `COLOR_FIELDS` order + sha256 CSP, with-row ≡ row-less bytes ✅; (4) full suite/coverage/lint/both E2E ✅; (5) commit left to the harness per instructions. - Deviations (previously made, probe-verified, kept): live repaint uses CSSOM `<html>` overrides because Chromium blocks `<style>` textContent mutations under the locked sha256-only CSP (tag text still mirrors the next load; `<html>` style exact-saved after Save, empty after Reset); wordmark themed via 3 `.brand-mark` CSS rules instead of inline styles (task 03's inline attrs were CSP-blocked — fixed during task 04). - Next pending phase: none — `todo/` contains only `92_theme_save_and_coverage`.
2026-09-10 00:23:08 -04:00
parent d22d260b8b
commit df91c6316c
49 changed files with 2282 additions and 189 deletions
@@ -97,15 +97,19 @@ def test_reduced_motion_calm_not_removed() -> None:
 def test_busy_button_style_tokens() -> None:
    """Phase 48 (revised contract, owner-locked 2026-08-29): in flight
    the button is the enabled Stop control — "Stop" label, .is-stop
-    class (rose treatment, 6.3:1 with the #fff label), spinner hidden;
-    idle/error keep the brand Send button (dark ink on brand 5.2:1).
+    class (--brand-stop treatment — the brand darkened toward --bg,
+    5.8:1 with the white label at the built-in default, phase 92),
+    spinner hidden; idle/error keep the brand Send button
+    (dark ink on brand 5.2:1).
    The spinner element stays in the markup + CSS (16px dark arc — the
    reduced-motion pin below) but the state machine never shows it: the
    Stop label + treatment carry the in-flight state."""
    css = _css()
    js = _js()
    assert ".send-btn.is-stop" in css
-    assert "#be123c" in css, "the stop background: rose-700 (6.3:1 with #fff)"
+    assert "background: var(--brand-stop)" in css, (
+        "the stop background: the brand darkened toward --bg (5.8:1 with the white label)"
+    )
    assert ".send-btn.is-stop:hover" in css, "the darker hover step"
    assert re.search(r"\.spinner \{[^}]*width: 16px", css)
    assert 'sendLabel.textContent = inFlight ? "Stop" : "Send"' in js