phase: 92_theme_save_and_coverage
**Phase 92 final verification pass — all green.** This pass re-verified the completed tasks (all 5 task files already in `complete/`) against every completion criterion; no defects found, nothing to fix. - Verified: 9th identity var `grid_line` end-to-end (migration `0015` at head, model/`theming.py`/schemas/API, 422 + built-in→NULL tests present); `styles.css` zero hardcoded literals outside `:root` + derived `--brand-*` vars; 9th picker in theme form; wordmark themed; `theme.js` save/reset/re-show/mount live-sync; dedicated E2E suite + phase-91 suite updated. - `uv run pytest --cov=app --cov-report=term-missing` → **1845 passed, exit 0, TOTAL 99%** (>90%) - `uv run ruff check .` → clean; `uv run pyright` → 0 errors, 0 warnings - `uv run pytest tests/e2e/test_theme_save_and_coverage.py -v --no-cov` → **3 passed** (save-live, reset-live, whole-site) - `uv run pytest tests/e2e/test_admin_theme_tab.py -v --no-cov` → **5 passed** - Criteria: (1) Save/Reset repaint open page, no nav, SPA-nav survives, pre-paint intact ✅; (2) both `rg` gates green (only `:root` + documented `#fff` Stop label; zero SVG hex attrs), grid/selection/hovers/wash/wordmark E2E-proven ✅; (3) no-op contract live-checked: row-less `/` = no tag + exact A1 CSP, grid-only row = 9-var tag in `COLOR_FIELDS` order + sha256 CSP, with-row ≡ row-less bytes ✅; (4) full suite/coverage/lint/both E2E ✅; (5) commit left to the harness per instructions. - Deviations (previously made, probe-verified, kept): live repaint uses CSSOM `<html>` overrides because Chromium blocks `<style>` textContent mutations under the locked sha256-only CSP (tag text still mirrors the next load; `<html>` style exact-saved after Save, empty after Reset); wordmark themed via 3 `.brand-mark` CSS rules instead of inline styles (task 03's inline attrs were CSP-blocked — fixed during task 04). - Next pending phase: none — `todo/` contains only `92_theme_save_and_coverage`.
This commit is contained in:
+10
-7
@@ -9,12 +9,12 @@ deleted the env var, the example-stylesheet directory, and the link
|
||||
insertion, and the admin Theme tab is now the only theming surface.
|
||||
The contract that directory's authoring guide carried is re-homed here
|
||||
(built-in table, the five contrast pairs, the never-white-on-brand
|
||||
trap — see below), and the 8 variables + built-in values are the
|
||||
trap — see below), and the 9 variables + built-in values are the
|
||||
authoritative table (the unit drift test parses
|
||||
``frontend/assets/styles.css``'s ``:root`` and asserts equality, so
|
||||
the two can never silently diverge).
|
||||
|
||||
The **8 identity variables** (bare names, README order) and their
|
||||
The **9 identity variables** (bare names, README order) and their
|
||||
built-in values (from ``frontend/assets/styles.css`` ``:root``):
|
||||
|
||||
=================== ========== =================================================
|
||||
@@ -25,6 +25,8 @@ Variable Built-in Role
|
||||
``ink`` ``#f0e6e6`` primary text
|
||||
``ink_soft`` ``#b8a8a8`` secondary text (5.1:1 on ``surface``)
|
||||
``line`` ``#2d1a1a`` decorative 1px borders (no contrast duty)
|
||||
``grid_line`` ``#4a2626`` background grid texture — decorative,
|
||||
no contrast duty, like ``line``
|
||||
``brand`` ``#f43f5e`` brand accent — buttons, links (text ON
|
||||
it is the DARK ``bg`` ink)
|
||||
``brand_soft`` ``#2d0a0a`` brand-tinted surface (chips, hover washes)
|
||||
@@ -66,7 +68,7 @@ from sqlalchemy.orm import Session
|
||||
from app.config import Settings, get_settings
|
||||
from app.models import UiSettings
|
||||
|
||||
#: The 8 built-in identity colors, keyed by BARE variable name (no ``--``)
|
||||
#: The 9 built-in identity colors, keyed by BARE variable name (no ``--``)
|
||||
#: in the themes-README order. Copied from ``frontend/assets/styles.css``
|
||||
#: ``:root`` — the unit drift test (``tests/unit/test_theming.py``)
|
||||
#: re-parses the stylesheet and asserts equality on every run.
|
||||
@@ -76,12 +78,13 @@ BUILTIN_COLORS: dict[str, str] = {
|
||||
"ink": "#f0e6e6",
|
||||
"ink_soft": "#b8a8a8",
|
||||
"line": "#2d1a1a",
|
||||
"grid_line": "#4a2626", # the background grid texture (phase 92)
|
||||
"brand": "#f43f5e",
|
||||
"brand_soft": "#2d0a0a",
|
||||
"brand_ink": "#fca5a5",
|
||||
}
|
||||
|
||||
#: The 8 color field names in the README's order (dicts preserve
|
||||
#: The 9 color field names in the README's order (dicts preserve
|
||||
#: insertion order) — used by the resolver, the API, and the
|
||||
#: ``theme_style_tag`` renderer (task 02).
|
||||
COLOR_FIELDS: tuple[str, ...] = tuple(BUILTIN_COLORS)
|
||||
@@ -102,7 +105,7 @@ def effective_settings(
|
||||
* **strings** (``app_name`` / ``input_placeholder`` / ``footer_text``)
|
||||
— the DB value when it is a non-empty string, else the env value
|
||||
(``settings.app_name`` etc. — B1: the env vars stay the fallback);
|
||||
* **colors** (the 8 :data:`COLOR_FIELDS`) — the DB value when not
|
||||
* **colors** (the 9 :data:`COLOR_FIELDS`) — the DB value when not
|
||||
``None``, else :data:`BUILTIN_COLORS` (B1: no env fallback for
|
||||
colors — the built-in palette IS the default).
|
||||
|
||||
@@ -110,7 +113,7 @@ def effective_settings(
|
||||
strings + the built-in palette. The ``settings`` parameter names the
|
||||
env-fallback source explicitly (the routes pass their
|
||||
dependency-injected instance so test overrides apply); ``None`` uses
|
||||
the cached :func:`app.config.get_settings`. Returns all 11 keys.
|
||||
the cached :func:`app.config.get_settings`. Returns all 12 keys.
|
||||
"""
|
||||
if settings is None:
|
||||
settings = get_settings()
|
||||
@@ -131,7 +134,7 @@ def theme_style_tag(colors: dict[str, str]) -> str:
|
||||
``""`` when every color equals its built-in — the byte-identical
|
||||
contract: an unset (or "defaults saved") deployment must serve
|
||||
exactly the pre-phase-91 HTML, no ``<style>`` tag anywhere.
|
||||
Otherwise one ``<style id="bor-theme">`` tag with ALL 8 variables in
|
||||
Otherwise one ``<style id="bor-theme">`` tag with ALL 9 variables in
|
||||
:data:`COLOR_FIELDS` order (the non-overridden ones repeat their
|
||||
built-in value — the tag is a complete ``:root`` override, so the
|
||||
page never mixes partial palettes)::
|
||||
|
||||
Reference in New Issue
Block a user