phase: 92_theme_save_and_coverage

**Phase 92 final verification pass — all green.** This pass re-verified the completed tasks (all 5 task files already in `complete/`) against every completion criterion; no defects found, nothing to fix. - Verified: 9th identity var `grid_line` end-to-end (migration `0015` at head, model/`theming.py`/schemas/API, 422 + built-in→NULL tests present); `styles.css` zero hardcoded literals outside `:root` + derived `--brand-*` vars; 9th picker in theme form; wordmark themed; `theme.js` save/reset/re-show/mount live-sync; dedicated E2E suite + phase-91 suite updated. - `uv run pytest --cov=app --cov-report=term-missing` → **1845 passed, exit 0, TOTAL 99%** (>90%) - `uv run ruff check .` → clean; `uv run pyright` → 0 errors, 0 warnings - `uv run pytest tests/e2e/test_theme_save_and_coverage.py -v --no-cov` → **3 passed** (save-live, reset-live, whole-site) - `uv run pytest tests/e2e/test_admin_theme_tab.py -v --no-cov` → **5 passed** - Criteria: (1) Save/Reset repaint open page, no nav, SPA-nav survives, pre-paint intact ✅; (2) both `rg` gates green (only `:root` + documented `#fff` Stop label; zero SVG hex attrs), grid/selection/hovers/wash/wordmark E2E-proven ✅; (3) no-op contract live-checked: row-less `/` = no tag + exact A1 CSP, grid-only row = 9-var tag in `COLOR_FIELDS` order + sha256 CSP, with-row ≡ row-less bytes ✅; (4) full suite/coverage/lint/both E2E ✅; (5) commit left to the harness per instructions. - Deviations (previously made, probe-verified, kept): live repaint uses CSSOM `<html>` overrides because Chromium blocks `<style>` textContent mutations under the locked sha256-only CSP (tag text still mirrors the next load; `<html>` style exact-saved after Save, empty after Reset); wordmark themed via 3 `.brand-mark` CSS rules instead of inline styles (task 03's inline attrs were CSP-blocked — fixed during task 04). - Next pending phase: none — `todo/` contains only `92_theme_save_and_coverage`.
2026-09-10 00:23:08 -04:00
parent d22d260b8b
commit df91c6316c
49 changed files with 2282 additions and 189 deletions
@@ -0,0 +1,39 @@
+"""ui_settings: the 9th identity color — grid_line (phase 92, task 01)
+
+Revision ID: 0015
+Revises: 0014
+Create Date: 2026-09-09
+
+Phase 92 (the theme controls drive the ENTIRE site — the owner's
+defect report: "the background grid never changes color"): the
+background grid texture becomes the 9th tab-controlled IDENTITY
+variable, so it flows through the resolver, the pre-paint tag, the
+CSP hash, and the admin API exactly like the existing 8 (all of those
+are ``COLOR_FIELDS``-driven — zero logic changes):
+
+* ``ui_settings.grid_line`` — VARCHAR(7) NULL ``#rrggbb`` (NULL = the
+  built-in ``#4a2626`` — today's hardcoded grid color, exact). ONE
+  additive, fully reversible column on the single-row table (A13).
+"""
+from __future__ import annotations
+
+import sqlalchemy as sa
+
+from alembic import op
+
+revision = "0015"
+down_revision = "0014"
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    op.add_column(
+        "ui_settings", sa.Column("grid_line", sa.String(length=7), nullable=True)
+    )
+
+
+def downgrade() -> None:
+    # Safe order: the column is the only 0015 artefact — dropping it
+    # leaves 0014's schema byte-identical (A13, fully reversible).
+    op.drop_column("ui_settings", "grid_line")