Experimental/brain-of-reese
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

phase: 135_git_source_branch
Build and Push Containers / build-and-push-app (push) Successful in 2m34s
Details
Build and Push Containers / build-and-push-db (push) Successful in 14s
Details

Browse Source 
All verification complete. No edits were needed by this pass — the phase work and docs were already consistent and green.

**Phase 135 final verification pass — report**

- Verified all 5 tasks' work present & correct: migration 0024 (reversible), `GitSource.branch` + 4 schema shapes, `validate_branch_name` (full check order per design), `clone_or_pull(…, branch)` (HEAD guard first, `--branch` clone, fetch+ff merge), both call sites pass `row.branch`, UI (add-form field, editor field, row tag), `file://` URL transport.
- Completion criteria: (1) branch-mirrored through Sync + CLI — **pass** (E2E + integration); (2) `branch=None` byte-identical — **pass** (`test_branch_none_argv_is_byte_identical_pre_phase_sequence` green); (3) fixed 422s / local-row 422 / tri-state — **pass**; (4) mismatch fails loudly with remove-and-re-add — **pass** (E2E); (5) coverage 99% >90%, E2E isolated green — **pass**; (6) no regressions — **pass**.
- Tests: `uv run pytest --cov=app --cov-report=term-missing` → 3223 passed, app/ 99%; `uv run pytest tests/e2e/test_git_source_branch.py -v --no-cov` → 4 passed (16.4 s); `uv run ruff check .` clean; `uv run pyright` → 0 errors, 0 warnings.
- Documentation: README.md reviewed in full — phase-135 branch section accurate; the phase's README diff also correctly fixed a pre-existing stale line (shallow `--depth 1` clone vs full-history, phase 107). Routes, env defaults, feature lists verified against code. AGENTS.md — all 10 rules + quick-reference verified (referenced tests, PLAN.md, phases dirs, commands all accurate). **Verified consistent — no changes needed.**
- No live-infrastructure changes (dev DB already running and healthy; no live steps in this phase).
- Next pending phase: `.agents/phases/todo/136_force_push_reset`.
This commit is contained in:
ducoterra
2026-09-28 21:15:03 -04:00
parent fcac876d40
commit d3f8c7f2c8
50 changed files with 3955 additions and 140 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.agents/reports/135_git_source_branch/135_git_source_branch__00_phase.a1.err
View File
.agents/reports/135_git_source_branch/135_git_source_branch__00_phase.a1.md
+10
View File
@@ -0,0 +1,10 @@
All verification complete. No edits were needed by this pass — the phase work and docs were already consistent and green.
**Phase 135 final verification pass — report**
- Verified all 5 tasks' work present & correct: migration 0024 (reversible), `GitSource.branch` + 4 schema shapes, `validate_branch_name` (full check order per design), `clone_or_pull(…, branch)` (HEAD guard first, `--branch` clone, fetch+ff merge), both call sites pass `row.branch`, UI (add-form field, editor field, row tag), `file://` URL transport.
- Completion criteria: (1) branch-mirrored through Sync + CLI — **pass** (E2E + integration); (2) `branch=None` byte-identical — **pass** (`test_branch_none_argv_is_byte_identical_pre_phase_sequence` green); (3) fixed 422s / local-row 422 / tri-state — **pass**; (4) mismatch fails loudly with remove-and-re-add — **pass** (E2E); (5) coverage 99% >90%, E2E isolated green — **pass**; (6) no regressions — **pass**.
- Tests: `uv run pytest --cov=app --cov-report=term-missing` → 3223 passed, app/ 99%; `uv run pytest tests/e2e/test_git_source_branch.py -v --no-cov` → 4 passed (16.4 s); `uv run ruff check .` clean; `uv run pyright` → 0 errors, 0 warnings.
- Documentation: README.md reviewed in full — phase-135 branch section accurate; the phase's README diff also correctly fixed a pre-existing stale line (shallow `--depth 1` clone vs full-history, phase 107). Routes, env defaults, feature lists verified against code. AGENTS.md — all 10 rules + quick-reference verified (referenced tests, PLAN.md, phases dirs, commands all accurate). **Verified consistent — no changes needed.**
- No live-infrastructure changes (dev DB already running and healthy; no live steps in this phase).
- Next pending phase: `.agents/phases/todo/136_force_push_reset`.
.agents/reports/135_git_source_branch/135_git_source_branch__00_phase.a1.validate
+116
View File
@@ -0,0 +1,116 @@
........................................................................ [ 2%]
........................................................................ [ 4%]
........................................................................ [ 6%]
........................................................................ [ 8%]
........................................................................ [ 11%]
........................................................................ [ 13%]
........................................................................ [ 15%]
........................................................................ [ 17%]
........................................................................ [ 20%]
........................................................................ [ 22%]
........................................................................ [ 24%]
........................................................................ [ 26%]
........................................................................ [ 29%]
........................................................................ [ 31%]
........................................................................ [ 33%]
........................................................................ [ 35%]
........................................................................ [ 37%]
........................................................................ [ 40%]
........................................................................ [ 42%]
........................................................................ [ 44%]
........................................................................ [ 46%]
........................................................................ [ 49%]
........................................................................ [ 51%]
........................................................................ [ 53%]
........................................................................ [ 55%]
........................................................................ [ 58%]
........................................................................ [ 60%]
........................................................................ [ 62%]
........................................................................ [ 64%]
........................................................................ [ 67%]
........................................................................ [ 69%]
........................................................................ [ 71%]
........................................................................ [ 73%]
........................................................................ [ 75%]
........................................................................ [ 78%]
........................................................................ [ 80%]
........................................................................ [ 82%]
........................................................................ [ 84%]
........................................................................ [ 87%]
........................................................................ [ 89%]
........................................................................ [ 91%]
........................................................................ [ 93%]
........................................................................ [ 96%]
........................................................................ [ 98%]
....................................................... [100%]
=============================== warnings summary ===============================
.venv/lib/python3.13/site-packages/fastapi/testclient.py:1
/var/home/ducoterra/Projects/Personal/brain_of_reese/.venv/lib/python3.13/site-packages/fastapi/testclient.py:1: StarletteDeprecationWarning: Using `httpx` with `starlette.testclient` is deprecated; install `httpx2` instead.
from starlette.testclient import TestClient as TestClient # noqa
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================ tests coverage ================================
_______________ coverage: platform linux, python 3.13.13-final-0 _______________
Name Stmts Miss Cover
--------------------------------------------------
app/__init__.py 1 0 100%
app/api/__init__.py 0 0 100%
app/api/auth.py 52 0 100%
app/api/chat.py 268 1 99%
app/api/chat_images.py 50 0 100%
app/api/chats.py 110 0 100%
app/api/config.py 13 0 100%
app/api/doc_drafts.py 99 0 100%
app/api/docs.py 179 1 99%
app/api/git_sources.py 259 0 100%
app/api/health.py 10 0 100%
app/api/steering.py 42 0 100%
app/api/suggestions.py 33 0 100%
app/api/sync.py 183 0 100%
app/api/tokens.py 40 0 100%
app/api/ui_settings.py 55 0 100%
app/config.py 256 0 100%
app/core/__init__.py 0 0 100%
app/core/auth.py 45 0 100%
app/core/caching.py 124 0 100%
app/core/debugging.py 29 2 93%
app/core/docs_push.py 39 0 100%
app/core/errors.py 5 0 100%
app/core/logging.py 13 0 100%
app/core/rate_limit.py 44 0 100%
app/core/security_headers.py 20 0 100%
app/core/theming.py 38 0 100%
app/core/tokens.py 44 0 100%
app/db.py 22 0 100%
app/main.py 68 0 100%
app/models.py 133 0 100%
app/rag/__init__.py 0 0 100%
app/rag/agent.py 412 1 99%
app/rag/archive_upload.py 134 0 100%
app/rag/chunker.py 220 4 98%
app/rag/doc_dates.py 18 0 100%
app/rag/folder_summaries.py 134 0 100%
app/rag/git_sources.py 56 0 100%
app/rag/importer.py 595 9 98%
app/rag/llm.py 246 1 99%
app/rag/md_images.py 63 0 100%
app/rag/overview.py 71 0 100%
app/rag/pdf.py 109 0 100%
app/rag/prompts.py 144 0 100%
app/rag/retriever.py 248 3 99%
app/rag/scaffolding.py 55 0 100%
app/rag/source_removal.py 41 0 100%
app/rag/sources_meta.py 16 0 100%
app/rag/suggestions.py 27 0 100%
app/rag/summarizer.py 49 0 100%
app/schemas.py 422 0 100%
--------------------------------------------------
TOTAL 5334 22 99%
coverage gate: app/ 99% (>90%) OK
All checks passed!
0 errors, 0 warnings, 0 informations
WARNING: there is a new pyright version available (v1.1.411 -> v1.1.414).
Please install the new version or set PYRIGHT_PYTHON_FORCE_VERSION to `latest`
validation OK
.agents/reports/135_git_source_branch/135_git_source_branch__01_branch_column.a1.err
View File
.agents/reports/135_git_source_branch/135_git_source_branch__01_branch_column.a1.md
+21
View File
@@ -0,0 +1,21 @@
Task 01 complete — all gates green. Report:
**Implemented**
- `alembic/versions/0024_git_source_branch.py`: reversible migration adding `git_sources.branch` (TEXT NULL, no default; NULL = repo's default branch) — `add_column`/`drop_column`, follows the 0021 pattern
- `app/models.py::GitSource.branch: Mapped[str | None] = mapped_column(Text, nullable=True)` with the phase-135 docstring
- `app/schemas.py`: `branch` on all four shapes — `GitSourceIn` (optional, max 200, `_trim_branch` before the length constraint; docstring documents the create-absent vs PATCH-clear split), `GitSourceOut`/`GitSourceRow` (explicit `str | None`, `extra="forbid"` kept; env rows report `None`), `GitSourcePatchIn` (tri-state documented, token precedent)
- `app/api/git_sources.py`: `branch` passed through at the four shape-construction sites (GET DB/env rows, POST 201, PATCH 200) + GET docstring — POST/PATCH storage/validation deliberately left to task 02 per its spec
- `tests/integration/test_migration_0024.py` (new, 0021 pattern): upgrade adds the column with the full contract, ALL pre-0024 rows (with/without token) backfill NULL, ORM round-trip, downgrade drops, round-trip restores
- Defect fix: `test_migration_0023.py` stale head pin ("land at head (0023)") now pins the 0022→0023 step explicitly (house 0021 pattern); exact-shape pins in `test_git_sources_api.py` (7 tests) and `test_git_source_token.py` kwargs updated for the new reported field
**Results**
- `uv run alembic upgrade head && downgrade -1 && upgrade head` → 0023→0024→0023→0024, dev DB at `0024 (head)`
- `uv run pytest tests/integration/test_migration_0024.py -v --no-cov` → 4 passed
- `uv run pytest --cov=app --cov-report=term-missing` → **3154 passed, 0 failed**, `app/` coverage **99%** (>90%)
- `uv run ruff check . && uv run pyright` → clean (0 errors/warnings)
**Docs**: no README/AGENTS.md changes — column/schema storage is not user-visible yet (API/UI land in tasks 02–04; README documents feature-level behavior, unchanged today).
**Decisions**: kept POST/PATCH branch *storage* out of scope — task 02's file explicitly owns `_create_git_row`/`_create_local_row`/`patch_git_source` wiring; this task makes the shapes accept/report and the DB persist. The two uncovered `_trim_branch` bodies are exercised by task 02's API tests.
**Next pending task**: `.agents/phases/todo/135_git_source_branch/02_branch_api.md`
.agents/reports/135_git_source_branch/135_git_source_branch__01_branch_column.a1.validate
+115
View File
@@ -0,0 +1,115 @@
........................................................................ [ 2%]
........................................................................ [ 4%]
........................................................................ [ 6%]
........................................................................ [ 9%]
........................................................................ [ 11%]
........................................................................ [ 13%]
........................................................................ [ 15%]
........................................................................ [ 18%]
........................................................................ [ 20%]
........................................................................ [ 22%]
........................................................................ [ 25%]
........................................................................ [ 27%]
........................................................................ [ 29%]
........................................................................ [ 31%]
........................................................................ [ 34%]
........................................................................ [ 36%]
........................................................................ [ 38%]
........................................................................ [ 41%]
........................................................................ [ 43%]
........................................................................ [ 45%]
........................................................................ [ 47%]
........................................................................ [ 50%]
........................................................................ [ 52%]
........................................................................ [ 54%]
........................................................................ [ 57%]
........................................................................ [ 59%]
........................................................................ [ 61%]
........................................................................ [ 63%]
........................................................................ [ 66%]
........................................................................ [ 68%]
........................................................................ [ 70%]
........................................................................ [ 73%]
........................................................................ [ 75%]
........................................................................ [ 77%]
........................................................................ [ 79%]
........................................................................ [ 82%]
........................................................................ [ 84%]
........................................................................ [ 86%]
........................................................................ [ 89%]
........................................................................ [ 91%]
........................................................................ [ 93%]
........................................................................ [ 95%]
........................................................................ [ 98%]
.......................................................... [100%]
=============================== warnings summary ===============================
.venv/lib/python3.13/site-packages/fastapi/testclient.py:1
/var/home/ducoterra/Projects/Personal/brain_of_reese/.venv/lib/python3.13/site-packages/fastapi/testclient.py:1: StarletteDeprecationWarning: Using `httpx` with `starlette.testclient` is deprecated; install `httpx2` instead.
from starlette.testclient import TestClient as TestClient # noqa
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================ tests coverage ================================
_______________ coverage: platform linux, python 3.13.13-final-0 _______________
Name Stmts Miss Cover
--------------------------------------------------
app/__init__.py 1 0 100%
app/api/__init__.py 0 0 100%
app/api/auth.py 52 0 100%
app/api/chat.py 268 1 99%
app/api/chat_images.py 50 0 100%
app/api/chats.py 110 0 100%
app/api/config.py 13 0 100%
app/api/doc_drafts.py 99 0 100%
app/api/docs.py 179 1 99%
app/api/git_sources.py 241 0 100%
app/api/health.py 10 0 100%
app/api/steering.py 42 0 100%
app/api/suggestions.py 33 0 100%
app/api/sync.py 183 0 100%
app/api/tokens.py 40 0 100%
app/api/ui_settings.py 55 0 100%
app/config.py 256 0 100%
app/core/__init__.py 0 0 100%
app/core/auth.py 45 0 100%
app/core/caching.py 124 0 100%
app/core/debugging.py 29 2 93%
app/core/docs_push.py 39 0 100%
app/core/errors.py 5 0 100%
app/core/logging.py 13 0 100%
app/core/rate_limit.py 44 0 100%
app/core/security_headers.py 20 0 100%
app/core/theming.py 38 0 100%
app/core/tokens.py 44 0 100%
app/db.py 22 0 100%
app/main.py 68 0 100%
app/models.py 133 0 100%
app/rag/__init__.py 0 0 100%
app/rag/agent.py 412 1 99%
app/rag/archive_upload.py 134 0 100%
app/rag/chunker.py 220 4 98%
app/rag/doc_dates.py 18 0 100%
app/rag/folder_summaries.py 134 0 100%
app/rag/git_sources.py 38 0 100%
app/rag/importer.py 595 9 98%
app/rag/llm.py 246 1 99%
app/rag/md_images.py 63 0 100%
app/rag/overview.py 71 0 100%
app/rag/pdf.py 109 0 100%
app/rag/prompts.py 144 0 100%
app/rag/retriever.py 248 3 99%
app/rag/scaffolding.py 55 0 100%
app/rag/source_removal.py 41 0 100%
app/rag/sources_meta.py 16 0 100%
app/rag/suggestions.py 27 0 100%
app/rag/summarizer.py 49 0 100%
app/schemas.py 422 2 99%
--------------------------------------------------
TOTAL 5298 24 99%
coverage gate: app/ 99% (>90%) OK
All checks passed!
0 errors, 0 warnings, 0 informations
WARNING: there is a new pyright version available (v1.1.411 -> v1.1.414).
Please install the new version or set PYRIGHT_PYTHON_FORCE_VERSION to `latest`
validation OK
.agents/reports/135_git_source_branch/135_git_source_branch__02_branch_api.a1.err
View File
.agents/reports/135_git_source_branch/135_git_source_branch__02_branch_api.a1.md
+17
View File
@@ -0,0 +1,17 @@
Everything is green. Final report:
**Implemented (task 02 — branch API wiring):**
- `validate_branch_name` in `app/rag/git_sources.py` (pure, next to `normalize_credential`; check order: trim → empty → 200-char → charset `[A-Za-z0-9._/-]+` → `..`/`//` → leading `-`/`.`/`/` → trailing `/`/`.` → HEAD ci; all `ValueError` reasons fixed strings, input never echoed)
- `app/api/git_sources.py`: POST git rows validate + store the branch (URL → credential → duplicate → branch order; absent/empty → NULL); POST local + PATCH-on-local → 422 `branch is only valid for git sources`; PATCH branch tri-state identical to the token (absent = keep, non-empty = validated set, `""` = clear); invalid name → fixed 422 `not a valid branch name` (exact, no input echo); module + route docstrings gained the branch clauses
- `tests/unit/test_git_sources_branch.py` (new, 33 tests: full accept/reject matrix, boundaries, input-free reasons)
- `tests/integration/test_git_sources_api.py` (+7 tests: create/store/report, trim, empty→NULL, invalid 422s, oversized, local 422s, full tri-state round-trip, local-PATCH 422, no-half-apply); env-row `branch: null` already pinned by task 01's tests
- README: documented branch pinning; fixed stale phase-107 doc drift ("shallow `--depth 1`" → full-history clone + one-time `--unshallow` self-heal). AGENTS.md: no doc impact
**Verification (all 100% green):**
- `uv run pytest tests/unit/test_git_sources_branch.py tests/integration/test_git_sources_api.py` → 96 passed
- `uv run pytest --cov=app --cov-report=term-missing` (full suite, final code) → exit 0, no failures; `app/` coverage **99%** (`app/api/git_sources.py` 100%, `app/rag/git_sources.py` 100%)
- `uv run ruff check . && uv run pyright` → clean (0 errors)
**Notes:** oversized-branch 422 is FastAPI's standard schema 422 (same house precedent as oversized URLs); API-layer branch 422s are the fixed-detail ones.
**Next pending task:** `.agents/phases/todo/135_git_source_branch/03_clone_pull_branch.md`
.agents/reports/135_git_source_branch/135_git_source_branch__02_branch_api.a1.validate
+116
View File
@@ -0,0 +1,116 @@
........................................................................ [ 2%]
........................................................................ [ 4%]
........................................................................ [ 6%]
........................................................................ [ 9%]
........................................................................ [ 11%]
........................................................................ [ 13%]
........................................................................ [ 15%]
........................................................................ [ 18%]
........................................................................ [ 20%]
........................................................................ [ 22%]
........................................................................ [ 24%]
........................................................................ [ 27%]
........................................................................ [ 29%]
........................................................................ [ 31%]
........................................................................ [ 33%]
........................................................................ [ 36%]
........................................................................ [ 38%]
........................................................................ [ 40%]
........................................................................ [ 42%]
........................................................................ [ 45%]
........................................................................ [ 47%]
........................................................................ [ 49%]
........................................................................ [ 51%]
........................................................................ [ 54%]
........................................................................ [ 56%]
........................................................................ [ 58%]
........................................................................ [ 60%]
........................................................................ [ 63%]
........................................................................ [ 65%]
........................................................................ [ 67%]
........................................................................ [ 69%]
........................................................................ [ 72%]
........................................................................ [ 74%]
........................................................................ [ 76%]
........................................................................ [ 78%]
........................................................................ [ 81%]
........................................................................ [ 83%]
........................................................................ [ 85%]
........................................................................ [ 87%]
........................................................................ [ 90%]
........................................................................ [ 92%]
........................................................................ [ 94%]
........................................................................ [ 96%]
........................................................................ [ 99%]
............................ [100%]
=============================== warnings summary ===============================
.venv/lib/python3.13/site-packages/fastapi/testclient.py:1
/var/home/ducoterra/Projects/Personal/brain_of_reese/.venv/lib/python3.13/site-packages/fastapi/testclient.py:1: StarletteDeprecationWarning: Using `httpx` with `starlette.testclient` is deprecated; install `httpx2` instead.
from starlette.testclient import TestClient as TestClient # noqa
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================ tests coverage ================================
_______________ coverage: platform linux, python 3.13.13-final-0 _______________
Name Stmts Miss Cover
--------------------------------------------------
app/__init__.py 1 0 100%
app/api/__init__.py 0 0 100%
app/api/auth.py 52 0 100%
app/api/chat.py 268 1 99%
app/api/chat_images.py 50 0 100%
app/api/chats.py 110 0 100%
app/api/config.py 13 0 100%
app/api/doc_drafts.py 99 0 100%
app/api/docs.py 179 1 99%
app/api/git_sources.py 259 0 100%
app/api/health.py 10 0 100%
app/api/steering.py 42 0 100%
app/api/suggestions.py 33 0 100%
app/api/sync.py 183 0 100%
app/api/tokens.py 40 0 100%
app/api/ui_settings.py 55 0 100%
app/config.py 256 0 100%
app/core/__init__.py 0 0 100%
app/core/auth.py 45 0 100%
app/core/caching.py 124 0 100%
app/core/debugging.py 29 2 93%
app/core/docs_push.py 39 0 100%
app/core/errors.py 5 0 100%
app/core/logging.py 13 0 100%
app/core/rate_limit.py 44 0 100%
app/core/security_headers.py 20 0 100%
app/core/theming.py 38 0 100%
app/core/tokens.py 44 0 100%
app/db.py 22 0 100%
app/main.py 68 0 100%
app/models.py 133 0 100%
app/rag/__init__.py 0 0 100%
app/rag/agent.py 412 1 99%
app/rag/archive_upload.py 134 0 100%
app/rag/chunker.py 220 4 98%
app/rag/doc_dates.py 18 0 100%
app/rag/folder_summaries.py 134 0 100%
app/rag/git_sources.py 56 0 100%
app/rag/importer.py 595 9 98%
app/rag/llm.py 246 1 99%
app/rag/md_images.py 63 0 100%
app/rag/overview.py 71 0 100%
app/rag/pdf.py 109 0 100%
app/rag/prompts.py 144 0 100%
app/rag/retriever.py 248 3 99%
app/rag/scaffolding.py 55 0 100%
app/rag/source_removal.py 41 0 100%
app/rag/sources_meta.py 16 0 100%
app/rag/suggestions.py 27 0 100%
app/rag/summarizer.py 49 0 100%
app/schemas.py 422 0 100%
--------------------------------------------------
TOTAL 5334 22 99%
coverage gate: app/ 99% (>90%) OK
All checks passed!
0 errors, 0 warnings, 0 informations
WARNING: there is a new pyright version available (v1.1.411 -> v1.1.414).
Please install the new version or set PYRIGHT_PYTHON_FORCE_VERSION to `latest`
validation OK
.agents/reports/135_git_source_branch/135_git_source_branch__03_clone_pull_branch.a1.err
View File
.agents/reports/135_git_source_branch/135_git_source_branch__03_clone_pull_branch.a1.md
+17
View File
@@ -0,0 +1,17 @@
Done. All completion criteria met:
**Implemented**
- `scripts/git_sync.py::clone_or_pull(url, dest, branch=None)`: fresh clone → `git clone --branch <b>`; existing checkout → HEAD guard (`rev-parse --abbrev-ref HEAD`, fail-loud remove-and-re-add `GitSyncError` — URL-free message, before any fetch) → unchanged shallow probe + one-time `fetch --unshallow` (now the shared `_unshallow_if_shallow` helper) → `fetch origin <b>` + `merge --ff-only FETCH_HEAD`; `branch=None` argv byte-identical (module + function docstrings updated)
- Both call sites pass `row.branch`: `app/api/sync.py::_run_sync` (Sync button) and `scripts/import_docs.py::_resolve_sources` (CLI), with phase-121-style comments + module docstrings
- Tests: unit argv matrix in `test_git_sync.py` (branch=None byte-identical pin, `--branch` clone, matching/shallow guard→probe→fetch→merge sequences, mismatch raises with both branch names + checkout path and NO fetch argv, URL-free even with token URL, fetch/merge failure propagation); real-git two-branch `file://` integration scenarios in `test_import_docs_git.py` (fresh branch checkout, ff-merge pull, mismatch leaves checkout untouched, `_resolve_sources` with `branch="release"` row imports file B, env row clones default branch) + button-path tests in `test_sync_api.py` (real `clone_or_pull` through `_run_sync`: branch row + mismatch fail-loud); updated all `clone_or_pull` fakes across 5 test files for the 3-arg signature
**Results**
- `uv run pytest --cov=app --cov-report=term-missing`: **3211 passed, 0 failed**, `app/` coverage **99%** (>90%); `scripts/git_sync.py` 100% in its test set
- `uv run pytest tests/unit/test_git_sync.py tests/integration/test_import_docs_git.py -v --no-cov`: 45 passed
- `uv run ruff check .` clean; `uv run pyright`: 0 errors
**Docs**: README already carried the phase-135 branch paragraph from tasks 01/02 (accurate as-is); AGENTS.md no doc impact.
**Decisions**: date-map assertion relaxed — `file_commit_dates` walks the reachable *log*, so a branch checkout also lists files from shared ancestor commits (harmless: the importer only consults paths it finds); left `file_commit_dates` untouched per the task.
**Next pending task**: `.agents/phases/todo/135_git_source_branch/04_branch_ui.md`
.agents/reports/135_git_source_branch/135_git_source_branch__03_clone_pull_branch.a1.validate
+116
View File
@@ -0,0 +1,116 @@
........................................................................ [ 2%]
........................................................................ [ 4%]
........................................................................ [ 6%]
........................................................................ [ 8%]
........................................................................ [ 11%]
........................................................................ [ 13%]
........................................................................ [ 15%]
........................................................................ [ 17%]
........................................................................ [ 20%]
........................................................................ [ 22%]
........................................................................ [ 24%]
........................................................................ [ 26%]
........................................................................ [ 29%]
........................................................................ [ 31%]
........................................................................ [ 33%]
........................................................................ [ 35%]
........................................................................ [ 38%]
........................................................................ [ 40%]
........................................................................ [ 42%]
........................................................................ [ 44%]
........................................................................ [ 47%]
........................................................................ [ 49%]
........................................................................ [ 51%]
........................................................................ [ 53%]
........................................................................ [ 56%]
........................................................................ [ 58%]
........................................................................ [ 60%]
........................................................................ [ 62%]
........................................................................ [ 65%]
........................................................................ [ 67%]
........................................................................ [ 69%]
........................................................................ [ 71%]
........................................................................ [ 73%]
........................................................................ [ 76%]
........................................................................ [ 78%]
........................................................................ [ 80%]
........................................................................ [ 82%]
........................................................................ [ 85%]
........................................................................ [ 87%]
........................................................................ [ 89%]
........................................................................ [ 91%]
........................................................................ [ 94%]
........................................................................ [ 96%]
........................................................................ [ 98%]
........................................... [100%]
=============================== warnings summary ===============================
.venv/lib/python3.13/site-packages/fastapi/testclient.py:1
/var/home/ducoterra/Projects/Personal/brain_of_reese/.venv/lib/python3.13/site-packages/fastapi/testclient.py:1: StarletteDeprecationWarning: Using `httpx` with `starlette.testclient` is deprecated; install `httpx2` instead.
from starlette.testclient import TestClient as TestClient # noqa
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================ tests coverage ================================
_______________ coverage: platform linux, python 3.13.13-final-0 _______________
Name Stmts Miss Cover
--------------------------------------------------
app/__init__.py 1 0 100%
app/api/__init__.py 0 0 100%
app/api/auth.py 52 0 100%
app/api/chat.py 268 1 99%
app/api/chat_images.py 50 0 100%
app/api/chats.py 110 0 100%
app/api/config.py 13 0 100%
app/api/doc_drafts.py 99 0 100%
app/api/docs.py 179 1 99%
app/api/git_sources.py 259 0 100%
app/api/health.py 10 0 100%
app/api/steering.py 42 0 100%
app/api/suggestions.py 33 0 100%
app/api/sync.py 183 0 100%
app/api/tokens.py 40 0 100%
app/api/ui_settings.py 55 0 100%
app/config.py 256 0 100%
app/core/__init__.py 0 0 100%
app/core/auth.py 45 0 100%
app/core/caching.py 124 0 100%
app/core/debugging.py 29 2 93%
app/core/docs_push.py 39 0 100%
app/core/errors.py 5 0 100%
app/core/logging.py 13 0 100%
app/core/rate_limit.py 44 0 100%
app/core/security_headers.py 20 0 100%
app/core/theming.py 38 0 100%
app/core/tokens.py 44 0 100%
app/db.py 22 0 100%
app/main.py 68 0 100%
app/models.py 133 0 100%
app/rag/__init__.py 0 0 100%
app/rag/agent.py 412 1 99%
app/rag/archive_upload.py 134 0 100%
app/rag/chunker.py 220 4 98%
app/rag/doc_dates.py 18 0 100%
app/rag/folder_summaries.py 134 0 100%
app/rag/git_sources.py 56 0 100%
app/rag/importer.py 595 9 98%
app/rag/llm.py 246 1 99%
app/rag/md_images.py 63 0 100%
app/rag/overview.py 71 0 100%
app/rag/pdf.py 109 0 100%
app/rag/prompts.py 144 0 100%
app/rag/retriever.py 248 3 99%
app/rag/scaffolding.py 55 0 100%
app/rag/source_removal.py 41 0 100%
app/rag/sources_meta.py 16 0 100%
app/rag/suggestions.py 27 0 100%
app/rag/summarizer.py 49 0 100%
app/schemas.py 422 0 100%
--------------------------------------------------
TOTAL 5334 22 99%
coverage gate: app/ 99% (>90%) OK
All checks passed!
0 errors, 0 warnings, 0 informations
WARNING: there is a new pyright version available (v1.1.411 -> v1.1.414).
Please install the new version or set PYRIGHT_PYTHON_FORCE_VERSION to `latest`
validation OK
.agents/reports/135_git_source_branch/135_git_source_branch__04_branch_ui.a1.err
View File
.agents/reports/135_git_source_branch/135_git_source_branch__04_branch_ui.a1.md
+13
View File
@@ -0,0 +1,13 @@
All gates green. Task complete.
**Report — phase 135, task 04 (branch UI)**
- **Add form** (`index.html` + `git-sources.js`): optional `#git-source-branch` (maxlength 200, autocomplete off, "optional — default: the repo's default branch" hint) between URL and Token; submit body `(url, token, branch) => ({ url, ...(branch ? {branch} : {}), ...(token ? {token} : {}) })` — blank omits the key; 201 clears all three inputs.
- **Per-row editor**: `#ignore-editor-branch` after the source line, before the ignore textarea (hint line "Leave empty for the repo's default branch."); git rows only (local rows hide label+input+hint and the body omits the key), prefilled from `s.branch ?? ""`; **tri-state asymmetry**: git rows' PATCH always includes `branch` (empty save = clear), token stays blank-keeps; existing §7.4 save lifecycle untouched.
- **Row tag**: `branch: <name>` text tag (the "hidden on" idiom, grouped CSS) for stored git rows with a branch; source-cell `title` names the branch; module docstring gained the phase-135 paragraph.
- **CSS**: branch input joins the URL/token box group (+placeholder/focus/mobile squeeze); editor field mirrors the token box (44px floor); tag joins the hidden-count rule.
- **Tests**: new `tests/unit/test_git_source_branch_ui.py` (12 source-level pins, house pattern); updated 5 stale pre-phase pins (3 unit, 1 E2E exact-body in `test_git_source_tokens.py` — now expects the mandated always-branch key) + the phase-121 docstring pin kept on its historical literal.
- **Results**: `uv run pytest --cov=app --cov-report=term` → 3223 passed, `app/` 99% (>90%); `uv run ruff check .` clean; `uv run pyright` → 0 errors; 7 related existing E2E suites green in isolation (admin, tokens, ignore-paths, hidden-toggle, local-dirs, archive-upload, dates).
- **Docs**: no doc impact — README already documents the branch feature (incl. the form field) from task 02; AGENTS.md is protocol-level.
- **Decisions**: task-05 E2E remains the formal browser gate for the new behavior (per task file); verified no regressions via the 7 existing real-browser suites.
- **Next pending task**: `05_e2e_git_source_branch.md`.
.agents/reports/135_git_source_branch/135_git_source_branch__04_branch_ui.a1.validate
+116
View File
@@ -0,0 +1,116 @@
........................................................................ [ 2%]
........................................................................ [ 4%]
........................................................................ [ 6%]
........................................................................ [ 8%]
........................................................................ [ 11%]
........................................................................ [ 13%]
........................................................................ [ 15%]
........................................................................ [ 17%]
........................................................................ [ 20%]
........................................................................ [ 22%]
........................................................................ [ 24%]
........................................................................ [ 26%]
........................................................................ [ 29%]
........................................................................ [ 31%]
........................................................................ [ 33%]
........................................................................ [ 35%]
........................................................................ [ 37%]
........................................................................ [ 40%]
........................................................................ [ 42%]
........................................................................ [ 44%]
........................................................................ [ 46%]
........................................................................ [ 49%]
........................................................................ [ 51%]
........................................................................ [ 53%]
........................................................................ [ 55%]
........................................................................ [ 58%]
........................................................................ [ 60%]
........................................................................ [ 62%]
........................................................................ [ 64%]
........................................................................ [ 67%]
........................................................................ [ 69%]
........................................................................ [ 71%]
........................................................................ [ 73%]
........................................................................ [ 75%]
........................................................................ [ 78%]
........................................................................ [ 80%]
........................................................................ [ 82%]
........................................................................ [ 84%]
........................................................................ [ 87%]
........................................................................ [ 89%]
........................................................................ [ 91%]
........................................................................ [ 93%]
........................................................................ [ 96%]
........................................................................ [ 98%]
....................................................... [100%]
=============================== warnings summary ===============================
.venv/lib/python3.13/site-packages/fastapi/testclient.py:1
/var/home/ducoterra/Projects/Personal/brain_of_reese/.venv/lib/python3.13/site-packages/fastapi/testclient.py:1: StarletteDeprecationWarning: Using `httpx` with `starlette.testclient` is deprecated; install `httpx2` instead.
from starlette.testclient import TestClient as TestClient # noqa
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================ tests coverage ================================
_______________ coverage: platform linux, python 3.13.13-final-0 _______________
Name Stmts Miss Cover
--------------------------------------------------
app/__init__.py 1 0 100%
app/api/__init__.py 0 0 100%
app/api/auth.py 52 0 100%
app/api/chat.py 268 1 99%
app/api/chat_images.py 50 0 100%
app/api/chats.py 110 0 100%
app/api/config.py 13 0 100%
app/api/doc_drafts.py 99 0 100%
app/api/docs.py 179 1 99%
app/api/git_sources.py 259 0 100%
app/api/health.py 10 0 100%
app/api/steering.py 42 0 100%
app/api/suggestions.py 33 0 100%
app/api/sync.py 183 0 100%
app/api/tokens.py 40 0 100%
app/api/ui_settings.py 55 0 100%
app/config.py 256 0 100%
app/core/__init__.py 0 0 100%
app/core/auth.py 45 0 100%
app/core/caching.py 124 0 100%
app/core/debugging.py 29 2 93%
app/core/docs_push.py 39 0 100%
app/core/errors.py 5 0 100%
app/core/logging.py 13 0 100%
app/core/rate_limit.py 44 0 100%
app/core/security_headers.py 20 0 100%
app/core/theming.py 38 0 100%
app/core/tokens.py 44 0 100%
app/db.py 22 0 100%
app/main.py 68 0 100%
app/models.py 133 0 100%
app/rag/__init__.py 0 0 100%
app/rag/agent.py 412 1 99%
app/rag/archive_upload.py 134 0 100%
app/rag/chunker.py 220 4 98%
app/rag/doc_dates.py 18 0 100%
app/rag/folder_summaries.py 134 0 100%
app/rag/git_sources.py 56 0 100%
app/rag/importer.py 595 9 98%
app/rag/llm.py 246 1 99%
app/rag/md_images.py 63 0 100%
app/rag/overview.py 71 0 100%
app/rag/pdf.py 109 0 100%
app/rag/prompts.py 144 0 100%
app/rag/retriever.py 248 3 99%
app/rag/scaffolding.py 55 0 100%
app/rag/source_removal.py 41 0 100%
app/rag/sources_meta.py 16 0 100%
app/rag/suggestions.py 27 0 100%
app/rag/summarizer.py 49 0 100%
app/schemas.py 422 0 100%
--------------------------------------------------
TOTAL 5334 22 99%
coverage gate: app/ 99% (>90%) OK
All checks passed!
0 errors, 0 warnings, 0 informations
WARNING: there is a new pyright version available (v1.1.411 -> v1.1.414).
Please install the new version or set PYRIGHT_PYTHON_FORCE_VERSION to `latest`
validation OK
.agents/reports/135_git_source_branch/135_git_source_branch__05_e2e_git_source_branch.a1.err
View File
.agents/reports/135_git_source_branch/135_git_source_branch__05_e2e_git_source_branch.a1.md
+17
View File
@@ -0,0 +1,17 @@
Everything is green. Final report:
**Implemented**
- `tests/e2e/test_git_source_branch.py` (new): the phase-135 dedicated Playwright suite — two-branch `file://` fixture (diverged branches: `release` drops `main-only.md`, shared `common.md` differs `VERSION: 1`/`2`) + a main-only clone; 4 tests: (1) UI add **with** branch → 201 → `branch: release` row tag → real sync indexes the branch's tree (sentinel docs present, `main-only.md` absent, modal content `VERSION: 2`) + idempotent "0 added · 2 unchanged"; (2) `branch=None` path on the clone = default branch exactly as pre-phase (`main-only.md` present, `release-only.md` absent, `VERSION: 1`, no tag); (3) per-row editor branch change → failed sync with the fixed `remove and re-add the source` copy in status/banner/modal, then restore → success; (4) API contracts via admin cookie (exact 422s, tri-state, local-row 422). Port 8134, dedicated `BOR_SOURCES_DIR`, empty `BOR_GIT_SOURCES`, 180 s wall guard.
- Fixed a blocking gap the task's UI flow exposed: `POST /api/git-sources` rejected `file://` (phase-35 URL contract). Extended `URL_RE` + fixed 422 detail to include `file://`, updated docstrings, and pinned the new shape in `tests/integration/test_git_sources_api.py`.
**Test / lint / coverage**
- `uv run pytest tests/e2e/test_git_source_branch.py -v --no-cov` → **4 passed** in ~17 s (run 3×, stable)
- `uv run pytest --cov=app --cov-report=term` → **3223 passed, 0 failed**, app/ coverage **99%** (>90% gate)
- `uv run ruff check .` → clean; `uv run pyright` → 0 errors
- Sibling E2E suites touching the changed 422 detail (`test_git_sources_admin.py`, `test_git_source_tokens.py`) → 10 passed
**Docs**: README.md gained the accepted-URL-shapes note (`file://` now a valid source); the branch-feature paragraph was already added by this phase's earlier tasks. AGENTS.md: no change needed (no new setup steps, commands, or env vars).
**Notable decisions**: (a) the `file://` prefix addition (phase-35's "exactly four prefixes" was an assumption, not a PLAN LOCKED decision; the task's owner-via-UI flow requires it); (b) fixture branches must diverge — `release` deletes `main-only.md`, else the "wrong branch's doc absent" promise can't hold; (c) `sync_and_wait` closes a re-rendered failure modal before clicking (a Sources-view remount over a stale `failed` terminal re-renders it, and its fixed backdrop intercepts the `#sync-btn` click).
**Next pending task**: none — task 05 is the final task of phase `135_git_source_branch`.
.agents/reports/135_git_source_branch/135_git_source_branch__05_e2e_git_source_branch.a1.validate
+116
View File
@@ -0,0 +1,116 @@
........................................................................ [ 2%]
........................................................................ [ 4%]
........................................................................ [ 6%]
........................................................................ [ 8%]
........................................................................ [ 11%]
........................................................................ [ 13%]
........................................................................ [ 15%]
........................................................................ [ 17%]
........................................................................ [ 20%]
........................................................................ [ 22%]
........................................................................ [ 24%]
........................................................................ [ 26%]
........................................................................ [ 29%]
........................................................................ [ 31%]
........................................................................ [ 33%]
........................................................................ [ 35%]
........................................................................ [ 37%]
........................................................................ [ 40%]
........................................................................ [ 42%]
........................................................................ [ 44%]
........................................................................ [ 46%]
........................................................................ [ 49%]
........................................................................ [ 51%]
........................................................................ [ 53%]
........................................................................ [ 55%]
........................................................................ [ 58%]
........................................................................ [ 60%]
........................................................................ [ 62%]
........................................................................ [ 64%]
........................................................................ [ 67%]
........................................................................ [ 69%]
........................................................................ [ 71%]
........................................................................ [ 73%]
........................................................................ [ 75%]
........................................................................ [ 78%]
........................................................................ [ 80%]
........................................................................ [ 82%]
........................................................................ [ 84%]
........................................................................ [ 87%]
........................................................................ [ 89%]
........................................................................ [ 91%]
........................................................................ [ 93%]
........................................................................ [ 96%]
........................................................................ [ 98%]
....................................................... [100%]
=============================== warnings summary ===============================
.venv/lib/python3.13/site-packages/fastapi/testclient.py:1
/var/home/ducoterra/Projects/Personal/brain_of_reese/.venv/lib/python3.13/site-packages/fastapi/testclient.py:1: StarletteDeprecationWarning: Using `httpx` with `starlette.testclient` is deprecated; install `httpx2` instead.
from starlette.testclient import TestClient as TestClient # noqa
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================ tests coverage ================================
_______________ coverage: platform linux, python 3.13.13-final-0 _______________
Name Stmts Miss Cover
--------------------------------------------------
app/__init__.py 1 0 100%
app/api/__init__.py 0 0 100%
app/api/auth.py 52 0 100%
app/api/chat.py 268 1 99%
app/api/chat_images.py 50 0 100%
app/api/chats.py 110 0 100%
app/api/config.py 13 0 100%
app/api/doc_drafts.py 99 0 100%
app/api/docs.py 179 1 99%
app/api/git_sources.py 259 0 100%
app/api/health.py 10 0 100%
app/api/steering.py 42 0 100%
app/api/suggestions.py 33 0 100%
app/api/sync.py 183 0 100%
app/api/tokens.py 40 0 100%
app/api/ui_settings.py 55 0 100%
app/config.py 256 0 100%
app/core/__init__.py 0 0 100%
app/core/auth.py 45 0 100%
app/core/caching.py 124 0 100%
app/core/debugging.py 29 2 93%
app/core/docs_push.py 39 0 100%
app/core/errors.py 5 0 100%
app/core/logging.py 13 0 100%
app/core/rate_limit.py 44 0 100%
app/core/security_headers.py 20 0 100%
app/core/theming.py 38 0 100%
app/core/tokens.py 44 0 100%
app/db.py 22 0 100%
app/main.py 68 0 100%
app/models.py 133 0 100%
app/rag/__init__.py 0 0 100%
app/rag/agent.py 412 1 99%
app/rag/archive_upload.py 134 0 100%
app/rag/chunker.py 220 4 98%
app/rag/doc_dates.py 18 0 100%
app/rag/folder_summaries.py 134 0 100%
app/rag/git_sources.py 56 0 100%
app/rag/importer.py 595 9 98%
app/rag/llm.py 246 1 99%
app/rag/md_images.py 63 0 100%
app/rag/overview.py 71 0 100%
app/rag/pdf.py 109 0 100%
app/rag/prompts.py 144 0 100%
app/rag/retriever.py 248 3 99%
app/rag/scaffolding.py 55 0 100%
app/rag/source_removal.py 41 0 100%
app/rag/sources_meta.py 16 0 100%
app/rag/suggestions.py 27 0 100%
app/rag/summarizer.py 49 0 100%
app/schemas.py 422 0 100%
--------------------------------------------------
TOTAL 5334 22 99%
coverage gate: app/ 99% (>90%) OK
All checks passed!
0 errors, 0 warnings, 0 informations
WARNING: there is a new pyright version available (v1.1.411 -> v1.1.414).
Please install the new version or set PYRIGHT_PYTHON_FORCE_VERSION to `latest`
validation OK