phase: 190_app_name_settings_fix

All gates re-verified green. Report:

- **Verified (all 4 tasks already complete; this was the final pass):** `effective_settings` resolves the 3 brand strings panel-row → tab-row → env (`applied_override_keys`, presence-not-value); `PUT /api/ui-settings` ignores string body fields; Theme-tab form is colors-only (17 pickers, no `#theme-app-name`/`#theme-placeholder`/`#theme-footer`); the ONE shared `applyBrandFromConfig` re-applies title/`.brand-text`/footer/placeholder after a panel save-reset and a tab save-reset; boot path byte-identical (single `/api/config`).
- **Completion criteria:**
  - strings order panel→tab→env, both branches — ✅ `tests/unit/test_theming.py::test_effective_app_name_prefers_settings_panel_row_over_ui_settings_row`, `..._fall_back_to_ui_settings_row_without_panel_row`, `..._per_field_panel_then_tab_then_env`, `..._ignore_panel_rows_when_the_overlay_is_off`
  - PUT ignores string fields + no 3 inputs in the tab — ✅ `tests/integration/test_ui_settings_api.py::test_put_ignores_string_fields_in_body` (+2) and the E2E `test_theme_tab_dom_is_colors_only`
  - live apply without reload + incident regression — ✅ `tests/e2e/test_app_name_settings_fix.py` tests 1–4
  - byte-identical boot, no double-apply — ✅ `tests/unit/test_brand_live.py` markers + E2E "exactly one /api/config"
  - suite green, coverage >90%, ruff+pyright clean — ✅
  - no behavior change in prior phases — ✅ (palette, phase-168 panel, env fallback suites all green)
  - atomic commit — **left to the harness** (pipeline rule overrides per-phase committing; no git write run)
- **Gates:** `uv run pytest --cov=app --cov-report=term-missing` → **4630 passed, TOTAL 6941 16 99%**, exit 0 · `uv run pytest tests/e2e/test_app_name_settings_fix.py -v --no-cov` → **6 passed** in isolation · regression E2E (isolated, one process each, all exit 0): `test_smoke` `test_configurable_brand` `test_admin_theme_tab` `test_theme_save_and_coverage` `test_theme_semantic_completion` `test_themed_favicon` `test_dark_tech_theme` `test_admin_settings_panel` `test_admin_settings_layout` `test_settings_mobile_value_width` · `uv run ruff check .` → All checks passed · `uv run pyright` → 0 errors.
- **Documentation:** README — fixed "saving one repaints *every* open page" (only the open document repaints; other pages on next load) and a broken paragraph wrap in *Customizing the look*; AGENTS.md rule 16 — `test_chunks_hnsw_recall.py` now described accurately (index paths forced with `enable_seqscan`/`indexonlyscan`/`bitmapscan` off, unforced plan asserted only on a pristine relation); `tests/unit/test_theme_frontend.py` — two stale section headers ("20 form fields"/"20 inputs" → 17 color). No AGENTS.md settings-overlay/resolution-order clause exists, so per the phase none was added. Full env-var cross-check (`BOR_*` in `app/config.py` vs README) → 0 gaps; 0 missing file references.
- **Notable:** the working tree also carries this phase's flake hardening of the phase-188 `tests/integration/test_chunks_hnsw_recall.py` (verified legit and green). Live infra untouched; shared DB left clean (0 `app_settings`, 0 `ui_settings`). **Flagged, not changed:** `settings_overlay.applied_override_keys` lets a `ProgrammingError` (missing `app_settings`) propagate from public `GET /api/config`, where `load_overrides` deliberately fails soft — only reachable on an un-migrated (0027) DB, outside this phase's pinned A1 semantics, so left for the owner to rule on rather than silently deviating.
- **Next pending phase:** `191_source_name_labels_tags`.

tests/unit/test_frontend_router.py

@@ -292,7 +292,7 @@ def test_router_writes_active_state_title_and_meta() -> None:
     assert "Generate and revoke the API tokens that let people use the app." in js
     assert 'theme: "Theme · Brain of Reese"' in js
     assert (
-        "Set the palette and branding — the theme is baked into every served page, "
+        "Set the palette — the theme is baked into every served page, "
         "live on the first paint."
     ) in js
     assert 'settings: "Settings · Brain of Reese"' in js
@@ -1444,20 +1444,26 @@ def test_theme_view_scaffold_in_the_shell() -> None:
         "#theme-content must ship hidden (anonymous-safe)"
     )
     # The static form skeleton (the E2E-stable-selectors house
-    # convention): the 3 labeled branding text inputs (maxlength=300)
-    # and the 17 labeled type=color palette inputs (the 9 identity
-    # variables, then the 8 semantic state variables — phase 93 —
-    # one per theming.COLOR_FIELDS field).
+    # convention): the 17 labeled type=color palette inputs (the 9
+    # identity variables, then the 8 semantic state variables — phase
+    # 93 — one per theming.COLOR_FIELDS field), and NOTHING else: the
+    # phase-190 (A1) strip removed the "Branding" fieldset and its
+    # three string inputs — the admin Settings panel owns the brand
+    # strings, so the tab neither renders nor sends them.
     assert re.search(r'<form[^>]*id="theme-form"[^>]*>', body), (
         "the #theme-form must be STATIC markup in the shell"
     )
     for field_id in ("theme-app-name", "theme-placeholder", "theme-footer"):
-        assert re.search(
-            rf'<label[^>]*for="{field_id}"[^>]*>', body
-        ), f"missing the visible label for #{field_id}"
-        assert re.search(
-            rf'<input[^>]*id="{field_id}"[^>]*maxlength="300"[^>]*>', body
-        ), f"#{field_id} must be a text input with maxlength=300"
+        assert f'id="{field_id}"' not in body, (
+            f"#{field_id} is gone from the Theme tab (phase 190 A1)"
+        )
+        assert f'for="{field_id}"' not in body, f"#{field_id}'s label is gone too"
+    assert "maxlength=\"300\"" not in body, (
+        "the 300-char string inputs were the branding fieldset's — gone"
+    )
+    assert not re.search(r"<legend[^>]*>\s*Branding\s*</legend>", body), (
+        "the Branding fieldset is gone (phase 190 A1)"
+    )
     for field_id in (
         "theme-bg",
         "theme-surface",