phase: 190_app_name_settings_fix

All gates re-verified green. Report:

- **Verified (all 4 tasks already complete; this was the final pass):** `effective_settings` resolves the 3 brand strings panel-row → tab-row → env (`applied_override_keys`, presence-not-value); `PUT /api/ui-settings` ignores string body fields; Theme-tab form is colors-only (17 pickers, no `#theme-app-name`/`#theme-placeholder`/`#theme-footer`); the ONE shared `applyBrandFromConfig` re-applies title/`.brand-text`/footer/placeholder after a panel save-reset and a tab save-reset; boot path byte-identical (single `/api/config`).
- **Completion criteria:**
  - strings order panel→tab→env, both branches — ✅ `tests/unit/test_theming.py::test_effective_app_name_prefers_settings_panel_row_over_ui_settings_row`, `..._fall_back_to_ui_settings_row_without_panel_row`, `..._per_field_panel_then_tab_then_env`, `..._ignore_panel_rows_when_the_overlay_is_off`
  - PUT ignores string fields + no 3 inputs in the tab — ✅ `tests/integration/test_ui_settings_api.py::test_put_ignores_string_fields_in_body` (+2) and the E2E `test_theme_tab_dom_is_colors_only`
  - live apply without reload + incident regression — ✅ `tests/e2e/test_app_name_settings_fix.py` tests 1–4
  - byte-identical boot, no double-apply — ✅ `tests/unit/test_brand_live.py` markers + E2E "exactly one /api/config"
  - suite green, coverage >90%, ruff+pyright clean — ✅
  - no behavior change in prior phases — ✅ (palette, phase-168 panel, env fallback suites all green)
  - atomic commit — **left to the harness** (pipeline rule overrides per-phase committing; no git write run)
- **Gates:** `uv run pytest --cov=app --cov-report=term-missing` → **4630 passed, TOTAL 6941 16 99%**, exit 0 · `uv run pytest tests/e2e/test_app_name_settings_fix.py -v --no-cov` → **6 passed** in isolation · regression E2E (isolated, one process each, all exit 0): `test_smoke` `test_configurable_brand` `test_admin_theme_tab` `test_theme_save_and_coverage` `test_theme_semantic_completion` `test_themed_favicon` `test_dark_tech_theme` `test_admin_settings_panel` `test_admin_settings_layout` `test_settings_mobile_value_width` · `uv run ruff check .` → All checks passed · `uv run pyright` → 0 errors.
- **Documentation:** README — fixed "saving one repaints *every* open page" (only the open document repaints; other pages on next load) and a broken paragraph wrap in *Customizing the look*; AGENTS.md rule 16 — `test_chunks_hnsw_recall.py` now described accurately (index paths forced with `enable_seqscan`/`indexonlyscan`/`bitmapscan` off, unforced plan asserted only on a pristine relation); `tests/unit/test_theme_frontend.py` — two stale section headers ("20 form fields"/"20 inputs" → 17 color). No AGENTS.md settings-overlay/resolution-order clause exists, so per the phase none was added. Full env-var cross-check (`BOR_*` in `app/config.py` vs README) → 0 gaps; 0 missing file references.
- **Notable:** the working tree also carries this phase's flake hardening of the phase-188 `tests/integration/test_chunks_hnsw_recall.py` (verified legit and green). Live infra untouched; shared DB left clean (0 `app_settings`, 0 `ui_settings`). **Flagged, not changed:** `settings_overlay.applied_override_keys` lets a `ProgrammingError` (missing `app_settings`) propagate from public `GET /api/config`, where `load_overrides` deliberately fails soft — only reachable on an un-migrated (0027) DB, outside this phase's pinned A1 semantics, so left for the owner to rule on rather than silently deviating.
- **Next pending phase:** `191_source_name_labels_tags`.

tests/e2e/test_theme_save_and_coverage.py

@@ -145,14 +145,9 @@ PALETTE: dict[str, str] = {
     "accent_ink": "#d9c37a",
     "accent_line": "#b8963e",
 }
-APP_NAME = "Theme E2E"
-PLACEHOLDER = "Ask the themed brain…"
-FOOTER = "E2E footer"
-SAVED_STRINGS: dict[str, str] = {
-    "app_name": APP_NAME,
-    "input_placeholder": PLACEHOLDER,
-    "footer_text": FOOTER,
-}
+# No saved-string fixture since phase 190 (A1): the admin Settings
+# panel owns the brand strings, so this surface saves COLORS only and
+# every string assertion reads the env/template default.
 
 #: The E2E-stable color-input ids, in COLOR_FIELDS order (the form's
 #: own markup — the static E2E-stable-selectors house convention).
@@ -234,17 +229,23 @@ def _template_defaults() -> dict[str, str]:
     }
 
 
-def _wait_mount_settled(page: Page) -> None:
-    """The theme view's mount-time load has SETTLED: its populate is
-    the last visible step — the app-name input carries the effective
-    default (the static markup ships it empty, so only a settled
-    ``loadSettings`` can have written it). From here on, no in-flight
-    mount load can race the test's own save/reset refetch (an
-    out-of-order settle would re-reconcile the open document onto a
-    stale read)."""
-    expect(page.locator("#theme-app-name")).to_have_value(
-        _template_defaults()["app_name"], timeout=15_000
-    )
+def _login_to_theme(page: Page, app_url: str) -> None:
+    """Log in straight into the Theme view AND wait for its mount-time
+    ``GET /api/ui-settings`` to ANSWER — the settle signal.
+
+    Phase 190 (task 02) moved it: the settle used to be read off the
+    ``#theme-app-name`` input (the only input the static markup ships
+    empty, so a value in it proved ``populate`` had run) — that input is
+    gone with the tab's string fieldset, so the network is the source of
+    truth now. From here on, no in-flight mount load can race the test's
+    own save/reset refetch (an out-of-order settle would re-reconcile the
+    open document onto a stale read)."""
+    with page.expect_response(
+        lambda r: "/api/ui-settings" in r.url, timeout=30_000
+    ) as info:
+        login(page, app_url, next="/theme.html")
+    assert info.value.status == 200, "the mount's GET /api/ui-settings failed"
+    expect(page.locator("#theme-content")).to_be_visible(timeout=15_000)
 
 
 def _expected_overrides(colors: dict[str, str], builtins: dict[str, str]) -> dict[str, str]:
@@ -476,12 +477,20 @@ def _cookies(page: Page) -> dict[str, str]:
 
 
 def _seed_theme_via_api(app_url: str, cookies: dict[str, str]) -> None:
-    """Admin ``PUT /api/ui-settings`` with the full theme (the API
-    seed — the UI save itself is test 1's job)."""
-    body = {**PALETTE, **SAVED_STRINGS}
-    r = httpx.put(f"{app_url}/api/ui-settings", json=body, cookies=cookies, timeout=10)
+    """Admin ``PUT /api/ui-settings`` with the full 17-color palette
+    (the API seed — the UI save path is this module's own tests' job).
+
+    Phase 190 (A1): no string key in the body — the Settings panel owns
+    the brand strings — and the response keeps reporting the effective
+    (env/template) strings, so a palette seed cannot rename the app."""
+    defaults = _template_defaults()
+    r = httpx.put(f"{app_url}/api/ui-settings", json=PALETTE, cookies=cookies, timeout=10)
     assert r.status_code == 200, r.text
-    assert r.json() == body, "the PUT must echo the new effective values"
+    body = r.json()
+    for field in COLOR_FIELDS:
+        assert body[field] == PALETTE[field], f"effective {field} != {PALETTE[field]}"
+    for field, value in defaults.items():
+        assert body[field] == value, f"{field} must stay the effective default (A1)"
 
 
 def _hold_theme_puts(page: Page, hold_s: float = 0.6) -> None:
@@ -506,18 +515,9 @@ def _release_theme_puts(page: Page) -> None:
     page.unroute("**/api/ui-settings")
 
 
-def _fill_theme_form(
-    page: Page,
-    palette: dict[str, str],
-    strings: dict[str, str] | None = None,
-) -> None:
-    """Fill the 20 inputs: the 3 text fields (``strings``, default
-    the E2E set) + the 17 color pickers (``palette`` — all 17 vars,
-    phase 93)."""
-    text_values = strings if strings is not None else SAVED_STRINGS
-    page.fill("#theme-app-name", text_values["app_name"])
-    page.fill("#theme-placeholder", text_values["input_placeholder"])
-    page.fill("#theme-footer", text_values["footer_text"])
+def _fill_theme_form(page: Page, palette: dict[str, str]) -> None:
+    """Fill the 17 color pickers (``palette`` — all 17 vars, phase 93).
+    The tab has no string inputs since phase 190 (A1)."""
     for field, value in palette.items():
         page.fill(COLOR_INPUT_IDS[field], value)
 
@@ -545,16 +545,14 @@ def _assert_raw_tag(raw: str, colors: dict[str, str]) -> None:
 def test_save_applies_live_without_reload(page: Page, app_url: str, db_ready: None) -> None:
     builtin = _builtin_colors()
     page.set_default_timeout(30_000)
-    login(page, app_url, next="/theme.html")
+    # The mount's initial load has SETTLED inside this helper (the
+    # row-less state — no tag, no overrides) before the test touches
+    # the form: no in-flight load can race the save's own refetch.
+    _login_to_theme(page, app_url)
     expect(page.locator("#theme-gate")).to_be_hidden()
-    expect(page.locator("#theme-content")).to_be_visible(timeout=15_000)
-    # The mount's initial load has settled (the row-less state — no
-    # tag, no overrides) before the test touches the form: no
-    # in-flight load can race the save's own refetch.
-    _wait_mount_settled(page)
 
-    # Fill the 20 inputs (the 3 strings + the 17-color palette) and Save
-    # through the real form — the PUT held so the §7.4 in-flight state
+    # Fill the 17 color inputs and Save through the real form — the PUT
+    # held so the §7.4 in-flight state
     # is observable deterministically (the same lifecycle assertions
     # as the phase-91 suite — the save's contract is unchanged).
     _fill_theme_form(page, PALETTE)