fix(web): retire the stale homelab-era copy — neutral, accurate defaults on every page
Fixed: index.html meta description, empty-state sub and composer placeholder (A1); app/config.py default suggestion chips → the four neutral A2 defaults (BOR_SUGGESTIONS override unchanged); sources.html KB page-sub → the current source model (git repos + local dirs + uploaded archives, Sync pulls/imports); git-sources.html example URL → your-repo.git (A3); all 9 footers → neutral default in span.footer-text (the phase-62 hook); E2E/unit conftests force the code defaults so a local .env cannot leak corpus copy into tests; new unit text pins + dedicated E2E suite. Task 02 verification read-through — no change needed: - sources.html sync result/error copy (matches the real sync behavior) - tuning.html page-sub (accurate as written) - history.html page-sub (accurate as written) - doc-edit.html page-sub (accurate as written) - git-sources.html page-sub (accurate as written) - #sources-gate anonymous copy (accurate as written)
This commit is contained in:
@@ -14,6 +14,7 @@ Prerequisite for story tests that touch the database:
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
import json
|
||||
import os
|
||||
import subprocess
|
||||
import sys
|
||||
@@ -25,6 +26,8 @@ import httpx
|
||||
import pytest
|
||||
from playwright.sync_api import Browser, Page, sync_playwright
|
||||
|
||||
from app.config import Settings as _Settings
|
||||
|
||||
REPO = Path(__file__).resolve().parents[2]
|
||||
APP_PORT = int(os.environ.get("E2E_APP_PORT", "8123"))
|
||||
MOCK_PORT = int(os.environ.get("E2E_MOCK_PORT", "8901"))
|
||||
@@ -99,6 +102,16 @@ def app_server(mock_llm: int) -> Iterator[str]:
|
||||
# Phase 16: admin auth must be set or create_app() refuses to boot.
|
||||
env["BOR_ADMIN_PASSWORD"] = ADMIN_PASSWORD
|
||||
env["BOR_SESSION_SECRET"] = SESSION_SECRET
|
||||
# Phase 61 (defect fix): force the code DEFAULTS so an operator's local
|
||||
# (gitignored) ``.env`` — loaded by pydantic-settings from ``cwd=REPO``
|
||||
# — cannot leak corpus-specific chips / a docs repo into the app under
|
||||
# test: process env ranks above the ``.env`` file. The suggestions
|
||||
# default is derived from the class field (never drifts from
|
||||
# ``app/config.py``); docs-push stays inert (empty repo).
|
||||
env["BOR_DOCS_REPO"] = ""
|
||||
env["BOR_SUGGESTIONS"] = json.dumps(
|
||||
_Settings.model_fields["suggestions"].default
|
||||
)
|
||||
proc = subprocess.Popen(
|
||||
[sys.executable, "-m", "uvicorn", "app.main:app",
|
||||
"--host", "127.0.0.1", "--port", str(APP_PORT), "--log-level", "warning"],
|
||||
|
||||
@@ -216,6 +216,11 @@ def _spawn_app(port: int, mock_port: int, docs_env: dict[str, str] | None) -> su
|
||||
"BOR_DOCS_WORK_DIR",
|
||||
):
|
||||
env.pop(var, None)
|
||||
# Phase 61 (defect fix): the pop only clears the process env —
|
||||
# pydantic-settings would still pick up ``BOR_DOCS_REPO`` from an
|
||||
# operator's local (gitignored) ``.env`` (``cwd=REPO``). Force
|
||||
# empty so the "unconfigured" boot really is the inert default.
|
||||
env["BOR_DOCS_REPO"] = ""
|
||||
else:
|
||||
env.update(docs_env)
|
||||
return subprocess.Popen(
|
||||
|
||||
@@ -0,0 +1,117 @@
|
||||
"""Phase 61 E2E (Playwright): the retired homelab-era copy is gone — the
|
||||
visitor SEES the locked neutral copy on the shared default server.
|
||||
|
||||
Story: n/a (TODO-derived — TODO.md L4 "Clean up the UI, there's text
|
||||
that references old features…"). Run in isolation (DB must be up:
|
||||
``podman compose up -d db``):
|
||||
|
||||
uv run pytest tests/e2e/test_stale_ui_copy.py -v --no-cov
|
||||
|
||||
The shared conftest server boots with the default env — and the code
|
||||
defaults are exactly this phase's locked copy (A1/A2; the conftest
|
||||
forces ``BOR_SUGGESTIONS`` from the ``Settings`` field so an operator's
|
||||
local ``.env`` cannot leak corpus-specific chips). Every assertion is a
|
||||
settled-state check: static HTML + one ``GET /api/suggestions`` fetch;
|
||||
Playwright's ``expect`` retries ride out the chip rendering.
|
||||
|
||||
Test → lock mapping (Playwright Mapping Rule):
|
||||
1. ``test_chat_page_placeholder_meta_footer_are_the_locked_copy``
|
||||
2. ``test_chat_page_shows_no_homelab_or_deployment_text``
|
||||
3. ``test_chat_page_suggestion_chips_are_the_locked_list``
|
||||
4. ``test_sources_page_sub_describes_the_current_source_model``
|
||||
5. ``test_git_sources_example_url_is_neutral``
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
from playwright.sync_api import Page, expect
|
||||
|
||||
# The locked replacement copy (owner-locked A1 / A2 / A3 — same literals
|
||||
# as tests/unit/test_stale_ui_copy.py; the unit pins guard the files,
|
||||
# this suite guards what the visitor actually sees).
|
||||
META = "Ask anything about your indexed documents — every answer cites the exact doc."
|
||||
PLACEHOLDER = "Ask me anything…"
|
||||
FOOTER = "Powered by self-hosted models"
|
||||
GIT_EXAMPLE = "https://github.com/you/your-repo.git"
|
||||
|
||||
CHIPS = [
|
||||
"What documents are in the knowledge base?",
|
||||
"Which source does each answer come from?",
|
||||
"How do I add a new source?",
|
||||
"Summarize the most recent document.",
|
||||
]
|
||||
|
||||
|
||||
def test_chat_page_placeholder_meta_footer_are_the_locked_copy(
|
||||
page: Page, app_url: str, db_ready: None
|
||||
) -> None:
|
||||
"""The composer placeholder, the <meta description> content and the
|
||||
footer span all read the locked (A1) copy — read from the DOM a
|
||||
visitor gets."""
|
||||
page.goto(f"{app_url}/")
|
||||
expect(page.locator("#message-input")).to_have_attribute(
|
||||
"placeholder", PLACEHOLDER
|
||||
)
|
||||
meta = page.eval_on_selector('meta[name="description"]', "el => el.content")
|
||||
assert meta == META, "the rendered meta description must be the locked copy"
|
||||
expect(page.locator(".footer-text").first).to_have_text(FOOTER)
|
||||
|
||||
|
||||
def test_chat_page_shows_no_homelab_or_deployment_text(
|
||||
page: Page, app_url: str, db_ready: None
|
||||
) -> None:
|
||||
"""The entire rendered chat page (nav, empty state, composer, footer)
|
||||
shows no homelab-era text — the empty-state sub AND the four
|
||||
rendered suggestion chips are covered by this body scan (case-
|
||||
insensitive; a fresh page context has no saved chats, so the empty
|
||||
state is what renders)."""
|
||||
page.goto(f"{app_url}/")
|
||||
expect(page.locator("#suggestions .suggestion-chip")).to_have_count(len(CHIPS))
|
||||
body = page.evaluate("() => document.body.innerText.toLowerCase()")
|
||||
assert "homelab" not in body, f"homelab-era text rendered on the chat page: {body!r}"
|
||||
assert "deployment" not in body, (
|
||||
f"homelab-era text rendered on the chat page: {body!r}"
|
||||
)
|
||||
|
||||
|
||||
def test_chat_page_suggestion_chips_are_the_locked_list(
|
||||
page: Page, app_url: str, db_ready: None
|
||||
) -> None:
|
||||
"""The four rendered empty-state chips (from ``GET
|
||||
/api/suggestions``, the code default) are the locked (A2) list, in
|
||||
order."""
|
||||
page.goto(f"{app_url}/")
|
||||
chips = page.locator("#suggestions .suggestion-chip")
|
||||
expect(chips).to_have_count(len(CHIPS))
|
||||
for i, chip in enumerate(CHIPS):
|
||||
expect(chips.nth(i)).to_have_text(chip)
|
||||
|
||||
|
||||
def test_sources_page_sub_describes_the_current_source_model(
|
||||
page: Page, app_url: str, db_ready: None
|
||||
) -> None:
|
||||
"""The KB page-sub (the string the TODO cited by name) no longer
|
||||
names ~/Homelab or ~/Deployments and describes the current source
|
||||
model. The page is anonymously viewable — the catalog gate hides
|
||||
the table, not the page-head."""
|
||||
page.goto(f"{app_url}/sources.html")
|
||||
sub = page.locator(".page-sub").first
|
||||
expect(sub).to_be_visible()
|
||||
text = sub.inner_text().lower()
|
||||
assert "homelab" not in text, f"retired copy in the page-sub: {text!r}"
|
||||
assert "deployments" not in text, f"retired copy in the page-sub: {text!r}"
|
||||
assert "configured sources" in text, (
|
||||
f"the page-sub must name the current source model: {text!r}"
|
||||
)
|
||||
|
||||
|
||||
def test_git_sources_example_url_is_neutral(
|
||||
page: Page, app_url: str, db_ready: None
|
||||
) -> None:
|
||||
"""The repo-URL form example (A3) is the neutral your-repo.git —
|
||||
read from the DOM; the element exists even while
|
||||
``#git-sources-content`` is hidden for an anonymous visitor (no
|
||||
sign-in needed)."""
|
||||
page.goto(f"{app_url}/git-sources.html")
|
||||
expect(page.locator("#git-source-url")).to_have_attribute(
|
||||
"placeholder", GIT_EXAMPLE
|
||||
)
|
||||
Reference in New Issue
Block a user