phase: 165_prose_word_wrap
All verification complete. Final report:
**Phase 165 — Prose word wrap (final verification pass)**
- Verified: `PROSE_FORMATS={txt,text}` + `isProseDoc` (single-site, image arm wins); `renderDocument` three-way branch (md → `.doc-md`, prose → `.doc-prose` text node, else `pre.doc-raw` byte-identical); `.doc-prose` CSS = 72rem column, `pre-wrap` + `overflow-wrap: anywhere`, tokens only, zero literals; `[data-view="pages"]` hide list includes `.doc-prose` as one grouped declaration; phase-116 scrollbar rules intact and modal-scoped; no `innerHTML` in the prose path.
- Tests/lint (all 100% green):
- `uv run pytest` → **3854 passed** (unit + integration)
- `uv run pytest --cov=app --cov-report=term-missing` → **TOTAL 99%** (>90%)
- `uv run ruff check .` → All checks passed; `uv run pyright` → **0 errors**
- `uv run pytest tests/e2e/test_prose_word_wrap.py -v --no-cov` → **5 passed** (isolation)
- Isolation regressions: document_viewer 8, image_documents 4, pdf_pages_in_sources 4, pdf_strip_additive_selfheal 5, edit_summaries 4, summary_in_viewer 4, chat_answer_clusters 4, garbage_pdf 3, pdf_support 6, sticky_navbar 3, smoke 3 — all passed
- Completion criteria: image description wraps, full text, both surfaces ✔; `.txt` wraps same way ✔; `py`/`json`/code keep `pre.doc-raw` + horizontal overflow + themed modal scrollbar (E2E negative control + pins) ✔; no innerHTML, AA `--ink`/`--surface` pair ✔; full gates green ✔; commit + phase-dir move are harness-owned (not executed per pipeline rules).
- Documentation: README already updated by task 03 (viewer section + image-docs section); full README/AGENTS.md review found no further inconsistencies — **verified consistent, no changes needed**.
- Notable deviations: `.doc-prose` omits `font-family: inherit` from 00_phase D2's snippet — task 01's authoritative "exact property set" excludes it and `div` inherits fonts anyway (behavior identical). PDF deferral (A4) intact: `format == "pdf"` stays in `.doc-raw`, owner call recorded.
- Next pending phase: `166_hide_empty_answer_bubble`.
This commit is contained in:
@@ -52,8 +52,11 @@ Test → observable mapping (Playwright Mapping Rule):
|
||||
BOTH docs — the read text doc first (read order), then the
|
||||
auto-cited image ref (``image_url`` present; the text ref's key is
|
||||
ABSENT); the last brain bubble's ``.msg-body`` direct children are
|
||||
exactly ``[tool-calls-disclosure, bubble, msg-meta, msg-meta
|
||||
msg-images, msg-meta msg-actions]`` — the chips row (EXACTLY the
|
||||
exactly ``[reasoning, bubble, msg-meta, msg-meta msg-images,
|
||||
msg-meta msg-actions]`` — the ONE phase-161 reasoning container
|
||||
ABOVE the answer (this turn's tool record lives inside its
|
||||
``.reasoning-body`` as a ``.tool-calls-disclosure`` block, the
|
||||
phase-130 timeline re-targeted by phase 161 D1) then the chips row (EXACTLY the
|
||||
text chip — NO chip for the image doc, phase 130 task 01) before
|
||||
the images row (the figure, ``<img>`` loaded from the bytes route,
|
||||
alt + caption settling to the canned description), no related row
|
||||
@@ -205,11 +208,14 @@ assert all(len(q) <= 120 for q in (Q_ORDER, Q_FIGURE, Q_RESTORE, Q_NONADMIN)), (
|
||||
)
|
||||
|
||||
#: The .msg-body child sequence of a completed scripted-read bubble
|
||||
#: (phase 130's fix, DOM-asserted): the tool record (the scripted read),
|
||||
#: the answer bubble, the chips row (the bare .msg-meta), the images
|
||||
#: row, the actions row LAST. The live and restore paths share it.
|
||||
#: (phase 130's fix, DOM-asserted; re-targeted by phase 161 D1): the
|
||||
#: ONE reasoning container (the scripted read's tool record rides
|
||||
#: INSIDE it — .reasoning .tool-calls-disclosure, asserted beside the
|
||||
#: sequence), the answer bubble, the chips row (the bare .msg-meta),
|
||||
#: the images row, the actions row LAST. The live and restore paths
|
||||
#: share it.
|
||||
EXPECTED_CHILD_CLASSES = [
|
||||
"tool-calls-disclosure",
|
||||
"reasoning",
|
||||
"bubble",
|
||||
"msg-meta",
|
||||
"msg-meta msg-images",
|
||||
@@ -759,13 +765,20 @@ def test_answer_clusters_render_in_order(
|
||||
expect(bubble).to_contain_text(TEXT_TITLE)
|
||||
expect(bubble).to_contain_text(READ_BODY_QUOTE)
|
||||
|
||||
# The DOM ORDER (the fix): tool record, answer, chips row, images
|
||||
# row, actions row LAST — asserted exactly (this sequence fails
|
||||
# against the pre-phase soup div, where the buttons shared the
|
||||
# chips row and the figure interleaved with it).
|
||||
# The DOM ORDER (the fix): reasoning container (tool record
|
||||
# inside), answer, chips row, images row, actions row LAST —
|
||||
# asserted exactly (this sequence fails against the pre-phase
|
||||
# soup div, where the buttons shared the chips row and the figure
|
||||
# interleaved with it).
|
||||
assert _body_child_classes(page) == EXPECTED_CHILD_CLASSES, (
|
||||
_body_child_classes(page)
|
||||
)
|
||||
# The tool record lives INSIDE the ONE reasoning container above
|
||||
# the answer (phase 161 D1/D5 re-target of the phase-130
|
||||
# timeline) — the read line carries the read document's path.
|
||||
tool_record = _last_brain(page).locator(".reasoning .tool-calls-disclosure")
|
||||
expect(tool_record).to_have_count(1)
|
||||
expect(tool_record.locator(".tool-call").last).to_contain_text(TEXT_SP)
|
||||
|
||||
# The clusters + the actions row's contents (all three buttons —
|
||||
# admin, docs repo configured) + nothing after the actions row.
|
||||
@@ -817,7 +830,9 @@ def test_image_without_chip_keeps_its_citation_via_figure(
|
||||
img = page.locator("#doc-modal .doc-image-img")
|
||||
expect(img).to_have_count(1)
|
||||
expect(img).to_have_attribute("src", seeded["image_url"])
|
||||
expect(page.locator("#doc-modal pre.doc-raw")).to_have_text(
|
||||
# Phase 165: the description renders in the wrapping .doc-prose
|
||||
# block (an image description is prose — no scrolling pre).
|
||||
expect(page.locator("#doc-modal .doc-prose")).to_have_text(
|
||||
seeded["description"]
|
||||
)
|
||||
page.keyboard.press("Escape") # the phase-26 close affordance
|
||||
@@ -877,10 +892,15 @@ def test_restore_renders_the_same_clusters(
|
||||
expect(restored).to_contain_text(READ_ANSWER_PREFIX, timeout=SETTLE_TIMEOUT_MS)
|
||||
|
||||
# The IDENTICAL structure (the restore renders through the same
|
||||
# appenders — the child sequence is the live one, exactly).
|
||||
# appenders — the child sequence is the live one, exactly) — the
|
||||
# segments path re-renders the reasoning container with the tool
|
||||
# record inside (phase 161 D4).
|
||||
assert _body_child_classes(page) == EXPECTED_CHILD_CLASSES == live_children, (
|
||||
_body_child_classes(page)
|
||||
)
|
||||
tool_record = _last_brain(page).locator(".reasoning .tool-calls-disclosure")
|
||||
expect(tool_record).to_have_count(1)
|
||||
expect(tool_record.locator(".tool-call").last).to_contain_text(TEXT_SP)
|
||||
_assert_cluster_rows(
|
||||
page, seeded,
|
||||
action_buttons=["tune-btn", "retry-btn", "save-as-doc-btn"],
|
||||
|
||||
Reference in New Issue
Block a user