phase: 119_name_signal_read_chips
All verification complete. Final report: **Phase 119 final verification pass — all criteria verified, one stale pin fixed.** - Verified implementation of all 6 tasks: D1 component name-hit rule (`name_hit` flag, titles never matched, retired length tie-break), D2 `BOR_NAME_HIT_BONUS` (0.005 default, 0 = byte-identical kill switch, negative fails startup, selection-layer only, `eval_retrieval` `suggested:` line), D3 suggested-folder lines (after `SUGGEST_INTRO`, before first block), D4 cite-discipline `SUGGEST_INTRO` sentence (PERSONA/LOW/`TOOLS_SECTION` byte-pins intact), D5 `done.sources` = read docs only (frontend no-op on empty confirmed), D6 mock `repeat your folder map` echo + new suite + telemetry. - Battery (replica restored per skill, fingerprint docs=1000/chunks=8866 verified, `eval_retrieval --from-file tests/fixtures/retrieval_battery.txt` re-run): **GATE PASS** — gitea README #4 in suggested top-5, forgejo 5/5 (README #1), gateway README in top-5 (#4), qwen3.8-27b quadlets top-5, Mongolia HIGH/fts=5 unchanged. - New E2E in isolation: `4 passed` ×2 (deterministic). All 27 modified E2E suites in isolation: 26 green; **1 stale pin fixed** — `test_source_chip_quality.py` durable-record order pin pre-dated the D1 re-rank (`aliases` stem sub-component name-hits `ssh_aliases.txt`, deterministically lifting `backups.md` over `kubernetes.md`; probe-verified 0.016277 vs 0.016036, 4/4 stable) — re-pinned with the phase-119 rationale; suite green ×2. - Gates: `uv run pytest --cov=app --cov-report=term-missing` → **2547 passed, app coverage 99%** (>90%); `uv run ruff check .` → All checks passed; `uv run pyright` → 0 errors. - Completion criteria: 1 ✅ (battery, recorded), 2 ✅ (folder lines; block/LOW byte-identical pins green), 3 ✅ (read-only chips, zero-read chips nothing, related row + durable record untouched — unit+E2E agree), 4 ✅ (all green), 5 → commit/phase-move left to the harness per pass rules (nothing committed). - Deviations: battery output + real-model telemetry recorded in `.agents/reports/119_name_signal_read_chips/task06_battery_and_e2e.md` and `TOOL_CALLING_TESTING.md` §11 (task files in `complete/` are immutable to this pass); gateway canonical doc at #4 vs overview's #3 was already documented at task 06 (containment gate met). - Next pending phase: **none** — `todo/` holds only phase 119.
This commit is contained in:
@@ -23,10 +23,12 @@ assistant message — A4).
|
||||
|
||||
The marker is checked BEFORE the mock's ``DEFLECT_MODE`` branch, so
|
||||
the echo fires on BOTH turn branches — the branch under test is
|
||||
discriminated separately (the grounded source chip / the
|
||||
``is-deflected`` bubble class). The echo answers carry no tool
|
||||
markup, so no marker tool flow is re-triggered by the now-always-
|
||||
present (user/assistant-only) history.
|
||||
discriminated separately (the persisted record's ``deflected`` flag /
|
||||
the ``is-deflected`` bubble class — phase 119, LOCKED A1: a zero-read
|
||||
grounded turn chips nothing, so the retired chip discriminator is
|
||||
gone). The echo answers carry no tool markup, so no marker tool flow
|
||||
is re-triggered by the now-always-present (user/assistant-only)
|
||||
history.
|
||||
|
||||
The file name deliberately differs from phase 50's
|
||||
``test_chat_history.py`` (save & view chat history — a different
|
||||
@@ -170,12 +172,15 @@ def test_followup_receives_history_and_thinking(
|
||||
expect(bubble).to_contain_text(f"last answer tail: {answer_tail}")
|
||||
expect(bubble).to_contain_text("thinking: yes")
|
||||
# Grounded proof — the echo fires in BOTH branches, so the branch
|
||||
# is discriminated by the kubernetes.md source chip (the deflected
|
||||
# turn carries no cited sources). Scoped to the LAST brain message:
|
||||
# turn 1 cited kubernetes.md too.
|
||||
# is discriminated by the persisted record's ``deflected`` flag
|
||||
# (phase 119, LOCKED A1: the turn read nothing, so it also chips
|
||||
# nothing — the retired chip discriminator is gone).
|
||||
brain2 = _wait_record(page, 4)["messages"][3]
|
||||
assert brain2["who"] == "brain"
|
||||
assert brain2["deflected"] is False, "the echo turn must be the grounded branch"
|
||||
expect(
|
||||
page.locator(".msg.brain").last.locator(".source-chip", has_text="kubernetes.md")
|
||||
).to_have_count(1)
|
||||
page.locator(".msg.brain").last.locator(".source-chip")
|
||||
).to_have_count(0)
|
||||
|
||||
|
||||
def test_first_question_has_no_history(
|
||||
@@ -194,11 +199,15 @@ def test_first_question_has_no_history(
|
||||
expect(bubble).to_contain_text("history: 0 prior messages", timeout=30_000)
|
||||
expect(bubble).to_contain_text("last answer tail: none")
|
||||
expect(bubble).to_contain_text("thinking: no")
|
||||
# Grounded: the echo question is on-topic (the chip proves the
|
||||
# HIGH gate, not a deflection).
|
||||
# Grounded: the echo question is on-topic (the record's deflected
|
||||
# flag proves the HIGH gate, not a deflection — phase 119, LOCKED
|
||||
# A1: the zero-read turn chips nothing, so the retired chip
|
||||
# discriminator is gone).
|
||||
record = _wait_record(page, 2)
|
||||
assert record["messages"][1]["deflected"] is False
|
||||
expect(
|
||||
page.locator(".msg.brain").last.locator(".source-chip", has_text="kubernetes.md")
|
||||
).to_have_count(1)
|
||||
page.locator(".msg.brain").last.locator(".source-chip")
|
||||
).to_have_count(0)
|
||||
|
||||
|
||||
def test_deflected_followup_receives_history(
|
||||
|
||||
Reference in New Issue
Block a user