phase: 119_name_signal_read_chips
All verification complete. Final report: **Phase 119 final verification pass — all criteria verified, one stale pin fixed.** - Verified implementation of all 6 tasks: D1 component name-hit rule (`name_hit` flag, titles never matched, retired length tie-break), D2 `BOR_NAME_HIT_BONUS` (0.005 default, 0 = byte-identical kill switch, negative fails startup, selection-layer only, `eval_retrieval` `suggested:` line), D3 suggested-folder lines (after `SUGGEST_INTRO`, before first block), D4 cite-discipline `SUGGEST_INTRO` sentence (PERSONA/LOW/`TOOLS_SECTION` byte-pins intact), D5 `done.sources` = read docs only (frontend no-op on empty confirmed), D6 mock `repeat your folder map` echo + new suite + telemetry. - Battery (replica restored per skill, fingerprint docs=1000/chunks=8866 verified, `eval_retrieval --from-file tests/fixtures/retrieval_battery.txt` re-run): **GATE PASS** — gitea README #4 in suggested top-5, forgejo 5/5 (README #1), gateway README in top-5 (#4), qwen3.8-27b quadlets top-5, Mongolia HIGH/fts=5 unchanged. - New E2E in isolation: `4 passed` ×2 (deterministic). All 27 modified E2E suites in isolation: 26 green; **1 stale pin fixed** — `test_source_chip_quality.py` durable-record order pin pre-dated the D1 re-rank (`aliases` stem sub-component name-hits `ssh_aliases.txt`, deterministically lifting `backups.md` over `kubernetes.md`; probe-verified 0.016277 vs 0.016036, 4/4 stable) — re-pinned with the phase-119 rationale; suite green ×2. - Gates: `uv run pytest --cov=app --cov-report=term-missing` → **2547 passed, app coverage 99%** (>90%); `uv run ruff check .` → All checks passed; `uv run pyright` → 0 errors. - Completion criteria: 1 ✅ (battery, recorded), 2 ✅ (folder lines; block/LOW byte-identical pins green), 3 ✅ (read-only chips, zero-read chips nothing, related row + durable record untouched — unit+E2E agree), 4 ✅ (all green), 5 → commit/phase-move left to the harness per pass rules (nothing committed). - Deviations: battery output + real-model telemetry recorded in `.agents/reports/119_name_signal_read_chips/task06_battery_and_e2e.md` and `TOOL_CALLING_TESTING.md` §11 (task files in `complete/` are immutable to this pass); gateway canonical doc at #4 vs overview's #3 was already documented at task 06 (containment gate met). - Next pending phase: **none** — `todo/` holds only phase 119.
This commit is contained in:
@@ -11,9 +11,18 @@ deterministic mock embeddings (same harness as the phase-10 suite — only
|
||||
the assertions changed: chips/row links now open the SAME-PAGE modal,
|
||||
no ``expect_popup``).
|
||||
|
||||
Phase 119 re-target (LOCKED A1): chips cite READ docs only — a plain
|
||||
question chips nothing, so the chat-driven tests here run the
|
||||
mock's scripted summary-read flow (``SUMMARY_SEED_READ_TRIGGER`` —
|
||||
the house scripted-turn convention): the turn ``read``s
|
||||
``docs/homelab/kubernetes.md``, whose read result is what earns the
|
||||
kubernetes.md chip the story interacts with (the chip's viewer-link
|
||||
contract is unchanged).
|
||||
|
||||
Test → story mapping (Playwright Mapping Rule):
|
||||
1. ``test_source_chip_opens_modal`` — chat chip → modal opens in-page
|
||||
(NO new tab, URL unchanged), title + ``.doc-md`` content + meta row.
|
||||
1. ``test_source_chip_opens_modal`` — chat chip (the turn's READ doc —
|
||||
phase 119 A1) → modal opens in-page (NO new tab, URL unchanged),
|
||||
title + ``.doc-md`` content + meta row.
|
||||
2. ``test_sources_row_opens_modal`` — Sources path link → modal, yaml in
|
||||
``<pre.doc-raw>``, mono font, URL unchanged.
|
||||
3. ``test_modal_closes_on_button_escape_and_backdrop`` — close via
|
||||
@@ -56,7 +65,14 @@ from e2e.auth_helpers import login
|
||||
REPO = Path(__file__).resolve().parents[2]
|
||||
FIXTURES = REPO / "tests" / "fixtures" / "docs"
|
||||
SCREENSHOTS = REPO / ".agents" / "screenshots" # house convention for visual records
|
||||
QUESTION = "How is my Kubernetes cluster set up?"
|
||||
# Phase 119 (LOCKED A1): the chip is the turn's READ doc — the scripted
|
||||
# summary-read flow (mock_llm.SUMMARY_SEED_READ_TRIGGER) reads the
|
||||
# kubernetes fixture so the story's chip exists (the retired phase-118
|
||||
# A4 suggested-chip is gone: a zero-read turn would chip nothing).
|
||||
QUESTION = (
|
||||
"Read the suggested document: read docs/homelab/kubernetes.md — "
|
||||
"how is my Kubernetes cluster set up?"
|
||||
)
|
||||
|
||||
|
||||
async def _import_fixtures(mock_port: int) -> ImportSummary:
|
||||
@@ -98,12 +114,20 @@ def _reset_db(mock_port: int, seed: bool) -> ImportSummary | None:
|
||||
|
||||
|
||||
def _ask_for_chip(page: Page, app_url: str) -> Any:
|
||||
"""Drive one chat turn and return the kubernetes.md source chip."""
|
||||
"""Drive one chat turn and return the kubernetes.md source chip.
|
||||
|
||||
The scripted summary-read flow (phase 119, LOCKED A1): the turn
|
||||
``read``s the kubernetes doc, so it is the turn's ONLY citation
|
||||
chip (chips cite read docs only — the answer is the mock's
|
||||
verbatim echo of the read result)."""
|
||||
login(page, app_url, next="/") # phase 79: chat is require_user-gated
|
||||
page.fill("#message-input", QUESTION)
|
||||
page.click("#send-btn")
|
||||
chip = page.locator(".msg.brain .source-chip", has_text="kubernetes.md")
|
||||
expect(chip).to_have_count(1, timeout=30_000)
|
||||
# Phase 119 A1: the read doc is the turn's ONLY chip (exactly one
|
||||
# .source-chip under the bubble — nothing suggested-but-unread).
|
||||
expect(page.locator(".msg.brain .source-chip")).to_have_count(1)
|
||||
return chip
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user