phase: 119_name_signal_read_chips
All verification complete. Final report: **Phase 119 final verification pass — all criteria verified, one stale pin fixed.** - Verified implementation of all 6 tasks: D1 component name-hit rule (`name_hit` flag, titles never matched, retired length tie-break), D2 `BOR_NAME_HIT_BONUS` (0.005 default, 0 = byte-identical kill switch, negative fails startup, selection-layer only, `eval_retrieval` `suggested:` line), D3 suggested-folder lines (after `SUGGEST_INTRO`, before first block), D4 cite-discipline `SUGGEST_INTRO` sentence (PERSONA/LOW/`TOOLS_SECTION` byte-pins intact), D5 `done.sources` = read docs only (frontend no-op on empty confirmed), D6 mock `repeat your folder map` echo + new suite + telemetry. - Battery (replica restored per skill, fingerprint docs=1000/chunks=8866 verified, `eval_retrieval --from-file tests/fixtures/retrieval_battery.txt` re-run): **GATE PASS** — gitea README #4 in suggested top-5, forgejo 5/5 (README #1), gateway README in top-5 (#4), qwen3.8-27b quadlets top-5, Mongolia HIGH/fts=5 unchanged. - New E2E in isolation: `4 passed` ×2 (deterministic). All 27 modified E2E suites in isolation: 26 green; **1 stale pin fixed** — `test_source_chip_quality.py` durable-record order pin pre-dated the D1 re-rank (`aliases` stem sub-component name-hits `ssh_aliases.txt`, deterministically lifting `backups.md` over `kubernetes.md`; probe-verified 0.016277 vs 0.016036, 4/4 stable) — re-pinned with the phase-119 rationale; suite green ×2. - Gates: `uv run pytest --cov=app --cov-report=term-missing` → **2547 passed, app coverage 99%** (>90%); `uv run ruff check .` → All checks passed; `uv run pyright` → 0 errors. - Completion criteria: 1 ✅ (battery, recorded), 2 ✅ (folder lines; block/LOW byte-identical pins green), 3 ✅ (read-only chips, zero-read chips nothing, related row + durable record untouched — unit+E2E agree), 4 ✅ (all green), 5 → commit/phase-move left to the harness per pass rules (nothing committed). - Deviations: battery output + real-model telemetry recorded in `.agents/reports/119_name_signal_read_chips/task06_battery_and_e2e.md` and `TOOL_CALLING_TESTING.md` §11 (task files in `complete/` are immutable to this pass); gateway canonical doc at #4 vs overview's #3 was already documented at task 06 (containment gate met). - Next pending phase: **none** — `todo/` holds only phase 119.
This commit is contained in:
@@ -171,8 +171,9 @@ def test_summary_hit_seeds_the_summary_not_the_full_text(
|
||||
quotes the last suggested doc's summary tail (digest + pointer), and
|
||||
the sentinel (the yaml doc's last line, outside the digest) is
|
||||
ABSENT: the full source doc never reached the prompt (A6). Both
|
||||
fixture docs are suggested (two-doc KB, no floor) and both chips
|
||||
render (deflected: false)."""
|
||||
fixture docs are suggested (two-doc KB, no floor) but chip
|
||||
NOTHING — the turn read nothing, so (phase 119, LOCKED A1) the
|
||||
citation surface is empty (deflected: false)."""
|
||||
_reset_db()
|
||||
summary = _run_in_thread(_import_fixtures(mock_llm))
|
||||
assert summary.added == 2 # yaml + md control
|
||||
@@ -225,13 +226,13 @@ def test_summary_hit_seeds_the_summary_not_the_full_text(
|
||||
expect(bubble).to_contain_text(yaml_digest_line[-80:])
|
||||
expect(bubble).not_to_contain_text(SENTINEL)
|
||||
|
||||
# Grounded: both fixture docs are suggested (two-doc KB — no floor)
|
||||
# and both chips render, in rank order (md first, yaml last).
|
||||
chip = page.locator(".msg.brain .source-chip", has_text=YAML_PATH)
|
||||
expect(chip).to_have_count(1)
|
||||
expect(chip.first).to_contain_text(f"{SOURCE}/{YAML_PATH}")
|
||||
expect(page.locator(".msg.brain .source-chip", has_text=MD_PATH)).to_have_count(1)
|
||||
expect(page.locator(".msg.brain .source-chip")).to_have_count(2)
|
||||
# Phase 119 (LOCKED A1): the turn read nothing, so ZERO citation
|
||||
# chips — both fixture docs are suggested (two-doc KB — no floor,
|
||||
# md first, yaml last) but suggested docs are seed context, not
|
||||
# citations (the retired phase-118 A4 suggested-chip union is gone);
|
||||
# their rank order is pinned by the durable record below (LOCKED
|
||||
# A3, untouched).
|
||||
expect(page.locator(".msg.brain .source-chip")).to_have_count(0)
|
||||
# No rank-6+ doc in a two-doc KB → the related row is absent.
|
||||
expect(page.locator(".msg.brain .related-docs")).to_have_count(0)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user