phase: 119_name_signal_read_chips
All verification complete. Final report: **Phase 119 final verification pass — all criteria verified, one stale pin fixed.** - Verified implementation of all 6 tasks: D1 component name-hit rule (`name_hit` flag, titles never matched, retired length tie-break), D2 `BOR_NAME_HIT_BONUS` (0.005 default, 0 = byte-identical kill switch, negative fails startup, selection-layer only, `eval_retrieval` `suggested:` line), D3 suggested-folder lines (after `SUGGEST_INTRO`, before first block), D4 cite-discipline `SUGGEST_INTRO` sentence (PERSONA/LOW/`TOOLS_SECTION` byte-pins intact), D5 `done.sources` = read docs only (frontend no-op on empty confirmed), D6 mock `repeat your folder map` echo + new suite + telemetry. - Battery (replica restored per skill, fingerprint docs=1000/chunks=8866 verified, `eval_retrieval --from-file tests/fixtures/retrieval_battery.txt` re-run): **GATE PASS** — gitea README #4 in suggested top-5, forgejo 5/5 (README #1), gateway README in top-5 (#4), qwen3.8-27b quadlets top-5, Mongolia HIGH/fts=5 unchanged. - New E2E in isolation: `4 passed` ×2 (deterministic). All 27 modified E2E suites in isolation: 26 green; **1 stale pin fixed** — `test_source_chip_quality.py` durable-record order pin pre-dated the D1 re-rank (`aliases` stem sub-component name-hits `ssh_aliases.txt`, deterministically lifting `backups.md` over `kubernetes.md`; probe-verified 0.016277 vs 0.016036, 4/4 stable) — re-pinned with the phase-119 rationale; suite green ×2. - Gates: `uv run pytest --cov=app --cov-report=term-missing` → **2547 passed, app coverage 99%** (>90%); `uv run ruff check .` → All checks passed; `uv run pyright` → 0 errors. - Completion criteria: 1 ✅ (battery, recorded), 2 ✅ (folder lines; block/LOW byte-identical pins green), 3 ✅ (read-only chips, zero-read chips nothing, related row + durable record untouched — unit+E2E agree), 4 ✅ (all green), 5 → commit/phase-move left to the harness per pass rules (nothing committed). - Deviations: battery output + real-model telemetry recorded in `.agents/reports/119_name_signal_read_chips/task06_battery_and_e2e.md` and `TOOL_CALLING_TESTING.md` §11 (task files in `complete/` are immutable to this pass); gateway canonical doc at #4 vs overview's #3 was already documented at task 06 (containment gate met). - Next pending phase: **none** — `todo/` holds only phase 119.
This commit is contained in:
@@ -42,9 +42,6 @@ OFF_TOPIC = "How do I bake sourdough bread?"
|
||||
MOCK_ANSWER_MARKER = "Deterministic mock answer for E2E"
|
||||
DEFLECT_PHRASE = r"haven't done anything like that"
|
||||
STORAGE_KEY = "bor.chat.v1"
|
||||
#: Phase 10 viewer URL + phase 13 back=/ (the restored chip must be
|
||||
#: byte-identical to the live-rendered one).
|
||||
CHIP_HREF = "/document.html?source=docs&path=homelab%2Fkubernetes.md&back=%2F"
|
||||
|
||||
|
||||
async def _import_fixtures(mock_port: int) -> ImportSummary:
|
||||
@@ -143,22 +140,24 @@ def test_conversation_survives_reload(
|
||||
assert MOCK_ANSWER_MARKER in brain["text"]
|
||||
assert "<" not in brain["text"], "persisted brain text must be raw, not rendered HTML"
|
||||
assert brain["deflected"] is False
|
||||
assert any(s["path"] == "homelab/kubernetes.md" for s in brain["sources"])
|
||||
# Phase 119 (LOCKED A1): the turn read nothing, so its done sources
|
||||
# — and the persisted record — are EMPTY (the suggested kubernetes
|
||||
# doc is context, not a citation; the retired phase-118 A4 union is
|
||||
# gone).
|
||||
|
||||
# Refresh — the same context keeps its localStorage.
|
||||
page.reload()
|
||||
expect(page.locator("#empty-state")).to_be_hidden()
|
||||
|
||||
# Both bubbles restored: text + the source chip with the exact viewer URL.
|
||||
# Both bubbles restored: the answer text, and ZERO citation chips
|
||||
# (the zero-read turn persisted an empty sources list — phase 119,
|
||||
# LOCKED A1; the retired phase-118 A4 chip pin is gone).
|
||||
expect(page.locator(".msg.user .bubble")).to_have_count(1)
|
||||
expect(page.locator(".msg.user .bubble")).to_contain_text(QUESTION)
|
||||
bubble = page.locator(".msg.brain .bubble")
|
||||
expect(bubble).to_have_count(1)
|
||||
expect(bubble).to_contain_text(MOCK_ANSWER_MARKER)
|
||||
chip = page.locator(".msg.brain .source-chip", has_text="kubernetes.md")
|
||||
expect(chip).to_have_count(1)
|
||||
expect(chip.first).to_have_attribute("href", CHIP_HREF)
|
||||
expect(chip.first).not_to_have_attribute("target") # phase 26: modal, not a new tab
|
||||
expect(page.locator(".msg.brain .source-chip")).to_have_count(0)
|
||||
|
||||
# The restore is read-only: storage still holds the same two messages.
|
||||
assert [m["who"] for m in _stored_parsed(page)["messages"]] == ["user", "brain"]
|
||||
@@ -294,7 +293,9 @@ def test_persists_across_page_navigation(
|
||||
expect(page.locator(".msg.user .bubble").first).to_contain_text(QUESTION)
|
||||
expect(page.locator(".msg.user .bubble").nth(1)).to_contain_text(OFF_TOPIC)
|
||||
expect(page.locator(".msg.brain .bubble").first).to_contain_text(MOCK_ANSWER_MARKER)
|
||||
expect(page.locator(".msg.brain .source-chip", has_text="kubernetes.md")).to_have_count(1)
|
||||
# Zero citation chips (phase 119, LOCKED A1 — the grounded turn read
|
||||
# nothing; the retired phase-118 A4 union is gone).
|
||||
expect(page.locator(".msg.brain .source-chip")).to_have_count(0)
|
||||
deflected = page.locator(".msg.brain.is-deflected .bubble")
|
||||
expect(deflected).to_have_count(1)
|
||||
expect(deflected.first).to_contain_text(re.compile(DEFLECT_PHRASE, re.IGNORECASE))
|
||||
|
||||
Reference in New Issue
Block a user