phase: 119_name_signal_read_chips
All verification complete. Final report: **Phase 119 final verification pass — all criteria verified, one stale pin fixed.** - Verified implementation of all 6 tasks: D1 component name-hit rule (`name_hit` flag, titles never matched, retired length tie-break), D2 `BOR_NAME_HIT_BONUS` (0.005 default, 0 = byte-identical kill switch, negative fails startup, selection-layer only, `eval_retrieval` `suggested:` line), D3 suggested-folder lines (after `SUGGEST_INTRO`, before first block), D4 cite-discipline `SUGGEST_INTRO` sentence (PERSONA/LOW/`TOOLS_SECTION` byte-pins intact), D5 `done.sources` = read docs only (frontend no-op on empty confirmed), D6 mock `repeat your folder map` echo + new suite + telemetry. - Battery (replica restored per skill, fingerprint docs=1000/chunks=8866 verified, `eval_retrieval --from-file tests/fixtures/retrieval_battery.txt` re-run): **GATE PASS** — gitea README #4 in suggested top-5, forgejo 5/5 (README #1), gateway README in top-5 (#4), qwen3.8-27b quadlets top-5, Mongolia HIGH/fts=5 unchanged. - New E2E in isolation: `4 passed` ×2 (deterministic). All 27 modified E2E suites in isolation: 26 green; **1 stale pin fixed** — `test_source_chip_quality.py` durable-record order pin pre-dated the D1 re-rank (`aliases` stem sub-component name-hits `ssh_aliases.txt`, deterministically lifting `backups.md` over `kubernetes.md`; probe-verified 0.016277 vs 0.016036, 4/4 stable) — re-pinned with the phase-119 rationale; suite green ×2. - Gates: `uv run pytest --cov=app --cov-report=term-missing` → **2547 passed, app coverage 99%** (>90%); `uv run ruff check .` → All checks passed; `uv run pyright` → 0 errors. - Completion criteria: 1 ✅ (battery, recorded), 2 ✅ (folder lines; block/LOW byte-identical pins green), 3 ✅ (read-only chips, zero-read chips nothing, related row + durable record untouched — unit+E2E agree), 4 ✅ (all green), 5 → commit/phase-move left to the harness per pass rules (nothing committed). - Deviations: battery output + real-model telemetry recorded in `.agents/reports/119_name_signal_read_chips/task06_battery_and_e2e.md` and `TOOL_CALLING_TESTING.md` §11 (task files in `complete/` are immutable to this pass); gateway canonical doc at #4 vs overview's #3 was already documented at task 06 (containment gate met). - Next pending phase: **none** — `todo/` holds only phase 119.
This commit is contained in:
@@ -391,8 +391,11 @@ def test_admin_generates_token_in_ui(page: Page, app_url: str, db_ready: None) -
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# 4. The token flow: a fresh context signs in through the real gate
|
||||
# and USES the app — a grounded chat turn (mock LLM), a cited
|
||||
# document opened in the same-page modal, the role-user header
|
||||
# and USES the app — a grounded chat turn (mock LLM; phase 119,
|
||||
# LOCKED A1: the turn is the scripted summary-read flow — chips
|
||||
# cite READ docs only, and this turn's read earns the cited chip),
|
||||
# a cited document opened in the same-page modal, the role-user
|
||||
# header
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
@@ -417,15 +420,27 @@ def test_token_user_uses_the_app(
|
||||
# task-04 helper: fill #auth-gate-input → submit → gate hides).
|
||||
login_with_token(user, app_url, token)
|
||||
|
||||
# Use the app: a grounded turn against the seeded KB (mock
|
||||
# LLM) — the brain bubble renders the deterministic answer.
|
||||
_ask(user, "How is my Kubernetes cluster set up? (api-tokens-flow)")
|
||||
# Use the app: a GROUNDED turn against the seeded KB (mock
|
||||
# LLM). Phase 119 (LOCKED A1): chips cite READ docs only — a
|
||||
# plain question would chip nothing (the retired phase-118 A4
|
||||
# union is gone), so the turn is the mock's scripted
|
||||
# summary-read flow (SUMMARY_SEED_READ_TRIGGER): it reads the
|
||||
# kubernetes fixture, and that read is the chip's source.
|
||||
q = (
|
||||
"Read the suggested document: read docs/homelab/kubernetes.md — "
|
||||
"how is my Kubernetes cluster set up? (api-tokens-flow)"
|
||||
)
|
||||
user.fill("#message-input", q)
|
||||
user.click("#send-btn")
|
||||
expect(user.locator(".msg.user .bubble").last).to_contain_text(q)
|
||||
|
||||
# A cited source chip opens the document in the SAME-PAGE
|
||||
# modal (the require_user content endpoint passes for a
|
||||
# live token session).
|
||||
# The turn's cited source chip (its one READ doc — the scripted
|
||||
# read, phase 119 A1) opens the document in the SAME-PAGE modal
|
||||
# (the require_user content endpoint passes for a live token
|
||||
# session).
|
||||
chip = user.locator(".msg.brain a.source-chip").first
|
||||
expect(chip).to_be_visible(timeout=15_000)
|
||||
expect(chip).to_be_visible(timeout=30_000)
|
||||
expect(user.locator("#send-label")).to_have_text("Send")
|
||||
chip.click()
|
||||
expect(user.locator("#doc-modal")).to_be_visible()
|
||||
expect(
|
||||
|
||||
Reference in New Issue
Block a user