phase: 119_name_signal_read_chips
All verification complete. Final report: **Phase 119 final verification pass — all criteria verified, one stale pin fixed.** - Verified implementation of all 6 tasks: D1 component name-hit rule (`name_hit` flag, titles never matched, retired length tie-break), D2 `BOR_NAME_HIT_BONUS` (0.005 default, 0 = byte-identical kill switch, negative fails startup, selection-layer only, `eval_retrieval` `suggested:` line), D3 suggested-folder lines (after `SUGGEST_INTRO`, before first block), D4 cite-discipline `SUGGEST_INTRO` sentence (PERSONA/LOW/`TOOLS_SECTION` byte-pins intact), D5 `done.sources` = read docs only (frontend no-op on empty confirmed), D6 mock `repeat your folder map` echo + new suite + telemetry. - Battery (replica restored per skill, fingerprint docs=1000/chunks=8866 verified, `eval_retrieval --from-file tests/fixtures/retrieval_battery.txt` re-run): **GATE PASS** — gitea README #4 in suggested top-5, forgejo 5/5 (README #1), gateway README in top-5 (#4), qwen3.8-27b quadlets top-5, Mongolia HIGH/fts=5 unchanged. - New E2E in isolation: `4 passed` ×2 (deterministic). All 27 modified E2E suites in isolation: 26 green; **1 stale pin fixed** — `test_source_chip_quality.py` durable-record order pin pre-dated the D1 re-rank (`aliases` stem sub-component name-hits `ssh_aliases.txt`, deterministically lifting `backups.md` over `kubernetes.md`; probe-verified 0.016277 vs 0.016036, 4/4 stable) — re-pinned with the phase-119 rationale; suite green ×2. - Gates: `uv run pytest --cov=app --cov-report=term-missing` → **2547 passed, app coverage 99%** (>90%); `uv run ruff check .` → All checks passed; `uv run pyright` → 0 errors. - Completion criteria: 1 ✅ (battery, recorded), 2 ✅ (folder lines; block/LOW byte-identical pins green), 3 ✅ (read-only chips, zero-read chips nothing, related row + durable record untouched — unit+E2E agree), 4 ✅ (all green), 5 → commit/phase-move left to the harness per pass rules (nothing committed). - Deviations: battery output + real-model telemetry recorded in `.agents/reports/119_name_signal_read_chips/task06_battery_and_e2e.md` and `TOOL_CALLING_TESTING.md` §11 (task files in `complete/` are immutable to this pass); gateway canonical doc at #4 vs overview's #3 was already documented at task 06 (containment gate met). - Next pending phase: **none** — `todo/` holds only phase 119.
This commit is contained in:
@@ -292,6 +292,24 @@ class Settings(BaseSettings):
|
||||
#: of document age (full weight at age 0, ``weight/e`` at one
|
||||
#: half-life). ``<= 0`` fails startup loudly (same validator family).
|
||||
recency_half_life_days: int = 365
|
||||
#: Bounded name-hit bonus on the SELECTION-time document score
|
||||
#: (phase 119, D2, LOCKED A3): the selection walks
|
||||
#: (``select_suggested`` / ``select_related`` / ``weak_hit_titles``
|
||||
#: in ``app.rag.retriever``) add this to a document's best fused
|
||||
#: chunk score when any of its chunks is a NAME HIT (the document
|
||||
#: PATH matched a question name token under the D1 two-class rule)
|
||||
#: — a product-name question ("How do I deploy gitea?") lifts the
|
||||
#: product's own documents into the seeded suggestion tier. The
|
||||
#: phase-106 recency-boost precedent: additive, bounded, single
|
||||
#: apply site (the selection layer ONLY — chunk scores, ``fuse()``,
|
||||
#: ``retrieve()``, the A8 honesty gate, and ``query_log.top_score``
|
||||
#: are untouched), ``0`` = off (the pre-phase walk returns
|
||||
#: byte-identical — the kill switch); a negative value fails startup
|
||||
#: loudly. 0.005 ≈ a 2-4 rank head start on the k=60 RRF scale
|
||||
#: (rank 1 vs 5 in one list differs by ~0.0010) — an owner-tunable
|
||||
#: starting point, not a calibrated constant (the phase-119 battery
|
||||
#: records the realized margins).
|
||||
name_hit_bonus: float = 0.005
|
||||
|
||||
# --- Admin & sign-in (phase 16; A10 revised 2026-08-22) ---
|
||||
# Single-admin auth via a signed session cookie (Starlette
|
||||
@@ -546,6 +564,17 @@ class Settings(BaseSettings):
|
||||
raise ValueError("recency_half_life_days must be > 0 (days)")
|
||||
return v
|
||||
|
||||
@field_validator("name_hit_bonus")
|
||||
@classmethod
|
||||
def _name_hit_bonus_non_negative(cls, v: float) -> float:
|
||||
"""``0`` is the byte-identical kill switch (the pre-phase
|
||||
selection order) — a NEGATIVE bonus would demote name-hit
|
||||
documents, the exact opposite of D2 (the ``agent_max_rounds``
|
||||
pattern, phase 119)."""
|
||||
if v < 0:
|
||||
raise ValueError("name_hit_bonus must be >= 0 (0 = off)")
|
||||
return v
|
||||
|
||||
@field_validator("db_pool_size")
|
||||
@classmethod
|
||||
def _db_pool_size_positive(cls, v: int) -> int:
|
||||
|
||||
Reference in New Issue
Block a user