phase: 139_read_range_tool_lines
All verification is complete and green. Phase 139's three tasks (01–03) were already implemented in prior passes; this was the final verification pass, and every gate holds. ## Phase 139 — final verification report **Verified in working tree (no code changes needed):** - `readRangeSuffix` single-source-of-truth helper in `app.js` + byte-identical parity copy in `shared.js` (EN-dash ` (lines N–M)`, `(from line N)`, `(first N lines)`, `Number.isInteger(x) && x >= 1` guard mirroring the server's `_whole_line_number`) - `appendToolLine(wrap, name, argument, offset = null, limit = null)` — `<span class="read-range">` sibling after `<code>`, only when suffix non-empty; `shared.js` `addToolLines` parity - Live `tool` branch: guarded `ev.offset`/`ev.limit`, additive `toolAcc` records (non-range keeps pre-phase shape), status label carries the suffix (A2); restore path passes stored `t.offset`/`t.limit` through, phase-95 truncation note untouched - E2E: `SAME_FILE_TRIGGER` mock flow (same file read twice, offsets 10/20 then 40/15) + 3-test Playwright suite **Test / lint / coverage results:** - `uv run pytest` (unit + integration): **3283 passed, 9 skipped, 0 failed** - `uv run pytest --cov=app --cov-report=term-missing`: **TOTAL 99%** (>90% gate) - `uv run pytest tests/e2e/test_read_range_tool_lines.py -v --no-cov`: **3 passed** in isolation - `uv run ruff check .`: clean; `uv run pyright`: **0 errors, 0 warnings** **Completion criteria:** 1. Range read renders `(lines N–M)` live; two same-file reads show DIFFERENT ranges — ✅ (E2E test 1) 2. Plain read byte-identical; phase-87/117 pins + emoji guard pass unedited — ✅ (E2E test 2 + full suite) 3. Suffix survives save → restore on chat page + shared page — ✅ (E2E test 3) 4. Full suite green, coverage >90%, E2E isolated green, ruff + pyright clean — ✅ 5. Commit + phase move — left to the harness per executor rules (no `git add`/`commit` run) **Notable:** the missing pytest summary line on one run was a transient output-buffering artifact, confirmed by re-run; DB was already up and healthy. **Next pending phase:** `140_pictorial_pdf_pages`
This commit is contained in:
@@ -730,6 +730,9 @@ def test_truncated_read_save_and_shared_fidelity(
|
||||
detail = _get_chat(app_url, cookies, chat_id)
|
||||
brain_msgs = [m for m in detail["messages"] if m["who"] == "brain"]
|
||||
assert len(brain_msgs) == 1, detail["messages"]
|
||||
# The full CURRENT shape (phase 139: + the additive range
|
||||
# fields, null for a plain read — the mock's read is not a
|
||||
# range read, so the record carries no range).
|
||||
assert brain_msgs[0]["tools"] == [
|
||||
{
|
||||
"name": "read",
|
||||
@@ -737,6 +740,8 @@ def test_truncated_read_save_and_shared_fidelity(
|
||||
"truncated": True,
|
||||
"chars_shown": READ_CAP,
|
||||
"chars_total": CAP_DOC_TOTAL,
|
||||
"offset": None,
|
||||
"limit": None,
|
||||
}
|
||||
], brain_msgs[0]["tools"]
|
||||
|
||||
@@ -842,6 +847,11 @@ def test_short_read_control_no_frame_no_marker(
|
||||
"truncated": False,
|
||||
"chars_shown": None,
|
||||
"chars_total": None,
|
||||
# Phase 139: the additive range fields, null for a
|
||||
# plain read (the pre-phase 5-key shape still
|
||||
# validates — stored as nulls, rendered suffix-less).
|
||||
"offset": None,
|
||||
"limit": None,
|
||||
}
|
||||
], brain_msgs[0]["tools"]
|
||||
finally:
|
||||
|
||||
Reference in New Issue
Block a user