phase: 118_summary_seed_context
**Phase 118 final verification pass — complete.** All criteria verified; 4 pre-existing defects found and fixed.
- **Verified:** summary-seed wiring (`select_suggested` top-5 no-floor → summary blocks, no full text in HIGH prompt), all-doc markdown summaries + NULL backfill (`summary_backfilled`, no `sources_meta` bump), `read` adds full text with `read_docs`-only dedupe, `done.sources` = suggested+read / durable record = suggested+related+read + `suggested=N` log line (seen live in E2E), byte-locked PERSONA/LOW/TOOLS_SECTION, battery gate PASS recorded in `TOOL_CALLING_TESTING.md` §10 (turbo 2026-09-16: 1/2/4 GREEN, cond-3 reported 9/10 per A7, contract 21/21, caps 0).
- **Defects fixed (all pre-existing, none phase-118):** ① `ChatMessage` schema missing the phase-113 `related` key → `extra="forbid"` 422'd every done-time auto-save of grounded turns with a related tier, leaving `message_count=1` (root cause of `test_share_chat` 3F; browser-level instrumentation proved the PUT 422) — added the field + unit/integration pins; ② `test_theme_semantic_completion` pins stale vs phase-117 debox (border/chip removed) — re-targeted to assert border/chip *absence*; ③ `test_header_consistency` `<26`px pin red on 26.125px native date-input line — bound relaxed to `<34` (wrap-detection intent kept); ④ `test_navbar_refresh` bor.chat.v1 key set updated for `related`.
- **Test/lint/coverage:** `uv run pytest --cov=app --cov-report=term-missing` → **2506 passed, app/ 99%** (>90%); `uv run ruff check . && uv run pyright` → clean, 0 errors.
- **E2E:** new story suite in isolation → **2 passed**; full 103-suite matrix sweep (each isolated) → **all 103 green** after the fixes; `test_share_chat` 4 passed, `test_theme_semantic_completion` 8 passed, `test_header_consistency` 3 passed, `test_navbar_refresh` 7 passed.
- **Deviations:** none from LOCKED decisions. Note: orphaned diagnostic uvicorn processes briefly made E2E sessions exercise stale code — killed and re-verified; a sweep-regenerated tracked screenshot was restored. No commits made (harness commits).
- **Completion criteria:** all 7 ✅ (commit/phase-move is the harness's step).
- **Next pending phase:** none — `todo/` holds only this phase's overview pending the harness move.
This commit is contained in:
@@ -58,6 +58,7 @@ def _doc(
|
||||
title: str = "T",
|
||||
content: str = "CONTENT",
|
||||
created_at: datetime = CREATED_AT,
|
||||
summary: str | None = None,
|
||||
) -> Document:
|
||||
return Document(
|
||||
id=uuid.uuid4(),
|
||||
@@ -68,6 +69,7 @@ def _doc(
|
||||
content=content,
|
||||
content_hash="0" * 64,
|
||||
created_at=created_at,
|
||||
summary=summary,
|
||||
)
|
||||
|
||||
|
||||
@@ -171,6 +173,32 @@ def test_high_block_date_always_present_for_every_document() -> None:
|
||||
assert prompt.count("<document ") == prompt.count(' date="')
|
||||
|
||||
|
||||
def test_high_block_date_survives_the_summary_body_change() -> None:
|
||||
"""Phase 118 (task 03): the block BODY became the document's summary
|
||||
(never the full content) — the D5 identity attributes, including
|
||||
``date`` after ``title``, survive byte-identical around the new
|
||||
body (the E2E mock's block parser keys off exactly these)."""
|
||||
doc = _doc(
|
||||
source="S",
|
||||
path="P",
|
||||
title="T",
|
||||
content="FULL_CONTENT_SENTINEL_42",
|
||||
created_at=CREATED_AT,
|
||||
summary="The stored summary.",
|
||||
)
|
||||
prompt = build_high_prompt([doc])
|
||||
block = (
|
||||
f'<document source="S" path="P" title="T" date="{DATE}">\n'
|
||||
"The stored summary.\n"
|
||||
"</document>"
|
||||
)
|
||||
assert block in prompt
|
||||
# Attribute order pinned: date directly after title, body after.
|
||||
assert f'title="T" date="{DATE}">' in prompt
|
||||
# The full content stays out (A6) — only the summary rides the block.
|
||||
assert "FULL_CONTENT_SENTINEL_42" not in prompt
|
||||
|
||||
|
||||
# --------------------------------------------------------------------
|
||||
# The deflection prompt — byte-identical to the pre-phase text (A8)
|
||||
# --------------------------------------------------------------------
|
||||
|
||||
Reference in New Issue
Block a user