phase: 118_summary_seed_context
**Phase 118 final verification pass — complete.** All criteria verified; 4 pre-existing defects found and fixed.
- **Verified:** summary-seed wiring (`select_suggested` top-5 no-floor → summary blocks, no full text in HIGH prompt), all-doc markdown summaries + NULL backfill (`summary_backfilled`, no `sources_meta` bump), `read` adds full text with `read_docs`-only dedupe, `done.sources` = suggested+read / durable record = suggested+related+read + `suggested=N` log line (seen live in E2E), byte-locked PERSONA/LOW/TOOLS_SECTION, battery gate PASS recorded in `TOOL_CALLING_TESTING.md` §10 (turbo 2026-09-16: 1/2/4 GREEN, cond-3 reported 9/10 per A7, contract 21/21, caps 0).
- **Defects fixed (all pre-existing, none phase-118):** ① `ChatMessage` schema missing the phase-113 `related` key → `extra="forbid"` 422'd every done-time auto-save of grounded turns with a related tier, leaving `message_count=1` (root cause of `test_share_chat` 3F; browser-level instrumentation proved the PUT 422) — added the field + unit/integration pins; ② `test_theme_semantic_completion` pins stale vs phase-117 debox (border/chip removed) — re-targeted to assert border/chip *absence*; ③ `test_header_consistency` `<26`px pin red on 26.125px native date-input line — bound relaxed to `<34` (wrap-detection intent kept); ④ `test_navbar_refresh` bor.chat.v1 key set updated for `related`.
- **Test/lint/coverage:** `uv run pytest --cov=app --cov-report=term-missing` → **2506 passed, app/ 99%** (>90%); `uv run ruff check . && uv run pyright` → clean, 0 errors.
- **E2E:** new story suite in isolation → **2 passed**; full 103-suite matrix sweep (each isolated) → **all 103 green** after the fixes; `test_share_chat` 4 passed, `test_theme_semantic_completion` 8 passed, `test_header_consistency` 3 passed, `test_navbar_refresh` 7 passed.
- **Deviations:** none from LOCKED decisions. Note: orphaned diagnostic uvicorn processes briefly made E2E sessions exercise stale code — killed and re-verified; a sweep-regenerated tracked screenshot was restored. No commits made (harness commits).
- **Completion criteria:** all 7 ✅ (commit/phase-move is the harness's step).
- **Next pending phase:** none — `todo/` holds only this phase's overview pending the harness move.
This commit is contained in:
@@ -62,7 +62,8 @@ def test_hidden_paths_not_indexed_by_default(db: Session, tmp_path: Path) -> Non
|
||||
assert summary.files == 1
|
||||
assert summary.added == 1
|
||||
assert summary.errors == 0
|
||||
assert summary.summaries == 0
|
||||
# Phase 118 (A2): the one visible md IS summarized.
|
||||
assert summary.summaries == 1
|
||||
assert summary.summary_errors == 0
|
||||
|
||||
docs = db.scalars(select(Document)).all()
|
||||
@@ -73,8 +74,9 @@ def test_hidden_paths_not_indexed_by_default(db: Session, tmp_path: Path) -> Non
|
||||
for t in texts:
|
||||
assert "HIDDEN-MD-CONTENT" not in t and "HIDDEN-YAML-VALUE" not in t
|
||||
assert "EXCLUDED-CONTENT" not in t
|
||||
# The hidden yaml never reached the lite model.
|
||||
assert not llm.chat_calls
|
||||
# Only the visible md reached the lite model (phase 118, A2) — the
|
||||
# hidden files were never walked.
|
||||
assert len(llm.chat_calls) == 1
|
||||
_reset(db)
|
||||
|
||||
|
||||
@@ -105,14 +107,14 @@ def test_hidden_paths_indexed_when_flag_on(db: Session, tmp_path: Path) -> None:
|
||||
assert not any(d.path == ".venv/junk.md" for d in docs)
|
||||
chunks = db.scalars(select(Chunk)).all()
|
||||
assert not any("EXCLUDED-CONTENT" in c.content for c in chunks)
|
||||
# The hidden md was embedded like any visible md (no summary — the
|
||||
# markdown path skips the lite model).
|
||||
# The hidden md was embedded like any visible md — AND summarized
|
||||
# like any other doc (phase 118, A2: markdown included).
|
||||
note = db.scalar(select(Document).where(Document.path == ".hidden/note.md"))
|
||||
assert note is not None and note.summary is None
|
||||
assert note is not None and note.summary is not None
|
||||
assert any("HIDDEN-MD-CONTENT" in c.content for c in chunks)
|
||||
# The hidden yaml went through the FULL non-markdown path (phase 30):
|
||||
# a stored summary plus one embedded is_summary chunk on top of the
|
||||
# content chunks.
|
||||
# The hidden yaml went through the full doc path (phase 30): a stored
|
||||
# summary plus one embedded is_summary chunk on top of the content
|
||||
# chunks.
|
||||
yaml_doc = db.scalar(select(Document).where(Document.path == ".hidden/data.yaml"))
|
||||
assert yaml_doc is not None and yaml_doc.summary is not None
|
||||
yaml_chunks = [
|
||||
@@ -121,11 +123,16 @@ def test_hidden_paths_indexed_when_flag_on(db: Session, tmp_path: Path) -> None:
|
||||
assert any(c.is_summary for c in yaml_chunks)
|
||||
assert any(not c.is_summary for c in yaml_chunks)
|
||||
assert any("HIDDEN-YAML-VALUE" in c.content for c in yaml_chunks)
|
||||
# Only the yaml reached the lite model.
|
||||
assert summary.summaries == 1
|
||||
assert len(llm.chat_calls) == 1
|
||||
user = next(m["content"] for m in llm.chat_calls[0] if m["role"] == "user")
|
||||
assert "HIDDEN-YAML-VALUE" in user
|
||||
# EVERY doc reached the lite model (phase 118, A2: markdown too).
|
||||
assert summary.summaries == 3
|
||||
assert len(llm.chat_calls) == 3
|
||||
users = [
|
||||
next(m["content"] for m in msgs if m["role"] == "user")
|
||||
for msgs in llm.chat_calls
|
||||
]
|
||||
assert any("HIDDEN-YAML-VALUE" in u for u in users)
|
||||
assert any("HIDDEN-MD-CONTENT" in u for u in users)
|
||||
assert any("visible body" in u for u in users)
|
||||
_reset(db)
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user