phase: 140_pictorial_pdf_pages

Everything is verified green. Final report:

## Phase 140 final verification pass — report

- Verified all 4 tasks already complete (code in working tree, task files in `complete/`): `pictorial_pages` gate + 2 settings (`BOR_PDF_PICTORIAL`, `BOR_PDF_PICTORIAL_MIN_CHARS` + validator), `PICTORIAL_PAGE_MODE`/`describe_pdf_page` seam + `render_pdf_pages` page selector + mock branch, `_pictorial_pdf_pass` in `_index_pdf_file` with log-only counters, dedicated E2E. No code changes needed.
- Test results (exact commands):
  - `uv run pytest --cov=app --cov-report=term-missing` → **3320 passed, 11 skipped, 0 failed; TOTAL 99%** (>90% gate)
  - `uv run pytest tests/e2e/test_pictorial_pdf.py -v --no-cov` → **3 passed in isolation** (Playwright, mock-only)
  - Pre-existing suites unedited: `test_pdf_support.py` 6 passed; `test_garbage_pdf.py` 2 passed + 1 skipped (owner fixture); `test_pdf_image_context.py` 4 passed
  - `uv run ruff check .` → All checks passed; `uv run pyright` → 0 errors
- Completion criteria:
  1. IKEA tar import repro — pinned by 2 integration tests; **skipped loudly here** (`test_sources/ikea_instructions.tar` absent on this machine — verified repo-wide; same house convention as completed phase-133 HNB tests; runs real on the owner's machine). Equivalent logic fully covered by unit pins on synthetic IKEA-class (vector-drawn, zero-raster) PDFs.
  2. Chat grounded on described page — **green** (E2E test b: phrase-only-in-illustration question, PDF in `done.sources`, answer echoes the block)
  3. Clean-text no-op (zero vision calls) + garbage precedence pin — **green** (`test_zero_candidates_is_a_noop` unit; `test_garbage_pdf_with_pictorial_on_takes_the_fallback_not_the_pass` integration, verified alone)
  4. `BOR_PDF_PICTORIAL=0` byte-identical — **green** (unit pin on synthetic PDF; IKEA variant runs on owner's machine)
  5. Full gate + E2E isolation + pre-existing suites — **green** (above)
  6. ruff + pyright — **clean**
  7. Commit/phase-move — delegated to harness per run rules (left in working tree: 16 modified + 8 new files, uncommitted)
- Deviations: none beyond the expected owner-fixture skips (11, all pre-existing fixture-missing skips, including 2 IKEA).
- Next pending phase: **none** — `todo/` holds only 140; 139 is already complete.

tests/integration/test_pdf_hnb_guide_regression.py

@@ -360,7 +360,16 @@ def test_hnb_guide_imports_clean_through_the_real_pipeline(
         )
     ]
     assert len(multimodal_calls) >= 1, "the multimodal chat was never called"
-    assert len(llm.vision_texts) == len(image_docs), (
+    # Phase 140 (task 03): the default-ON pictorial pass ALSO runs on
+    # this fixture's sparse pages (the fake is seam-agnostic — the
+    # same canned reply) — so the pin counts only the EMBEDDED-IMAGE
+    # describe calls (the ``DESCRIBE_PROMPT``-headed text parts; the
+    # ``PICTORIAL_PAGE_MODE`` parts are the pass's own calls, covered
+    # by the phase-140 suites).
+    image_vision_texts = [
+        t for t in llm.vision_texts if t.startswith(DESCRIBE_PROMPT)
+    ]
+    assert len(image_vision_texts) == len(image_docs), (
         "one vision call per embedded image doc (no failures)"
     )
     # The locked prompt + the generalized prefix + the document context
@@ -372,7 +381,7 @@ def test_hnb_guide_imports_clean_through_the_real_pipeline(
         + _expected_context_block(PDF_REL, _page_of(img.path), page_texts)
         for img in image_docs
     )
-    assert Counter(llm.vision_texts) == expected_calls
+    assert Counter(image_vision_texts) == expected_calls
     assert summary.images_failed == 0
 
     # The added accounting (see the module docstring): the walked file