phase: 93_theme_semantic_completion

All verification is complete. Final report:

**Phase 93 — Theme semantic completion: FINAL VERIFICATION PASS — ALL GREEN**

- Verified full implementation in tree: migration `0016` (8 nullable semantic columns, applied at head), 17-var `BUILTIN_COLORS`/`COLOR_FIELDS`/`effective_settings`, API validation, `#view-theme` State-colors fieldset (17 pickers), `theme.js` FIELDS/PAIRS (5→8), `.page-head` surface panel (6 shell views + doc-edit + shared.html; login card / document sticky header audited as already-surfaced), mock_llm `content: None` fix
- Fixed 2 pre-existing defects (both fail identically on baseline `d4f38ad`, proven via worktree A/B): `test_nav_rename_sources` — expected nav tail missing the phase-91 "Theme" link; `test_stale_ui_copy` — now truncates `saved_chats` before/after (house `test_suggestion_chips` pattern) so the seed-chip contract is deterministic on the shared dev DB (owner's 22 saved chats triggered phase-80 last-3-questions)
- Tests: `uv run pytest --cov=app --cov-report=term-missing` → **1868 passed, app/ 99%** (>90% ✓); `uv run ruff check .` → clean; `uv run pyright` → **0 errors**
- E2E: dedicated `uv run pytest tests/e2e/test_theme_semantic_completion.py -v --no-cov` → **8/8 in isolation** (all-gray 17-color theme: zero residual color on saved-result/Stale/Revoked/Local/tool-call elements, text labels intact, gray heads non-transparent, pre-paint tag, Reset → byte-identical no-tag); 15 theme/header/nav/responsive suites green in isolation; full 85-file combined run: only the 2 fixed pre-existing failures + 1 combined-run artifact (`test_sync_upload_progress`, green in isolation)
- Completion criteria: (1) monochrome E2E ✓ (2) default byte-identical, no `#bor-theme` tag ✓ (3) all page heads on solid surface ✓ (4) suite/coverage/lint/E2E green ✓ (5) phases 01–92 no behavior change ✓ (6) commit left to harness per protocol
- Notable: cleaned stray uvicorn leftovers from prior implementation pass (owner's `--reload` dev server untouched); no deviations from the phase design
- Next pending phase: `94_ls_tree_drilldown`

tests/unit/test_models.py

@@ -22,10 +22,11 @@ def test_all_tables_registered() -> None:
 
 
 def test_ui_settings_single_row_nullable_contract() -> None:
-    """Phase 91 (9 identity colors after phase 92, task 01): the
+    """Phase 91 (9 identity colors after phase 92, task 01; the 8
+    semantic state colors after phase 93, task 01 — B3 revised): the
     single-row UI settings table — Integer PK ``id`` with the
     Python-side ``default=1`` (the row is always id 1), the 3 strings
-    VARCHAR(300) and the 9 identity colors VARCHAR(7), ALL nullable
+    VARCHAR(300) and the 17 palette colors VARCHAR(7), ALL nullable
     (NULL = default — B1: env value for the strings, the built-in
     palette for the colors)."""
     settings_table = Base.metadata.tables["ui_settings"]
@@ -33,6 +34,8 @@ def test_ui_settings_single_row_nullable_contract() -> None:
         "id", "app_name", "input_placeholder", "footer_text",
         "bg", "surface", "ink", "ink_soft", "line", "grid_line",
         "brand", "brand_soft", "brand_ink",
+        "ok_bg", "ok_ink", "err_bg", "err_ink", "err_line",
+        "accent_bg", "accent_ink", "accent_line",
     }
     pk = settings_table.c["id"]
     assert pk.primary_key is True, "ui_settings.id must be the PK"
@@ -42,7 +45,9 @@ def test_ui_settings_single_row_nullable_contract() -> None:
         assert col.nullable is True, f"{name} must be NULL (env default)"
         assert getattr(col.type, "length", None) == 300, f"{name} must be String(300)"
     for name in ("bg", "surface", "ink", "ink_soft", "line", "grid_line",
-                 "brand", "brand_soft", "brand_ink"):
+                 "brand", "brand_soft", "brand_ink",
+                 "ok_bg", "ok_ink", "err_bg", "err_ink", "err_line",
+                 "accent_bg", "accent_ink", "accent_line"):
         col = settings_table.c[name]
         assert col.nullable is True, f"{name} must be NULL (the built-in)"
         assert getattr(col.type, "length", None) == 7, f"{name} must be String(7) — #rrggbb"