phase: 93_theme_semantic_completion

All verification is complete. Final report:

**Phase 93 — Theme semantic completion: FINAL VERIFICATION PASS — ALL GREEN**

- Verified full implementation in tree: migration `0016` (8 nullable semantic columns, applied at head), 17-var `BUILTIN_COLORS`/`COLOR_FIELDS`/`effective_settings`, API validation, `#view-theme` State-colors fieldset (17 pickers), `theme.js` FIELDS/PAIRS (5→8), `.page-head` surface panel (6 shell views + doc-edit + shared.html; login card / document sticky header audited as already-surfaced), mock_llm `content: None` fix
- Fixed 2 pre-existing defects (both fail identically on baseline `d4f38ad`, proven via worktree A/B): `test_nav_rename_sources` — expected nav tail missing the phase-91 "Theme" link; `test_stale_ui_copy` — now truncates `saved_chats` before/after (house `test_suggestion_chips` pattern) so the seed-chip contract is deterministic on the shared dev DB (owner's 22 saved chats triggered phase-80 last-3-questions)
- Tests: `uv run pytest --cov=app --cov-report=term-missing` → **1868 passed, app/ 99%** (>90% ✓); `uv run ruff check .` → clean; `uv run pyright` → **0 errors**
- E2E: dedicated `uv run pytest tests/e2e/test_theme_semantic_completion.py -v --no-cov` → **8/8 in isolation** (all-gray 17-color theme: zero residual color on saved-result/Stale/Revoked/Local/tool-call elements, text labels intact, gray heads non-transparent, pre-paint tag, Reset → byte-identical no-tag); 15 theme/header/nav/responsive suites green in isolation; full 85-file combined run: only the 2 fixed pre-existing failures + 1 combined-run artifact (`test_sync_upload_progress`, green in isolation)
- Completion criteria: (1) monochrome E2E ✓ (2) default byte-identical, no `#bor-theme` tag ✓ (3) all page heads on solid surface ✓ (4) suite/coverage/lint/E2E green ✓ (5) phases 01–92 no behavior change ✓ (6) commit left to harness per protocol
- Notable: cleaned stray uvicorn leftovers from prior implementation pass (owner's `--reload` dev server untouched); no deviations from the phase design
- Next pending phase: `94_ls_tree_drilldown`

tests/unit/test_frontend_router.py

@@ -902,8 +902,10 @@ def test_theme_view_scaffold_in_the_shell() -> None:
     the ship-hidden #theme-content (the #git-sources-content pattern)
     holding the STATIC form skeleton: the page-head (h1 "Theme"), the
     #theme-form with the 3 labeled branding text inputs (maxlength=300
-    — the server re-validates) + the 9 labeled type=color palette inputs
-    (the 9 identity variables, in the theming.COLOR_FIELDS order), the
+    — the server re-validates) + the 17 labeled type=color palette
+    inputs (the 9 identity variables, then the 8 semantic state
+    variables in the State colors fieldset — phase 93 — in the
+    theming.COLOR_FIELDS order), the
     #theme-save (primary) + #theme-reset (secondary) — BOTH type="button"
     (no real submit), and the three task-05 feedback lines: #theme-error
     (role=alert), #theme-result (role=status), #theme-contrast
@@ -941,8 +943,9 @@ def test_theme_view_scaffold_in_the_shell() -> None:
     )
     # The static form skeleton (the E2E-stable-selectors house
     # convention): the 3 labeled branding text inputs (maxlength=300)
-    # and the 9 labeled type=color palette inputs (the 9 identity
-    # variables — one per theming.COLOR_FIELDS field).
+    # and the 17 labeled type=color palette inputs (the 9 identity
+    # variables, then the 8 semantic state variables — phase 93 —
+    # one per theming.COLOR_FIELDS field).
     assert re.search(r'<form[^>]*id="theme-form"[^>]*>', body), (
         "the #theme-form must be STATIC markup in the shell"
     )
@@ -963,6 +966,16 @@ def test_theme_view_scaffold_in_the_shell() -> None:
         "theme-brand",
         "theme-brand-soft",
         "theme-brand-ink",
+        # The 8 semantic state pickers (phase 93 — the State colors
+        # fieldset after the palette fieldset).
+        "theme-ok-bg",
+        "theme-ok-ink",
+        "theme-err-bg",
+        "theme-err-ink",
+        "theme-err-line",
+        "theme-accent-bg",
+        "theme-accent-ink",
+        "theme-accent-line",
     ):
         assert re.search(
             rf'<label[^>]*for="{field_id}"[^>]*>', body