phase: 93_theme_semantic_completion

All verification is complete. Final report:

**Phase 93 — Theme semantic completion: FINAL VERIFICATION PASS — ALL GREEN**

- Verified full implementation in tree: migration `0016` (8 nullable semantic columns, applied at head), 17-var `BUILTIN_COLORS`/`COLOR_FIELDS`/`effective_settings`, API validation, `#view-theme` State-colors fieldset (17 pickers), `theme.js` FIELDS/PAIRS (5→8), `.page-head` surface panel (6 shell views + doc-edit + shared.html; login card / document sticky header audited as already-surfaced), mock_llm `content: None` fix
- Fixed 2 pre-existing defects (both fail identically on baseline `d4f38ad`, proven via worktree A/B): `test_nav_rename_sources` — expected nav tail missing the phase-91 "Theme" link; `test_stale_ui_copy` — now truncates `saved_chats` before/after (house `test_suggestion_chips` pattern) so the seed-chip contract is deterministic on the shared dev DB (owner's 22 saved chats triggered phase-80 last-3-questions)
- Tests: `uv run pytest --cov=app --cov-report=term-missing` → **1868 passed, app/ 99%** (>90% ✓); `uv run ruff check .` → clean; `uv run pyright` → **0 errors**
- E2E: dedicated `uv run pytest tests/e2e/test_theme_semantic_completion.py -v --no-cov` → **8/8 in isolation** (all-gray 17-color theme: zero residual color on saved-result/Stale/Revoked/Local/tool-call elements, text labels intact, gray heads non-transparent, pre-paint tag, Reset → byte-identical no-tag); 15 theme/header/nav/responsive suites green in isolation; full 85-file combined run: only the 2 fixed pre-existing failures + 1 combined-run artifact (`test_sync_upload_progress`, green in isolation)
- Completion criteria: (1) monochrome E2E ✓ (2) default byte-identical, no `#bor-theme` tag ✓ (3) all page heads on solid surface ✓ (4) suite/coverage/lint/E2E green ✓ (5) phases 01–92 no behavior change ✓ (6) commit left to harness per protocol
- Notable: cleaned stray uvicorn leftovers from prior implementation pass (owner's `--reload` dev server untouched); no deviations from the phase design
- Next pending phase: `94_ls_tree_drilldown`

tests/e2e/test_nav_rename_sources.py

@@ -112,13 +112,13 @@ CURRENT_LINK: dict[str, str | None] = {
 #: The four primary nav links, in their physical DOM order — the labels
 #: after the phase-48 swap (ids/hrefs unchanged).
 NAV_LABELS = ("Chat", "RAG", "Sources", "Tuning")
-#: The FIFTH + SIXTH a.nav-link in every page header (phase 53
-#: saved-chat history + phase 79 task 06 access tokens — both
-#: ship-hidden, revealed by header.js for admins). The DOM enumeration
-#: below therefore always sees them (pre-existing; the list matches the
-#: real nav — the phase-34 one-bar contract ships the SAME nav, incl.
-#: the Tokens link, on every page).
-NAV_TAIL = ("History", "Tokens")
+#: The FIFTH–SEVENTH a.nav-link in every page header (phase 53
+#: saved-chat history + phase 79 task 06 access tokens + phase 91
+#: theme tab — all ship-hidden, revealed by header.js for admins).
+#: The DOM enumeration below therefore always sees them (pre-existing;
+#: the list matches the real nav — the phase-34 one-bar contract ships
+#: the SAME nav, incl. the Tokens and Theme links, on every page).
+NAV_TAIL = ("History", "Tokens", "Theme")
 
 #: The login.js script — route pattern for the redirect suppression.
 LOGIN_JS_ROUTE = re.compile(r"/assets/login\.js(\?.*)?$")
@@ -199,8 +199,8 @@ def _assert_renamed_labels(page: Page, name: str) -> None:
     expect(git).to_have_attribute("href", "/git-sources.html")
 
     # The nav links (class nav-link) in physical DOM order — the four
-    # primaries plus the admin-only History (phase 53) and Tokens
-    # (phase 79 task 06) tail links.
+    # primaries plus the admin-only History (phase 53), Tokens
+    # (phase 79 task 06) and Theme (phase 91) tail links.
     nav_texts = page.eval_on_selector_all(
         ".app-nav a.nav-link", "els => els.map(e => e.textContent.trim())"
     )