phase: 93_theme_semantic_completion

All verification is complete. Final report:

**Phase 93 — Theme semantic completion: FINAL VERIFICATION PASS — ALL GREEN**

- Verified full implementation in tree: migration `0016` (8 nullable semantic columns, applied at head), 17-var `BUILTIN_COLORS`/`COLOR_FIELDS`/`effective_settings`, API validation, `#view-theme` State-colors fieldset (17 pickers), `theme.js` FIELDS/PAIRS (5→8), `.page-head` surface panel (6 shell views + doc-edit + shared.html; login card / document sticky header audited as already-surfaced), mock_llm `content: None` fix
- Fixed 2 pre-existing defects (both fail identically on baseline `d4f38ad`, proven via worktree A/B): `test_nav_rename_sources` — expected nav tail missing the phase-91 "Theme" link; `test_stale_ui_copy` — now truncates `saved_chats` before/after (house `test_suggestion_chips` pattern) so the seed-chip contract is deterministic on the shared dev DB (owner's 22 saved chats triggered phase-80 last-3-questions)
- Tests: `uv run pytest --cov=app --cov-report=term-missing` → **1868 passed, app/ 99%** (>90% ✓); `uv run ruff check .` → clean; `uv run pyright` → **0 errors**
- E2E: dedicated `uv run pytest tests/e2e/test_theme_semantic_completion.py -v --no-cov` → **8/8 in isolation** (all-gray 17-color theme: zero residual color on saved-result/Stale/Revoked/Local/tool-call elements, text labels intact, gray heads non-transparent, pre-paint tag, Reset → byte-identical no-tag); 15 theme/header/nav/responsive suites green in isolation; full 85-file combined run: only the 2 fixed pre-existing failures + 1 combined-run artifact (`test_sync_upload_progress`, green in isolation)
- Completion criteria: (1) monochrome E2E ✓ (2) default byte-identical, no `#bor-theme` tag ✓ (3) all page heads on solid surface ✓ (4) suite/coverage/lint/E2E green ✓ (5) phases 01–92 no behavior change ✓ (6) commit left to harness per protocol
- Notable: cleaned stray uvicorn leftovers from prior implementation pass (owner's `--reload` dev server untouched); no deviations from the phase design
- Next pending phase: `94_ls_tree_drilldown`

tests/e2e/mock_llm.py

@@ -333,9 +333,19 @@ def _user(body: dict[str, Any]) -> str:
 
 
 def _context(body: dict[str, Any]) -> str:
-    """The document context is the longest system/user message in practice."""
+    """The document context is the longest system/user message in practice.
+
+    ``m.get("content") or ""`` (NOT ``m.get("content", "")``): a well-formed
+    OpenAI tool-call message carries ``content: None`` EXPLICITLY (the app's
+    agent loop appends exactly that — ``app/rag/agent.py``), and a forced
+    final answer after a tool round (the round-cap path) reaches this helper
+    with those messages in play. The default-value form returns ``None`` for
+    an explicit ``None`` and crashes ``len()`` with a 500 (phase 93 task 04
+    caught it via the deterministic single-read flow's ALREADY_IN_CONTEXT
+    loop); ``or ""`` treats absent and explicit-None alike, so the fallback
+    composes deterministically instead of traceback-ing."""
     msgs = _messages(body)
-    return max((m.get("content", "") for m in msgs), key=len)
+    return max((m.get("content") or "" for m in msgs), key=len)
 
 
 LONG_ANSWER_TRIGGER = "write a long answer"