phase: 93_theme_semantic_completion
All verification is complete. Final report: **Phase 93 — Theme semantic completion: FINAL VERIFICATION PASS — ALL GREEN** - Verified full implementation in tree: migration `0016` (8 nullable semantic columns, applied at head), 17-var `BUILTIN_COLORS`/`COLOR_FIELDS`/`effective_settings`, API validation, `#view-theme` State-colors fieldset (17 pickers), `theme.js` FIELDS/PAIRS (5→8), `.page-head` surface panel (6 shell views + doc-edit + shared.html; login card / document sticky header audited as already-surfaced), mock_llm `content: None` fix - Fixed 2 pre-existing defects (both fail identically on baseline `d4f38ad`, proven via worktree A/B): `test_nav_rename_sources` — expected nav tail missing the phase-91 "Theme" link; `test_stale_ui_copy` — now truncates `saved_chats` before/after (house `test_suggestion_chips` pattern) so the seed-chip contract is deterministic on the shared dev DB (owner's 22 saved chats triggered phase-80 last-3-questions) - Tests: `uv run pytest --cov=app --cov-report=term-missing` → **1868 passed, app/ 99%** (>90% ✓); `uv run ruff check .` → clean; `uv run pyright` → **0 errors** - E2E: dedicated `uv run pytest tests/e2e/test_theme_semantic_completion.py -v --no-cov` → **8/8 in isolation** (all-gray 17-color theme: zero residual color on saved-result/Stale/Revoked/Local/tool-call elements, text labels intact, gray heads non-transparent, pre-paint tag, Reset → byte-identical no-tag); 15 theme/header/nav/responsive suites green in isolation; full 85-file combined run: only the 2 fixed pre-existing failures + 1 combined-run artifact (`test_sync_upload_progress`, green in isolation) - Completion criteria: (1) monochrome E2E ✓ (2) default byte-identical, no `#bor-theme` tag ✓ (3) all page heads on solid surface ✓ (4) suite/coverage/lint/E2E green ✓ (5) phases 01–92 no behavior change ✓ (6) commit left to harness per protocol - Notable: cleaned stray uvicorn leftovers from prior implementation pass (owner's `--reload` dev server untouched); no deviations from the phase design - Next pending phase: `94_ls_tree_drilldown`
This commit is contained in:
@@ -1533,6 +1533,25 @@ details.thinking .thinking-text ul { margin: 0 0 0.5rem; }
|
||||
gap: 1.25rem;
|
||||
flex: 1;
|
||||
}
|
||||
/* Phase 93 task 03 (TODO.md L3): "the header and description of each
|
||||
page needs a background - the grid makes it hard to read." Every
|
||||
page's h1 + description sits on a solid surface panel — the house
|
||||
card language (var(--surface) fill, itself tab-controlled, so a
|
||||
monochrome theme grays it automatically; the 1px --line border; the
|
||||
house radius). No new color literal, no blur (the phase-08 perf
|
||||
anchor). One rule covers the six shell views' .page-head (Global
|
||||
Tuning, Knowledge base, Git sources, Saved chats, Access tokens,
|
||||
Theme) + doc-edit.html, and the shared page's head (its h1 + lede
|
||||
are wrapped in the same class in shared.html). #view-chat carries
|
||||
no .page-head — its head is the navbar (audited, unchanged). The
|
||||
History page-head keeps its flex row (scoped below — the padding
|
||||
lives on the flex container, not the children). */
|
||||
.page-head {
|
||||
background: var(--surface);
|
||||
border: 1px solid var(--line);
|
||||
border-radius: var(--radius);
|
||||
padding: 1rem 1.25rem;
|
||||
}
|
||||
.page-head h1 { margin: 0 0 0.25rem; font-size: 1.7rem; }
|
||||
.page-head-row {
|
||||
display: flex;
|
||||
@@ -3187,7 +3206,7 @@ details.thinking .thinking-text ul { margin: 0 0 0.5rem; }
|
||||
}
|
||||
/* Page title (JS-filled with the shared chat's title; the static
|
||||
fallback is "Shared conversation") — the page-head h1 size. */
|
||||
#shared-title { margin: 0; font-size: 1.7rem; }
|
||||
#shared-title { margin: 0 0 0.25rem; font-size: 1.7rem; }
|
||||
/* The muted meta line under the h1 ("Shared via … — read-only."):
|
||||
ink-soft on the page bg ≥8.6:1, the page-sub language. */
|
||||
.shared-note {
|
||||
|
||||
Reference in New Issue
Block a user