phase: 93_theme_semantic_completion

All verification is complete. Final report:

**Phase 93 — Theme semantic completion: FINAL VERIFICATION PASS — ALL GREEN**

- Verified full implementation in tree: migration `0016` (8 nullable semantic columns, applied at head), 17-var `BUILTIN_COLORS`/`COLOR_FIELDS`/`effective_settings`, API validation, `#view-theme` State-colors fieldset (17 pickers), `theme.js` FIELDS/PAIRS (5→8), `.page-head` surface panel (6 shell views + doc-edit + shared.html; login card / document sticky header audited as already-surfaced), mock_llm `content: None` fix
- Fixed 2 pre-existing defects (both fail identically on baseline `d4f38ad`, proven via worktree A/B): `test_nav_rename_sources` — expected nav tail missing the phase-91 "Theme" link; `test_stale_ui_copy` — now truncates `saved_chats` before/after (house `test_suggestion_chips` pattern) so the seed-chip contract is deterministic on the shared dev DB (owner's 22 saved chats triggered phase-80 last-3-questions)
- Tests: `uv run pytest --cov=app --cov-report=term-missing` → **1868 passed, app/ 99%** (>90% ✓); `uv run ruff check .` → clean; `uv run pyright` → **0 errors**
- E2E: dedicated `uv run pytest tests/e2e/test_theme_semantic_completion.py -v --no-cov` → **8/8 in isolation** (all-gray 17-color theme: zero residual color on saved-result/Stale/Revoked/Local/tool-call elements, text labels intact, gray heads non-transparent, pre-paint tag, Reset → byte-identical no-tag); 15 theme/header/nav/responsive suites green in isolation; full 85-file combined run: only the 2 fixed pre-existing failures + 1 combined-run artifact (`test_sync_upload_progress`, green in isolation)
- Completion criteria: (1) monochrome E2E ✓ (2) default byte-identical, no `#bor-theme` tag ✓ (3) all page heads on solid surface ✓ (4) suite/coverage/lint/E2E green ✓ (5) phases 01–92 no behavior change ✓ (6) commit left to harness per protocol
- Notable: cleaned stray uvicorn leftovers from prior implementation pass (owner's `--reload` dev server untouched); no deviations from the phase design
- Next pending phase: `94_ls_tree_drilldown`

app/api/ui_settings.py

@@ -2,8 +2,9 @@
 
 The persistence surface of the admin Theme tab (the tab itself lands in
 tasks 04/05): the single ``ui_settings`` row (id 1) that stores what the
-admin sets — the app name, input placeholder, footer text, and the 9
-identity colors. The whole router sits behind
+admin sets — the app name, input placeholder, footer text, and the 17
+palette colors (the 9 identity colors + the 8 semantic state colors,
+phase 93 — B3 revised). The whole router sits behind
 :func:`app.core.auth.require_admin` (router-wide ``dependencies`` — the
 :mod:`app.api.tokens` pattern): anonymous callers AND token users get
 403 on every route (only the admin themes the deployment).
@@ -73,11 +74,13 @@ def _validate_strings(payload: UiSettingsIn) -> dict[str, str | None]:
 
 
 def _validate_colors(payload: UiSettingsIn) -> dict[str, str | None]:
-    """Validate + normalize the 9 identity colors: strict ``#rrggbb``
-    (else 422 naming the field), lowercased on store, and a value equal
-    to its BUILT-IN is stored as ``None`` — the owner-locked
-    normalization that keeps "save the defaults" byte-identical (the
-    row stays empty, the no-op injection contract)."""
+    """Validate + normalize the 17 palette colors (the 9 identity +
+    the 8 semantic state — all ``COLOR_FIELDS``-driven, phase 93):
+    strict ``#rrggbb`` (else 422 naming the field), lowercased on
+    store, and a value equal to its BUILT-IN is stored as ``None`` —
+    the owner-locked normalization that keeps "save the defaults"
+    byte-identical (the row stays empty, the no-op injection
+    contract)."""
     values: dict[str, str | None] = {}
     for field in theming.COLOR_FIELDS:
         raw = getattr(payload, field)
@@ -113,7 +116,7 @@ def update_ui_settings(
     settings: Settings = Depends(get_settings),  # noqa: B008
     db: Session = Depends(get_db),  # noqa: B008
 ) -> UiSettingsOut:
-    """Replace the single row with the body's 12 values (validated and
+    """Replace the single row with the body's 20 values (validated and
     normalized — see the module docstring), then report the new
     effective values.