phase: 155_folder_summary_voice
All verification is complete — the whole project is 100% green. Final report: **Phase 155 final verification pass — complete.** **Verified (all tasks 01–04 done in `complete/`):** - Instruction nudge in `app/rag/folder_summaries.py` (forbidden openers as the pin, 4 constraints preserved, docstring cites the phase) - `scripts/regen_folder_summaries.py` (import_docs idiom, full mode, cron-safe summary line, fail-loud boot) - Unit pins, integration suite, mock voice update, dedicated E2E suite **Test / lint / coverage:** - `uv run pytest --cov=app -q` → 100% passed (exit 0, zero failures); coverage **99%** on `app/` (>90% ✓) - `uv run pytest tests/e2e/test_folder_summary_voice.py -v --no-cov` → **3 passed** in isolation - `uv run ruff check .` → clean; `uv run pyright` → 0 errors, 0 warnings **Completion criteria:** 1. Marker + header prefix byte-identical — ✅ (git vs HEAD + unit pins verbatim, green) 2. Regen script full regeneration — ✅ (live smoke: exit 0, `folders=… limit=7` summary line; misconfig boot → named stderr, exit 1; `updated_at`-advance/no-prune/canned-text semantics proven by the integration suite, green) 3. Sync path untouched — ✅ (0 diffs to `app/api/sync.py` / `app/rag/importer.py`; phase-127 pins green) 4. E2E stored + rendered without forbidden openers — ✅ (3/3, exact canned-string assertions + phase-127 regression guard) 5. Full suite green, E2E isolated green, ruff + pyright clean, coverage >90% — ✅ 6. Atomic commit — deferred to the harness (working tree left intact per protocol) **Documentation:** README.md and AGENTS.md reviewed in full — verified consistent, no changes needed (README already documents the new script in the update workflow; all `.env.example` vars documented; pages table matches routes; 17 colors = 9+8; no stale mock-voice references). **Decisions:** No live-infrastructure changes (dev-DB read + a 0-row script smoke only). The `TODO.md` working-tree edit is the owner's own, left untouched. **Next pending phase:** `156_table_ux_polish`.
This commit is contained in:
@@ -39,9 +39,9 @@ Run in isolation (DB must be up: ``podman compose up -d db``):
|
||||
MOCK-ONLY suite: ``E2E_REAL_LLM=1`` is not supported — the clamp test's
|
||||
level-block assertion keys on a MANUAL description (LLM-free), but the
|
||||
seeded KB's stored descriptions at the other levels are the mock's
|
||||
canned ``FOLDER_SUMMARY_MODE`` one-liner ``Fixture folder summary for
|
||||
<folder>.`` (the phase-94 convention — byte-exact only against the
|
||||
mock).
|
||||
canned ``FOLDER_SUMMARY_MODE`` one-liner ``Documentation for
|
||||
<folder>.`` (the phase-155 voice convention — byte-exact only against
|
||||
the mock).
|
||||
|
||||
KB fixture — a host temp dir (``tmp_path_factory``; the app runs on the
|
||||
same host) with ONE registered local source (the
|
||||
@@ -161,7 +161,7 @@ TOTAL_DOCS = 6 # 2 one/ + 2 one/two/ + 2 three/ (no root-level files)
|
||||
#: folder_path)`` order: one row per ≥ 2-doc folder (the
|
||||
#: recursive-subtree rule — ``one/two`` is a distinct nested folder) —
|
||||
#: the ``""`` row is the source root.
|
||||
SUMMARY_FOR = "Fixture folder summary for {}."
|
||||
SUMMARY_FOR = "Documentation for {}."
|
||||
ALPHA_ROOT_SUM = SUMMARY_FOR.format(ALPHA)
|
||||
ONE_SUM = SUMMARY_FOR.format(f"{ALPHA}/one")
|
||||
TWO_SUM = SUMMARY_FOR.format(f"{ALPHA}/one/two")
|
||||
|
||||
Reference in New Issue
Block a user