phase: 191_source_name_labels_tags

All gates re-verified against a stable tree. Report:

**Verified (all 6 tasks in `complete/`; this was the final pass)**
- `SourceLabel`+alembic `0030` (dev DB `alembic current` = `0030 (head)`, table present, 0 rows); admin-only `GET/PUT/DELETE /api/source-labels` (`require_admin` router-wide, `resolve_source_name`, partial-update caps/404s); Sources-page "Names, labels and tags" card (read-only derived-name `<code>`, per-row `saveInFlight`, 404 note that survives the settle, chips reuse `.git-source-hidden-count`); `question_name_hits` D2 rule; ONE `all_labels` read per turn in `chat.py` feeding both the `source_name_hit` flag and the prompt surfaces; `source_name_hit_bonus=0.005` in `_selection_order`; ` name=`/` label=` in `build_high_prompt` + `build_overview_prompt(names=…)`.
- **Completion criteria:** E2E `tests/e2e/test_source_name_labels.py` ✅ 7 passed (arms a–e: editor all kinds, control/named question, rename-never-breaks-identity, 404 note, reset) · full suite ✅ · coverage ✅ · README/AGENTS ✅ · phase dir in `complete/` ✅ · commit left to the harness.
- **Gates:** `uv run pytest --cov=app --cov-report=term-missing` → **exit 0, TOTAL 7160 stmts / 16 missed = 99%** (>90%) · `uv run pytest tests/e2e/test_source_name_labels.py -v --no-cov` → **7 passed, exit 0** · regression E2E isolated, exit 0: `test_document_viewer`, `test_admin_auth`, `test_api_tokens`, `test_git_sources_admin`, `test_kb_tree`, `test_local_directory_sources` · `uv run ruff check .` → All checks passed · `uv run pyright` → 0 errors.
- **Battery (task 04 criterion):** `uv run python -m scripts.eval_retrieval --from-file tests/fixtures/retrieval_battery.txt` at default vs `BOR_SOURCE_NAME_HIT_BONUS=0` → **`diff` empty (line-for-line identical)**, matching the recorded arms (dev KB is empty, so every question deflects; the observable boost is unit/E2E-pinned).
- **Documentation:** README — fixed the `/git-sources.html` rows (nav label is **Sources**) and cross-linked the phase-191 card from that section; full audit otherwise clean: all 86 `BOR_*` settings documented with defaults matching `app/config.py`, 0 broken file/dir references and 0 broken anchors in README+AGENTS, AGENTS rule 17 re-checked line-by-line against the code.
- **Notable / deviations:** (1) a **concurrent pipeline process** (`phased-execution/progress.mjs` for `191_…_00_phase`) was mutating this same working tree mid-pass — it rewrote `tests/e2e/test_source_name_labels.py` (11→7 tests), `frontend/assets/git-sources.js`, `tests/unit/test_source_labels_editor_ui.py` and `AGENTS.md` at 05:27; every gate above was (re-)run after those edits with the tree no source file newer than the green full run. (2) The task-06 report/phase text claims regression suites `test_chat_token_gate.py`, `test_git_sources_page.py`, `test_rag_browser.py` are green — **those files have never existed in git history** (those runs exit 4); I ran the real equivalents listed above instead (phase files are not mine to edit). (3) **No live changes**: the VM DB already has `source_labels` (0 rows) but the deployed app predates this uncommitted code, so deploying `/api/source-labels` to the live service is the owner's post-commit step, not part of this phase's criteria.
- **Next pending phase:** none — `191_source_name_labels_tags` is the only entry in `.agents/phases/todo/`.

tests/integration/test_chunks_hnsw_index.py

@@ -236,7 +236,17 @@ def test_invalid_index_is_dropped_and_rebuilt(db: Session, alembic: Config) -> N
     data, and timing a real interruption is nondeterministic; the dev/
     test DB role is a superuser, and a role without catalog UPDATE
     rights skips cleanly instead of leaving the DB inconsistent (the
-    stamp that follows the forced state, never before it)."""
+    stamp that follows the forced state, never before it).
+
+    Phase 191 fix: the stamp moves the version table ALL the way below
+    0029, so every LATER migration's objects must be genuinely dropped
+    first (``downgrade("0029")``) — a stamped-below head with a later
+    migration's table still physically present would make every
+    following ``upgrade(head)`` re-run that migration and die on
+    ``relation already exists`` (observed with 0030's
+    ``source_labels`` once it landed). The only lie that stays between
+    the stamp and the re-run is the corrupted index — exactly the
+    state this test is about."""
     command.upgrade(alembic, "head")
     assert _index_valid(db) is True, "precondition: a valid index to corrupt"
 
@@ -253,8 +263,12 @@ def test_invalid_index_is_dropped_and_rebuilt(db: Session, alembic: Config) -> N
         db.rollback()
         pytest.skip(f"forcing INVALID needs catalog UPDATE rights: {exc}")
 
-    # The stamp moves the version table WITHOUT touching the index, so
-    # the next upgrade() re-runs 0029 against the corrupted state.
+    # Drop every post-0029 migration's objects for real BEFORE the
+    # stamp (the phase-191 note above), then move the version table
+    # WITHOUT touching the index, so the next upgrade() re-runs 0029
+    # against the corrupted state and head is re-derivable cleanly.
+    db.rollback()  # release the session before the DDL (house pattern)
+    command.downgrade(alembic, "0029")
     command.stamp(alembic, "0028")
     assert _version(db) == "0028"
     assert _index_valid(db) is False, "the forced INVALID state must be visible"