phase: 175_history_pagination

All criteria verified. This pass found no defects — the phase was fully implemented by prior task runs, and every gate is green. **Phase 175 final verification pass — report** - Verified tasks 01–03 implementation in-tree: `list_chats` `?limit=` (25, 1–100) / `?offset=` + `func.count` `total`; `SavedChatList.total` required; `#history-pager` below `#history-table-wrap` (hidden default, aria-labels, aria-hidden SVGs); `history.js` `PAGE_SIZE=25`/offset state, parameterized fetch, `updatePager`, refresh-keeps-current-page; CSS pill union + ≤640px block. No code changes were needed. - Full suite: `uv run pytest --cov=app --cov-report=term-missing` → **exit 0, TOTAL 99%** (>90% gate). - `uv run ruff check .` → all checks passed; `uv run pyright` → 0 errors, 0 warnings. - Phase E2E in isolation: `uv run pytest tests/e2e/test_history_pagination.py -v --no-cov` → **9 passed** (page 1-of-2 / 2-of-2 walk, replace-not-append, refresh-on-page-2, delete-to-empty + single-page hide, anonymous no-fetch, 375px mobile, a11y/no-CDN). - Regression set, each in isolation: test_chat_history 5✓, test_history_page_width 5✓, test_share_chat 4✓, test_stale_saved_chats 3✓, test_history_copy 1✓; integration `test_chats_api.py` green (incl. updated `test_list_empty` two-key pin and all five new pagination pins). - Completion criteria: all nine boxes satisfied (API slice/422/honest-total pins ✓; E2E walk + status lines ✓; refresh/delete/hide ✓; anonymous gate ✓; mobile ✓; gates ✓; E2E + regression ✓; docs ✓; commit/phase-move is the harness's). - Documentation: README.md reviewed in full — the saved-chats section already carries the `?limit=`/`?offset=`/`total` contract from this phase; all 31 `.env.example` vars documented; AGENTS.md verified accurate. **Consistent — no changes needed.** - Deviations: none. No defects found in previously completed work. - Next pending phase: none — 175 is the only entry in `todo/`.
2026-10-11 04:12:53 -04:00
parent 938d6cf09d
commit 375169bbfc
31 changed files with 2339 additions and 61 deletions
@@ -516,11 +516,12 @@ def test_active_view_reclick_dispatches_refresh_not_bare_return() -> None:
 def test_history_view_listens_for_view_refresh_in_admin_branch_only() -> None:
    """Phase 77: the History view re-fetches on a user-initiated
    re-show — history.js registers a ``bor:view-refresh`` listener on
-    the view's root that re-runs the (now re-entrant) ``loadChats()``.
-    The listener is armed only AFTER the whoami gate passes: anonymous
-    shows the gate and never fetches (the phase-50 contract the story
-    E2E pins), and the ``started`` flag means the listener can only
-    re-run a load the mount already made."""
+    the view's root that re-runs the (now re-entrant) load. Phase 175:
+    the re-show re-fetches the CURRENT page — ``loadChats(offset)``,
+    never 0 (A5). The listener is armed only AFTER the whoami gate
+    passes: anonymous shows the gate and never fetches (the phase-50
+    contract the story E2E pins), and the ``started`` flag means the
+    listener can only re-run a load the mount already made."""
    history_js = (ASSETS / "history.js").read_text(encoding="utf-8")
    assert 'addEventListener("bor:view-refresh"' in history_js, (
        "history.js must listen for the refresh event on the view root"
@@ -530,20 +531,21 @@ def test_history_view_listens_for_view_refresh_in_admin_branch_only() -> None:
    assert 0 <= gate < listener, (
        "the listener is armed only in the ADMIN branch (after the gate)"
    )
-    assert re.search(r"if \(started\)\s+loadChats\(\)", history_js), (
-        "the listener is gated on the first load (started)"
+    assert re.search(r"if \(started\)\s+loadChats\(offset\)", history_js), (
+        "the listener is gated on the first load (started) — and "
+        "re-fetches the CURRENT page (phase 175, A5: never resets to 0)"
    )
    # Re-entrancy: a re-load drops the data rows (except the hidden
    # empty-state row) before fetching — the list is replaced, not
    # duplicated.
-    load = history_js.find("async function loadChats()")
+    load = history_js.find("async function loadChats(pageOffset)")
    assert load != -1, "loadChats must exist"
    load_body = history_js[load : history_js.find("\n  }", load)]
    assert "tr !== emptyRow" in load_body and "tr.remove()" in load_body, (
        "loadChats must remove the data rows (the empty row stays) first"
    )
    clear_i = load_body.find("tr !== emptyRow")
-    fetch_i = load_body.find('fetch("/api/chats")')
+    fetch_i = load_body.find('fetch("/api/chats?limit="')
    assert 0 <= clear_i < fetch_i, "the row clearing precedes the fetch"


@@ -763,12 +765,15 @@ def test_history_refresh_button_binding_admin_only_with_outcome_lines() -> None:
    fn = js.find("async function refreshChats()")
    assert fn != -1, "refreshChats must exist"
    fn_body = js[fn:js.find("\n  }", fn)]
-    assert "loadChats()" in fn_body, "the button re-runs the (re-entrant) load"
+    assert "loadChats(offset)" in fn_body, (
+        "the button re-runs the (re-entrant) load — the CURRENT page "
+        "(phase 175, A5: a page-2 refresh never resets to page 1)"
+    )
    assert "finally" in fn_body and "refreshBtn.disabled = false" in fn_body, (
        "the button re-enables on success AND failure (the finally)"
    )
    assert '"Saved chats refreshed."' in fn_body, "the exact success line"
-    load = js.find("async function loadChats()")
+    load = js.find("async function loadChats(pageOffset)")
    load_body = js[load:js.find("\n  }", load)]
    assert "Couldn't load saved chats — is the app reachable?" in load_body, (
        "the network-error line lives in loadChats (every caller sees it)"
@@ -788,20 +793,33 @@ def test_history_refresh_button_css_reuses_the_new_chat_language() -> None:
    The page-head flex row is SCOPED to #view-history (the other four
    views' page-heads are untouched). Below 640px the pill goes full
    width with the label visible (the icon-only squeeze is gone —
-    the glyph joins the label)."""
+    the glyph joins the label). Phase 175: the pager buttons join
+    the rule (the selector union — this pin names the union shape,
+    so the pill language stays pinned on .history-refresh itself)."""
    css = _asset("styles.css")
-    block = re.search(r"\.history-refresh \{([\s\S]*?)\n\}", css)
+    block = re.search(
+        r"\.history-refresh(?:,\s*\.history-pager-btn)? \{([\s\S]*?)\n\}", css
+    )
    assert block, "styles.css must style .history-refresh"
    body = block.group(1)
    assert "background: var(--brand)" in body, "the .new-chat-btn brand fill"
    assert "color: var(--bg)" in body, "--bg text on --brand (5.2:1, AA)"
    assert "min-height: 44px" in body, "the comfortable touch target"
    assert "border-radius: 999px" in body and "border: 0" in body, "the pill"
-    assert ".history-refresh:hover { background: var(--brand-hover); color: var(--bg); }" in css
-    assert ".history-refresh:disabled { opacity: 0.6; cursor: wait; }" in css, (
+    assert (
+        ".history-refresh:hover, .history-pager-btn:hover {"
+        " background: var(--brand-hover); color: var(--bg); }"
+    ) in css
+    assert (
+        ".history-refresh:disabled, .history-pager-btn:disabled {"
+        " opacity: 0.6; cursor: wait; }"
+    ) in css, (
        "the in-flight disabled state is dimmed (the house language)"
    )
-    assert ".history-refresh svg { width: 16px; height: 16px; display: none; }" in css, (
+    assert (
+        ".history-refresh svg, .history-pager-btn svg {"
+        " width: 16px; height: 16px; display: none; }"
+    ) in css, (
        "desktop: the label carries the pill (the glyph is hidden)"
    )
    row = re.search(r"#view-history \.page-head \{([\s\S]*?)\n\}", css)
@@ -811,10 +829,10 @@ def test_history_refresh_button_css_reuses_the_new_chat_language() -> None:
    mobile = re.search(r"@media \(max-width: 640px\) \{([\s\S]*?)\n\}\n", css)
    assert mobile, "the 640px media query must exist"
    mbody = mobile.group(1)
-    assert ".history-refresh { width: 100%; }" in mbody, (
+    assert ".history-refresh, .history-pager-btn { width: 100%; }" in mbody, (
        "full width below 640px (the icon-only squeeze is gone)"
    )
-    assert ".history-refresh svg { display: block; }" in mbody, (
+    assert ".history-refresh svg, .history-pager-btn svg { display: block; }" in mbody, (
        "the glyph joins the visible label below 640px"
    )