phase: 145_git_source_links
**Phase 145 final verification pass — all green, no code changes needed** - **Verified (no defects found):** resolver `origin_for_source` + `_url_basename` (scp/`.git`/trailing-slash, sanitize, ambiguity WARNING); `origin:`/`branch:` lines in all four read shapes via shared `_origin_lines`; HIGH `<tools>` origin rule (verbatim + only-byte-change pins); `DocContent.origin_url/origin_branch` (absent-never-null serializer); `renderDocument` "Original" anchor (copyable verbatim URL, `_blank`/`noopener`, branch in title); mock scripted origin-link flow (disjoint trigger — grep-verified vs all other E2E files) - **Tests:** `uv run pytest --cov=app --cov-report=term-missing` → 3402 passed, `app/` coverage **99%** (>90% gate); `uv run pytest tests/e2e/test_git_source_links.py -v --no-cov` → **4 passed** in isolation; `uv run ruff check .` → clean; `uv run pyright` → 0 errors, 0 warnings - **Completion criteria:** (1) git read results carry origin/branch, local byte-identical — ✅ (unit pins + E2E control); (2) HIGH `<tools>` rule pinned, LOW byte-identical — ✅; (3) modal AND /document.html show Original link, branch in label when pinned, nothing for local — ✅; (4) full suite green + coverage + E2E + lint/types — ✅; (5) no completed-phase behavior change (read header line 1, mock prefix, done frame/SourceRef untouched, LOW sha) — ✅ - **Extra regression check:** re-ran shared-mock E2E suites `test_read_line_ranges.py` (2 passed) and `test_document_viewer.py` (8 passed) — no cross-suite regressions from the `mock_llm.py` addition - **Documentation:** README.md reviewed in full (env table ⊇ `.env.example`, pages/routes, config defaults, scripts, 17-color palette, 300 s guard, 2 s sync poll, phase-145 provenance section matches implementation) and AGENTS.md (72rem container, no-CDN test, smoke test, gitignore, gates) — **verified consistent, no changes needed** - **Notable:** phase-116 screenshot PNG was regenerated during this phase's E2E runs (byte re-encode only, visually identical, correct no-anchor local-source meta row) — left in tree for the harness commit - **Next pending phase:** `146_search_tool_scope` (then 147, 148, 149)
This commit is contained in:
@@ -561,12 +561,30 @@ class DocContent(BaseModel):
|
||||
#: omission precedent); also absent for an image row whose
|
||||
#: ``image_path`` is NULL (the viewer's onerror fallback covers it).
|
||||
image_url: str | None = None
|
||||
#: Phase 145 (task 03) — the document's git origin: the sanitized
|
||||
#: repository URL (the task-01 resolver's output — the phase-121
|
||||
#: credential-free mask; the document's ``source`` is the directory
|
||||
#: the clone landed in, so no unambiguous git row means no origin).
|
||||
#: ABSENT from the wire for non-git documents (``None`` → dropped by
|
||||
#: the serializer — never ``null``, the :func:`_drop_absent_share_url`
|
||||
#: omission precedent), so a non-git document's payload is
|
||||
#: byte-identical to pre-phase.
|
||||
origin_url: str | None = None
|
||||
#: Phase 145 (task 03) — the row's PINNED branch (phase 135).
|
||||
#: ABSENT from the wire when the row pins none (NULL = the
|
||||
#: repository's default branch — nothing to show); also dropped by
|
||||
#: the serializer (never ``null``).
|
||||
origin_branch: str | None = None
|
||||
|
||||
@model_serializer(mode="wrap")
|
||||
def _serialize(self, handler: SerializerFunctionWrapHandler) -> Any:
|
||||
data = handler(self)
|
||||
if self.image_url is None:
|
||||
data.pop("image_url", None)
|
||||
if self.origin_url is None:
|
||||
data.pop("origin_url", None)
|
||||
if self.origin_branch is None:
|
||||
data.pop("origin_branch", None)
|
||||
return data
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user