phase: 86_history_page_width
All criteria verified. Final report: **Phase 86 final verification pass — all green, no defects found.** - **Verified (previously implemented):** `position: relative` on shared `.table-wrap` (the one-rule A3 fix, +12 lines in `frontend/assets/styles.css`); unit pin `tests/unit/test_table_wrap_stacking.py` (3 tests); E2E story `tests/e2e/test_history_page_width.py` (5 tests: History 626→≤375, Tokens 618→≤375, SPA switch with window-sentinel, RAG regression, desktop 1280×800) - **Tests/lint (this pass):** `uv run pytest` → 1720 passed · `uv run pytest --cov=app --cov-report=term-missing` → TOTAL **99%** (>90% floor) · E2E in isolation: `test_history_page_width.py` 5 passed, `test_chat_history.py` 5 passed, `test_api_tokens.py` 9 passed, `test_smoke.py` 3 passed · `uv run ruff check . && uv run pyright` → clean, 0 errors - **Completion criteria:** ① 375px direct+SPA `scrollWidth ≤ innerWidth` on History/Tokens — PASS (E2E pins) ② in-card scroll preserved + full-width + a11y spans in DOM — PASS ③ Sources + desktop regression — PASS ④ full suite/coverage/E2E/lint gates — PASS ⑤ `git diff --stat` limited to `styles.css` (+12) + new test files + phase files, no `app/`/markup/JS — PASS ⑥ commit/move — left to harness per executor rules (working tree intact, `todo/` dir removal already reflected) - **Notable:** red→green (CSS reverted → 626px failure) and manual live check already recorded in `.agents/reports/86_history_page_width/`; pre-existing untracked `.agents/remediation_plan.md` (Sep 7 security audit) untouched - **Next pending phase:** `87_big_read_progress`
This commit is contained in:
@@ -1741,7 +1741,19 @@ details.thinking .thinking-text ul { margin: 0 0 0.5rem; }
|
||||
other door: the admin password login (the static ?next=/ is the
|
||||
no-JS fallback). */
|
||||
|
||||
/* Phase 86: the card is the containing block for the
|
||||
position:absolute .visually-hidden elements it hosts (the table
|
||||
<caption> + the Actions header span in #view-history /
|
||||
#view-tokens). Without a positioned ancestor their 1px boxes lay
|
||||
out against the INITIAL containing block — at the 640px table's
|
||||
right edge — and leak into the DOCUMENT's scrollable overflow
|
||||
(the page appeared "the width of the table", TODO.md L4; the
|
||||
Tokens view carried the identical defect). Zero-offset positioning
|
||||
changes no layout: the spans stay clipped by their own
|
||||
clip: rect(0 0 0 0) + 1px box, and cards without such spans (the
|
||||
RAG .docs-table, the git-sources table) render unchanged. */
|
||||
.table-wrap {
|
||||
position: relative;
|
||||
background: var(--surface);
|
||||
border: 1px solid var(--line);
|
||||
border-radius: var(--radius);
|
||||
|
||||
Reference in New Issue
Block a user